DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=16113 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2005-07-08 00:07 --- *** Bug 35650 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2004-03-09 13:58 --- Does this patch is applied to both Tomcat 5.x and Tomcat 4.1.x or only to Tomcat 5.x? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2004-03-09 17:55 --- I just applied the patch to 4.1.x also. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-03-09 00:48 --- Patch applied. Thanks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 [EMAIL PROTECTED] changed: What|Removed |Added Component|Unknown |Jasper Product|Tomcat 4|Tomcat 5 Version|4.1.29 |5.0.19 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 [EMAIL PROTECTED] changed: What|Removed |Added Platform|Other |All - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2004-03-07 08:56 --- Created an attachment (id=10692) poproposed patch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113
removing then replacing a jsp page continues to give a 404
--- Additional Comments From [EMAIL PROTECTED] 2004-03-05 13:26 ---
Simply compare JspRuntimeContext.checkCompile(), this calls
ctxt.incrementRemoved() if a FileNotFoundException occur. JspServletWrapper
only set a 404 if a FileNotFoundException occur and finish.
Code from JspRuntineContext:
synchronized(jsw) {
try {
ctxt.compile();
} catch (FileNotFoundException ex) {
ctxt.incrementRemoved();
} catch (Throwable t) {
jsw.getServletContext().log(Background compile failed,
t);
}
}
Code from JspServletWrapper:
} catch (FileNotFoundException ex) {
String includeRequestUri = (String)
request.getAttribute(javax.servlet.include.request_uri);
if (includeRequestUri != null) {
// This file was included. Throw an exception as
// a response.sendError() will be ignored by the
// servlet engine.
throw new ServletException(ex);
} else {
try {
response.sendError(HttpServletResponse.SC_NOT_FOUND,
ex.getMessage());
} catch (IllegalStateException ise) {
log.error(Localizer.getMessage(jsp.error.file.not.found,
ex.getMessage()),
ex);
}
add a simple ctxt.incrementRemoved in catch block and test case works.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113
removing then replacing a jsp page continues to give a 404
--- Additional Comments From [EMAIL PROTECTED] 2004-03-05 13:39 ---
Another solution : in JspServletWrapper, line 343, before sending
HttpServletResponse.SC_NOT_FOUND, remove wrapper from collection of previously
created wrapper :
Code from JspServletWrapper:
} catch (FileNotFoundException ex) {
String includeRequestUri = (String)
request.getAttribute(javax.servlet.include.request_uri);
if (includeRequestUri != null) {
// This file was included. Throw an exception as
// a response.sendError() will be ignored by the
// servlet engine.
throw new ServletException(ex);
} else {
try {
// BELOW 1 LINE PROPOSED FOR THIS BUG
ctxt.getRuntimeContext().removeWrapper(jspUri);
response.sendError(HttpServletResponse.SC_NOT_FOUND,
ex.getMessage());
} catch (IllegalStateException ise) {
log.error(Localizer.getMessage(jsp.error.file.not.found,
ex.getMessage()),
ex);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113
removing then replacing a jsp page continues to give a 404
--- Additional Comments From [EMAIL PROTECTED] 2004-03-05 13:44 ---
using incrementRemoved() is cleaner, it removes wrapper and java-/class-file.
Code from JspCompilationContext:
// Removal
public void incrementRemoved() {
if (removed 1) {
jspCompiler.removeGeneratedFiles();
if( rctxt != null )
rctxt.removeWrapper(jspUri);
}
removed++;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2004-03-05 13:50 --- OK, I agree. What's happen now? I suppose this patch must be validated and voted by Tomcat commiters. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113
removing then replacing a jsp page continues to give a 404
--- Additional Comments From [EMAIL PROTECTED] 2004-03-05 13:56 ---
Example for fixed code
JspServletWrapper:
} catch (FileNotFoundException ex) {
String includeRequestUri = (String)
request.getAttribute(javax.servlet.include.request_uri);
ctxt.incrementRemoved()
if (includeRequestUri != null) {
// This file was included. Throw an exception as
// a response.sendError() will be ignored by the
// servlet engine.
throw new ServletException(ex);
} else {
try {
response.sendError(HttpServletResponse.SC_NOT_FOUND,
ex.getMessage());
} catch (IllegalStateException ise) {
log.error(Localizer.getMessage(jsp.error.file.not.found,
ex.getMessage()),
ex);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2004-03-05 14:19 --- oh, you reminder JspServletWrapper/JspCompilationContext in your reminder, read the discussion on tomcat-user currently. i agree with Q. Bordeaux. some live-enviroment requires jasper background compilation or development enabled. some not, use precompile instead. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2004-03-04 13:53 --- If you have a patch, preferably against 5.0.19, please post it so we can evaluate how risky it is. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 [EMAIL PROTECTED] changed: What|Removed |Added Version|4.1.18 |4.1.29 --- Additional Comments From [EMAIL PROTECTED] 2003-11-04 18:19 --- I have verified that it is still a bug in 4.1.29. David, would it be possible for you to mail me a copy of your patch? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2003-09-15 16:19 --- Any word on this bug? Very surprised to see the 4.0.x series disappear from the jakarta mirrors with serious bugs like this outstanding in the 4.1 branch. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2003-09-15 22:41 --- What I wrote (patch against 4.1.24 source archive) never got in. I was building a patch file; as a sanity check, I had checked out the public CVS code labeled TOMCAT_4_1_24, and I saw that it didn't match their 4.1.24 source archives. When I asked about this, Remy basically told me learn CVS, and that was the only response I got. I did notice that the dev code in CVS had progressed pretty far from 4.1.24 already at the time, and I recall seeing some significant changes in and around the relevant code... I guessed that this bug had already been fixed, and just forgotten in the DB. Does this still happen in 4.1.27? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2003-07-11 14:40 --- We're seeing it too. Very nasty. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2003-07-11 17:36 --- I have a working patch for this bug; I'd appreciate help/advice from anyone more familiar with creating and submitting patches to the Tomcat team. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 --- Additional Comments From [EMAIL PROTECTED] 2003-01-30 20:10 --- FWIW, this problem does not occur with tomcat-4.0.6. The problem is serious enough in our context that we have been forced to downgrade. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16113] - removing then replacing a jsp page continues to give a 404
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16113 removing then replacing a jsp page continues to give a 404 [EMAIL PROTECTED] changed: What|Removed |Added Severity|Blocker |Normal --- Additional Comments From [EMAIL PROTECTED] 2003-01-15 16:54 --- I can reproduce it. It doesn't happen with non-JSPs, such as images, so it shouldn't be a cache bug. BTW, the (small) delay is there because there's a cache. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
