DO NOT REPLY [Bug 17504] - JDBCRealm start() opens but does not close connection.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504 JDBCRealm start() opens but does not close connection. [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-01 13:54 --- Starting at about version 4.1.18 of Tomcat there is a Realm which can use db connection pooling. The DataSourceRealm can use a JNDI named JDBC DataSource such as a DBCP. Since the DataSourceRealm meets your needs for db connection pooling of a Realm I am marking this as invalid. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17504] - JDBCRealm start() opens but does not close connection.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504 JDBCRealm start() opens but does not close connection. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-02-28 14:33 --- JDBCRealm synchronizes use of one db connection for all realm authentications. There is no need to close the connection since it is reused. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17504] - JDBCRealm start() opens but does not close connection.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504 JDBCRealm start() opens but does not close connection. [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2003-02-28 23:04 --- Yes, I understand why it is not a problem in the default implementation, but it is a problem if you are extending this class, in my case, to use a connection pool. To prevent the connection from never being closed or returned to the pool, I have to do some ugly workarounds in the extended class. It seems to me like just closing the connection opened by start() would be an extremely simple change and would have little risk of destabilizing anything. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17504] - JDBCRealm start() opens but does not close connection.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17504
JDBCRealm start() opens but does not close connection.
--- Additional Comments From [EMAIL PROTECTED] 2003-03-01 00:47 ---
Ooops. I meant to say call JDBCRealm.release(con) not close. In the standard
JDBCRealm implementation this will not do anything and is harmless, but for
sub-classes this allows us to return the connection to a pool.
So the change is just:
try {
release(open());
} catch (SQLException e) {
throw new LifecycleException(sm.getString(jdbcRealm.open), e);
}
I would be happy to do this change, but it is so trivial that it just seems
easier for a committer to do it.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
