Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-14 Thread Mario Ivankovits
I emailed marek about the CLIENT-CERT problem, still no response. I'm going to look into it and see what the gist of Mario's objections were, and if the patch is good. Good Words ;-) If you have any question do not hesitate to contact me. Mario

Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-14 Thread Tim Funk
Oops forgot about that one. There is a PATCH but the writer says that the bug is really with the JNDI Provider (Netscape) and not tomcat. The patch is a workaround to the Netcape's bug. (But maybe I took those words out of context) Remy - your thoughts on this one? (My pref is WONTFIX since the

Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-14 Thread Jeff Tulley
Tim, I've attached the diff file for the defect referenced by Jon on the user list. I was able to (fortunately) duplicate this going against eDirectory on NetWare; this one fix seems to solve bug #19864, and bug #11678 as well (JNDIRealm re-prompting for a password). Actually, the new code was

Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-14 Thread Tim Funk
I got eager and saw you bug update yesterday and applied a patch to 4.1 last night. Here's a link to the PATCH email: http://marc.theaimsgroup.com/?l=tomcat-devm=106004487327965w=2 The commit also does a null pointer check on the getMessage() to fix a related bug and also avoids doing the

Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-11 Thread Jeff Tulley
I just tested it, and the fix seems to work well. At first I thought that your null check would actually cause a problem, in case the exception is something besides a connection(or socket) closed, and the provider chose to not to set the message on the exception. But, I think the fact that the

Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-06 Thread Remy Maucherat
Tim Funk wrote: Oops forgot about that one. There is a PATCH but the writer says that the bug is really with the JNDI Provider (Netscape) and not tomcat. The patch is a workaround to the Netcape's bug. (But maybe I took those words out of context) Remy - your thoughts on this one? (My pref is

Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-05 Thread Tim Funk
in line ... Jeff Tulley wrote: With defect 20518 -- It does seem innocent, though if the primary LDAP server is down for an extended period of time, you would constantly be trying it first, then the alternate. But, I'm guessing the performance hit is not huge and the fix seems correct beyond

Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-05 Thread Jeff Tulley
From another user's comment, it looked like it was invalid and there didn't seem to be a rebuttal. But I had many windows open at the same time and may have gotten it confused with something else. Yeah, somebody was nitpicking the snippet of server.xml that he had there, where the thing they

Re: Fwd: Re: Tomcat and LDAP Issues

2003-08-02 Thread Tim Funk
Jeff, I see nine bugs out there for JNDIRealm for tomat 4 and 5, included is the one mentioned below in the previous email.

Fwd: Re: Tomcat and LDAP Issues

2003-08-01 Thread Jeff Tulley
Something from the user list of note for development. The current method does something like this when handling a communication exception at authenticate time: / If not a Socket closed. error then rethrow. if (e.getMessage().indexOf(Socket closed) 0)