Hi folks! I haven't contributed to tomcat in so long, I no longer have a working password to apache.org! :-) I.E. - my last commit predates the great break-in of '01 and during that time I had moved, changed jobs, etc. so I didn't get a new password back when they were being reset. It feels cool to be posting to tomcat-dev again! :-)
Well, sure enough, I have a change I need to commit. Attached is a patch to fix an obscure use of a deprecated java.lang.String method (getBytes(int,int,byte[],int)). In this case the fix is to simply use getBytes(). The patch I built applies the fix for jakarta-tomcat-4.0/catalina/share/src/org/apache/catalina/util/RequestUtil.java The same problem is also in the same file in the jakarta-tomcat-catalina module. Are these sym-linked together (i.e are they the same file?) or does the change need to be submitted separately for identical files in the separate modules? I am working on a project that may require the removal of the use of other deprecated API's and (among other things) we are using an embedded form of tomcat that may need to run on a VM that does not support deprecated APIs. If someone would tell me who I should contact to reset my committer account access ([EMAIL PROTECTED]), it would be very helpful. Cheers, Mel Dr. Mel Martinez [EMAIL PROTECTED] [EMAIL PROTECTED] __________________________________________________ Do you Yahoo!? Yahoo! Shopping - Send Flowers for Valentine's Day http://shopping.yahoo.com
Index: RequestUtil.java =================================================================== RCS file: /home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/RequestUtil.java,v retrieving revision 1.19 diff -u -r1.19 RequestUtil.java --- RequestUtil.java 21 Feb 2002 22:51:55 -0000 1.19 +++ RequestUtil.java 12 Feb 2003 17:18:27 -0000 @@ -331,9 +331,7 @@ throws UnsupportedEncodingException { if ((data != null) && (data.length() > 0)) { - int len = data.length(); - byte[] bytes = new byte[len]; - data.getBytes(0, len, bytes, 0); + byte[] bytes = data.getBytes(); parseParameters(map, bytes, encoding); } @@ -371,9 +369,7 @@ if (str == null) return (null); - int len = str.length(); - byte[] bytes = new byte[len]; - str.getBytes(0, len, bytes, 0); + byte[] bytes = str.getBytes(); return URLDecode(bytes, enc);
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]