Re: TCK request

2004-12-06 Thread Remy Maucherat
Shapira, Yoav wrote:
I don't hate you or anyone else ;)  I agree it's a fairly serious issue,
and it probably means 5.5.5 stays beta.  But that's not that big a
deal...
It copies the contents of the drive where Tomcat is installed to a 
folder named conf/Catalina/localhost/. It's 
recursive, so I don't know what it will do. All I know is that I killed 
my TC quite fast :)

Can you reproduce the issue ? (give the form a path to a war, but leave 
context empty)
I suppose most people will just use the form to upload a war just below, 
so this is not (thakfully) used too often. With the Ant task, I expect 
it to work ok, as the context attribute won't get submitted (and should 
be set to null).

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


RE: TCK request

2004-12-06 Thread Shapira, Yoav

Hi,

>>Can someone with access please run the Servlet and JSP TCKs against
>>Tomcat 5.5.5?  I'd like to have a stability vote starting Thursday.
>>
>I think you're going to hate me, but *32505* is a serious issue (which
I
>misundurstood at first), so it needs at least one hotfix :(

I don't hate you or anyone else ;)  I agree it's a fairly serious issue,
and it probably means 5.5.5 stays beta.  But that's not that big a
deal...

Yoav



This e-mail, including any attachments, is a confidential business 
communication, and may contain information that is confidential, proprietary 
and/or privileged.  This e-mail is intended only for the individual(s) to whom 
it is addressed, and may not be saved, copied, printed, disclosed or used by 
anyone else.  If you are not the(an) intended recipient, please immediately 
delete this e-mail from your computer system and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: TCK request

2004-12-06 Thread Remy Maucherat
Shapira, Yoav wrote:
Hi,
Can someone with access please run the Servlet and JSP TCKs against
Tomcat 5.5.5?  I'd like to have a stability vote starting Thursday.
I think you're going to hate me, but *32505* is a serious issue (which I 
misundurstood at first), so it needs at least one hotfix :(
AFAIK, the bug isn't a regression.

The change is very simple:
 diff -u -r1.22 -r1.23
 --- ManagerServlet.java	23 Sep 2004 07:03:27 -	1.22
 +++ ManagerServlet.java	3 Dec 2004 15:35:25 -	1.23
 @@ -737,6 +737,9 @@
  protected void deploy(PrintWriter writer, String config,
  String path, String war, boolean update) {
  
 +if (config != null && config.length() == 0) {
 +config = null;
 +}
  if (war != null && war.length() == 0) {
  war = null;
  }

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]