Re: back port to 3.2 -- JspInterceptor

2000-12-22 Thread Pierre Delisle 

Hi Costin,

 JspInterceptor is not "enabled" in 3.2 - it was one of the changes I
 wanted to spend more time into and make sure it's stable enough. It'll be
 used in 3.3 - or whatever will be called.

Thanks for the clarification. However since it is being compiled in the
build, it is "somewhat" enabled :-). I'll just comment out the part that 
does not compile (with proper references).

 BTW, did you fixed the command line compiler ? JspInterceptor is based on
 the command line compiler, so if you fix the first it'll be very easy for
 me to fix the 3.3 interceptor.

Sorry, my radar must have missed this one. If you can give me pointers/info,
I'll look into it.

-- Pierre

Re: back port to 3.2 -- JspInterceptor

2000-12-22 Thread Pierre Delisle 



[EMAIL PROTECTED] wrote:
 
   BTW, did you fixed the command line compiler ? JspInterceptor is based on
   the command line compiler, so if you fix the first it'll be very easy for
   me to fix the 3.3 interceptor.
 
  Sorry, my radar must have missed this one. If you can give me pointers/info,
  I'll look into it.
 
 JspC ? It's a great tool - and BTW, in 3.2 it can drastically increase the
 performance of jsp pages ( if you precompile _and_ use the option to
 automatically declare the jsps in web.xml )- it's almost as fast as 3.3
 with JspInterceptor ( which does the same thing at run time). ( it's not
 about the first compilation, but JspC and JspInterceptor are removing the
 *.jsp - JspServlet - actual page servlet overhead )

Costin,

Sorry, I was confused. I thought you meant that the command line compiler was broken
and needed a fix. 

A fix was made to JspC to accomodate the proper handling of "javaEncoding". 
Is that what you were asking?

-- Pierre

back port to 3.2 -- JspInterceptor

2000-12-21 Thread Pierre Delisle 

Tried to back port the last fix I made to Jasper in tomcat 4.0 
to tomcat 3.2 (the fix related to bug report #269 -- java encoding).

Was almost there until I realized there is a new class
"JspInterceptor" in tomcat 3.2 that is impacted by that fix. 
Unfortunately, I'm not too knowledgeable about this new class 
and am afraid I might miss something.

So, if some kind sould wants to do the port,
all the details are in my last commit.
Otherwise, I'd need someone to explain to me the relationship 
between the Compiler and JspInterceptor classes.
[Sorry, too tired and getting lazy...]

-- Pierre