cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java mbeans-descriptors.xml

2004-10-05 Thread remm
remm2004/10/05 10:12:52 Modified:catalina/src/share/org/apache/catalina/startup HostConfig.java catalina/src/share/org/apache/catalina/valves ValveBase.java catalina/src/share/org/apache/catalina Lifecycle.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-05-26 Thread yoavs
yoavs 2004/05/26 09:14:10 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: Minor JavaDoc fixes (Bugzilla 28335) Revision ChangesPath 1.22 +3 -3

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-02-06 Thread remm
remm2004/02/06 03:45:58 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - Call endAccess after reading a session from storage so that the session properly timeouts. - Bug 26715, submitted by Jochen Strunk.

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java PersistentManagerBase.java StandardSession.java PersistentManager.java ManagerBase.java

2004-01-26 Thread remm
remm2004/01/26 11:47:48 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java PersistentManagerBase.java StandardSession.java PersistentManager.java ManagerBase.java Log: - Remove

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-01-12 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: fhanik 2004/01/11 21:21:48 Modified:catalina/src/share/org/apache/catalina Manager.java catalina/src/share/org/apache/catalina/core StandardContext.java catalina/src/share/org/apache/catalina/session

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-01-12 Thread Filip Hanik
I'll roll back, fix my editor, I just noticed that Filip -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Monday, January 12, 2004 12:16 AM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-01-12 Thread Remy Maucherat
Filip Hanik wrote: I'll roll back, fix my editor, I just noticed that Cool. Did you do anything more other than adding the new method ? Anyway, roll back the changes as a whole, so that diffs work. I think cosmetic changes to the source code should be separate commits. Rémy

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-01-12 Thread Filip Hanik
PROTECTED] Sent: Monday, January 12, 2004 10:32 AM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java Filip Hanik wrote: I'll roll back, fix my editor, I just noticed that Cool. Did you do anything more other

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-01-12 Thread Remy Maucherat
Filip Hanik wrote: nope that is it. The method I added, and would still like to get buy in, is to add backgroundProcess() as a method to the manager interface. That way, any manager can take advantage of the background thread from the context calling that method. If we don't want to change the

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-01-12 Thread Filip Hanik
ok, if no one else objects, I'll add this in. Filip -Original Message- From: [mailto:[EMAIL PROTECTED] Sent: Monday, January 12, 2004 12:12 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2004-01-11 Thread fhanik
fhanik 2004/01/11 21:21:48 Modified:catalina/src/share/org/apache/catalina Manager.java catalina/src/share/org/apache/catalina/core StandardContext.java catalina/src/share/org/apache/catalina/session

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-12-10 Thread Amy Roh
Amy Roh wrote: [EMAIL PROTECTED] wrote: remm2003/12/05 01:28:55 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - isValid already expires sessions, so backgroundProcess shouldn't call expire again.

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-12-10 Thread Remy Maucherat
Amy Roh wrote: Amy Roh wrote: [EMAIL PROTECTED] wrote: There doesn't seem many methods changing isValid to false. invalidate is another one, and it calls expire. As long as all the methods which invalidate the session right away expire them, it should be ok I think. IMHO, not calling expire()

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-12-09 Thread Amy Roh
[EMAIL PROTECTED] wrote: remm2003/12/05 01:28:55 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - isValid already expires sessions, so backgroundProcess shouldn't call expire again. isValid doesn't *always* expire

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-12-09 Thread Remy Maucherat
Amy Roh wrote: [EMAIL PROTECTED] wrote: remm2003/12/05 01:28:55 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - isValid already expires sessions, so backgroundProcess shouldn't call expire again. isValid doesn't

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-12-05 Thread remm
remm2003/12/05 01:28:55 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - isValid already expires sessions, so backgroundProcess shouldn't call expire again. - Bug 25234, submitted by Paul Harvey. Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java

2003-11-29 Thread remm
remm2003/11/29 10:06:35 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java Log: - private - protected. A lot of this package should be protected, as there could be an good use case to reuse code by

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-08-26 Thread remm
remm2003/08/26 07:11:04 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - Don't restore invalid sessions. There's no apparent side effect to that. This fixes bug 22695 (the sessions were really invalid after all if

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java

2003-08-26 Thread remm
remm2003/08/26 07:18:54 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java StandardSession.java Log: - Revert my previous fix. I think it could cause sessions to not be invalidated properly. - Instead, don't check for

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2003-03-17 Thread costin
costin 2003/03/17 11:25:37 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: Registration. Less verbosity. Revision ChangesPath 1.7 +26 -16

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2002-12-09 Thread remm
remm2002/12/09 23:46:38 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - Remove getNewSession (moved to the superclass). Revision ChangesPath 1.5 +4 -12

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2002-12-05 Thread remm
remm2002/12/05 06:05:12 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - Allow specifying the implementation class for sessions when deserializing (obviously, JG doesn't like StandardSession instances). Revision

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardManager.java

2002-10-11 Thread remm
remm2002/10/10 23:58:20 Modified:catalina/src/share/org/apache/catalina/session StandardManager.java Log: - Allow disabling persistence using a blank String (BZ 13513). Revision ChangesPath 1.2 +5 -5