Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves RequestFilterValve.java
Glenn Nielsen wrote: On Wed, Apr 14, 2004 at 03:04:51PM -0500, Jess Holle wrote: Jan Luehe wrote: Sandy McArthur wrote: Does this mean J2SE 1.3 support is no more? On Apr 14, 2004, at 1:45 PM, [EMAIL PROTECTED] wrote: \ Log: Added support for exception chaining. +iae.initCause(e); If there is a strong desire to maintain BC with J2SE 1.3, I'll resort to the JdkCompat mechanism, but both Remy and Jess voiced (strongly in the case of Jess) opinions that there was no need for it. Though I strongly feel Java 2 v1.3.1 is too old to bother with it (and that those who are still stuck back on it for some strange reason can stick with older versions of Tomcat as well), I do believe a statement that "this and future versions of Tomcat shall require Java 2 v1.4 or higher" should accompany the first public release after any change requiring Java 2 v1.4 for basic functionality. I don't think the minimum JVM requirement should be changed between minor releases. What about those who for whatever reason can't move to java 1.4 yet but need a Tomcat upgrade path for bug fixes, etc.? You're right that this should likely have been stated on the first public release of 5 and not changed until 5.1 or some such -- Jess Holle - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves RequestFilterValve.java
On Wed, Apr 14, 2004 at 03:04:51PM -0500, Jess Holle wrote: > Jan Luehe wrote: > > >Sandy McArthur wrote: > > > >>Does this mean J2SE 1.3 support is no more? > >> > >>On Apr 14, 2004, at 1:45 PM, [EMAIL PROTECTED] wrote: \ > >> > >>> Log: > >>> Added support for exception chaining. > >>> +iae.initCause(e); > >> > >If there is a strong desire to maintain BC with J2SE 1.3, > >I'll resort to the JdkCompat mechanism, but both Remy and Jess > >voiced (strongly in the case of Jess) opinions that there was no need > >for it. > > Though I strongly feel Java 2 v1.3.1 is too old to bother with it (and > that those who are still stuck back on it for some strange reason can > stick with older versions of Tomcat as well), I do believe a statement > that "this and future versions of Tomcat shall require Java 2 v1.4 or > higher" should accompany the first public release after any change > requiring Java 2 v1.4 for basic functionality. I don't think the minimum JVM requirement should be changed between minor releases. What about those who for whatever reason can't move to java 1.4 yet but need a Tomcat upgrade path for bug fixes, etc.? Regards, Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves RequestFilterValve.java
On Apr 14, 2004, at 4:04 PM, Jess Holle wrote: Jan Luehe wrote: Sandy McArthur wrote: Does this mean J2SE 1.3 support is no more? On Apr 14, 2004, at 1:45 PM, [EMAIL PROTECTED] wrote: \ Log: Added support for exception chaining. +iae.initCause(e); If there is a strong desire to maintain BC with J2SE 1.3, I'll resort to the JdkCompat mechanism, but both Remy and Jess voiced (strongly in the case of Jess) opinions that there was no need for it. Though I strongly feel Java 2 v1.3.1 is too old to bother with it (and that those who are still stuck back on it for some strange reason can stick with older versions of Tomcat as well), I do believe a statement that "this and future versions of Tomcat shall require Java 2 v1.4 or higher" should accompany the first public release after any change requiring Java 2 v1.4 for basic functionality. Personally I'd prefer to drop J2SE 1.3 support. It gives me another argument to management for "See, those AIX 4.3 boxes are so old we cannot use the latest Tomcat on them because a 1.4 JVM isn't available." As a programmer/site admin/all around nice guy :) I think it would be nice if there was one more stable release that supported J2SE 1.3 that included an announcement like "This is the last version that will run on J2SE 1.3. All future versions of Tomcat will require a 1.4 JVM. You have been warned." Sandy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves RequestFilterValve.java
Jan Luehe wrote: Sandy McArthur wrote: Does this mean J2SE 1.3 support is no more? On Apr 14, 2004, at 1:45 PM, [EMAIL PROTECTED] wrote: \ Log: Added support for exception chaining. +iae.initCause(e); If there is a strong desire to maintain BC with J2SE 1.3, I'll resort to the JdkCompat mechanism, but both Remy and Jess voiced (strongly in the case of Jess) opinions that there was no need for it. Though I strongly feel Java 2 v1.3.1 is too old to bother with it (and that those who are still stuck back on it for some strange reason can stick with older versions of Tomcat as well), I do believe a statement that "this and future versions of Tomcat shall require Java 2 v1.4 or higher" should accompany the first public release after any change requiring Java 2 v1.4 for basic functionality. -- Jess Holle - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves RequestFilterValve.java
Sandy McArthur wrote: Does this mean J2SE 1.3 support is no more? On Apr 14, 2004, at 1:45 PM, [EMAIL PROTECTED] wrote: Log: Added support for exception chaining. +iae.initCause(e); If there is a strong desire to maintain BC with J2SE 1.3, I'll resort to the JdkCompat mechanism, but both Remy and Jess voiced (strongly in the case of Jess) opinions that there was no need for it. Jan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves RequestFilterValve.java
Does this mean J2SE 1.3 support is no more? On Apr 14, 2004, at 1:45 PM, [EMAIL PROTECTED] wrote: Log: Added support for exception chaining. +iae.initCause(e); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves RequestFilterValve.java
luehe 2004/04/14 10:45:18
Modified:catalina/src/share/org/apache/catalina/valves
RequestFilterValve.java
Log:
Added support for exception chaining.
Revision ChangesPath
1.4 +4 -2
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/RequestFilterValve.java
Index: RequestFilterValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/RequestFilterValve.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- RequestFilterValve.java 27 Feb 2004 14:58:52 - 1.3
+++ RequestFilterValve.java 14 Apr 2004 17:45:18 - 1.4
@@ -228,8 +228,10 @@
try {
reList.add(new RE(pattern));
} catch (RESyntaxException e) {
-throw new IllegalArgumentException
+IllegalArgumentException iae = new IllegalArgumentException
(sm.getString("requestFilterValve.syntax", pattern));
+iae.initCause(e);
+throw iae;
}
list = list.substring(comma + 1);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
