Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2005-07-21 Thread Jan Luehe
Bill, [EMAIL PROTECTED] wrote: billbarker2005/07/20 20:59:10 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Make certain that release is called for custom tags when tag-pooling is disabled. Fix for Bug #35696 Revision ChangesPath

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2005-07-21 Thread Bill Barker
- Original Message - From: Jan Luehe [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Thursday, July 21, 2005 6:24 PM Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Bill, [EMAIL PROTECTED

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2005-07-21 Thread billbarker
billbarker2005/07/21 21:16:25 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Return a custom tag to the pool when doEndTag returns SKIP_PAGE Submitted by: Jan Revision ChangesPath 1.242 +9 -2

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2005-07-20 Thread billbarker
billbarker2005/07/20 20:59:10 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Make certain that release is called for custom tags when tag-pooling is disabled. Fix for Bug #35696 Revision ChangesPath 1.241 +9 -2

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java

2005-03-02 Thread markt
markt 2005/03/02 12:56:03 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java JspUtil.java Log: Port fix for 22867 tag handlers can't be inner/nested classes from TC5 - TC4 port provided by Steven Parkes in bug 24586

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2005-02-22 Thread markt
markt 2005/02/22 14:00:55 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: Fix bug 25095. Tags generated by jsp:plugin are not well-formed. Revision ChangesPath No revision No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2005-02-08 Thread kinman
kinman 2005/02/08 10:03:58 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - More fine-tuning on smap for jsp:element, making sure that the java line range is at least one. Revision ChangesPath 1.239 +4 -3

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2005-02-07 Thread kinman
kinman 2005/02/07 16:23:58 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Samp for a jsp:element should not include its body. Revision ChangesPath 1.238 +3 -2

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-08-10 Thread luehe
luehe 2004/08/10 17:50:29 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: TOMCAT_5_0 Generator.java Log: Ported fixes for: - Bugzilla 30291 (Smap for a tag should not include its body) - Bugzilla 30289 (Incorrect Smap for multiple line java

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-07-26 Thread kinman
kinman 2004/07/26 13:50:36 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fix 30291: Smap for a tag should not include its body. - Fix 30289: Incorrect Smap for multiple line java expression. Revision ChangesPath 1.236 +8 -5

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-06-25 Thread luehe
luehe 2004/06/25 19:22:27 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: Fixed 18778: popBody not always called as expected resulting in unexpected output Revision ChangesPath No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-06-10 Thread kinman
kinman 2004/06/10 14:17:28 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fixed 29478: bean instantiations should be avoided at compilation time. Patch by Jess Holle Revision ChangesPath 1.233 +9 -1

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java

2004-06-10 Thread kinman
kinman 2004/06/10 17:29:57 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java Log: - If the value of the type attribute of the attribute directive is an array, allow it to be specified as [Lclassname; Revision Changes

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java

2004-04-19 Thread kinman
kinman 2004/04/19 14:10:19 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java Log: - Fix 28380: Javac error with ':' and '.' in attribute names. Revision ChangesPath 1.232 +7 -29

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-04-05 Thread luehe
luehe 2004/04/05 09:07:41 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Moved initialization of 'varName' to where it is needed Revision ChangesPath 1.231 +1 -1

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-26 Thread kinman
kinman 2004/03/26 16:52:55 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fix bugzilla 27665: Nested tags with scripting variables generates invalid code Revision ChangesPath 1.230 +16 -0

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-26 Thread kinman
kinman 2004/03/26 17:04:39 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: - Fix bugzilla 19361: Nested tags with scripting variables generates invalid code Revision ChangesPath No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-25 Thread luehe
luehe 2004/03/25 13:44:35 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed Bugzilla 27948 (NPE with null fragment) Revision ChangesPath 1.228 +8 -2

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-25 Thread luehe
luehe 2004/03/25 13:53:13 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed Bugzilla 27948 (NPE with null fragment) Revision ChangesPath 1.229 +8 -8

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-24 Thread kinman
kinman 2004/03/24 13:05:27 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - FIx bugzilla 16830: bodyContent content not reset when a tag is reused. Revision ChangesPath 1.227 +7 -2

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-24 Thread kinman
kinman 2004/03/24 13:31:07 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: -Fix 16830: bodyContent content not reset when a tag is reused. Revision ChangesPath No revision No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-22 Thread kinman
kinman 2004/03/22 16:06:07 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fix bugzilla 27830: undefined EL variable in unterpreted text (XML syntax) causes null (instead of) to be generated. Revision ChangesPath 1.225 +1 -1

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-22 Thread luehe
luehe 2004/03/22 17:56:40 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Return 500 error code if JSP error page mechanism is invoked (the current impl used to return 200) Revision ChangesPath 1.226 +6 -0

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-02 Thread kinman
kinman 2004/03/02 11:39:13 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Annotate several node types with missing Java line information. This also fixes bugzilla 27368: missing smap for UninterpretedTag nodes. Revision ChangesPath

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-03-01 Thread kinman
kinman 2004/03/01 13:09:21 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fix bugzilla 27330: pageContext not defined in the body of nest tags. Revision ChangesPath 1.221 +6 -3

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-18 Thread kinman
kinman 2004/02/18 13:30:54 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Remove Sun copyright. Revision ChangesPath 1.220 +3 -8 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java Index:

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-03 Thread remm
remm2004/02/03 00:27:43 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Revert patch. Revision ChangesPath 1.218 +32 -28 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java Index: Generator.java

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-03 Thread Remy Maucherat
Mark Roth wrote: Okay, I took a look at the patch and the bug report and I think I know what's going on now. Please let me know if I do not understand the scenario correctly. It seems there are some JSP 1.2 pages that misuse jsp:useBean by doing one of the following: 1. The class attribute

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread remm
remm2004/02/02 10:18:01 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Revert useBean optimization done by Kin-Man, as it seems to violate the spec wording (which basically says that an error should occur at runtime if the class is not a

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Kin-Man Chung
: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java To: [EMAIL PROTECTED] remm2004/02/02 10:18:01 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Revert useBean optimization

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Remy Maucherat
Kin-Man Chung wrote: -1. Remy, please reread JSP 2.0 spec, p 1-101,1-102. Bullet .2 of the Semantics section was added to allow for this kind of optimization. Bullet .5 and .6 will be executed ONLY IF the container choose not to issue translation errors. I cannot really understand what the

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Kin-Man Chung
happy... -Kin-man Date: Mon, 02 Feb 2004 19:41:54 +0100 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java To: Tomcat Developers List [EMAIL PROTECTED] Kin-Man Chung wrote: -1. Remy, please

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Remy Maucherat
Kin-Man Chung wrote: Agreed that the spec can be clearer. :-) This has been discussed by the Spec expert group, and bullet .2 was added because some vendors wanted it. I'll check with the spec lead for a clarification. Ok. Also agreed that this breaks backward compatibility; but it not really

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Kin-Man Chung
Date: Mon, 02 Feb 2004 20:17:29 +0100 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java To: Tomcat Developers List [EMAIL PROTECTED] Kin-Man Chung wrote: Agreed that the spec can be clearer

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Remy Maucherat
Kin-Man Chung wrote: I'd rather you check with me first before the patch, but since it is already done, let's wait for the spec clarification before we do anything. A revert on a revert would make us look really silly. :-) This has been lying in BZ for a while, that's why I just patched. Ok, I'll

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Mark Roth
will be executed ONLY IF the container choose not to issue translation errors. -Kin-man Date: Mon, 02 Feb 2004 18:18:01 + From: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java To: [EMAIL PROTECTED] remm2004/02/02 10:18:01

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2004-02-02 Thread Mark Roth
Okay, I took a look at the patch and the bug report and I think I know what's going on now. Please let me know if I do not understand the scenario correctly. It seems there are some JSP 1.2 pages that misuse jsp:useBean by doing one of the following: 1. The class attribute is used for a

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-11-05 Thread kinman
kinman 2003/11/05 10:31:34 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - A smal performance improvement: instantiate the bean object with its constructor, if class attribute is specified in usebean, instead of going thru

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-10-20 Thread kinman
kinman 2003/10/20 14:07:46 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Tweak the SMAP tracking code so that it works for classic custom tag and JSP fragments. This also fixes bug 23691. Revision ChangesPath 1.214 +48 -28

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-10-10 Thread luehe
luehe 2003/10/10 10:40:39 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Quote value of 'classid' attribute Revision ChangesPath 1.213 +11 -18 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java SmapStratum.java SmapUtil.java

2003-09-22 Thread Kin-Man Chung
PROTECTED] Sent: Tuesday, September 16, 2003 10:46 AM Subject: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java SmapStratum.java SmapUtil.java kinman 2003/09/16 10:46:44 Modified:jasper2/src/share/org/apache/jasper

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-22 Thread Kin-Man Chung
.examples.el.Functions.class, numVowels, new Class[] {java.lang.String.class}); } which is clearly wrong. Eric - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 19, 2003 4:38 PM Subject: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java SmapStratum.java SmapUtil.java

2003-09-22 Thread Eric Carmichael
Message - From: Kin-Man Chung [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, September 22, 2003 1:00 PM Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java SmapStratum.java SmapUtil.java The actual mapping before we

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java SmapStratum.java SmapUtil.java

2003-09-20 Thread Eric Carmichael
number advances in the input file or the output file. Eric - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, September 16, 2003 10:46 AM Subject: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-20 Thread Eric Carmichael
is clearly wrong. Eric - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 19, 2003 4:38 PM Subject: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java kinman 2003/09/19 16:38:09 Modified:jasper2

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java

2003-09-19 Thread kinman
kinman 2003/09/19 11:30:10 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java Log: - When a tag handler class is an inner class, it is specified in the TLD in binary form (Outer$Inner). It needs to be converted to

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-19 Thread kinman
kinman 2003/09/19 16:38:09 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Make sure scriptlet declarations get properly mapped. This fixes 22833 Revision ChangesPath 1.211 +7 -6

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-18 Thread kinman
kinman 2003/09/18 16:12:39 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - When adjusting Java lines for tag handler codes that are generated in a body, make sure to include the CustomTag node itself. This avoid strange Smap mappings in some

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java SmapStratum.java SmapUtil.java

2003-09-16 Thread kinman
kinman 2003/09/16 10:46:44 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java SmapStratum.java SmapUtil.java Log: - For template texts that generate multiple Java lines, addidtional mapping informantion are kept in the

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-15 Thread ecarmich
ecarmich2003/09/15 06:43:54 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fix SMAPping for small text strings with genStrAsCharArray=false Revision ChangesPath 1.207 +18 -18

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-11 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: kinman 2003/09/10 16:11:56 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Use out.print(expr) instead of out.write(String.valueOf(expr)) for outputting expressions in template texts. The problem was when the expression was

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-11 Thread Kin-Man Chung
to raise NPE. Let's leave print's in until someone else objects! :-) -Kin-man Date: Thu, 11 Sep 2003 08:53:36 +0200 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java To: Tomcat Developers List [EMAIL

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-10 Thread kinman
kinman 2003/09/10 16:11:56 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Use out.print(expr) instead of out.write(String.valueOf(expr)) for outputting expressions in template texts. Revision ChangesPath 1.206 +4 -5

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-04 Thread kinman
kinman 2003/09/04 15:30:06 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fix a careless mistake. Revision ChangesPath 1.204 +4 -4 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java Index:

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-03 Thread kinman
kinman 2003/09/03 14:20:29 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Use just the class name if package is imported. - In tag files, declare request as HttpServletRequest and response HttpServletResponse, as is the case in servlets.

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-09-02 Thread ecarmich
ecarmich2003/09/01 22:50:47 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Expand wildcard imports Remove unused imports Remove tabs Revision ChangesPath 1.202 +3044

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-08-22 Thread luehe
luehe 2003/08/22 12:42:58 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Avoid defining multiple getServletInfo() methods (one for each page directive with an 'info' attribute) Revision ChangesPath 1.201 +22 -5

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-08-21 Thread kinman
kinman 2003/08/21 16:59:11 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Don't generate code to do an instanceof when it can be done at translation. - Minor code cleanup in the codes generated for fragments. Revision ChangesPath 1.199

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-08-21 Thread kinman
kinman 2003/08/21 17:07:32 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Remove obselete codes in comments. Revision ChangesPath 1.200 +3 -41 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-08-20 Thread luehe
luehe 2003/08/20 09:37:10 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Temporary hack. If a JSP page uses the extends attribute of the page directive, the _jspInit() method of the generated servlet class will not be called (it is only called for

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java

2003-08-18 Thread kinman
kinman 2003/08/18 17:36:35 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java Log: - Adjust Java lines mappings for codes that are generated in buffers. The diff is more than was actually changed, due to a change of a class

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-08-17 Thread kinman
kinman 2003/08/17 14:54:36 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - The out in the Fragment helper functions is now JspWriter instead of java.io.Writer, so that it won't trigger errors when a fragment contains include actions.

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java SmapStratum.java SmapUtil.java

2003-08-14 Thread remm
remm2003/08/09 12:19:37 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java JspUtil.java SmapStratum.java SmapUtil.java Log: - Bug 2006: Invalid SMAP line entries when running with mappedfile=true. - Submitted by Eric Carmichael (like

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-08-03 Thread remm
remm2003/08/03 02:07:47 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fix incorrect indentation of generated code, submitted by Eric Carmichael. Revision ChangesPath 1.193 +6 -4

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-07-20 Thread billbarker
billbarker2003/07/20 22:34:56 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fix comment generation. Fix for bug #21753 Submitted by: Eric Carmichael [EMAIL PROTECTED] Revision ChangesPath 1.190 +7 -9

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-06-23 Thread kinman
kinman 2003/06/23 16:20:45 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Allow the value attrbute of jsp:param action be non String types. Revision ChangesPath 1.189 +14 -11

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java

2003-03-31 Thread luehe
luehe 2003/03/31 13:14:05 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java Log: Fixed wrong signature of setJspContext for SimpleTag handlers that are not supported by tag files Revision ChangesPath 1.179 +11

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-02-28 Thread kinman
kinman 2003/02/28 14:12:39 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fix a typo for tag plugins. Revision ChangesPath 1.171 +4 -4 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java Index:

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-02-27 Thread luehe
luehe 2003/02/27 12:10:13 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed 17492: If the omit-xml-declaration attribute of jsp:output is 'true' or 'yes' in the context of a JSP document, the xml declaration is still generated. Revision

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-02-25 Thread luehe
luehe 2003/02/25 16:54:02 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed bracket indentation Revision ChangesPath 1.167 +6 -6 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java Index:

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-02-25 Thread luehe
luehe 2003/02/25 17:11:15 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed 17052: jsp:element name attribute clobbered by nested jsp:attribute (cont.) Revision ChangesPath 1.168 +9 -9

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-02-24 Thread luehe
luehe 2003/02/24 08:38:41 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: Fixed 17049: Invalid code generated when nesting tags Revision ChangesPath No revision No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java JspDocumentParser.java Node.java Parser.java

2003-02-13 Thread luehe
luehe 2003/02/13 10:15:46 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java JspDocumentParser.java Node.java Parser.java Log: Added support for jsp:fallback to XML syntax Revision Changes

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Validator.java

2003-02-10 Thread luehe
luehe 2003/02/10 09:06:15 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Validator.java Log: Fixed 16200 (isThreadSafe does not work !!) Revision ChangesPath No revision No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-30 Thread luehe
luehe 2003/01/30 12:30:52 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed out-of-scope problem with pushBody count variables when custom tag invocations are separated out into their own methods Revision ChangesPath 1.157 +15 -5

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-22 Thread costin
costin 2003/01/22 11:55:47 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Use the factory method of TagHandlerPool Revision ChangesPath 1.152 +5 -5 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-22 Thread costin
costin 2003/01/22 12:54:54 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Move tag pool initialization to _jspInit - to have access to config info. Revision ChangesPath 1.153 +16 -11

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-21 Thread luehe
luehe 2003/01/21 15:45:19 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Modified code generated for jsp:plugin to be well-formed. Example: Previous format of generated code: COMMENT EMBED ... NOEMBED /COMMENT

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-17 Thread luehe
luehe 2003/01/16 17:21:16 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed 16181: JspWriter not restored properly when exception thrown in a tag's body content Revision ChangesPath 1.150 +12 -12

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-17 Thread luehe
luehe 2003/01/16 17:21:06 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: Fixed 16181: JspWriter not restored properly when exception thrown in a tag's body content Revision ChangesPath No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-17 Thread luehe
luehe 2003/01/16 16:51:23 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: Fixed 16181: JspWriter not restored properly when exception thrown in a tag's body content Revision ChangesPath No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-17 Thread luehe
luehe 2003/01/16 16:51:35 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed 16181: JspWriter not restored properly when exception thrown in a tag's body content Revision ChangesPath 1.149 +48 -7

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-15 Thread luehe
luehe 2003/01/15 14:46:29 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed 15961 (getBodyContent() is not returning null when the action has only jsp:attribute actions within the body) for simple tag handlers Revision ChangesPath 1.148

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java

2003-01-10 Thread luehe
luehe 2003/01/10 16:52:14 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java Log: Fixed 15961: getBodyContent() is not returning null when the action has only jsp:attribute actions within the body. Revision Changes

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java Validator.java

2003-01-08 Thread luehe
luehe 2003/01/08 10:42:43 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java Validator.java Log: Fixed 15854: Unable to provide a qname attribute value to the name attribute of the jsp:attribute action.

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-08 Thread luehe
luehe 2003/01/08 14:15:57 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Applied patch provided by Dimitry Ivanov to fix synchronization of AT_BEGIN and NESTED variables for tag handlers implementing BodyTag whose doStartTag() returns

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-08 Thread luehe
luehe 2003/01/08 14:24:29 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: Applied patch provided by Dimitry Ivanov to fix synchronization of AT_BEGIN and NESTED variables for tag handlers implementing BodyTag

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java Parser.java

2002-12-16 Thread luehe
luehe 2002/12/16 08:13:28 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java Parser.java Log: Fixed 15364: The jsp:body action doesn't work as expected when used with the jsp:fallback action. Revision ChangesPath

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-12-16 Thread kinman
kinman 2002/12/16 15:38:00 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Turn off XML escape for EL. Revision ChangesPath 1.143 +4 -4 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java Index:

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-12-12 Thread luehe
luehe 2002/12/12 15:31:52 Modified:jasper2/src/share/org/apache/jasper/runtime JspRuntimeLibrary.java jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Added support for named attributes whose associated attributes are of

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-12-11 Thread luehe
luehe 2002/12/11 11:40:46 Modified:jasper2/src/share/org/apache/jasper/runtime JspRuntimeLibrary.java jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Added support for named attributes that do not evaluate to String

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java JspDocumentParser.java Node.java Parser.java

2002-12-11 Thread luehe
luehe 2002/12/11 19:30:59 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java JspDocumentParser.java Node.java Parser.java Log: - Allow empty jsp:attribute body, and treat it as . - In a JSP document (XML syntax), preserve any leading and

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-12-03 Thread luehe
luehe 2002/12/03 15:49:46 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Do not call the setParent() method on SimpleTag handlers if the value being passed is null, since SimpleTag instances are not reused Revision ChangesPath 1.135 +11

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java TagPluginManager.java

2002-11-25 Thread kinman
kinman 2002/11/25 17:25:29 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java TagPluginManager.java Log: - Revert changes for tag plugin work. I changed my mind. :-) Revision ChangesPath 1.131 +64 -80

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-11-22 Thread luehe
luehe 2002/11/22 15:47:15 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed 14699: Scripting variables declared AT_END do not work when tag implements TryCatchFinally. Revision ChangesPath 1.129 +9 -8

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-11-22 Thread luehe
luehe 2002/11/22 15:47:32 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: Fixed 14699: Scripting variables declared AT_END do not work when tag implements TryCatchFinally. Revision Changes

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-11-18 Thread kinman
kinman 2002/11/18 16:49:42 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: - Fix 14577: Declarations should geneate a '\n' at end. Revision ChangesPath 1.128 +4 -3

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-11-18 Thread kinman
kinman 2002/11/18 16:51:05 Modified:jasper2/src/share/org/apache/jasper/compiler Tag: tomcat_4_branch Generator.java Log: - Fix 14577: Declarations should geneate a '\n' at end. Revision ChangesPath No revision No

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-11-15 Thread luehe
luehe 2002/11/15 11:41:28 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Optimization: Do not create JSP fragment for simple tag invocation if tag body is empty Revision ChangesPath 1.126 +14 -8

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-11-07 Thread luehe
luehe 2002/11/07 11:09:03 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Use 'this' qualifier to disambiguate jspContext instance (e.g., required when invoking fragment from within simple tag). Revision ChangesPath 1.122 +11 -11

  1   2   >