Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-07-23 Thread Remy Maucherat
Jan Luehe wrote: Remy Maucherat wrote: BTW, I don't see why the spec saying that the header is optional implies that the flag must be implemented as something optional. It merely means that an implementation may ignore completely this feature. Actually, the Servlet spec is going to say

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-07-23 Thread Remy Maucherat
Jan Luehe wrote: one comment, though: By adding the xpoweredBy property to CoyoteConnector instead of Host/Context, we get the X-Powered-By: Servlet/2.4 response header even for static resources. You could argue that this is OK, since static resources are handled by the DefaultServlet, but

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-07-22 Thread Remy Maucherat
Jan Luehe wrote: This is a pretty bad implementation IMO. What's the use of disabling this feature ? The spec declares these headers as optional, which means Tomcat should make them configurable. Some sites may prefer not to include this information in their responses, for security reasons or

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-07-22 Thread Remy Maucherat
Martin Algesten wrote: Remy, I don't agree with that at all. For security reasons you always want the option to reveal as little as possible about your system. By default httpd creates headers like: Server: Apache/1.3.26 (Unix) mod_jk/1.1.0 DAV/1.0.3 mod_ssl/2.8.9 OpenSSL/0.9.6b Which for a

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-07-22 Thread Tim Funk
Could an alternative be to introduce a Valve which does the equivalent of mod_headers? -Tim - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-07-22 Thread Remy Maucherat
Tim Funk wrote: Could an alternative be to introduce a Valve which does the equivalent of mod_headers? Well, I'm trying to reduce the stack trace length of the default installation, so I don't think this is a good idea. Jan's implementation was right IMO in the respect of where approximately

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-07-21 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2003/07/21 12:06:35 Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java Log: Added support for X-Powered-By response header, as defined by the Servlet 2.4 and JSP 2.0 specs. The Servlet 2.4 spec defines a special

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-01-29 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: jfarcand2003/01/29 10:20:08 Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java Log: Add a small comment to remind that the case occurs only when DummyRequest is used. Thsi method should never return a null enumration. The thing is that

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servletJspServlet.java

2003-01-29 Thread Jeanfrancois Arcand
OK Then I will remove that and create a dummy enumeration instead :-) -- Jeanfrancois Remy Maucherat wrote: [EMAIL PROTECTED] wrote: jfarcand2003/01/29 10:20:08 Modified:jasper2/src/share/org/apache/jasper/servlet JspServlet.java Log: Add a small comment to remind that the