DO NOT REPLY [Bug 20380] - AccessLogValve incorrectly calculates timezone

2005-03-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=20380.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=20380


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-28 21:12 ---
This has now been fixed in TC4.1.x and TC5.5.x

For the record getOffset() can't be used (at least in TC4) as it is a JDK 1.4
method and TC4 has to work with JDK 1.2

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 20380] - AccessLogValve incorrectly calculates timezone

2004-03-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=20380.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=20380

AccessLogValve incorrectly calculates timezone

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |
Version|4.1.24  |4.1.30



--- Additional Comments From [EMAIL PROTECTED]  2004-03-25 01:07 ---
The offset still appears to be incorrect, though for a different reason that
that originally reported: the timezone offset output does not include daylight
saving. At the moment:

   x.x.x.x - - [25/Mar/2004:10:17:07 +0930] GET / HTTP/1.1 304 -

should be reported as:

   x.x.x.x - - [25/Mar/2004:10:17:07 +1030] GET / HTTP/1.1 304 -

Looking at org.apache.catalina.valves.AccessLogValve (4.1.30), line 1128 is:
   timeZone = calculateTimeZoneOffset(tz.getRawOffset());

I think this should use the TimeZone.getOffset() method instead, which returns
the offset including DST. AFAICS from the CVS history the getRawOffset() method
has always been used.

Considering the length of time this has been in the source, either (a) I'm
wrong, or (b) few people care.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 20380] - AccessLogValve incorrectly calculates timezone

2003-06-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20380.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20380

AccessLogValve incorrectly calculates timezone

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-06-04 17:01 ---
Fixed in tomcat5. If ok - will eventually backport to 4.1

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]