RE: License files error - PMC Approval Required
(Trimming licensing from the to list, as prompted by Greg Stein) On Tue, 23 Dec 2003, Mark Thomas wrote: OK. The patch files have all been attached to the bug report at http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10286 Once I get the OK from the PMC I will commit them. +1 from me. Seems pretty straightforward. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: License files error
Howdy, Yeah, I wondered why it crossed my inbox for approval when it came from you (the first, non-apache one) ;) I think the change is OK. Yoav Shapira Millennium ChemInformatics -Original Message- From: Mark Thomas [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 23, 2003 1:00 PM To: Tomcat-Dev (E-mail) Subject: License files error Resending using my apache e-mail address. Sorry for the duplicate mail. All, There is a small grammatical error in most (all?) of the license files in various tomcat CVS repositories as described in http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10286. Does anyone have any objection to me editing the tomcat license files to align them with the official version (http://www.apache.org/LICENSE)? I ask since I don't want to change the license file in case there are any legal complications. I can't see why there would be but you never know - better safe than sorry ;) Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: License files error
On Tue, 23 Dec 2003, Mark Thomas wrote: them with the official version (http://www.apache.org/LICENSE)? I ask since I don't want to change the license file in case there are any legal complications. I can't see why there would be but you never know - better safe than sorry ;) You bet :-) Fiddling with the license, no matter how trivial, should be checked, double checked, triple checked and approved first :-) So what is the error ? I read on bug id #10286: The LICENSE file contains a small grammatical error in the first condition. The word 'notice' is incorrectly repeated. From the license (1.1) file (http://www.apache.org/LICENSE): * 1. Redistributions of source code must retain the above copyright *notice, this list of conditions and the following disclaimer. What is the incorrect repeat ? Dw -- Dirk-Willem van Gulik, President of the ASF. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: License files error
A lot of the license files in tomcat have the following lines: * 1. Redistributions of source code must retain the above copyright notice * *notice, this list of conditions and the following disclaimer. * Note that notice appears at the end of the first line as well as the beginning of the second. Mark On Tuesday, December 23, 2003 6:02 PM, Dirk-Willem van Gulik [SMTP:[EMAIL PROTECTED] wrote: So what is the error ? I read on bug id #10286: The LICENSE file contains a small grammatical error in the first condition. The word 'notice' is incorrectly repeated. From the license (1.1) file (http://www.apache.org/LICENSE): * 1. Redistributions of source code must retain the above copyright *notice, this list of conditions and the following disclaimer. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: License files error
Files in question: http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-4.0/LICENSE?rev=1.4view=auto http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-5/LICENSE?rev=1.1.1.1view=auto Looking at CVS, it looks like some other jakarta projects have also had (differenet) typo problems and also fixed their LICENSE files so I guess the change is OK as long as it gets in sync with http://www.apache.org/LICENSE -Tim Dirk-Willem van Gulik wrote: On Tue, 23 Dec 2003, Mark Thomas wrote: them with the official version (http://www.apache.org/LICENSE)? I ask since I don't want to change the license file in case there are any legal complications. I can't see why there would be but you never know - better safe than sorry ;) You bet :-) Fiddling with the license, no matter how trivial, should be checked, double checked, triple checked and approved first :-) So what is the error ? I read on bug id #10286: The LICENSE file contains a small grammatical error in the first condition. The word 'notice' is incorrectly repeated. From the license (1.1) file (http://www.apache.org/LICENSE): * 1. Redistributions of source code must retain the above copyright *notice, this list of conditions and the following disclaimer. What is the incorrect repeat ? Dw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: License files error
On Tue, 23 Dec 2003, Mark Thomas wrote: A lot of the license files in tomcat have the following lines: * 1. Redistributions of source code must retain the above copyright notice * *notice, this list of conditions and the following disclaimer. * Note that notice appears at the end of the first line as well as the beginning of the second. Ok - no problem, genuine error - permission for a committer to fix this; BUT I strongly suggest to play it safe and follow this procedure: - post a patch _first_, Cc: the PMC and [EMAIL PROTECTED] and then - commit exactly that patch after a quick OK from your PMC. Make sure there are no other changes in that commit - no code, nothing (except perhaps something like the CHANGES file) but the above fix and make sure there is a nice log message saying what was changed to the license and why ;-) Sorry to be overly careful; but the last time we had such a 'quick and trivial fix' we lost a few lines out of the disclaimer in a few files by accident due to \r\n inconsistency and it took us a while to notice. Dw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: License files error
Will do. I'll start preparing the patches now. Mark On Tuesday, December 23, 2003 6:23 PM, Dirk-Willem van Gulik [SMTP:[EMAIL PROTECTED] wrote: On Tue, 23 Dec 2003, Mark Thomas wrote: A lot of the license files in tomcat have the following lines: * 1. Redistributions of source code must retain the above copyright notice * *notice, this list of conditions and the following disclaimer. * Note that notice appears at the end of the first line as well as the beginning of the second. Ok - no problem, genuine error - permission for a committer to fix this; BUT I strongly suggest to play it safe and follow this procedure: -post a patch _first_, Cc: the PMC and [EMAIL PROTECTED] and then -commit exactly that patch after a quick OK from your PMC. Make sure there are no other changes in that commit - no code, nothing (except perhaps something like the CHANGES file) but the above fix and make sure there is a nice log message saying what was changed to the license and why ;-) Sorry to be overly careful; but the last time we had such a 'quick and trivial fix' we lost a few lines out of the disclaimer in a few files by accident due to \r\n inconsistency and it took us a while to notice. Dw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: License files error - PMC Approval Required
OK. The patch files have all been attached to the bug report at http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10286 Once I get the OK from the PMC I will commit them. Mark On Tuesday, December 23, 2003 9:21 PM, Mark Thomas [SMTP:[EMAIL PROTECTED] wrote: Will do. I'll start preparing the patches now. Mark On Tuesday, December 23, 2003 6:23 PM, Dirk-Willem van Gulik [SMTP:[EMAIL PROTECTED] wrote: On Tue, 23 Dec 2003, Mark Thomas wrote: A lot of the license files in tomcat have the following lines: * 1. Redistributions of source code must retain the above copyright notice * *notice, this list of conditions and the following disclaimer. * Note that notice appears at the end of the first line as well as the beginning of the second. Ok - no problem, genuine error - permission for a committer to fix this; BUT I strongly suggest to play it safe and follow this procedure: - post a patch _first_, Cc: the PMC and [EMAIL PROTECTED] and then - commit exactly that patch after a quick OK from your PMC. Make sure there are no other changes in that commit - no code, nothing (except perhaps something like the CHANGES file) but the above fix and make sure there is a nice log message saying what was changed to the license and why ;-) Sorry to be overly careful; but the last time we had such a 'quick and trivial fix' we lost a few lines out of the disclaimer in a few files by accident due to \r\n inconsistency and it took us a while to notice. Dw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
