Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/coreStandardWrapper.java

2002-11-06 Thread Remy Maucherat 
[EMAIL PROTECTED] wrote:


costin  2002/11/05 13:35:00

  Modified:catalina/src/share/org/apache/catalina/core
StandardWrapper.java
  Log:
  Use commons-logging.

  Add a short message for servlets that take a long time to load
  ( right now it's 200 ms - we can increase it, but no need to
  make it configurable, it's mostly do debug perf. ).

  I used idea to edit the file - and it removed unused imports and
  forced me to fix some name mismatches... Probably should go back
  to emacs...



Especially since it converted the imports to * imports (evil, evil). 
Please stop using it or disable the feature (and can you revert the 
changes on the imports ?).

Remy


--
To unsubscribe, e-mail:   mailto:tomcat-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:tomcat-dev-help;jakarta.apache.org

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/coreStandardWrapper.java

2002-11-06 Thread Tim Funk 
In case you weren't joking ...

It can easily break compatibility if someone introduces a new class with 
the same class name as another class in a different package.

ex:
import foo.*; /* has class A */
import bar.*; /* has class B */

class Foo {
A a;
B b;
}

Imagine time going by and another developer creates another class called 
A in the bar package. The code above will not recompile because of the 
abiguous class name.

-Tim


Costin Manolache wrote:
BTW - what's evil in import * ? I never understood.




--
To unsubscribe, e-mail:   mailto:tomcat-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:tomcat-dev-help;jakarta.apache.org

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/coreStandardWrapper.java

2002-11-06 Thread Henri Gomez 
Tim Funk wrote:

In case you weren't joking ...

It can easily break compatibility if someone introduces a new class with 
the same class name as another class in a different package.

ex:
import foo.*; /* has class A */
import bar.*; /* has class B */

class Foo {
A a;
B b;
}

Imagine time going by and another developer creates another class called 
A in the bar package. The code above will not recompile because of the 
abiguous class name.

I think costin is speaking about importing java.io.*
or org.apache.*.

BTW, there is ant task, for example CheckStyle 
(http://checkstyle.sourceforge.net/) which could be used
and which may be integrated in build/gump to clean code




--
To unsubscribe, e-mail:   mailto:tomcat-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:tomcat-dev-help;jakarta.apache.org