Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Protocol.java

2003-08-14 Thread Remy Maucherat 
[EMAIL PROTECTED] wrote:
luehe   2003/08/11 14:44:49
  +public void setProtocols(String k) {
  +setAttribute(protocols, k);
  +}
  +
This probably should be sslProtocols, no ?

Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11Http11Protocol.java

2002-10-22 Thread Glenn Nielsen 
There are times when client disconnects (aborted requests) may be an indicator
of problems within Tomcat.  An increased number of aborted requests can be an
indicator that Tomcat performance has degraded to the point where request
latency has increased to the point where remote users are giving up on viewing
the page.  Or there may just be one JSP page or servlet which takes a long
time to finish generating a response.

I think this exception should be at the WARN or INFO level, and the message
should mention that the most likely cause is that the request was aborted
by the remote client.  No need to log the exception stack trace, just log
a message.

Regards,

Glenn


[EMAIL PROTECTED] wrote:

remm2002/10/22 02:23:32

  Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java
  Log:
  - Decrease amount of logging (client disconnects are normal, so they should
have DEBUG level IMO).
  
  Revision  ChangesPath
  1.16  +0 -4  jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
  
  Index: Http11Protocol.java
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- Http11Protocol.java	7 Jun 2002 00:48:21 -	1.15
  +++ Http11Protocol.java	22 Oct 2002 09:23:32 -	1.16
  @@ -394,15 +394,11 @@
   TcpConnection.shutdownInput( socket );
   } catch(java.net.SocketException e) {
   // SocketExceptions are normal
  -proto.log.info(sm.getString
  -   (http11protocol.proto.socketexception.info));
   proto.log.debug
   (sm.getString
(http11protocol.proto.socketexception.debug), e);
   } catch (java.io.IOException e) {
   // IOExceptions are normal 
  -proto.log.info(sm.getString
  -   (http11protocol.proto.ioexception.info));
   proto.log.debug
   (sm.getString
(http11protocol.proto.ioexception.debug), e);
  
  
  

--
To unsubscribe, e-mail:   mailto:tomcat-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:tomcat-dev-help;jakarta.apache.org




--
To unsubscribe, e-mail:   mailto:tomcat-dev-unsubscribe;jakarta.apache.org
For additional commands, e-mail: mailto:tomcat-dev-help;jakarta.apache.org