Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-02-03 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2004/02/02 15:08:29 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Expose handshake failure as error, so it gets logged unconditionally -1. Unlike what occurs for normal sockets, errors at this point are rather common,

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-01-13 Thread Remy Maucherat
if( usePool ) { con=(TcpConnection)connectionCache.get(); if( con == null ) I would like to remove this pool thing. It is dead code (there's a static final flag to enable it at compile time), so I think it should go. Rémy

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: amyroh 2003/11/24 15:01:22 Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Add getters for all attributes defined in MBeanInfo so getAttribute calls suceed.

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: amyroh 2003/11/24 15:01:22 Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Add getters for all attributes defined in MBeanInfo so getAttribute calls suceed.

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-25 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, November 25, 2003 12:27 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java [EMAIL PROTECTED] wrote

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-25 Thread Amy Roh
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Tuesday, November 25, 2003 12:27 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java [EMAIL PROTECTED] wrote

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-01 Thread Remy Maucherat
Bill Barker wrote: Jan Luehe [EMAIL PROTECTED] wrote in message Remy, I think we should make any maxThreads setting work, as my patch attempts to do, and update the documentation to make users aware of the limitations they will run into when picking a low maxThreads. I think that would be the

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-01 Thread Tim Funk
Could a simple compromise be - Die (with error message) if 2 - Warn if less than 10 (or ??). Letting the user be stupid, but warn them about it. -Tim Bill Barker wrote: Jan Luehe [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] Remy, I agree we should help users come up with

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-01 Thread Remy Maucherat
Tim Funk wrote: Could a simple compromise be - Die (with error message) if 2 - Warn if less than 10 (or ??). Letting the user be stupid, but warn them about it. I don't agree with that behavior. Why should we fail or (worse) allow bad values ? Good defaults and being tolerant is a quality of

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-01 Thread Sriram N
+1 on that. I'd rather that TC defaulted to safe values over my idotically low or even absent settings. -- Sriram --- Remy Maucherat [EMAIL PROTECTED] wrote: Tim Funk wrote: Could a simple compromise be - Die (with error message) if 2 - Warn if less than 10 (or ??). Letting the user be

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Remy Maucherat
Jan Luehe wrote: Remy Maucherat wrote: I guess I don't understand what makes 1 bad but 2 OK. Where do we draw the line of what is a stupid config? Yes, definitely, 2 is nearly as stupid as 1. We need a reasonable minimal value for maxThreads; let's say 10 - 20. Remy

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: I guess I don't understand what makes 1 bad but 2 OK. Where do we draw the line of what is a stupid config? Yes, definitely, 2 is nearly as stupid as 1. We need a reasonable minimal value for maxThreads; let's say 10 - 20. Remy, I

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Remy Maucherat
Jan Luehe wrote: I agree we should help users come up with reasonable config values, but I'm just afraid rejecting any maxThreads 10 or 20 will send the wrong message, as if there was a bug in the way we dispatch incoming requests that requires at least 10 threads. Nope, I disagree. If

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Jan Luehe
Remy, I agree we should help users come up with reasonable config values, but I'm just afraid rejecting any maxThreads 10 or 20 will send the wrong message, as if there was a bug in the way we dispatch incoming requests that requires at least 10 threads. Nope, I disagree. If maxThreads (say)

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Bill Barker
Jan Luehe [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] Remy, I agree we should help users come up with reasonable config values, but I'm just afraid rejecting any maxThreads 10 or 20 will send the wrong message, as if there was a bug in the way we dispatch incoming

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first request: SEVERE: All threads (1)

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Bill Barker
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, October 30, 2003 1:45 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java [EMAIL PROTECTED] wrote

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Remy Maucherat
Bill Barker wrote: [EMAIL PROTECTED] wrote: luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first request: SEVERE: All

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Jan Luehe
Remy Maucherat wrote: Bill Barker wrote: [EMAIL PROTECTED] wrote: luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: glenn 2003/10/22 06:46:28 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: SocketExceptions can occur in a networked app. No need to log a stack trace, just log the remote host name/ip and the exception message. Then there is

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-22 Thread Glenn Nielsen
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: glenn 2003/10/22 06:46:28 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: SocketExceptions can occur in a networked app. No need to log a stack trace, just log the remote host name/ip and the exception

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-04 Thread Bill Barker
- Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Saturday, October 04, 2003 11:05 AM Subject: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java remm2003/10/04 11:05:29 Modified:

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-04 Thread Bill Barker
- Original Message - From: Bill Barker [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Saturday, October 04, 2003 3:10 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java - Original Message

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Stefan Bodewig
On 12 Sep 2003, [EMAIL PROTECTED] wrote: +++ PoolTcpEndpoint.java 12 Sep 2003 03:51:36 - 1.16 @@ -389,12 +389,12 @@ if (accepted != null) { try { accepted.close(); -accepted = null;

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Bill Barker
- Original Message - From: Stefan Bodewig [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 12, 2003 12:58 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java On 12 Sep 2003, [EMAIL PROTECTED] wrote

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Remy Maucherat
Bill Barker wrote: On 12 Sep 2003, [EMAIL PROTECTED] wrote: +++ PoolTcpEndpoint.java 12 Sep 2003 03:51:36 - 1.16 @@ -389,12 +389,12 @@ if (accepted != null) { try { accepted.close(); -accepted = null; }

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Stefan Bodewig
On Fri, 12 Sep 2003, Bill Barker [EMAIL PROTECTED] wrote: From: Stefan Bodewig [EMAIL PROTECTED] wouldn't it be better to put the accepted = null into a finally block Wouldn't do anything. The 'accepted' variable is local to the stack-frame, so it goes away if I throw clear of the method.