Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java
Does this need to be back ported to the Tomcat 4.1 branch of Jasper?
[EMAIL PROTECTED] wrote:
luehe 2003/01/29 19:22:01
Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
Log:
Capture javac error messages
Revision ChangesPath
1.48 +1 -4 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
Index: Compiler.java
===
RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -r1.47 -r1.48
--- Compiler.java 26 Jan 2003 19:00:58 - 1.47
+++ Compiler.java 30 Jan 2003 03:22:01 - 1.48
@@ -153,10 +153,7 @@
logger = new JasperAntLogger();
logger.setOutputPrintStream(System.out);
logger.setErrorPrintStream(System.err);
-
-if( log.isTraceEnabled() ) {
-logger.setMessageOutputLevel( Project.MSG_VERBOSE );
-}
+ logger.setMessageOutputLevel(Project.MSG_INFO);
project.addBuildListener( logger);
if( options.getCompiler() != null ) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
--
Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder|
MOREnet System Programming | * if iz ina coment. |
Missouri Research and Education Network | */ |
--
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java
[EMAIL PROTECTED] wrote: glenn 2002/12/31 06:01:17 Modified:jasper2/src/share/org/apache/jasper EmbededServletOptions.java JspC.java Options.java jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: Implement new Ant javac fork option. If set to true Ant forks a new process to compile JSP pages and does it without synchronization. Default is false. I didn't try it (but I was looking at that in the Ant docs after the posts in tomcat-user), but there seems to be redundency in Ant, as using extJavac as the compier name is supposed to do the same. Since changing the compiler name is already supported, maybe adding the fork parameter was not needed. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: glenn 2002/12/31 06:01:17 Modified:jasper2/src/share/org/apache/jasper EmbededServletOptions.java JspC.java Options.java jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: Implement new Ant javac fork option. If set to true Ant forks a new process to compile JSP pages and does it without synchronization. Default is false. I didn't try it (but I was looking at that in the Ant docs after the posts in tomcat-user), but there seems to be redundency in Ant, as using extJavac as the compier name is supposed to do the same. Since changing the compiler name is already supported, maybe adding the fork parameter was not needed. BTW, I just found that: quote Windows Note:When the modern compiler is used in unforked mode on Windows, it locks up the files present in the classpath of the javac task, and does not release them. The side effect of this is that you will not be able to delete or move those files later on in the build. The workaround is to fork when invoking the compiler. /quote So it could (finally) explain the mysterious JAR file locking on Windows. I think we should set to fork as the default; javac is just too risky to run in the same process ;-) Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java
Remy Maucherat wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: glenn 2002/12/31 06:01:17 Modified:jasper2/src/share/org/apache/jasper EmbededServletOptions.java JspC.java Options.java jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: Implement new Ant javac fork option. If set to true Ant forks a new process to compile JSP pages and does it without synchronization. Default is false. I didn't try it (but I was looking at that in the Ant docs after the posts in tomcat-user), but there seems to be redundency in Ant, as using extJavac as the compier name is supposed to do the same. Since changing the compiler name is already supported, maybe adding the fork parameter was not needed. BTW, I just found that: quote Windows Note:When the modern compiler is used in unforked mode on Windows, it locks up the files present in the classpath of the javac task, and does not release them. The side effect of this is that you will not be able to delete or move those files later on in the build. The workaround is to fork when invoking the compiler. /quote Right, I think I posted that in my original proposal. So it could (finally) explain the mysterious JAR file locking on Windows. I think we should set to fork as the default; javac is just too risky to run in the same process ;-) Thats fine with me. Go for it. :-) Glenn -- Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder| MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | -- -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java
Costin Manolache wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: costin 2002/12/10 16:38:29 Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: Remove getCanonicalPath. This may not be a good idea, and I think would break Jasper on Windows. I'll revert it, if you don't mind. I added it in my previous patch, it wasn't there before - and it broke something. ( I added it because the path looked strange on windows - with a \/file.java in it, but it works fine without getCanonicalPath and it seems it doesn't if getCP is added ) In the end, it looked to work, after fixing the compilation problem, so I didn't revert anything :) Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java
[EMAIL PROTECTED] wrote: costin 2002/12/10 16:38:29 Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: Remove getCanonicalPath. This may not be a good idea, and I think would break Jasper on Windows. I'll revert it, if you don't mind. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java
On Fri, 14 Jun 2002, Kin-Man Chung wrote: costin 2002/06/14 13:44:37 Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: Split the compile() method in generateJava() and generateClass() - JspC only generates java, the compile is a separate step. Why not have an option to include javac compilation in JspC? There has been requests for this functionality. Quite easy to do so, I can add it. But some people prefer to have it separated, and use javac for compilation ( where you can specify the options much easier, in standard ant syntax ). I also prefer to keep the source and .class separated, in my build file I generated the source in a separate directory, I compile then I build a jar, and only the .jar gets into the WEB-INF. ( well, this also makes easier debugging, since I have the source in jswat's sourcepath ) But there's no problem in adding the option. Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
