Re: [tor-bugs] #18812 [Core Tor/Tor]: [warn] Tried connecting to router at 81.7.17.171:443, but identity key was not as expected: wanted 00C4B4731658D3B4987132A3F77100CFCB190D97 but got CFECDDCA990E3E

[Tor Bug Tracker & Wiki]

#18812: [warn] Tried connecting to router at 81.7.17.171:443, but identity key 
was
not as expected: wanted 00C4B4731658D3B4987132A3F77100CFCB190D97 but got
CFECDDCA990E3EF7B7EC958B22441386B6B8D820.
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  fallback, must-fix-  |Version:  Tor:
  before-028-stable, easy, TorCoreTeam201606 |  0.2.8.1-alpha
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:  0.5
 | Points:  1
 |Sponsor:
-+-
Changes (by teor):

 * keywords:  fallback, must-fix-before-028-rc, easy => fallback, must-fix-
 before-028-stable, easy, TorCoreTeam201606
 * status:  assigned => needs_review
 * actualpoints:   => 0.5


Comment:

 Please see my branch bug18812 on https://github.com/teor2345/tor.git

 It replaces the warning with an info-level log, with additional text
 saying we'll just try another fallback.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19518 [Core Tor]: Configure argument --without-tcmalloc causes linking with libtcmalloc library

[Tor Bug Tracker & Wiki]

#19518: Configure argument --without-tcmalloc causes linking with libtcmalloc
library
-+--
 Reporter:  yurivict271  |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor |Version:  Tor: 0.2.7.6
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 Only --with-tcmalloc should link with the library.

 Please make sure that this and other --with- flags don't malfunction
 this way.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+--
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  reopened
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by ikurua22):

 First things first, @yawning,

 > a) I removed myself because this has nothing to do with me.

 Please explain why this scandal is "nothing to do with me".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+--
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  reopened
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by ikurua22):

 Just in case you delete my post again; https://archive.is/nFCHI

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+--
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  reopened
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by ikurua22):

 * status:  closed => reopened
 * resolution:  not a bug =>


Comment:

 This is not a "bug". Yeah, sure. But this is an "issue" which must be
 discussed with the
 community. Also, why do you delete my 2nd posts? I'll post it again for
 all of you.

 As a admin who host 2 Tor non-exit nodes, and Tor user, I want to read
 your official
 statement about this leak. Is this hard for you? I ask again, where can I
 find "transparen-
 cy of your project"?

 The more you try to close this issue without explanation, the more doubt
 will rise.
 What else are you hiding, Tor Project?

 asn: George Kadianakis
 atagar: Damian Johnson
 athena: Andrea Shepard
 DaveC1: David Chasteen
 gamambel: Moritz Bartl
 helix: Erinn Clark
 ioerror: Jacob Appelbaum
 infinity0: Ximin Luo
 isis: Isis Agora Lovecruft
 Julius23: Julius Mittenzwei
 Lunar^: Lunar
 mikeperry: Mike Perry
 mrphs: Nima Fatemi
 puffin: Karen Reilly
 Phoul: Colin Childs
 qbi: Jens Kubieziel
 Runa: Runa Sandvik
 sekritarma: Roger Dingledine
 sysrqb: Matt Finkel
 weasel: Peter Palfrader
 yawning: Yawning

 I hope you being honest with us.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+---
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:  not a bug
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by saint):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 Replying to [comment:2 cypherpunks]:
 > HEY TOR PROJECT, ARE YOU A CHILD OR SOMETHING?
 > WHY DID YOU REJECT MY MAIL, AND BLOCKING FURTHER DUSCUSSION?

 The moderation queue only affects new subscribers. You subscribed with two
 new accounts within one minute and immediately tried to post a bunch of
 unrelated blog comments and links, peppered with bizarre accusations.
 Other people are still sharing their opinions (both pro-Tor and anti-Tor)
 in that thread.

 I'm closing this as it is absolutely not a bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+-
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by yawning):

 Since I'm still getting e-mail spam despite removing myself from the CC
 list...

   a) I removed myself because this has nothing to do with me.
   b) I did not write the blog post.

 Leave me out of this bullshit.  I don't care, I have more important things
 to do.  Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+-
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ikurua22):

 > Is being held until the list moderator can review it for approval.
 > "Your message was deemed inappropriate by the moderator."

 What? Really, Tor?
 So you think hiding this info and let people forget about it is OK?

 Dear these people, if you have a little morality, please
 consider posting a public statement about this to your official
 Tor Project Blog.

 asn: George Kadianakis
 atagar: Damian Johnson
 athena: Andrea Shepard
 DaveC1: David Chasteen
 gamambel: Moritz Bartl
 helix: Erinn Clark
 ioerror: Jacob Appelbaum
 infinity0: Ximin Luo
 isis: Isis Agora Lovecruft
 Julius23: Julius Mittenzwei
 Lunar^: Lunar
 mikeperry: Mike Perry
 mrphs: Nima Fatemi
 puffin: Karen Reilly
 Phoul: Colin Childs
 qbi: Jens Kubieziel
 Runa: Runa Sandvik
 sekritarma: Roger Dingledine
 sysrqb: Matt Finkel
 weasel: Peter Palfrader
 yawning: Yawning

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19517 [- Select a component]: crashing in OS X on 6.0, 6.01, 6.02

[Tor Bug Tracker & Wiki]

#19517: crashing in OS X on 6.0, 6.01, 6.02
--+-
 Reporter:  cypherpunks   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:  crash, OS X
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Should have sent this dump sooner.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #5430 [Metrics/Atlas]: Add top-10 relays by bandwidth history to Atlas?

[Tor Bug Tracker & Wiki]

#5430: Add top-10 relays by bandwidth history to Atlas?
--+
 Reporter:  karsten   |  Owner:  irl
 Type:  enhancement   | Status:
 Priority:  Low   |  needs_review
Component:  Metrics/Atlas |  Milestone:
 Severity:  Normal|Version:
 Keywords:  complete-before-abandoning-globe  | Resolution:
Parent ID:  #6787 |  Actual Points:
 Reviewer:| Points:
  |Sponsor:
--+

Comment (by phw):

 The patch looks great, thanks irl! I had to fix a merge conflict. Do you
 mind having a quick look at the last commits, to see if I merged your
 changes correctly? It's all in the master branch at
 https://gitweb.torproject.org/user/phw/atlas.git/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+-
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Recorded for evidence. https://archive.is/DfeCK

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+-
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 HEY TOR PROJECT, ARE YOU A CHILD OR SOMETHING?
 WHY DID YOU REJECT MY MAIL, AND BLOCKING FURTHER DUSCUSSION?

 You are really harming people's trust by hiding and blocking.
 DO YOU REALIZE THAT?

 1. I send an email and got this.
 
 Your mail to 'tor-talk' with the subject

 Re: [tor-talk] Why do you hide the fact that "Ex-CIA in Tor" from
 all of Tor users?

 Is being held until the list moderator can review it for approval.

 The reason it is being held:

 Post to moderated list

 Either the message will get posted to the list, or you will receive
 notification of the moderator's decision.  If you would like to cancel
 this posting, please visit the following URL:
 

 2. I tried to post these;
 
 continue from hts;!!lists.torproject.org/pipermail/tor-
 talk/2016-June/041667.html
 ===


 Found a post "Yawning" posts(I don't know he is true, but it seems so):
 @www.schneier.com/blog/archives/2016/06/friday_squid_bl_533.html
 ===
 Yawning • June 27, 2016 7:05 AM

 This Tor dustup is total man bites dog.

 CIA weasel trying (or pretending) to go straight finds out he stinks up
 every place he goes.
 If a guy with balls did this, he would disclose and denounce some crimes.
 Instead, this DaveC1 tool lies about his background, then when he gets
 caught he offers to set up a back-channel with CIA.
 After threatening a discrimination suit.

 This is the kind of dipshit that CIA hires.
 They recruit manipulative worms.
 This one has zero integrity, as required, he's just too much of a coward
 to gain some semblance of bona fides by breaking the rules.
 He can't talk about anything. Pussy.

 hts;!!cryptome.org/2016/06/ex-cia-inside-tor.pdf

 Tho possibly relevant to the Jacob-Applebaum-is-a-sexual-predator-and-
 also-horny-and-mean-too furor:

 htp;!!theindicter.com/the-weaponising-of-social-part-2-stomping-on-
 ioerrors-grave/
 ===


 He also removed himself without explanation.
 @trac.torproject.org/projects/tor/ticket/19513
 ===
 Changed 6 hours ago by yawning
 Cc yawning removed
 ===
 

 2b. Sent another email because of blocking, titled: "Tor Project is
 blocking the C-I-A releated discussion now.".

 3. Got this a few minutes later.
 
 Your request to the tor-talk mailing list

 Posting of your message titled "Tor Project is blocking the C-I-A
 releated discussion now."

 has been rejected by the list moderator.  The moderator gave the
 following reason for rejecting your request:

 "Your message was deemed inappropriate by the moderator."

 Any questions or comments should be directed to the list administrator
 at:

 tor-talk-ow...@lists.torproject.org
 

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19516 [Applications/Tor Browser]: TBB build from source error: exeDir was not declared

[Tor Bug Tracker & Wiki]

#19516: TBB build from source error: exeDir was not declared
--+---
 Reporter:  zenitur   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by zenitur):

 Replying to [comment:4 mcs]:
 > I am not sure about your build procedure, but if you are not building
 the updater you are probably encountering #19484. Does the patch in that
 ticket fix this build problem?

 Yes, it was fixed my problem!

 What are a next steps? Tor binary, Torbutton, Tor Launcher, HTTPS-
 Everywhere, NoScript and Pluggable Transports?

 P.S. I'm sorry for a detailed description of build procedure. I thought it
 was important.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #6314 [Applications/TorBirdy]: prevent leak via Date header field (local timestamp disclosure)

[Tor Bug Tracker & Wiki]

#6314: prevent leak via Date header field (local timestamp disclosure)
---+-
 Reporter:  tagnaq |  Owner:  ioerror
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:
Component:  Applications/TorBirdy  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by arthuredelstein):

 * status:  reopened => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #6314 [Applications/TorBirdy]: prevent leak via Date header field (local timestamp disclosure)

[Tor Bug Tracker & Wiki]

#6314: prevent leak via Date header field (local timestamp disclosure)
---+--
 Reporter:  tagnaq |  Owner:  ioerror
 Type:  defect | Status:  reopened
 Priority:  High   |  Milestone:
Component:  Applications/TorBirdy  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by arthuredelstein):

 * status:  closed => reopened
 * resolution:  fixed =>
 * parent:  #9131 =>


Comment:

 For reference, there are two patches in torbirdy for this ticket:

 
https://github.com/ioerror/torbirdy/commit/7169642643b91f203782d8e6a885d53fbb43f49e
 
https://github.com/ioerror/torbirdy/commit/230ba97882424d35e12794c45db7c6715fe753f9

 We patched torbirdy instead of landing a patch in Thunderbird.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18640 [Core Tor/Tor]: Use smarter algorithms to handle socket exhaustion

[Tor Bug Tracker & Wiki]

#18640: Use smarter algorithms to handle socket exhaustion
+--
 Reporter:  nickm   |  Owner:  andrea
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.9.x-final
 Severity:  Normal  |Version:
 Keywords:  tor-dos, TorCoreTeam201606  | Resolution:
Parent ID:  #17293  |  Actual Points:
 Reviewer:  | Points:  3
|Sponsor:  SponsorU-can
+--
Changes (by nickm):

 * milestone:   => Tor: 0.2.9.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19449 [Core Tor/Tor]: Remove --disable-transparent configure option?

[Tor Bug Tracker & Wiki]

#19449: Remove --disable-transparent configure option?
--+
 Reporter:  arma  |  Owner:
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => merge_ready
 * milestone:  Tor: 0.2.??? => Tor: 0.2.9.x-final


Comment:

 This looks okay with me .. just need a changes file. I'll add one when I
 merge, unless somebody else writes one first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18322 [Core Tor/Tor]: Log unparseable votes so they can be analysed

[Tor Bug Tracker & Wiki]

#18322: Log unparseable votes so they can be analysed
-+-
 Reporter:  teor |  Owner:  andrea
 Type:  defect   | Status:
 Priority:  Medium   |  merge_ready
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-dos, TorCoreTeam201606, review-  |Version:
  group-4| Resolution:
Parent ID:  #17293   |  Actual Points:  3
 Reviewer:   | Points:  2
 |Sponsor:
 |  SponsorU-can
-+-
Changes (by nickm):

 * status:  needs_revision => merge_ready


Comment:

 I'm actually going to call it merge_ready (pending my review) -- since
 fixing up changes stuff is no big deal for me, and otherwise I'll forget
 this. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19468 [Core Tor/Tor]: Revise prop259 to fit the Tor networking API

[Tor Bug Tracker & Wiki]

#19468: Revise prop259 to fit the Tor networking API
-+-
 Reporter:  asn  |  Owner:  nickm
 Type:  defect   | Status:
 Priority:  Medium   |  accepted
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-guard TorCoreTeam201606 prop259  |Version:
Parent ID:  #12595   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:  3
 |Sponsor:
 |  SponsorU-must
-+-

Comment (by nickm):

 Just added a third version based on most recent comments.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19516 [Applications/Tor Browser]: TBB build from source error: exeDir was not declared

[Tor Bug Tracker & Wiki]

#19516: TBB build from source error: exeDir was not declared
--+---
 Reporter:  zenitur   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by mcs):

 I am not sure about your build procedure, but if you are not building the
 updater you are probably encountering #19484. Does the patch in that
 ticket fix this build problem?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19478 [Applications/Tor Browser]: File API leaks ms-resolution time

[Tor Bug Tracker & Wiki]

#19478: File API leaks ms-resolution time
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  tbb-fingerprinting,  |Version:
  TorBrowserTeam201606R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:7 arthuredelstein]:
 > Thanks everyone for having a look at this patch. I used 10 exactly
 because that mLastModificationDate variable is in microseconds, so my
 feeling is the patch is correct. What part do you have in mind that needs
 to be changed?

 Hmm. On second thought, I think your patch is correct. I will try to
 compile and run it later, unless GeKo has second thoughts about the
 problem he saw.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19516 [Applications/Tor Browser]: TBB build from source error: exeDir was not declared

[Tor Bug Tracker & Wiki]

#19516: TBB build from source error: exeDir was not declared
--+---
 Reporter:  zenitur   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by zenitur):

 My build way is hard.

 1). Try to compile Firefox:
 a). Install deps.

 sudo yum-builddep firefox

 b). Install non-repository deps:

 tar xf Python-2.7.8.tgz
 cd Python-2.7.8
 ./configure --prefix=/home/zenitur/python --exec-
 prefix=/home/zenitur/python
 make
 make install
 cd ..

 tar xf yasm-1.2.0.tar.gz
 cd yasm-1.2.0
 ./configure --prefix/home/zenitur/yasm --exec-prefix=/home/zentur/yasm
 make
 make install
 cd ..

 c). Enable GCC 4.8.2 from
 http://linux.web.cern.ch/linux/devtoolset/#install

 scl enable devtoolset-2 bash
 gcc --version
 export PATH=/home/zenitur/python/bin:/home/zenitur/yasm/bin:$PATH

 d). Build Firefox

 tar xf firefox-45.2esr-source.tar.xz
 cd firefox-45.2.0esr
 cp ../mozconfig .mozconfig
 cp ../mozilla-api-key .
 cp ~/mozilla-patches/* .
 ./apply.sh
 make -f client.mk build
 cd objdir/dist
 cp -R -L -p bin ~/firefox-45.2esr

 2). Try to build Tor Browser

 a). Compare .mozconfig files

 b). Download GIT:

 git clone https://git.torproject.org/tor-browser.git

 c). Switch to the branch:

 cd tor-browser
 git checkout 6803b2f08165a02cac4621db10fc2e1d99b7b435

 d). Remove GIT hidden files and make backup

 find . -name .git -print0 | xargs -0 rm -rf
 cd ..
 tar cf tor-browser-45.2.tar tor-browser
 xz tor-browser-45.2.tar

 e). Build

 cd tor-browser
 cp ../mozconfig .mozconfig
 cp ~/mozilla-patches/* .
 ./apply.sh
 make -f client.mk configure
 make -j3 -f client.mk build

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19478 [Applications/Tor Browser]: File API leaks ms-resolution time

[Tor Bug Tracker & Wiki]

#19478: File API leaks ms-resolution time
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  tbb-fingerprinting,  |Version:
  TorBrowserTeam201606R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:6 mcs]:
 > Replying to [comment:4 gk]:
 > > Hm. `new Date.getTime()` gives me something like 1467036079100 and
 `Math.floor(new File([], "").lastModified / 10) * 10)`
 146703610 or 146703640 or something similar. It seems your code is
 not rounding to 100ms?
 >
 > The units for mLastModificationDate are microseconds, so part of the
 patch will need to be changed.

 Thanks everyone for having a look at this patch. I used 10 exactly
 because that mLastModificationDate variable is in microseconds, so my
 feeling is the patch is correct. What part do you have in mind that needs
 to be changed?

 Here are relevant lines from the mochitest on OS X. I think it is
 correctly rounding to the most recent 100 ms.
 {{{
 7 INFO TEST-PASS | tbb-tests/test_tor_bug1517.html | 'new
 Date().getTime()' should be rounded to nearest 100 ms; saw 1467057044400
 [snip]
 13 INFO TEST-PASS | tbb-tests/test_tor_bug1517.html | 'new File([],
 "").lastModified' should be rounded to nearest 100 ms; saw 1467057044500
 14 INFO TEST-PASS | tbb-tests/test_tor_bug1517.html | 'new File([],
 "").lastModifiedDate.getTime()' should be rounded to nearest 100 ms; saw
 1467057044500
 }}}

 > I am not sure how to fix the tests to detect when values are rounded too
 much. Maybe by using a real file with a known modified date?

 If we bind this behavior to a pref (perhaps in the upstreamed version) and
 then measure the same value with pref on and off, it should be possible to
 test that the two values are within 100 ms. But since we don't have that
 pref right now, I would be inclined to just do manual tests for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19516 [Applications/Tor Browser]: TBB build from source error: exeDir was not declared

[Tor Bug Tracker & Wiki]

#19516: TBB build from source error: exeDir was not declared
--+---
 Reporter:  zenitur   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by zenitur):

 I build TBB in some old Linux (CentOS 6) just for self using. I have been
 applied patches for downgrade dependencies:
 https://yadi.sk/d/xds05pH6sqFG5

 My .mozconfig: http://pastebin.com/Z0i36uLV

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19481 [Applications/Tor Browser]: Change app.update.url to point to aus1.tpo

[Tor Bug Tracker & Wiki]

#19481: Change app.update.url to point to aus1.tpo
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201606R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:1 mcs]:
 > Here is a patch for the browser:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19481-01=0df39cf9448b523421db8f66d300b2586613d004
 >
 > Is this all we need to do? What about key pinning for aus1.tpo and
 cdn.tpo?

 weasel said there is no key pinning for aus1.tpo nor for cdn.tpo right
 now. It might come in the future.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19516 [Applications/Tor Browser]: TBB build from source error: exeDir was not declared

[Tor Bug Tracker & Wiki]

#19516: TBB build from source error: exeDir was not declared
--+---
 Reporter:  zenitur   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * cc: mcs, brade (added)
 * status:  new => needs_information


Comment:

 How are you building it? What does your .mozconfig file look like?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19516 [Applications/Tor Browser]: TBB build from source error: exeDir was not declared

[Tor Bug Tracker & Wiki]

#19516: TBB build from source error: exeDir was not declared
--+--
 Reporter:  zenitur   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Linux x86 32-bit, GCC 4.8.2, branch "tor-browser-45.2.0esr-6.0-1"

 An error log: http://pastebin.com/UdSd99Jy

 {{{
 c++ -o Unified_cpp_dom_power0.o -c -I/home/zenitur/tor-browser/tor-
 browser/obj-i686-pc-linux-gnu/dist/stl_wrappers -I/home/zenitur/tor-
 browser/tor-browser/obj-i686-pc-linux-gnu/dist/system_wrappers -include
 /home/zenitur/tor-browser/tor-browser/config/gcc_hidden.h -DOS_POSIX=1
 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API
 -DIMPL_LIBXUL -I/home/zenitur/tor-browser/tor-browser/dom/power -I.
 -I../../ipc/ipdl/_ipdlheaders -I/home/zenitur/tor-browser/tor-
 browser/ipc/chromium/src -I/home/zenitur/tor-browser/tor-browser/ipc/glue
 -I../../dist/include  -I/home/zenitur/tor-browser/tor-browser/obj-i686-pc-
 linux-gnu/dist/include/nspr -I/home/zenitur/tor-browser/tor-
 browser/obj-i686-pc-linux-gnu/dist/include/nss   -fPIC
 -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF
 .deps/Unified_cpp_dom_power0.o.pp  -Wall -Wempty-body -Woverloaded-virtual
 -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -fno-
 exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno
 -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -g -Os -march=i686 -fomit-
 frame-pointer  -Wshadow   /home/zenitur/tor-browser/tor-browser/obj-i686
 -pc-linux-gnu/dom/power/Unified_cpp_dom_power0.cpp
 /home/zenitur/tor-browser/tor-browser/toolkit/xre/nsAppRunner.cpp: In
 member function ‘int XREMain::XRE_mainStartup(bool*)’:
 /home/zenitur/tor-browser/tor-browser/toolkit/xre/nsAppRunner.cpp:4398:65:
 error: ‘exeDir’ was not declared in this scope
rv = SelectProfile(getter_AddRefs(mProfileLock), mProfileSvc, exeDir,
  ^
 }}}

 I've found a huge patch: https://github.com/MeisterP/torbrowser-
 overlay/blob/master/www-client/torbrowser/files/torbrowser-45.1.1-exeDir-
 not-declared.patch

 Can it be fixed easy? With dirty hack for example

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19001 [Obfuscation/Snowflake]: Tor Browser with Snowflake

[Tor Bug Tracker & Wiki]

#19001: Tor Browser with Snowflake
---+-
 Reporter:  dcf|  Owner:
 Type:  project| Status:  new
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by mrphs):

 * cc: mrphs (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE

[Tor Bug Tracker & Wiki]

#19259: uncaught NFE
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  needs_information
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by karsten):

 Replying to [comment:14 iwakeh]:
 > That was the information I was intending to elicit :-) Thanks!
 >
 > Just a few things left:
 >
 > > How about we represent missing values on disk as empty string (`""`),
 which also saves disk space, and in memory as `-1.0` to keep the current
 code working?
 > >
 > I still would prefer Double.NaN (cf. comment:9) as being more obvious in
 code/in memory.

 Okay, let's use `Double.NaN` then.

 > On disk it could be the empty string even though not very nice, but it's
 used already anyway.

 Okay.  Well, the nice part is that it saves disk space.  We'll just need
 to make it compatible with existing status files that contain negative
 doubles.

 > > > `testCompare` fails, b/c there is an entry with the key from the
 first and values from the second element.
 > >
 > > Let's reject those lines, too.
 > It's not that easy here; the test demonstrates would could happen b/c of
 the
 > comparator not being compatible with equal.
 > So the missing part is an ordering for the intervals. The only one I can
 think
 > of is the lexicographical ordering according to interval ends, e.g.,
 > [10, 20] before [10, 21] before [12, 25].  That should capture the
 intend of
 > the current approach?

 Okay, sounds good to me.

 Thanks for trying hard to understand this code!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19515 [Applications/Tor Browser]: Hardened Tor Browser Crash (AddressSanitizer: stack-buffer-overflow)

[Tor Bug Tracker & Wiki]

#19515: Hardened Tor Browser Crash (AddressSanitizer: stack-buffer-overflow)
---+--
 Reporter:  pege   |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Critical   | Resolution:
 Keywords:  tbb-crash, ff45-esr-will-have  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * keywords:  tbb-crash, ff45esr-will-have => tbb-crash, ff45-esr-will-have


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19515 [Applications/Tor Browser]: Hardened Tor Browser Crash (AddressSanitizer: stack-buffer-overflow)

[Tor Bug Tracker & Wiki]

#19515: Hardened Tor Browser Crash (AddressSanitizer: stack-buffer-overflow)
--+--
 Reporter:  pege  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:  tbb-crash, ff45esr-will-have  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-crash, ff45esr-will-have
 * priority:  Medium => Very High
 * severity:  Normal => Critical


Comment:

 Thanks. This is https://bugzilla.mozilla.org/show_bug.cgi?id=1268854 and
 the fix already landed on ESR45. We'll pick it up with 45.3.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19515 [Applications/Tor Browser]: Hardened Tor Browser Crash (AddressSanitizer: stack-buffer-overflow)

[Tor Bug Tracker & Wiki]

#19515: Hardened Tor Browser Crash (AddressSanitizer: stack-buffer-overflow)
--+--
 Reporter:  pege  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by mcs):

 * cc: gk, mcs (added)
 * owner:   => tbb-team
 * component:  - Select a component => Applications/Tor Browser


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18923 [Applications/Tor Browser]: Add a script in tor-browser.git to run all of our TBB-specific regression tests

[Tor Bug Tracker & Wiki]

#18923: Add a script in tor-browser.git to run all of our TBB-specific 
regression
tests
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 I added a first version of a patch adding a `run-tbb-tests` script which
 run the Tor Browser specific tests and save the logs in file `tbb-
 tests.log`.

 I still have some issues running this script because for some tests the
 `./mach mochitest` command get stuck after running the test and only exit
 after a long timeout.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19515 [- Select a component]: Hardened Tor Browser Crash (AddressSanitizer: stack-buffer-overflow)

[Tor Bug Tracker & Wiki]

#19515: Hardened Tor Browser Crash (AddressSanitizer: stack-buffer-overflow)
--+-
 Reporter:  pege  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Hardened Tor Browser crashes when I visit http://physioflex.ch/.

 Steps to reproduce:
 1. open Hardened Tor Browser 6.5a1
 2. set security slider to "Medium-Low"
 3. open http://physioflex.ch/
 4. wait for the crash (no need to do anything)

 Error message:
 =
 ==537696==ERROR: AddressSanitizer: stack-buffer-overflow on address
 0x7f7e818fa240 at pc 0x7f7ea152ae7a bp 0x7f7e818fa180 sp 0x7f7e818fa178
 READ of size 4 at 0x7f7e818fa240 thread T28 (Compositor)
 ASAN:SIGSEGV
 ==537696==AddressSanitizer: while reporting a bug found another one.
 Ignoring.
 Jun 27 18:18:45.000 [notice] Owning controller connection has closed --
 exiting now.
 Jun 27 18:18:45.000 [notice] Catching signal TERM, exiting cleanly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19499 [Core Tor/Tor]: Compile time warnings with OpenSSL 1.1.0-pre6-dev (aka master).

[Tor Bug Tracker & Wiki]

#19499: Compile time warnings with OpenSSL 1.1.0-pre6-dev (aka master).
-+
 Reporter:  yawning  |  Owner:  yawning
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.2.8.4-rc
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-core crypto  |  Actual Points:
Parent ID:  #19429   | Points:  0.5
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+-
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by yawning):

 * cc: yawning (removed)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE

[Tor Bug Tracker & Wiki]

#19259: uncaught NFE
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  needs_information
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by iwakeh):

 That was the information I was intending to elicit :-) Thanks!

 Just a few things left:

 > How about we represent missing values on disk as empty string (`""`),
 which also saves disk space, and in memory as `-1.0` to keep the current
 code working?
 >
 I still would prefer Double.NaN (cf. comment:9) as being more obvious in
 code/in memory.
 On disk it could be the empty string even though not very nice, but it's
 used already anyway.


 > > `testCompare` fails, b/c there is an entry with the key from the first
 and values from the second element.
 >
 > Let's reject those lines, too.
 It's not that easy here; the test demonstrates would could happen b/c of
 the
 comparator not being compatible with equal.
 So the missing part is an ordering for the intervals. The only one I can
 think
 of is the lexicographical ordering according to interval ends, e.g.,
 [10, 20] before [10, 21] before [12, 25].  That should capture the intend
 of
 the current approach?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19478 [Applications/Tor Browser]: File API leaks ms-resolution time

[Tor Bug Tracker & Wiki]

#19478: File API leaks ms-resolution time
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  tbb-fingerprinting,  |Version:
  TorBrowserTeam201606R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:4 gk]:
 > Hm. `new Date.getTime()` gives me something like 1467036079100 and
 `Math.floor(new File([], "").lastModified / 10) * 10)`
 146703610 or 146703640 or something similar. It seems your code is
 not rounding to 100ms?

 The units for mLastModificationDate are microseconds, so part of the patch
 will need to be changed.

 I am not sure how to fix the tests to detect when values are rounded too
 much. Maybe by using a real file with a known modified date?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19514 [Internal Services/Service - trac]: tor-bugs@ mails are set to reply-to tor-assistants@

[Tor Bug Tracker & Wiki]

#19514: tor-bugs@ mails are set to reply-to tor-assistants@
--+
 Reporter:  karsten   |  Owner:  qbi
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by atagar):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Changed. Skimmed through a handful of other lists and didn't spot any
 others like this though tor-news@ did point to tor-talk@ (changed that to
 no-re...@torproject.org too).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19514 [Internal Services/Service - trac]: tor-bugs@ mails are set to reply-to tor-assistants@

[Tor Bug Tracker & Wiki]

#19514: tor-bugs@ mails are set to reply-to tor-assistants@
--+-
 Reporter:  karsten   |  Owner:  qbi
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by atagar):

 Great catch. tor-team@ is *not* the appropriate destination - our use of
 tor-assistants@ as a catch-all forwarding address is part of what made it
 so terrible. Imho tor-bugs@ and other lists that don't accept posts should
 have a no-reply@ address.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19183 [Metrics/Metrics website]: Add sybilhunter's visualisations to Metrics website

[Tor Bug Tracker & Wiki]

#19183: Add sybilhunter's visualisations to Metrics website
-+-
 Reporter:  phw  |  Owner:  phw
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Metrics website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  sybilhunter, visualization, churn,   |  Actual Points:
  uptime | Points:
Parent ID:   |Sponsor:
 Reviewer:   |
-+-

Comment (by karsten):

 Hmm, I had some trouble fetching that .csv file.  The server seems quite
 overloaded, and the downloaded file was partially corrupt.  But I think I
 got the overall picture.

 However, I noticed that you didn't implement the wide-to-long suggestion I
 mentioned a few months ago on [https://lists.torproject.org/pipermail
 /metrics-team/2016-February/76.html metrics-team@], and I think that
 would make the graphing code somewhat easier.  How likely is it that
 you'll find the time to work on that issue?

 But we probably shouldn't block on that for putting stuff on Tor Metrics.
 How's this approach:

  - We start by adding two new "link" pages to your
 [https://nymity.ch/sybilhunting/churn-values/slide_2016-01.html churn] and
 [https://nymity.ch/sybilhunting/uptime-visualisation/slide_2014-01.html
 uptime] visualizations.  Can you send me text similar to the
 [https://gitweb.torproject.org/metrics-
 web.git/tree/website/etc/metrics.json#n532 "oxford-anonymous-internet"
 link page] but for these two new link pages?  We'll need this text anyway
 even when we take the next steps below.

  - We add a new page type to Metrics called "gallery" which displays image
 files from a local directory directly on the Tor Metrics site.  We need
 this type anyway for the uptime visualizations even when we replace the
 churn visualizations by something more interactive below.  We'd produce
 these images exactly how you're currently producing them on your server
 but on the metrics server.  Once we deploy this gallery pages, we'll
 replace the corresponding link pages, though we'd keep the URLs unchanged.

  - We write some R/ggplot2 code to make the churn visualizations somewhat
 more interactive by letting users select start and end date, flag type,
 and displayed metric (absolute numbers, fractions, etc.).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19514 [Internal Services/Service - trac]: tor-bugs@ mails are set to reply-to tor-assistants@

[Tor Bug Tracker & Wiki]

#19514: tor-bugs@ mails are set to reply-to tor-assistants@
--+-
 Reporter:  karsten   |  Owner:  qbi
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 tor-bugs@ mails are set to reply-to tor-assistants@.  We might want to
 change that to some other list.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19508 [Applications/Tor Browser]: Proposal to drop Tor Browser's plugin patches

[Tor Bug Tracker & Wiki]

#19508: Proposal to drop Tor Browser's plugin patches
+--
 Reporter:  arthuredelstein |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201606, tbb-obsolete  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by mcs):

 * cc: brade, mcs (added)


Comment:

 I do not think Flash is disabled by default in Firefox (I tested with
 49.0b3 and a clean profile). That said, I am not fan of Flash and I am in
 favor of dropping browser patches when we can. But I wonder if making it
 harder to activate Flash will generate a lot of complaints.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19478 [Applications/Tor Browser]: File API leaks ms-resolution time

[Tor Bug Tracker & Wiki]

#19478: File API leaks ms-resolution time
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  tbb-fingerprinting,  |Version:
  TorBrowserTeam201606R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by gk):

 * cc: mcs, brade (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19478 [Applications/Tor Browser]: File API leaks ms-resolution time

[Tor Bug Tracker & Wiki]

#19478: File API leaks ms-resolution time
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  tbb-fingerprinting,  |Version:
  TorBrowserTeam201606R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by gk):

 Hm. `new Date.getTime()` gives me something like 1467036079100 and
 `Math.floor(new File([], "").lastModified / 10) * 10)`
 146703610 or 146703640 or something similar. It seems your code is
 not rounding to 100ms?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19511 [Applications/Tor Browser]: Drop #16488 patch

[Tor Bug Tracker & Wiki]

#19511: Drop #16488 patch
+--
 Reporter:  arthuredelstein |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201606, tbb-obsolete  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by mcs):

 Yes, this approach seems OK to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE

[Tor Bug Tracker & Wiki]

#19259: uncaught NFE
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  needs_information
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by karsten):

 Oh, sorry for misunderstanding.  Let me reply to this comment instead:

 Replying to [comment:10 iwakeh]:
 > Test class commentary
 >
 > `testSetup` for warm-up, passes

 Sounds good. :)

 > `testWeightHistory` fails, document contains `NaN` after compression

 It seems there are two problems with this test case:

  1. Intervals should be at least one hour long for the internal math to
 work.  This is unfortunate, though the assumption is realistic for real
 data.  But let's relax this requirement and accept intervals shorter than
 1 hour.  A plausible minimum would be 1 second, because we cannot
 represent anything shorter than that.
  1. Entries are only compressed if they are a given number of days in the
 past, calculated from the current system time.  A better approach would be
 to compress based on the end time of the most recent history entry to
 remove yet another dependency on system time.  For the test to work you'll
 have to date entries back by 1 year or maybe even more.

 > `testSetFromDocumentString` passes

 Okay.

 > `testMissingValues` fails, b/c the small negative values are not
 recognized as missing

 How about we represent missing values on disk as empty string (`""`),
 which also saves disk space, and in memory as `-1.0` to keep the current
 code working?

 > `testSetFromDocumentStringWrongInput` fails, error b/c of nfe

 Right, let's fix that nfe.

 > `testSetFromDocumentStringWrongDateTime` failes, b/c line with later
 beginning than end is not rejected.

 Right, let's reject those lines.  That means additional tests, but those
 are cheap and might make the code more robust.

 > `testCompare` fails, b/c there is an entry with the key from the first
 and values from the second element.

 Let's reject those lines, too.

 Is that more what you had in mind?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18322 [Core Tor/Tor]: Log unparseable votes so they can be analysed

[Tor Bug Tracker & Wiki]

#18322: Log unparseable votes so they can be analysed
-+-
 Reporter:  teor |  Owner:  andrea
 Type:  defect   | Status:
 Priority:  Medium   |  needs_revision
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-dos, TorCoreTeam201606, review-  |Version:
  group-4| Resolution:
Parent ID:  #17293   |  Actual Points:  3
 Reviewer:   | Points:  2
 |Sponsor:
 |  SponsorU-can
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hello, feature looking more robust now IMO! I did some chutney testing and
 it seems to work fine as well!

 BTW, on the changes file you don't need to write `bugfix on ???` since
 this is a feature. You can just say `Closes ticket 18322` and be done with
 it.

 I'm gonna turn this to `needs_revision` just for the changes file fix.
 After this feel free to turn this into `merge_ready` from my part.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #8725 [Applications/Tor Browser]: resource:// URIs leak information

[Tor Bug Tracker & Wiki]

#8725: resource:// URIs leak information
-+-
 Reporter:  holizz   |  Owner:  tbb-
 Type:  defect   |  team
 Priority:  Very High| Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Major|  Milestone:
 Keywords:  tbb-fingerprinting, tbb-rebase-  |Version:
  regression, tbb-testcase, tbb-firefox-patch,   | Resolution:
  TorBrowserTeam201606R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:32 arthuredelstein]:
 > I also made a test to see if I could use redirects from content to load
 resource:// or chrome:// URIs into 

Re: [tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE

[Tor Bug Tracker & Wiki]

#19259: uncaught NFE
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  needs_information
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by iwakeh):

 * status:  needs_revision => needs_information


Comment:

 I didn't phrase my question here clearly, sorry.
 The issue was/is set to `needs information` intentionally.

 So the tests do not constitute a patch (that's why there a bit sloppy).
 I wanted information about the assumptions expressed in the tests, and
 then
 intended to write the real test patch, which will be provided as a branch
 from my repo.
 I agree with what you point out above.

 Is it possible for you to make out the tests content/assumptions and
 indicate what makes sense and what should be different? What added?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19513 [User Experience]: Ex-CIA inside Tor. You need to write a blog about this.

[Tor Bug Tracker & Wiki]

#19513: Ex-CIA inside Tor. You need to write a blog about this.
-+-
 Reporter:  ikurua22 |  Owner:
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  User Experience  |Version:
 Severity:  Major|   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 www.ibtimes.co.uk/leaked-tor-project-chat-logs-reveal-it-struggled-over-
 hiring-ex-cia-agent-1567591

 I read chat logs, and all I want to say is: WHAT THE F.
 Where is your "transparency"?

 I'm not talking about "Hiring CIA Agent is bad". They're just as human as
 we are
 and deserve second change. I have a friend in NSA and police, so I know
 about this.

 I'm VERY disappointed, the fact that you hide this truth from the
 community, all Tor users. Let us discuss about this today. Don't hide your
 projects.
 This is a open source project, and transparency is extremely important.

 Thanks for reading.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19481 [Applications/Tor Browser]: Change app.update.url to point to aus1.tpo

[Tor Bug Tracker & Wiki]

#19481: Change app.update.url to point to aus1.tpo
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201606R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => TorBrowserTeam201606R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19478 [Applications/Tor Browser]: File API leaks ms-resolution time

[Tor Bug Tracker & Wiki]

#19478: File API leaks ms-resolution time
-+-
 Reporter:  arthuredelstein  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  tbb-fingerprinting,  |Version:
  TorBrowserTeam201606R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-fingerprinting, TorBrowserTeam201506R => tbb-
 fingerprinting, TorBrowserTeam201606R


Comment:

 We already have 2016. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19403 [Applications/Tor Browser]: Domain isolation toggle

[Tor Bug Tracker & Wiki]

#19403: Domain isolation toggle
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 Type:  defect   |  team
 Priority:  Medium   | Status:  closed
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  tbb-usability-website,   | Resolution:  wontfix
  TorBrowserTeam201606R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => wontfix


Comment:

 Yes, I looked at the code and I don't think we should include that without
 calling New Identity. Thus, as I said the one option we already have
 should be enough.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19382 [Internal Services/Service - trac]: Batch-close all tickets in Metrics/Tor Weather and remove that component

[Tor Bug Tracker & Wiki]

#19382: Batch-close all tickets in Metrics/Tor Weather and remove that component
--+
 Reporter:  karsten   |  Owner:  qbi
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - trac  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by karsten):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Done and done.  Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #2467, #12917, #2461, #2508, #2521, #2719, #2829, #2862, #3236, #3262, #4208, #4915, #5564, #5941, #6886, #6952, #7035, #8999, #9418, #10256, #10372,

[Tor Bug Tracker & Wiki]

Batch modification to #2467, #12917, #2461, #2508, #2521, #2719, #2829, #2862, 
#3236, #3262, #4208, #4915, #5564, #5941, #6886, #6952, #7035, #8999, #9418, 
#10256, #10372, #10697, #10706, #10769, #11080, #11081, #11084, #11086, #11141, 
#11239, #11956, #12085, #12918, #13918, #14225, #14841, #14842, #15204, #17185, 
#17186, #17385, #2460, #2526, #2625, #9760, #10709, #12915, #12916, #18467, 
#14028 by karsten:


Action: resolve

Comment:
Tor Weather has been discontinued as of May 24, 2016: 
https://lists.torproject.org/pipermail/tor-relays/2016-June/009424.html.  
Batch-closing all remaining tickets as announced in #19382.  A list of these 
tickets and any other Weather tickets modified after June 26, 2016 will be 
available here: 
https://trac.torproject.org/projects/tor/query?changetime=Jun+27%2C+2016..=^Metrics%2FTor+Weather

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE

[Tor Bug Tracker & Wiki]

#19259: uncaught NFE
-+
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * status:  needs_information => needs_revision


Comment:

 Sorry for the long delay in responding.  This patch is not easy to review
 for me, because we're using somewhat different approaches to writing unit
 tests.  Can we discuss those approaches first before going into the
 details of reviewing and merging this particular test class?  I think
 there's a benefit for future test classes here.

  - I'm having a hard time connecting the test data at the beginning of the
 class with the methods where they're used.  I see how it's useful to
 separate the two, but may I suggest that test data preceding actual tests
 should be self-explanatory without having to read subsequent tests?  For
 example, the name `compareLines` doesn't really make much sense to me
 without reading the corresponding test method.  And `correctLines` and
 `correctHistory` could be described a little bit better.
  - I prefer tests to be as small as possible and not mix different test
 scenarios.  For example, rather than stuffing four (related) test input
 lines into `wrongDateLines` and commenting them there, I'd probably write
 four test methods with self-explanatory method names that simply include
 the test data themselves.  That would also solve the previous aspect where
 test data preceding test methods is not self-explanatory to the reader.
  - Most of the test data lines violate the code style by being longer than
 70 or 80 or whatever we said characters.  And I think there should be a
 space in `new String[]{`, but I'm not sure.  And there are missing
 newlines between variable declarations.
  - To me, test method names should be self-explanatory, even if that makes
 them rather lengthy.  Rather than `testSetup`, I'd prefer something like
 `testEmptyWeightsStatus`.

 There, these are some of the things I'd do differently.  I can be
 convinced that your approach has advantages over mine.  Or maybe some of
 these suggestions make sense to you and you can send me an updated patch?
 Happy to look again, and, as always, thanks for your hard work!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19511 [Applications/Tor Browser]: Drop #16488 patch

[Tor Bug Tracker & Wiki]

#19511: Drop #16488 patch
+--
 Reporter:  arthuredelstein |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201606, tbb-obsolete  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * cc: gk, mcs, brade (added)


Comment:

 Sounds like a good idea to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19508 [Applications/Tor Browser]: Proposal to drop Tor Browser's plugin patches

[Tor Bug Tracker & Wiki]

#19508: Proposal to drop Tor Browser's plugin patches
+--
 Reporter:  arthuredelstein |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201606, tbb-obsolete  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * cc: gk (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13017 [Applications/Tor Browser]: Determine if AudioBuffers/OfflineAudioContext are a fingerprinting vector

[Tor Bug Tracker & Wiki]

#13017: Determine if AudioBuffers/OfflineAudioContext are a fingerprinting 
vector
-+-
 Reporter:  mikeperry|  Owner:
 Type:  task |  arthuredelstein
 Priority:  Very High| Status:
Component:  Applications/Tor Browser |  assigned
 Severity:  Critical |  Milestone:
 Keywords:  tbb-fingerprinting-os,   |Version:
  TorBrowserTeam201606   | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-fingerprinting-os, tbb-easy, TorBrowserTeam201606 => tbb-
 fingerprinting-os, TorBrowserTeam201606


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17584 [Applications/Tor Browser]: Disable bookmark backups (easy fix) (!)

[Tor Bug Tracker & Wiki]

#17584: Disable bookmark backups (easy fix) (!)
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-easy, tbb-torbutton   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  tbb-easy => tbb-easy, tbb-torbutton


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17584 [Applications/Tor Browser]: Disable bookmark backups (easy fix) (!)

[Tor Bug Tracker & Wiki]

#17584: Disable bookmark backups (easy fix) (!)
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Binding this pref change to the option to disable Private Browsing Mode in
 Tor Browser (Don't record browsing history or website data (enabled
 Private Browsing Mode)) seems the way to go here. Patches are welcome!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17584 [Applications/Tor Browser]: Disable bookmark backups (easy fix) (!)

[Tor Bug Tracker & Wiki]

#17584: Disable bookmark backups (easy fix) (!)
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-easy


Comment:

 Binding this pref change to the option to disable Private Browsing Mode in
 Tor Browser (Don't record browsing history or website data (enabled
 Private Browsing Mode)) seems the way to go here. Patches are welcome!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19512 [- Select a component]: Jumbled considering Point

[Tor Bug Tracker & Wiki]

#19512: Jumbled considering Point
--+-
 Reporter:  HelenPorter   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Jumbled considering? Point the finger at it on anxiety. In one study,
 focused on restorative understudies performed fundamentally more terrible
 on a critical exam. Melancholy can likewise deny us of intellectual
 prowess [http://brainammofacts.com/alpha-boost-scam/ Alpha Boost] The
 indications can incorporate foggy memory, trouble with appreciation, even
 slurred discourse. In elderly individuals, these manifestations are
 normally confused for dementia, yet mental aptitudes can enhance when
 dejection is dealt with. Instructions to expand intellectual prowess -
 Cross-prepare your cerebrum.


 Message Body
 http://brainammofacts.com/alpha-boost-scam/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs