Re: [tor-bugs] #25600 [Obfuscation/Snowflake]: Tor eventually hits "No running bridges" with Snowflake (was: Running 2 instances of snowflake-client leads to the former one stopping)

2018-05-09 Thread Tor Bug Tracker & Wiki
#25600: Tor eventually hits "No running bridges" with Snowflake ---+-- Reporter: cypherpunks| Owner: (none) Type: defect | Status: reopened Priority: Medium |

Re: [tor-bugs] #26035 [Metrics/Statistics]: Streamline sample quantile types used in the various modules

2018-05-09 Thread Tor Bug Tracker & Wiki
#26035: Streamline sample quantile types used in the various modules +--- Reporter: karsten | Owner: iwakeh Type: enhancement | Status: accepted Priority: Medium | Milestone:

Re: [tor-bugs] #25804 [Obfuscation/Snowflake]: Domain fronting to App Engine stopped working

2018-05-09 Thread Tor Bug Tracker & Wiki
#25804: Domain fronting to App Engine stopped working ---+ Reporter: dcf| Owner: (none) Type: defect | Status: new Priority: Medium | Milestone: Component:

[tor-bugs] #26058 [Applications/Tor Browser]: Revert fix for #18743

2018-05-09 Thread Tor Bug Tracker & Wiki
#26058: Revert fix for #18743 --+ Reporter: gk| Owner: tbb-team Type: enhancement | Status: new Priority: Medium| Milestone:

Re: [tor-bugs] #25947 [Core Tor/Tor]: Create unit test for dirserv_read_measured_bandwidths

2018-05-09 Thread Tor Bug Tracker & Wiki
#25947: Create unit test for dirserv_read_measured_bandwidths --+ Reporter: juga | Owner: juga Type: enhancement | Status: needs_information Priority: Medium| Milestone: Tor:

Re: [tor-bugs] #26005 [Core Tor/Tor]: OpenSSL-nodep fixes seem to have broken LibreSSL

2018-05-09 Thread Tor Bug Tracker & Wiki
#26005: OpenSSL-nodep fixes seem to have broken LibreSSL -+ Reporter: nickm| Owner: nickm Type: defect | Status: merge_ready Priority: High |

Re: [tor-bugs] #26035 [Metrics/Statistics]: Streamline sample quantile types used in the various modules

2018-05-09 Thread Tor Bug Tracker & Wiki
#26035: Streamline sample quantile types used in the various modules +-- Reporter: karsten | Owner: metrics-team Type: enhancement | Status: new Priority: Medium |

Re: [tor-bugs] #25960 [Core Tor/Tor]: Allow additional header lines in bandwidth measurements documents

2018-05-09 Thread Tor Bug Tracker & Wiki
#25960: Allow additional header lines in bandwidth measurements documents -+- Reporter: juga | Owner: juga Type: enhancement | Status:

Re: [tor-bugs] #24732 [Core Tor/Tor]: Remove unused IPv6 DirPort code

2018-05-09 Thread Tor Bug Tracker & Wiki
#24732: Remove unused IPv6 DirPort code -+- Reporter: teor | Owner: (none) Type: enhancement | Status:

Re: [tor-bugs] #24732 [Core Tor/Tor]: Remove unused IPv6 DirPort code

2018-05-09 Thread Tor Bug Tracker & Wiki
#24732: Remove unused IPv6 DirPort code -+- Reporter: teor | Owner: (none) Type: enhancement | Status:

[tor-bugs] #26059 [Applications/Tor Browser]: Use mar files from the signed directory when generating incremental mars

2018-05-09 Thread Tor Bug Tracker & Wiki
#26059: Use mar files from the signed directory when generating incremental mars -+- Reporter: boklm| Owner: tbb-team Type: task | Status: new Priority: Medium

Re: [tor-bugs] #25947 [Core Tor/Tor]: Create unit test for dirserv_read_measured_bandwidths

2018-05-09 Thread Tor Bug Tracker & Wiki
#25947: Create unit test for dirserv_read_measured_bandwidths --+ Reporter: juga | Owner: juga Type: enhancement | Status: needs_review Priority: Medium| Milestone: Tor: 0.3.4.x-final

Re: [tor-bugs] #26006 [Core Tor/Tor]: LibreSSL compilation warnings on all supported Tor versions

2018-05-09 Thread Tor Bug Tracker & Wiki
#26006: LibreSSL compilation warnings on all supported Tor versions -+- Reporter: nickm| Owner: nickm Type: defect | Status:

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

2018-05-09 Thread Tor Bug Tracker & Wiki
#24465: Snowflake broken if no libatomic on host -+- Reporter: isabela | Owner: tbb- | team Type: defect

Re: [tor-bugs] #26057 [Applications/Tor Browser]: Make it easy to see in the logs which commit was used in nightly build

2018-05-09 Thread Tor Bug Tracker & Wiki
#26057: Make it easy to see in the logs which commit was used in nightly build -+- Reporter: boklm| Owner: tbb- | team Type:

Re: [tor-bugs] #25761 [Core Tor/Tor]: hs: Reload signal (HUP) doesn't remove a disabled service

2018-05-09 Thread Tor Bug Tracker & Wiki
#25761: hs: Reload signal (HUP) doesn't remove a disabled service -+- Reporter: dgoulet | Owner: dgoulet Type: defect | Status:

[tor-bugs] #26057 [Applications/Tor Browser]: Make it easy to see in the logs which commit was used in nightly build

2018-05-09 Thread Tor Bug Tracker & Wiki
#26057: Make it easy to see in the logs which commit was used in nightly build -+- Reporter: boklm| Owner: tbb-team Type: task | Status: new Priority: Medium

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

2018-05-09 Thread Tor Bug Tracker & Wiki
#16472: Upgrade Binutils to 2.25+ for Tor Browser builds -+- Reporter: gk | Owner: tbb- | team Type: task

Re: [tor-bugs] #25694 [Applications/Tor Browser]: Activity 3.1: Improve the user experience of updating Tor Browser

2018-05-09 Thread Tor Bug Tracker & Wiki
#25694: Activity 3.1: Improve the user experience of updating Tor Browser --+--- Reporter: isabela | Owner: antonela Type: defect| Status: assigned Priority: Medium

Re: [tor-bugs] #25761 [Core Tor/Tor]: hs: Reload signal (HUP) doesn't remove a disabled service

2018-05-09 Thread Tor Bug Tracker & Wiki
#25761: hs: Reload signal (HUP) doesn't remove a disabled service -+- Reporter: dgoulet | Owner: dgoulet Type: defect | Status: closed

Re: [tor-bugs] #26009 [Core Tor/Tor]: Remove management of approx_time() from second_elapsed_callback

2018-05-09 Thread Tor Bug Tracker & Wiki
#26009: Remove management of approx_time() from second_elapsed_callback -+- Reporter: nickm| Owner: nickm Type: defect | Status:

Re: [tor-bugs] #26009 [Core Tor/Tor]: Remove management of approx_time() from second_elapsed_callback

2018-05-09 Thread Tor Bug Tracker & Wiki
#26009: Remove management of approx_time() from second_elapsed_callback -+- Reporter: nickm| Owner: nickm Type: defect | Status:

Re: [tor-bugs] #26048 [Applications/Tor Browser]: potentially confusing "restart to update" message in ESR60

2018-05-09 Thread Tor Bug Tracker & Wiki
#26048: potentially confusing "restart to update" message in ESR60 --+-- Reporter: mcs | Owner: tbb-team Type: defect| Status: new Priority: Medium

Re: [tor-bugs] #25852 [Core Tor/Tor]: GETINFO exit-policy for tor client should return 551

2018-05-09 Thread Tor Bug Tracker & Wiki
#25852: GETINFO exit-policy for tor client should return 551 +-- Reporter: dmr | Owner: (none) Type: defect | Status:

Re: [tor-bugs] #25694 [Applications/Tor Browser]: Activity 3.1: Improve the user experience of updating Tor Browser

2018-05-09 Thread Tor Bug Tracker & Wiki
#25694: Activity 3.1: Improve the user experience of updating Tor Browser --+--- Reporter: isabela | Owner: antonela Type: defect| Status: assigned Priority: Medium

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

2018-05-09 Thread Tor Bug Tracker & Wiki
#26007: Stop logging stack contents when reading a zero-length bandwidth file -+- Reporter: teor | Owner: teor Type: defect | Status:

Re: [tor-bugs] #26009 [Core Tor/Tor]: Remove management of approx_time() from second_elapsed_callback

2018-05-09 Thread Tor Bug Tracker & Wiki
#26009: Remove management of approx_time() from second_elapsed_callback -+- Reporter: nickm| Owner: nickm Type: defect | Status:

Re: [tor-bugs] #26049 [Applications/Tor Browser]: consider reducing the delay before the update prompt is displayed (ESR60)

2018-05-09 Thread Tor Bug Tracker & Wiki
#26049: consider reducing the delay before the update prompt is displayed (ESR60) --+-- Reporter: mcs | Owner: tbb-team Type: defect| Status: new Priority: Medium

Re: [tor-bugs] #26006 [Core Tor/Tor]: LibreSSL compilation warnings on all supported Tor versions

2018-05-09 Thread Tor Bug Tracker & Wiki
#26006: LibreSSL compilation warnings on all supported Tor versions -+- Reporter: nickm| Owner: nickm Type: defect | Status: closed

Re: [tor-bugs] #24732 [Core Tor/Tor]: Remove unused IPv6 DirPort code

2018-05-09 Thread Tor Bug Tracker & Wiki
#24732: Remove unused IPv6 DirPort code -+- Reporter: teor | Owner: (none) Type: enhancement | Status:

Re: [tor-bugs] #26034 [Core Tor/Tor]: LibreSSL 2.7.x supports some OpenSSL 1.1 APIs? (was: LibreSSL 2.7.x may support OpenSSL 1.1 APIs?)

2018-05-09 Thread Tor Bug Tracker & Wiki
#26034: LibreSSL 2.7.x supports some OpenSSL 1.1 APIs? --+ Reporter: nickm | Owner: nickm Type: defect| Status: assigned Priority: Medium| Milestone: Tor: 0.3.5.x-final Component:

Re: [tor-bugs] #25761 [Core Tor/Tor]: hs: Reload signal (HUP) doesn't remove a disabled service

2018-05-09 Thread Tor Bug Tracker & Wiki
#25761: hs: Reload signal (HUP) doesn't remove a disabled service -+- Reporter: dgoulet | Owner: dgoulet Type: defect | Status:

Re: [tor-bugs] #26005 [Core Tor/Tor]: OpenSSL-nodep fixes seem to have broken LibreSSL

2018-05-09 Thread Tor Bug Tracker & Wiki
#26005: OpenSSL-nodep fixes seem to have broken LibreSSL -+ Reporter: nickm| Owner: nickm Type: defect | Status: closed Priority: High | Milestone:

[tor-bugs] #26060 [Core Tor/Stem]: Invalid [Length] field when receiving RELAY cells via stem.client.Circuit

2018-05-09 Thread Tor Bug Tracker & Wiki
#26060: Invalid [Length] field when receiving RELAY cells via stem.client.Circuit ---+ Reporter: plcp | Owner: atagar Type: defect | Status: new Priority: Medium | Milestone: Component:

Re: [tor-bugs] #26022 [Metrics/Statistics]: Fix a flaw in the noise-removing code in our onion service statistics

2018-05-09 Thread Tor Bug Tracker & Wiki
#26022: Fix a flaw in the noise-removing code in our onion service statistics +-- Reporter: karsten | Owner: metrics-team Type: defect | Status: needs_review Priority: Medium

Re: [tor-bugs] #26022 [Metrics/Statistics]: Fix a flaw in the noise-removing code in our onion service statistics

2018-05-09 Thread Tor Bug Tracker & Wiki
#26022: Fix a flaw in the noise-removing code in our onion service statistics +-- Reporter: karsten | Owner: metrics-team Type: defect | Status: needs_review Priority: Medium

Re: [tor-bugs] #21346 [Core Tor/Tor]: Clients with NoIPv4Traffic should only choose IPv6-supporting Exits

2018-05-09 Thread Tor Bug Tracker & Wiki
#21346: Clients with NoIPv4Traffic should only choose IPv6-supporting Exits -+- Reporter: teor | Owner: neel Type: defect | Status:

[tor-bugs] #26061 [Webpages/Blog]: Add blog posts to contributor pages

2018-05-09 Thread Tor Bug Tracker & Wiki
#26061: Add blog posts to contributor pages ---+-- Reporter: steph | Owner: hiro Type: defect | Status: new Priority: Medium | Milestone: Component: Webpages/Blog |Version:

Re: [tor-bugs] #25552 [Core Tor/Tor]: prop224: Onion service rev counters are useless and actually harmful for scalability

2018-05-09 Thread Tor Bug Tracker & Wiki
#25552: prop224: Onion service rev counters are useless and actually harmful for scalability ---+--- Reporter: asn| Owner: dgoulet Type: defect |

Re: [tor-bugs] #1760 [Core Tor/Tor]: Parallel Crypto: Design a good crypto parallelization plan and architecture

2018-05-09 Thread Tor Bug Tracker & Wiki
#1760: Parallel Crypto: Design a good crypto parallelization plan and architecture --+- Reporter: nickm | Owner: (none) Type: task | Status: closed Priority: Medium| Milestone:

[tor-bugs] #26063 [Core Tor/Tor]: Disable the per-second timer when we can

2018-05-09 Thread Tor Bug Tracker & Wiki
#26063: Disable the per-second timer when we can -+- Reporter: nickm| Owner: nickm Type: defect | Status: assigned Priority: High | Milestone: Tor: 0.3.4.x-final Component:

Re: [tor-bugs] #26063 [Core Tor/Tor]: Disable the per-second timer when we can

2018-05-09 Thread Tor Bug Tracker & Wiki
#26063: Disable the per-second timer when we can -+- Reporter: nickm| Owner: nickm Type: defect | Status:

Re: [tor-bugs] #25694 [Applications/Tor Browser]: Activity 3.1: Improve the user experience of updating Tor Browser

2018-05-09 Thread Tor Bug Tracker & Wiki
#25694: Activity 3.1: Improve the user experience of updating Tor Browser --+--- Reporter: isabela | Owner: antonela Type: defect| Status: assigned Priority: Medium

Re: [tor-bugs] #25483 [Obfuscation/Snowflake]: Windows reproducible build of snowflake

2018-05-09 Thread Tor Bug Tracker & Wiki
#25483: Windows reproducible build of snowflake ---+-- Reporter: arlolra| Owner: sukhbir Type: project| Status: assigned Priority: High | Milestone:

Re: [tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

2018-05-09 Thread Tor Bug Tracker & Wiki
#19665: Should *Port_set count sockets? -+- Reporter: teor | Owner: (none) Type: defect | Status: new Priority: Medium

Re: [tor-bugs] #1760 [Core Tor/Tor]: Parallel Crypto: Design a good crypto parallelization plan and architecture

2018-05-09 Thread Tor Bug Tracker & Wiki
#1760: Parallel Crypto: Design a good crypto parallelization plan and architecture --+- Reporter: nickm | Owner: (none) Type: task | Status: closed Priority: Medium| Milestone:

Re: [tor-bugs] #26062 [Core Tor/Tor]: client: ControlPort set doesn't mean you're a client

2018-05-09 Thread Tor Bug Tracker & Wiki
#26062: client: ControlPort set doesn't mean you're a client -+- Reporter: dgoulet | Owner: dgoulet Type: defect | Status:

Re: [tor-bugs] #26063 [Core Tor/Tor]: Disable the per-second timer when we can

2018-05-09 Thread Tor Bug Tracker & Wiki
#26063: Disable the per-second timer when we can -+- Reporter: nickm| Owner: nickm Type: defect | Status:

[tor-bugs] #26064 [Core Tor/Tor]: Use a mainloop timer to wake up from hibernation.

2018-05-09 Thread Tor Bug Tracker & Wiki
#26064: Use a mainloop timer to wake up from hibernation. -+- Reporter: nickm| Owner: nickm Type: defect | Status: assigned Priority: Medium | Milestone: Tor: 0.3.4.x-final

Re: [tor-bugs] #25750 [Applications/Tor Launcher]: update Tor Launcher for ESR 60

2018-05-09 Thread Tor Bug Tracker & Wiki
#25750: update Tor Launcher for ESR 60 +-- Reporter: mcs | Owner: brade Type: defect | Status: needs_review Priority: Very High

Re: [tor-bugs] #1749 [Core Tor/Tor]: Split relay and link crypto across multiple CPU cores

2018-05-09 Thread Tor Bug Tracker & Wiki
#1749: Split relay and link crypto across multiple CPU cores -+- Reporter: nickm| Owner: nickm Type: project | Status:

Re: [tor-bugs] #25461 [Core Tor/Tor]: main event-loop spins consuming 100% of a CPU core at times

2018-05-09 Thread Tor Bug Tracker & Wiki
#25461: main event-loop spins consuming 100% of a CPU core at times -+- Reporter: Dhalgren | Owner: dgoulet Type: defect | Status:

Re: [tor-bugs] #26016 [Core Tor/Tor]: Replace n_libevent_errors logic with a rate-limiter.

2018-05-09 Thread Tor Bug Tracker & Wiki
#26016: Replace n_libevent_errors logic with a rate-limiter. -+- Reporter: nickm| Owner: nickm Type: defect | Status:

Re: [tor-bugs] #26009 [Core Tor/Tor]: Remove management of approx_time() from second_elapsed_callback

2018-05-09 Thread Tor Bug Tracker & Wiki
#26009: Remove management of approx_time() from second_elapsed_callback -+- Reporter: nickm| Owner: nickm Type: defect | Status: closed

[tor-bugs] #26065 [Webpages/Blog]: Please create a blog account for Amogh

2018-05-09 Thread Tor Bug Tracker & Wiki
#26065: Please create a blog account for Amogh ---+-- Reporter: sukhbir| Owner: hiro Type: defect | Status: new Priority: Medium | Milestone: Component: Webpages/Blog |Version:

Re: [tor-bugs] #25403 [Metrics/Website]: Create jsp with bgp documentation

2018-05-09 Thread Tor Bug Tracker & Wiki
#25403: Create jsp with bgp documentation -+-- Reporter: iwakeh | Owner: metrics-team Type: enhancement | Status: needs_review Priority: Medium | Milestone: Component:

Re: [tor-bugs] #25544 [Core Tor/Tor]: Complete vanguard specification

2018-05-09 Thread Tor Bug Tracker & Wiki
#25544: Complete vanguard specification -+- Reporter: asn | Owner: (none) Type: defect | Status:

Re: [tor-bugs] #26016 [Core Tor/Tor]: Replace n_libevent_errors logic with a rate-limiter.

2018-05-09 Thread Tor Bug Tracker & Wiki
#26016: Replace n_libevent_errors logic with a rate-limiter. -+- Reporter: nickm| Owner: nickm Type: defect | Status: closed Priority:

Re: [tor-bugs] #26064 [Core Tor/Tor]: Use a mainloop timer to wake up from hibernation.

2018-05-09 Thread Tor Bug Tracker & Wiki
#26064: Use a mainloop timer to wake up from hibernation. -+- Reporter: nickm| Owner: nickm Type: defect | Status:

Re: [tor-bugs] #26063 [Core Tor/Tor]: Disable the per-second timer when we can

2018-05-09 Thread Tor Bug Tracker & Wiki
#26063: Disable the per-second timer when we can -+- Reporter: nickm| Owner: nickm Type: defect | Status:

Re: [tor-bugs] #25847 [Webpages/Website]: Update boklm's key for signing Tor Browser builds

2018-05-09 Thread Tor Bug Tracker & Wiki
#25847: Update boklm's key for signing Tor Browser builds --+ Reporter: boklm | Owner: (none) Type: task | Status: closed Priority: Medium| Milestone: Component:

Re: [tor-bugs] #26066 [Webpages/Blog]: Include clip of post summaries in sidebar

2018-05-09 Thread Tor Bug Tracker & Wiki
#26066: Include clip of post summaries in sidebar ---+-- Reporter: steph | Owner: hiro Type: defect | Status: new Priority: Medium | Milestone: Component: Webpages/Blog |Version:

Re: [tor-bugs] #26064 [Core Tor/Tor]: Use a mainloop timer to wake up from hibernation.

2018-05-09 Thread Tor Bug Tracker & Wiki
#26064: Use a mainloop timer to wake up from hibernation. -+- Reporter: nickm| Owner: nickm Type: defect | Status:

[tor-bugs] #26066 [Webpages/Blog]: Include clip of post summaries in sidebar

2018-05-09 Thread Tor Bug Tracker & Wiki
#26066: Include clip of post summaries in sidebar ---+-- Reporter: steph | Owner: hiro Type: defect | Status: new Priority: Medium | Milestone: Component: Webpages/Blog |Version:

Re: [tor-bugs] #1749 [Core Tor/Tor]: Split relay and link crypto across multiple CPU cores

2018-05-09 Thread Tor Bug Tracker & Wiki
#1749: Split relay and link crypto across multiple CPU cores -+- Reporter: nickm| Owner: nickm Type: project | Status:

Re: [tor-bugs] #25686 [Core Tor/Tor]: Mystery bug causes relays to attempt many many descriptor publishes, with no X-Desc-Gen-Reason header

2018-05-09 Thread Tor Bug Tracker & Wiki
#25686: Mystery bug causes relays to attempt many many descriptor publishes, with no X-Desc-Gen-Reason header -+- Reporter: arma | Owner: (none) Type: defect

Re: [tor-bugs] #26037 [Core Tor/Tor]: DirAuths should check vote signatures before parsing

2018-05-09 Thread Tor Bug Tracker & Wiki
#26037: DirAuths should check vote signatures before parsing --+ Reporter: isis | Owner: Samdney Type: defect| Status: assigned Priority: Medium

Re: [tor-bugs] #25694 [Applications/Tor Browser]: Activity 3.1: Improve the user experience of updating Tor Browser

2018-05-09 Thread Tor Bug Tracker & Wiki
#25694: Activity 3.1: Improve the user experience of updating Tor Browser --+--- Reporter: isabela | Owner: antonela Type: defect| Status: assigned Priority: Medium

Re: [tor-bugs] #26037 [Core Tor/Tor]: DirAuths should check vote signatures before parsing

2018-05-09 Thread Tor Bug Tracker & Wiki
#26037: DirAuths should check vote signatures before parsing --+ Reporter: isis | Owner: (none) Type: defect| Status: new Priority: Medium

Re: [tor-bugs] #25750 [Applications/Tor Launcher]: update Tor Launcher for ESR 60

2018-05-09 Thread Tor Bug Tracker & Wiki
#25750: update Tor Launcher for ESR 60 +-- Reporter: mcs | Owner: brade Type: defect | Status: |

Re: [tor-bugs] #1749 [Core Tor/Tor]: Split relay and link crypto across multiple CPU cores

2018-05-09 Thread Tor Bug Tracker & Wiki
#1749: Split relay and link crypto across multiple CPU cores -+- Reporter: nickm| Owner: nickm Type: project | Status:

Re: [tor-bugs] #1760 [Core Tor/Tor]: Parallel Crypto: Design a good crypto parallelization plan and architecture

2018-05-09 Thread Tor Bug Tracker & Wiki
#1760: Parallel Crypto: Design a good crypto parallelization plan and architecture --+- Reporter: nickm | Owner: (none) Type: task | Status: closed Priority: Medium| Milestone:

Re: [tor-bugs] #26060 [Core Tor/Stem]: Invalid [Length] field when receiving RELAY cells via stem.client.Circuit

2018-05-09 Thread Tor Bug Tracker & Wiki
#26060: Invalid [Length] field when receiving RELAY cells via stem.client.Circuit ---+ Reporter: plcp | Owner: atagar Type: defect | Status: new Priority: Medium | Milestone: Component:

Re: [tor-bugs] #26061 [Webpages/Blog]: Add blog posts to contributor pages

2018-05-09 Thread Tor Bug Tracker & Wiki
#26061: Add blog posts to contributor pages ---+-- Reporter: steph | Owner: hiro Type: defect | Status: new Priority: Medium | Milestone: Component: Webpages/Blog |Version: Severity:

[tor-bugs] #26062 [Core Tor/Tor]: client: ControlPort set doesn't mean you're a client

2018-05-09 Thread Tor Bug Tracker & Wiki
#26062: client: ControlPort set doesn't mean you're a client --+- Reporter: dgoulet | Owner: dgoulet Type: defect| Status: assigned Priority: Medium| Milestone: Tor: 0.3.4.x-final