Re: [tor-bugs] #26702 [Core Tor/Tor]: Remind authority operators that bandwidth files should be transferred outside the voting period

[Tor Bug Tracker & Wiki]

#26702: Remind authority operators that bandwidth files should be transferred
outside the voting period
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, 035-removed-20180711,   |  Actual Points:
  fast-fix, doc  |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 It seems it has been accidentally removed?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18642 [Core Tor/Tor]: Teach the OOM handler about the DNS cache

[Tor Bug Tracker & Wiki]

#18642: Teach the OOM handler about the DNS cache
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dos, oom, tor-relay, dns, 035|  Actual Points:
  -triaged-in-20180711   |
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorV-can
-+-
Changes (by neel):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26838 [Webpages/Website]: Port the research portal content to Lektor

[Tor Bug Tracker & Wiki]

#26838: Port the research portal content to Lektor
--+--
 Reporter:  irl   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal|   Keywords:  research,ux-team
Actual Points:|  Parent ID:  #26836
   Points:|   Reviewer:
  Sponsor:|
--+--
 This will allow easy update to conform to the styleguide and make it
 easier to edit the content, and provide translations if desired.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26831 [Core Tor/Torsocks]: Feature: conditionally allow non-localhost inbound connections with command-line flag

[Tor Bug Tracker & Wiki]

#26831: Feature: conditionally allow non-localhost inbound connections with
command-line flag
---+-
 Reporter:  dbkaplun   |  Owner:  dgoulet
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Torsocks  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by nickm):

 * owner:  (none) => dgoulet
 * component:  - Select a component => Core Tor/Torsocks


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26694 [Core Tor/Tor]: dir-spec: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#26694: dir-spec: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  juga |  Owner:  juga
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-triaged-in-20180711|
Parent ID:  #21377   | Points:
 Reviewer:  juga, teor   |Sponsor:
-+-

Comment (by nickm):

 It's now prop296.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

[Tor Bug Tracker & Wiki]

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  task   | Status:
   |  needs_review
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531 | Points:
 Reviewer: |Sponsor:
---+---

Comment (by gk):

 commit 21149e7a423d1f88866e5781e521021a08fca126 -- not okay

 Indentation of code in the else-clauses is missing. Are we good with all
 the other account manager related things that Orfox patched but this patch
 omits?

 commit db3c54ef05e71234a009bdc1abdbf9b80135cb0a -- ???

 That one is hard for me to review. Is that a new NetCipher version
 included? If so, what's the new one and what was the old one, used for
 ESR52?

 Do we really want to have mobile/android/orfox? What happened to
 {{{
 +  _space_to_start_error;
 +  _loading_file;
 }}}
 ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26835 [Applications/Tor Browser]: Tor Browser 8.0a9 crash while browsing on twitter then suddenly typing then going to a different twitter url

[Tor Bug Tracker & Wiki]

#26835: Tor Browser 8.0a9 crash while browsing on twitter then suddenly typing 
then
going to a different twitter url
--+--
 Reporter:  ProTipGuyFWIWWeLoveARMA   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ProTipGuyFWIWWeLoveARMA):

 It doesn't happen when NoScript is disabled, so as mentioned it's surely a
 NoScript bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26842 [Core Tor/Tor]: prop289: Add consensus parameters to control new SENDME behavior

[Tor Bug Tracker & Wiki]

#26842: prop289: Add consensus parameters to control new SENDME behavior
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop289, tor-spec, 035-roadmap-  |  Actual Points:
  subtask|
Parent ID:  #26288   | Points:
 Reviewer:   |Sponsor:
 |  SponsorV
-+-
Changes (by dgoulet):

 * parent:   => #26288


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26814 [Applications/Tor Browser]: tor won't start on windows 10

[Tor Bug Tracker & Wiki]

#26814: tor won't start on windows 10
--+---
 Reporter:  Grabler   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:
 Keywords:  startup   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by Grabler):

 Thanks for the reply mcs!
 I tried all your advice--new tor install, new firefox install
 got error msg: cant load xpcom
 i'm about to give up for now
 besides i got epic browser, nice new version
 thanks again
 glenn

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26839 [Core Tor/Tor]: prop289: Make a relay remember last cell digests before SENDME

[Tor Bug Tracker & Wiki]

#26839: prop289: Make a relay remember last cell digests before SENDME
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  prop289
Actual Points:|  Parent ID:  #26288
   Points:|   Reviewer:
  Sponsor:|
--+
 From proposal 289, this would be phase one and quoting:

 In phase one, both sides begin remembering their expected digests, and
 they learn how to parse sendme payloads. When they receive a sendme with
 payload version 1, they verify its digest and tear down the circuit if
 it's wrong. But they continue to send and accept payload version 0
 sendmes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16546 [Webpages/Website]: Should we move anonbib to the Tor website?

[Tor Bug Tracker & Wiki]

#16546: Should we move anonbib to the Tor website?
-+-
 Reporter:  nickm|  Owner:
 |  cypherpunks
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
 |  WebsiteV3
Component:  Webpages/Website |Version:
 Severity:  Normal   | Resolution:
 Keywords:  defer-new-website, ux-team,  |  Actual Points:
  research   |
Parent ID:  #26836   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by irl):

 * keywords:  defer-new-website, ux-team => defer-new-website, ux-team,
 research
 * parent:   => #26836


Comment:

 If we did this, it would be part of #26836.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26841 [Core Tor/Tor]: prop289: Have tor handle the new SENDME cell format and validate

[Tor Bug Tracker & Wiki]

#26841: prop289: Have tor handle the new SENDME cell format and validate
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  prop289
Actual Points:|  Parent ID:  #26288
   Points:|   Reviewer:
  Sponsor:|
--+
 First is to properly parse the cell and then second, validate it against
 the expected digest (#26839).

 As of an initial deployment phase, only version 1 cell should be validated
 and the version 0 is accepted as is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18642 [Core Tor/Tor]: Teach the OOM handler about the DNS cache

[Tor Bug Tracker & Wiki]

#18642: Teach the OOM handler about the DNS cache
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dos, oom, tor-relay, dns, 035|  Actual Points:
  -triaged-in-20180711   |
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorV-can
-+-

Comment (by neel):

 New PR is here: https://github.com/torproject/tor/pull/239

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26837 [Webpages/Website]: Move the "research-ideas" tickets to research ideas page

[Tor Bug Tracker & Wiki]

#26837: Move the "research-ideas" tickets to research ideas page
--+--
 Reporter:  irl   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal|   Keywords:  research,ux-team
Actual Points:|  Parent ID:  #26836
   Points:|   Reviewer:
  Sponsor:|
--+--
 The Metrics/Analysis trac component has been gathering tickets that are
 not really suited to being trac tickets. The Metrics team certainly isn't
 going to look at them any time soon. I had tagged these with the keyword
 [[https://trac.torproject.org/projects/tor/query?status=!closed
 =~research-ideas|research-ideas]].

 The ideas page is at [[https://research.torproject.org/ideas.html]] on the
 portal.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25552 [Core Tor/Tor]: prop224: Onion service rev counters are useless and actually harmful for scalability

[Tor Bug Tracker & Wiki]

#25552: prop224: Onion service rev counters are useless and actually harmful for
scalability
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.1.9
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, 035-roadmap-|  Actual Points:
  master, 035-must, regression, 035-triaged- |
  in-20180711|
Parent ID:   | Points:  6+++
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:49 nickm]:
 > If it passed before in chutney, but now it fails, my first suspicion
 would be that you're not using the correct saved OPE keys.  Let me know if
 you want debugging help.

 OK, addressed your comments and pushed fixes for a few bugs found during
 chutney testing.
 Thanks for the review!

 Let me know if something smells funny.

 Pushing this back in merge_ready after also discussing it with David in
 IRC.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26835 [Applications/Tor Browser]: Tor Browser 8.0a9 crash while browsing on twitter then suddenly typing then going to a different twitter url

[Tor Bug Tracker & Wiki]

#26835: Tor Browser 8.0a9 crash while browsing on twitter then suddenly typing 
then
going to a different twitter url
--+--
 Reporter:  ProTipGuyFWIWWeLoveARMA   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ProTipGuyFWIWWeLoveARMA):

 Please add ff60-esr keyword

 Also only the content process crashes not the whole browser. Platform
 Linux x86_64

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18642 [Core Tor/Tor]: Teach the OOM handler about the DNS cache

[Tor Bug Tracker & Wiki]

#18642: Teach the OOM handler about the DNS cache
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dos, oom, tor-relay, dns, 035|  Actual Points:
  -triaged-in-20180711   |
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
 |  SponsorV-can
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 True, `ExitRelay` won't work. I'm also not very enthusiastic on using
 `policy_is_reject_star()` which possibly goes over the entire policy just
 to learn if we are an Exit relay with a non reject policy.

 The Roles we've added recently for the callbacks in tor should be what we
 look for imo but don't have one for the Exit just yet (#25899).

 So for now, lets always run it, checking the HT size is very cheap and the
 OOM is only triggered on memory pressure so shouldn't be that often in
 most cases.

 Sorry neel, the PR looks good, just remove the `ExitRelay` condition :P.
 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26835 [Applications/Tor Browser]: Tor Browser 8.0a9 crash while browsing on twitter then suddenly typing then going to a different twitter url

[Tor Bug Tracker & Wiki]

#26835: Tor Browser 8.0a9 crash while browsing on twitter then suddenly typing 
then
going to a different twitter url
--+--
 Reporter:  ProTipGuyFWIWWeLoveARMA   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-crash, ff60-esr   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  tbb-crash => tbb-crash, ff60-esr
 * cc: ma1 (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26814 [Applications/Tor Browser]: tor won't start on windows 10

[Tor Bug Tracker & Wiki]

#26814: tor won't start on windows 10
--+---
 Reporter:  Grabler   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:  not a bug
 Keywords:  startup   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by mcs):

 * status:  needs_information => closed
 * resolution:   => not a bug


Comment:

 Closing as "not a bug" because we don't have enough information to
 determine if this is a bug in Tor Browser. Grabler, if you want more help
 later please start here:
 https://www.torproject.org/about/contact.html.en#support (the #tor IRC
 channel can be a good place to go for interactive help).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26844 [Applications/Tor Browser]: TBA: Investigate/Setup Fastlane

[Tor Bug Tracker & Wiki]

#26844: TBA: Investigate/Setup Fastlane
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:  #26782
   Points:|   Reviewer:
  Sponsor:|
--+
 Let's try it and see how well it works for us.
 https://fastlane.tools/

 In particular, does Fastlane provide an easy/useful way for integrating
 translations/localizations and deploying them (both for App stores and
 within the app). If this provides an easier way for publishing a new app
 and publishing app updates, then that is a bonus benefit of using this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26845 [Applications/Tor Browser]: TBA: Is the "Slow Script" warning is triggered too often?

[Tor Bug Tracker & Wiki]

#26845: TBA: Is the "Slow Script" warning is triggered too often?
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 When loading Google News, the Slow Script warning is triggered every time
 the page is loaded. Is this because the timeout is too low and loading the
 page over Tor exceeds the threshold every time? Is there something else we
 can do for tuning this for a better user experience?

 We can start by looking at `nsGlobalWindowInner::SlowScriptResponse()` in
 dom/base/nsGlobalWindowInner.cpp and see when it's called and why.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

[Tor Bug Tracker & Wiki]

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  task   | Status:
   |  needs_review
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531 | Points:
 Reviewer: |Sponsor:
---+---

Comment (by gk):

 I need to look with fresh eyes at commit
 44c65b7904d8bf599345991942e0407af2030199 and commit
 952f0ae78cc17f66624f3c634d831ff0aedc9692 tomorrow but the comments to the
 remaining commits are:

 commit a2c4e6217da42219327206508015ee24846907c4 -- probably okay (Any
 reason the Facebook bg color (#ffecf0f3) did not get adjusted as done in
 the original patch?)

 commit 91498b6733075d1de69d9f3568bfbffb5f05 -- not okay

 I assume the resistfingerprinting related UA is not being used by Java
 code automatically? If so, then we should hardcode that one and not a
 custom one.

 commit 14cefdc4bd90083e22ac263954a857d254b346a9 -- not okay

 Indentation of the if-clauses

 commit 94f9d2324391c5c18ac22a025b322a71adff3fcc -- okay
 commit e1ed56fc4ed4a6cdcef8c692cb2d5f909174ddc4 -- okay

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26798 [Core Tor/Tor]: Write unit tests for reading measured bandwidths with non-NULL routerststuses

[Tor Bug Tracker & Wiki]

#26798: Write unit tests for reading measured bandwidths with non-NULL
routerststuses
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by juga):

 * cc: juga (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26836 [Webpages/Website]: Update and refresh the research portal

[Tor Bug Tracker & Wiki]

#26836: Update and refresh the research portal
--+--
 Reporter:  irl   |  Owner:  (none)
 Type:  project   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal|   Keywords:  research,ux-team
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 The research portal isn't the prettiest website, nor does it contain the
 most up to date information. This ticket will act as a central ticket for
 tasks around updating and refreshing the research portal.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26840 [Core Tor/Tor]: prop289: Modify SENDME cell to have a version and payload

[Tor Bug Tracker & Wiki]

#26840: prop289: Modify SENDME cell to have a version and payload
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  prop289, tor-spec
Actual Points:|  Parent ID:  #26288
   Points:|   Reviewer:
  Sponsor:|
--+
 To implement prop289, we need the SENDME cell (empty payload right now) to
 have a version and payload for the bytes inserted into them.

 1) We should have a trunnel definition with a proper specification of the
 cell.

 2) Have the code interface to construct those new SENDME cells but don't
 put them on the wire just yet.

 For (2), we could put them on the wire right now but we should make sure
 tor will accept them (validating empty payload vs not looking at the
 payload at all).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by irl):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I think other things can be new tickets if we come across them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by juga):

 > It looks like the squashed and rebased code is in juga's
 ticket3723_03_squashed_rebased branch.

 It is, i didn't notify here because i wanted first to:

 > run it against a test bandwidth file, and check the vote contents

 i did it, example output:

 {{{
 bandwidth-file-headers timestamp=1531683804 version=1.1.0
 earliest_bandwidth=2018-07-13T12:49:16 file_created=2018-07-17T13:13:03
 generator_started=2018-07-14T15:14:35 latest_bandwidth=2018-07-15T19:43:24
 software=sbws software_version=0.6.1-dev
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26843 [Applications/Tor Browser]: TBA: Investigate how Mozilla Fennec provides localization

[Tor Bug Tracker & Wiki]

#26843: TBA: Investigate how Mozilla Fennec provides localization
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:  #5709
   Points:|   Reviewer:
  Sponsor:|
--+
 Fennec is shipped with multi-locale support. Under the Settings menu
 option, `General` -> `Language` -> `Browser Language` there are tens of
 languages and locales available. How are these included and shipped?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26789 [Core Tor/Tor]: configure --disable-unittests causes build to fail when linking

[Tor Bug Tracker & Wiki]

#26789: configure --disable-unittests causes build to fail when linking
--+
 Reporter:  jchevali  |  Owner:  rl1987
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  034-must? regression  |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 Pull request to `maint-0.3.4`: https://github.com/torproject/tor/pull/238

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26702 [Core Tor/Tor]: Remind authority operators that bandwidth files should be transferred outside the voting period

[Tor Bug Tracker & Wiki]

#26702: Remind authority operators that bandwidth files should be transferred
outside the voting period
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, 035-removed-20180711,   |  Actual Points:
  fast-fix, doc  |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I'm sorry; I can't find this branch. Are you sure it's where you say?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26799 [Core Tor/Tor]: dir-spec: specify failure modes for the bandwidth-file-headers vote line

[Tor Bug Tracker & Wiki]

#26799: dir-spec: specify failure modes for the bandwidth-file-headers vote line
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-bwauth, fast-fix  |  Actual Points:
Parent ID:  #3723 | Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26842 [Core Tor/Tor]: prop289: Add consensus parameters to control new SENDME behavior

[Tor Bug Tracker & Wiki]

#26842: prop289: Add consensus parameters to control new SENDME behavior
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  prop289, tor-spec
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 This is phase two and phase three of proposal 289. Meaning, this ticket is
 for implementing those switch.

 In phase two, we flip a switch in the consensus, and everybody starts
 sending payload version 1 sendmes. Payload version 0 sendmes are still
 accepted.

 In phase three, we flip a different switch in the consensus, and everybody
 starts refusing payload version 0 sendmes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #26842, #26841, #26840, #26839

[Tor Bug Tracker & Wiki]

Batch modification to #26842, #26841, #26840, #26839 by dgoulet:
sponsor to SponsorV

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26520 [Applications/Tor Browser]: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser

[Tor Bug Tracker & Wiki]

#26520: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:6 rustybird]:

 Thanks for testing! Addressing your comments in rearranged order:

 > (Slightly related, `noscript-control.js` has a guard against the
 `initialized` variable, but it's never set to `true`.)

 > `log(e.message);` -> `log(5, e.message);`

 Thanks for catching these two mistakes. Here's a revised patch that
 includes fixes for those:
 https://github.com/arthuredelstein/torbutton/commit/26520+1

 > Now it seems to fire too late - on first site load (not including
 about:tor). If that first loaded site contains JavaScript, it will be
 disabled there. Tested on e.g. https://enable-javascript.com

 > I tried with a line `log(5, "XXX sending");` added inside the
 `sendNoScriptSettings` function and noticed that both the first site load
 and moving the slider resulted in //multiple// messages to NoScript - not
 sure if that's a problem.

 I wasn't able to reproduce these two issues. I even tried setting https
 ://enable-javascript.com as the browser's homepage, but in every case the
 NoScript state seems to be set correctly. Do you still see these issues
 with the revised patch?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26412 [Core Tor/Stem]: KeyError in can_exit_to caused by lru_cache

[Tor Bug Tracker & Wiki]

#26412: KeyError in can_exit_to caused by lru_cache
---+
 Reporter:  juga   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-bwauth |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Description changed by juga:

Old description:

> As pastly reported in https://github.com/pastly/simple-bw-
> scanner/issues/198,
> stem giving this traceback:
>
> `File "/home/pastly/src/simple-bw-scanner/venv-editable/lib/python3.5
> /site-packages/stem/exit_policy.py", line 285, in can_exit_to`
>
> `if not self.is_exiting_allowed():KeyError:
> (,)`
>
> Apparently caused by  a Python bug with `lru_cache`.
>
> pastly is already trying to find out which Python versions fail, to use
> `stem`'s `lru_cache` for those ones.

New description:

 As pastly reported in https://github.com/pastly/simple-bw-
 scanner/issues/198,
 stem giving this traceback:

 `File "/home/pastly/src/simple-bw-scanner/venv-editable/lib/python3.5
 /site-packages/stem/exit_policy.py", line 285, in can_exit_to`

 `if not self.is_exiting_allowed():KeyError:
 (,)`

 Apparently caused by  a Python bug with `lru_cache`.

 pastly is already trying to find out which Python versions fail, to use
 `stem`'s `lru_cache` for those ones.

 This ticket blocks #26848

 Edit: blocks ticket

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26034 [Core Tor/Tor]: LibreSSL 2.7.x supports some OpenSSL 1.1 APIs?

[Tor Bug Tracker & Wiki]

#26034: LibreSSL 2.7.x supports some OpenSSL 1.1 APIs?
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-removed-20180711  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 (In fact, that issue might be #26712?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26849 [Internal Services/Service - dist]: Upload sbws releases in dist.torproject.org

[Tor Bug Tracker & Wiki]

#26849: Upload sbws releases in dist.torproject.org
--+
 Reporter:  juga  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - dist  |Version:
 Severity:  Normal|   Keywords:  sbws
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Some `Core Tor` components use https://dist.torproject.org/ to upload
 releases.
 It would be useful to have `sbws` releases also published there.
 They should be created with `git archive` and gpg signed.
 They can be created from sbws tags (that are already currently signed).
 This would be also facilitate sbws debian package (#26848) to detect when
 there are new `sbws` releases without depending on Github automatic
 releases from tags.

 I think this would require to create a directory called `sbws`, give
 permissions to pastly (and optionally juga).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26848 [Core Tor/sbws]: Create Debian package for sbws

[Tor Bug Tracker & Wiki]

#26848: Create Debian package for sbws
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #25925 | Points:
 Reviewer: |Sponsor:
---+-
Description changed by juga:

Old description:

> We agreed that to easy bandwidth authorities to run `sbws` we should have
> a Debian package.
> This is also part of #17275.
> This ticket follows the issue created in github [0]
>
> Tasks to have a Debian package:
> - [x] create a proper Python package (solved by GHXX, GHXX, GHXX)
> - [x] create metadata for the Python package, useful for source and
> binary distributions (solved by GHXX)
> - [X] create Debian ITP [1] (https://bugs.debian.org/cgi-
> bin/bugreport.cgi?bug=903976)
> - [ ] get ITP accepted
> - [ ] try to get a team to collectively maintain the package so that it
> does not depend on a single person
> - [ ] get steam to release new version, currently blocked by #26412
> - [ ] (optionall) provide sbws releases via dist.tpo (#XXX) so that
> `watch` does not use Github
> - [ ] create debian source package in Debian repositories
> (salsa.debian.org)
> - [ ] get the source reviewed
> - [ ] get the package uploaded to Debian archive (sid)
> - [ ] create debian backport to current stable (stretch)
> - [ ] get backport reviewed
> - [ ] get backport uploaded to Debian archive
> - [ ] (optional) upload the package to deb.tpo
> - [ ] (optional) create bug in Ubuntu to get the package distributed in
> Ubuntu too
>
> [0] https://github.com/pastly/simple-bw-scanner/issues/101
> [1] https://wiki.debian.org/ITP
>
> Edit:
> - link to ITP bug, mark as done
> - [ ] get ITP accepted
> - [ ] (optionall) provide sbws releases via dist.tpo (#XXX) so that
> `watch` does not use Github
> - [ ] get the source reviewed
> - [ ] get the package uploaded to Debian archive (sid)
> - [ ] create debian backport to current stable (stretch)
> - [ ] get backport reviewed
> - [ ] get backport uploaded to Debian archive
> - [ ] (optional) upload the package to deb.tpo
> - [ ] (optional) create bug in Ubuntu to get the package distributed in
> Ubuntu too

New description:

 We agreed that to easy bandwidth authorities to run `sbws` we should have
 a Debian package.
 This is also part of #17275.
 This ticket follows the issue created in github [0]

 Tasks to have a Debian package:
 - [x] create a proper Python package (solved by GHXX, GHXX, GHXX)
 - [x] create metadata for the Python package, useful for source and binary
 distributions (solved by GHXX)
 - [X] create Debian ITP [1] (https://bugs.debian.org/cgi-
 bin/bugreport.cgi?bug=903976)
 - [ ] get ITP accepted
 - [ ] try to get a team to collectively maintain the package so that it
 does not depend on a single person
 - [ ] get steam to release new version, currently blocked by #26412
 - [ ] (optionall) provide sbws releases via dist.tpo (#26849) so that
 `watch` does not use Github
 - [ ] create debian source package in Debian repositories
 (salsa.debian.org)
 - [ ] get the source reviewed
 - [ ] get the package uploaded to Debian archive (sid)
 - [ ] create debian backport to current stable (stretch)
 - [ ] get backport reviewed
 - [ ] get backport uploaded to Debian archive
 - [ ] (optional) upload the package to deb.tpo
 - [ ] (optional) create bug in Ubuntu to get the package distributed in
 Ubuntu too

 [0] https://github.com/pastly/simple-bw-scanner/issues/101
 [1] https://wiki.debian.org/ITP

 Edit:
 - link to ITP bug, mark as done
 - [ ] get ITP accepted
 - [ ] (optionall) provide sbws releases via dist.tpo (#XXX) so that
 `watch` does not use Github
 - [ ] get the source reviewed
 - [ ] get the package uploaded to Debian archive (sid)
 - [ ] create debian backport to current stable (stretch)
 - [ ] get backport reviewed
 - [ ] get backport uploaded to Debian archive
 - [ ] (optional) upload the package to deb.tpo
 - [ ] (optional) create bug in Ubuntu to get the package distributed in
 Ubuntu too
 - Add ticket number for having releases in dist.tpo

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26789 [Core Tor/Tor]: configure --disable-unittests causes build to fail when linking

[Tor Bug Tracker & Wiki]

#26789: configure --disable-unittests causes build to fail when linking
--+
 Reporter:  jchevali  |  Owner:  rl1987
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  034-must? regression  |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Works fine -- both branches merged.  Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26830 [Core Tor/Tor]: SKIP test_keygen.sh on Windows

[Tor Bug Tracker & Wiki]

#26830: SKIP test_keygen.sh on Windows
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.3-rc
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci, tor-testing, 035-must,   |  Actual Points:
  regression, fast-fix   |
Parent ID:  #26076   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26830 [Core Tor/Tor]: SKIP test_keygen.sh on Windows

[Tor Bug Tracker & Wiki]

#26830: SKIP test_keygen.sh on Windows
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7.3-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-testing, 035-must,   |  Actual Points:
  regression, fast-fix   |
Parent ID:  #26076   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Squashed and merged to 0.2.9 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

[Tor Bug Tracker & Wiki]

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  task   | Status:
   |  needs_review
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531 | Points:
 Reviewer: |Sponsor:
---+---

Comment (by sysrqb):

 Replying to [comment:17 gk]:
 > I started my review based on `tor-browser-60.1.0esr-8.0-1+26401` which
 is what I stuck to. Here comes the first batch of comments:

 Thanks, no problem.

 >
 > commit 970c95dff0b30eaf0597e43c442b375fe8a68da0 -- not okay
 >
 > "We exclude the all testStumbler*.java files" (one of "the" and "all"
 should be
 > enough :) )
 >
 > Maybe use `''` instead of `""` as all exclude rules are using the former
 >

 Changed.

 > commit 66ecd900c106de3bb84ba9f5aa1cdc59ab28cdd7 -- not okay
 >
 > .mozconfig-android: are we really still using ndk r10e for esr60;

 No, I'll update the comment (Fennec is build using NDK r15c now)

 > I guess the comments before the *strip options are essentially enabling
 stripping? if so, we should be explicit about it an use `--enable-strip`
 like on other platforms as well
 >

 The defaults are effectively `--disable-strip` and `--enable-install-
 strip` but we should test these options and understand what improves and
 what fails when we enable/disable them. I'm still not sure.

 {{{
 dnl 
 dnl = Enable stripping of libs & executables
 dnl 
 MOZ_ARG_ENABLE_BOOL(strip,
 [  --enable-strip  Enable stripping of libs & executables ],
 ENABLE_STRIP=1,
 ENABLE_STRIP= )

 dnl 
 dnl = Enable stripping of libs & executables when packaging
 dnl 
 MOZ_ARG_ENABLE_BOOL(install-strip,
 [  --enable-install-strip  Enable stripping of libs & executables when
 packaging ],
 PKG_SKIP_STRIP= ,
 PKG_SKIP_STRIP=1)
 }}}

 {{{
 $ grep -e ENABLE_STRIP -e PKG_SKIP_STRIP obj-arm-linux-
 androideabi/config.status
 'ENABLE_STRIP': '',
 'PKG_SKIP_STRIP': '',
 }}}

 > mozconfig.common.override: why do we have all of those changes here?
 Shouldn't the .mozconfig-android file already take care of them? If there
 are some options missing in the former let's add them there. Looking
 closer at that file it seems this is intended for Mozilla's try infra?
 While I think that's worthwhile I think we should have a separate bug for
 that and thinking about a strategy including all the other platforms we
 support as well.
 >

 Okay, that's fair, I'll factor out these changes.

 > "When using --disable-crashreporter the symbole file" -> "When using
 --disable-crashreporter the symbols file"

 ack.

 >
 > commit 9d8303c145317d067b130855eb0b17c70c614d76 -- okay (should we file
 a bug in Mozilla's bug tracker for the unused defines?)

 Yes, I'll open a ticket for that.

 >
 > commit ae36b1d20547358c49ee2206af5e28767ea7d48b -- not okay
 >
 > Indentation:
 > {{{
 > +if (!AppConstants.isTorBrowser()) {
 >  getApplicationContext().sendBroadcast(
 >  new Intent(INTENT_REGISTER_STUMBLER_LISTENER)
 >  );
 > +} // !isTorBrowser()
 > }}}

 I did this so the diff is only the new lines instead of the entire
 statement. This seemed easier for reviewing and future rebase. I can
 indent the conditional if that is more readable.

 >
 > commit 69bdd94ecb8e97e4d590dc75c04963b6659bdae0 -- probably okay (why do
 we need the duplicated entries we already have in confvars.sh?)

 I added those in torbrowser.configure because they look like configure
 flags but they are environment variables. They are still in
 torbrowser.configure only for documentation purposes. I can delete them if
 it's confusing or you think they aren't helpful.

 >
 > commit 97ca08c7c8bc6d58cbeac4838cf2587dc8603050 -- not okay
 >
 > I think we can skip the whole UA override thing as it does not play any
 role anymore once we set the resistfingerprinting pref (which is done for
 mobile as well)

 Okay, I'll delete it.

 >
 > Why is "#ifdef TOR_BROWSER_VERSION" commented out? It seems to me we
 don't want to point our users to the aus5 URL. Maybe I am missing
 something here.

 Hm! Those `//` were only supposed to be visual and not affect the
 inclusion. I thought the preprocessor preserves and enforces the ifdef
 when it scans the file - but I 

Re: [tor-bugs] #26845 [Applications/Tor Browser]: TBA: Is the "Slow Script" warning is triggered too often?

[Tor Bug Tracker & Wiki]

#26845: TBA: Is the "Slow Script" warning is triggered too often?
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arma):

 I hit this sometimes on Tor Browser 8 alpha Linux too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21785 [Applications/Tor Browser]: Keep an eye on the Storage API

[Tor Bug Tracker & Wiki]

#21785: Keep an eye on the Storage API
--+---
 Reporter:  gk|  Owner:  pospeselr
 Type:  task  | Status:  assigned
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-fingerprinting, ff60-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by pospeselr):

 * status:  new => assigned
 * owner:  tbb-team => pospeselr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26846 [Core Tor/Tor]: prop289: Leave unused random bytes in relay cell payload

[Tor Bug Tracker & Wiki]

#26846: prop289: Leave unused random bytes in relay cell payload
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop289, 035-roadmap-subtask  |  Actual Points:
Parent ID:  #26288| Points:
 Reviewer:|Sponsor:  SponsorV
--+
Changes (by dgoulet):

 * keywords:  prop289 => prop289, 035-roadmap-subtask


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24056 [Applications/Tor Browser]: UI locale is detectable by button width

[Tor Bug Tracker & Wiki]

#24056: UI locale is detectable by button width
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:
 Keywords:  tbb-fingerprinting|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arthuredelstein):

 Here's list of strings that are displayed by default in elements of HTML
 forms:
 https://dxr.mozilla.org/mozilla-central/source/dom/locales/en-
 US/chrome/layout/HtmlForm.properties

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)

[Tor Bug Tracker & Wiki]

#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
+--
 Reporter:  cypherpunks |  Owner:  tbb-team
 Type:  defect  | Status:  reopened
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by Hello71):

 what's wrong with rpath?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25555 [Applications/Tor Browser]: Reimplement Optimistic SOCKS feature

[Tor Bug Tracker & Wiki]

#2: Reimplement Optimistic SOCKS feature
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-performance, ff60-esr,   |  Actual Points:
  TorBrowserTeam201807   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: pospeselr (added)
 * priority:  Very High => High


Comment:

 Putting this to a slightly less high prio right now. While performance is
 important, we need to make progress on the `tbb-fingerprinting` tickets
 first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26814 [Applications/Tor Browser]: tor won't start on windows 10

[Tor Bug Tracker & Wiki]

#26814: tor won't start on windows 10
--+---
 Reporter:  Grabler   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:  not a bug
 Keywords:  startup   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by notcypherpunks):

 https://community.webroot.com/t5/Webroot-SecureAnywhere-Complete/tor-show-
 error-quot-can-not-load-xpcom-quot/td-p/92478

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #26846, #26842, #26841, #26840, ...

[Tor Bug Tracker & Wiki]

Batch modification to #26846, #26842, #26841, #26840, #26839, #26288 by dgoulet:
type to enhancement

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26437 [Core Tor/Tor]: Forking tests fails on Windows if there is a space in the path of the test runner

[Tor Bug Tracker & Wiki]

#26437: Forking tests fails on Windows if there is a space in the path of the 
test
runner
-+
 Reporter:  ahf  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:  fixed
 Keywords:  035-triaged-in-20180711  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 lgtm; merged to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #9923 [HTTPS Everywhere/EFF-HTTPS Everywhere]: Automatically merge translations from Transifex

[Tor Bug Tracker & Wiki]

#9923: Automatically merge translations from Transifex
-+-
 Reporter:  schoen   |  Owner:  schoen
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  HTTPS Everywhere/EFF-HTTPS   |Version:
  Everywhere |
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by emmapeel):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26689 [Core Tor/Tor]: No support for an upstream proxy that uses NTLM authentication

[Tor Bug Tracker & Wiki]

#26689: No support for an upstream proxy that uses NTLM authentication
--+--
 Reporter:  irl   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * type:  defect => enhancement


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #9923 [HTTPS Everywhere/EFF-HTTPS Everywhere]: Automatically merge translations from Transifex

[Tor Bug Tracker & Wiki]

#9923: Automatically merge translations from Transifex
-+-
 Reporter:  schoen   |  Owner:  schoen
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  HTTPS Everywhere/EFF-HTTPS   |Version:
  Everywhere |
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by emmapeel):

 We run such a script, and we are keeping the translations for
 HTTP_Everywhere updated:

 https://gitweb.torproject.org/translation.git/log/?h=https_everywhere

 https://gitweb.torproject.org/translation.git/log/?h=https_everywhere_completed

 Please reopen if there is something else needed, by now I will close this
 ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26846 [Core Tor/Tor]: prop289: Leave unused random bytes in relay cell payload

[Tor Bug Tracker & Wiki]

#26846: prop289: Leave unused random bytes in relay cell payload
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  prop289
Actual Points:|  Parent ID:  #26288
   Points:|   Reviewer:
  Sponsor:  SponsorV  |
--+
 This is section 3.3 of proposal 289 which is, in short, to add randomness
 to some relay cell payload.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26847 [Applications/Tor Browser]: Tor Browser 8a, noscript pops up a full-browser-size window to warn me about x-site scripting

[Tor Bug Tracker & Wiki]

#26847: Tor Browser 8a, noscript pops up a full-browser-size window to warn me
about x-site scripting
--+--
 Reporter:  arma  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 When I go to certain sites in the Tor Browser 8 alpha, I get a new window
 popping up, which is the same size as my current browser window, which
 looks like it comes from noscript. It says "NoScript XSS Warning" at the
 top, and the window title is moz-extension://4536b558- NoScript XSS
 Warning", and there's a bit of text towards the top that says
 {{{


 NoScript detected a potential Cross-Site Scripting attack

 from http://www.espn.com to https://8397396.fls.doubleclick.net.

 Suspicious data:

 (URL)
 
https://8397396.fls.doubleclick.net/activityi;src=8397396;type=espng0;cat=espna0;u1=http://www.espn.com/mlb/story/_/id/24116616
 /mlb-bryce-harper-brings-house-epic-derby-
 comeback;u2=[s.products];u3=[c.promocode];u4=[payment
 
method];u5=[c.SWID];u6=[c.UNID];u7=[c.NavMethod];u8=[Trial/Monthly/Annual];dc_lat=;dc_rdid=;tag_for_child_directed_treatment=;tfua=;npa=;ord=9016327828417.457?
 }}}

 and towards the bottom I have the options to block, always block, allow,
 always allow, and then an ok button.

 The example url in this case was
 http://www.espn.com/mlb/story/_/id/24116616/mlb-bryce-harper-brings-house-
 epic-derby-comeback

 (I've noticed the behavior happens pretty consistently with espn urls.)

 I'm not sure quite what behavior I would expect instead, but "making a new
 huge window that's mostly whitespace and that prevents me from doing
 anything on any tab until I've made the window go away" was not it. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26848 [Core Tor/sbws]: Create Debian package for sbws

[Tor Bug Tracker & Wiki]

#26848: Create Debian package for sbws
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #25925
   Points: |   Reviewer:
  Sponsor: |
---+-
 We agreed that to easy bandwidth authorities to run `sbws` we should have
 a Debian package.
 This is also part of #17275.
 This ticket follows the issue created in github [0]

 Tasks to have a Debian package:
 - [x] create a proper Python package (solved by GHXX, GHXX, GHXX)
 - [x] create metadata for the Python package, useful for source and binary
 distributions (solved by GHXX)
 - [ ] create Debian ITP [1]
 - [ ] try to get a team to collectively maintain the package so that it
 does not depend on a single person
 - [ ] get steam to release new version, currently blocked by #26412

 [0] https://github.com/pastly/simple-bw-scanner/issues/101
 [1] https://wiki.debian.org/ITP

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26789 [Core Tor/Tor]: configure --disable-unittests causes build to fail when linking

[Tor Bug Tracker & Wiki]

#26789: configure --disable-unittests causes build to fail when linking
--+
 Reporter:  jchevali  |  Owner:  rl1987
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  034-must? regression  |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 Great -- I'll merge once I've given it a quick test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26849 [Internal Services/Service - dist]: Upload sbws releases in dist.torproject.org

[Tor Bug Tracker & Wiki]

#26849: Upload sbws releases in dist.torproject.org
--+
 Reporter:  juga  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Internal Services/Service - dist  |Version:
 Severity:  Normal| Resolution:
 Keywords:  sbws  |  Actual Points:
Parent ID:  #26848| Points:
 Reviewer:|Sponsor:
--+
Changes (by juga):

 * parent:   => #26848


Comment:

 Add parent

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26848 [Core Tor/sbws]: Create Debian package for sbws

[Tor Bug Tracker & Wiki]

#26848: Create Debian package for sbws
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #25925 | Points:
 Reviewer: |Sponsor:
---+-
Description changed by juga:

Old description:

> We agreed that to easy bandwidth authorities to run `sbws` we should have
> a Debian package.
> This is also part of #17275.
> This ticket follows the issue created in github [0]
>
> Tasks to have a Debian package:
> - [x] create a proper Python package (solved by GHXX, GHXX, GHXX)
> - [x] create metadata for the Python package, useful for source and
> binary distributions (solved by GHXX)
> - [X] create Debian ITP [1] (https://bugs.debian.org/cgi-
> bin/bugreport.cgi?bug=903976)
> - [ ] get ITP accepted
> - [ ] try to get a team to collectively maintain the package so that it
> does not depend on a single person
> - [ ] get steam to release new version, currently blocked by #26412
> - [ ] (optionall) provide sbws releases via dist.tpo (#26849) so that
> `watch` does not use Github
> - [ ] create debian source package in Debian repositories
> (salsa.debian.org)
> - [ ] get the source reviewed
> - [ ] get the package uploaded to Debian archive (sid)
> - [ ] create debian backport to current stable (stretch)
> - [ ] get backport reviewed
> - [ ] get backport uploaded to Debian archive
> - [ ] (optional) upload the package to deb.tpo
> - [ ] (optional) create bug in Ubuntu to get the package distributed in
> Ubuntu too
>
> [0] https://github.com/pastly/simple-bw-scanner/issues/101
> [1] https://wiki.debian.org/ITP
>
> Edit:
> - link to ITP bug, mark as done
> - [ ] get ITP accepted
> - [ ] (optionall) provide sbws releases via dist.tpo (#XXX) so that
> `watch` does not use Github
> - [ ] get the source reviewed
> - [ ] get the package uploaded to Debian archive (sid)
> - [ ] create debian backport to current stable (stretch)
> - [ ] get backport reviewed
> - [ ] get backport uploaded to Debian archive
> - [ ] (optional) upload the package to deb.tpo
> - [ ] (optional) create bug in Ubuntu to get the package distributed in
> Ubuntu too
> - Add ticket number for having releases in dist.tpo

New description:

 We agreed that to easy bandwidth authorities to run `sbws` we should have
 a Debian package.
 This is also part of #17275.
 This ticket follows the issue created in github [0]

 Tasks to have a Debian package:
 - [x] create a proper Python package (solved by GHXX, GHXX, GHXX)
 - [x] create metadata for the Python package, useful for source and binary
 distributions (solved by GHXX)
 - [X] create Debian ITP [1] (https://bugs.debian.org/cgi-
 bin/bugreport.cgi?bug=903976)
 - [ ] get ITP accepted
 - [X] try to get a team to collectively maintain the package so that it
 does not depend on a single person (https://alioth-
 lists.debian.net/pipermail/pkg-privacy-maintainers/Week-of-
 Mon-20180716/002184.html)
 - [ ] get steam to release new version, currently blocked by #26412
 - [ ] (optionall) provide sbws releases via dist.tpo (#26849) so that
 `watch` does not use Github
 - [ ] create debian source package in Debian repositories
 (salsa.debian.org)
 - [ ] get the source reviewed
 - [ ] get the package uploaded to Debian archive (sid)
 - [ ] create debian backport to current stable (stretch)
 - [ ] get backport reviewed
 - [ ] get backport uploaded to Debian archive
 - [ ] (optional) upload the package to deb.tpo
 - [ ] (optional) create bug in Ubuntu to get the package distributed in
 Ubuntu too

 [0] https://github.com/pastly/simple-bw-scanner/issues/101
 [1] https://wiki.debian.org/ITP

 Edit:
 - link to ITP bug, mark as done
 - [ ] get ITP accepted
 - [ ] (optionall) provide sbws releases via dist.tpo (#XXX) so that
 `watch` does not use Github
 - [ ] get the source reviewed
 - [ ] get the package uploaded to Debian archive (sid)
 - [ ] create debian backport to current stable (stretch)
 - [ ] get backport reviewed
 - [ ] get backport uploaded to Debian archive
 - [ ] (optional) upload the package to deb.tpo
 - [ ] (optional) create bug in Ubuntu to get the package distributed in
 Ubuntu too
 - Add ticket number for having releases in dist.tpo
 - Add link to team mail

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24598 [Webpages/Website]: Upload site content on transifex for translation

[Tor Bug Tracker & Wiki]

#24598: Upload site content on transifex for translation
--+--
 Reporter:  isabela   |  Owner:  emmapeel
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  website redesign
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  ux-team,  |  Actual Points:
Parent ID:  #24129| Points:
 Reviewer:|Sponsor:
--+--
Changes (by emmapeel):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26814 [Applications/Tor Browser]: tor won't start on windows 10

[Tor Bug Tracker & Wiki]

#26814: tor won't start on windows 10
--+---
 Reporter:  Grabler   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:  not a bug
 Keywords:  startup   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by arma):

 Yes, this definitely sounds like a webroot issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17275 [Core Tor/Tor]: Package directory authority scripts for debian in compliant packages

[Tor Bug Tracker & Wiki]

#17275: Package directory authority scripts for debian in compliant packages
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  task | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-tests-integration tor-dirauth|  Actual Points:
  packaging  |
Parent ID:   | Points:  4.5
 Reviewer:   |Sponsor:
 |  SponsorS-can
-+-

Comment (by juga):

 The bandwidth scanner, `sbws` will have a Debian package too (#26848)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26839 [Core Tor/Tor]: prop289: Make a relay remember last cell digests before SENDME

[Tor Bug Tracker & Wiki]

#26839: prop289: Make a relay remember last cell digests before SENDME
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop289, 035-roadmap-subtask  |  Actual Points:
Parent ID:  #26288| Points:
 Reviewer:|Sponsor:  SponsorV
--+

Comment (by nickm):

 I think the best subsystem to implement this in would be in the
 relay_crypto.c area.  The logical place to store it would be in
 relay_crypto_t, which is the shared state between two points on a Tor
 circuit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 Thanks! I've left an inline comment on github about a minor comment
 accuracy thing, and asked about tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 You're correct on both counts -- I'll revise.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26456 [Applications/Tor Browser]: HTTP .onion sites inherit previous page's certificate information

[Tor Bug Tracker & Wiki]

#26456: HTTP .onion sites inherit previous page's certificate information
+--
 Reporter:  pospeselr   |  Owner:  pospeselr
 Type:  defect  | Status:
|  needs_revision
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  ff60-esr, TorBrowserTeam201807R => ff60-esr,
 TorBrowserTeam201807
 * status:  needs_review => needs_revision


Comment:

 One nit and one concern/question. The nit:
 {{{
 if(mSSLStatus != nullptr) {
 }}}
 please add a whitespace after `if`.

 So, the current code seems to keep the `mSSLStatus` as-is in case `if
 (sp)` is `false`. I wonder if that is intentional and a use-case we should
 keep in mind (your patch is essentially getting rid of that possibility).
 Is there a way we can reach that scenario? It seems to me the answer is
 "Yes", just by looking at the way the code is written. However, I am not
 sure which transition from load A to load B would match this in reality.
 It worries me that we are missing something here, so it might be worth
 double-checking.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26848 [Core Tor/sbws]: Create Debian package for sbws

[Tor Bug Tracker & Wiki]

#26848: Create Debian package for sbws
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #25925 | Points:
 Reviewer: |Sponsor:
---+-
Description changed by juga:

Old description:

> We agreed that to easy bandwidth authorities to run `sbws` we should have
> a Debian package.
> This is also part of #17275.
> This ticket follows the issue created in github [0]
>
> Tasks to have a Debian package:
> - [x] create a proper Python package (solved by GHXX, GHXX, GHXX)
> - [x] create metadata for the Python package, useful for source and
> binary distributions (solved by GHXX)
> - [ ] create Debian ITP [1]
> - [ ] try to get a team to collectively maintain the package so that it
> does not depend on a single person
> - [ ] get steam to release new version, currently blocked by #26412
>
> [0] https://github.com/pastly/simple-bw-scanner/issues/101
> [1] https://wiki.debian.org/ITP

New description:

 We agreed that to easy bandwidth authorities to run `sbws` we should have
 a Debian package.
 This is also part of #17275.
 This ticket follows the issue created in github [0]

 Tasks to have a Debian package:
 - [x] create a proper Python package (solved by GHXX, GHXX, GHXX)
 - [x] create metadata for the Python package, useful for source and binary
 distributions (solved by GHXX)
 - [X] create Debian ITP [1] (https://bugs.debian.org/cgi-
 bin/bugreport.cgi?bug=903976)
 - [ ] get ITP accepted
 - [ ] try to get a team to collectively maintain the package so that it
 does not depend on a single person
 - [ ] get steam to release new version, currently blocked by #26412
 - [ ] (optionall) provide sbws releases via dist.tpo (#XXX) so that
 `watch` does not use Github
 - [ ] create debian source package in Debian repositories
 (salsa.debian.org)
 - [ ] get the source reviewed
 - [ ] get the package uploaded to Debian archive (sid)
 - [ ] create debian backport to current stable (stretch)
 - [ ] get backport reviewed
 - [ ] get backport uploaded to Debian archive
 - [ ] (optional) upload the package to deb.tpo
 - [ ] (optional) create bug in Ubuntu to get the package distributed in
 Ubuntu too

 [0] https://github.com/pastly/simple-bw-scanner/issues/101
 [1] https://wiki.debian.org/ITP

 Edit:
 - link to ITP bug, mark as done
 - [ ] get ITP accepted
 - [ ] (optionall) provide sbws releases via dist.tpo (#XXX) so that
 `watch` does not use Github
 - [ ] get the source reviewed
 - [ ] get the package uploaded to Debian archive (sid)
 - [ ] create debian backport to current stable (stretch)
 - [ ] get backport reviewed
 - [ ] get backport uploaded to Debian archive
 - [ ] (optional) upload the package to deb.tpo
 - [ ] (optional) create bug in Ubuntu to get the package distributed in
 Ubuntu too

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26034 [Core Tor/Tor]: LibreSSL 2.7.x supports some OpenSSL 1.1 APIs?

[Tor Bug Tracker & Wiki]

#26034: LibreSSL 2.7.x supports some OpenSSL 1.1 APIs?
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-removed-20180711  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 toralf -- that sounds like a separate issue, if it's happening on an
 unmodified version of git master?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24296 [Metrics/Onionoo]: Make Onionoo's document classes available as part of metrics-lib

[Tor Bug Tracker & Wiki]

#24296: Make Onionoo's document classes available as part of metrics-lib
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Oh, well. Even though the `ZonedDateTime` change doesn't look terribly
 hard, I'm still running into issues. I feel like this is a perfect-is-the-
 enemy-of-good case. How about we postpone the `ZonedDateTime` change and
 go with the Jackson-related changes only for now? In particular, would you
 like to review
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-24296=403f107954c3a35e8b444e401e650d8d10b8f396
 commit 403f107 in my task-24296 branch] that adds annotations as discussed
 above? We can still make more changes later. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Linux CI passed on this branch.
 I opened ​https://github.com/torproject/tor/pull/241 so that Windows CI
 runs on this branch.
 You can set up Windows CI on your GitHub by going to
 https://ci.appveyor.com/

 After it's successful, let's merge the branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26847 [Applications/Tor Browser]: Tor Browser 8a, noscript pops up a full-browser-size window to warn me about x-site scripting

[Tor Bug Tracker & Wiki]

#26847: Tor Browser 8a, noscript pops up a full-browser-size window to warn me
about x-site scripting
--+--
 Reporter:  arma  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ProTipGuyFWIWWeLoveARMA):

 I agree, as is, it's pretty inconvenient. Also I had one of those
 existential thoughts "Will these settings persists?" after I kept getting
 that warning and had to chose to the "Always block from ..." option, not
 good!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  tom  |  Owner:  juga
 Type:  enhancement  | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-removed-20180711, 035-roadmap-proposed |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 The refactor in #26797 will involve storing a copy of the bandwidth file
 in RAM or on disk, so let's do it first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26702 [Core Tor/Tor]: Remind authority operators that bandwidth files should be transferred outside the voting period

[Tor Bug Tracker & Wiki]

#26702: Remind authority operators that bandwidth files should be transferred
outside the voting period
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, 035-removed-20180711,   |  Actual Points:
  fast-fix, doc  |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:9 nickm]:
 > I'm sorry; I can't find this branch. Are you sure it's where you say?

 I forked torproject/tor yesterday so I could do pull requests. (GitHub
 doesn't support pull requests between repositories, unless they are in the
 same GitHub fork tree.) My old tor repository is at tor-old.

 I have re-pushed the branch ticket26702 to
 ​https://github.com/teor2345/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26034 [Core Tor/Tor]: LibreSSL 2.7.x supports some OpenSSL 1.1 APIs?

[Tor Bug Tracker & Wiki]

#26034: LibreSSL 2.7.x supports some OpenSSL 1.1 APIs?
--+--
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-removed-20180711  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by toralf):

 Replying to [comment:4 nickm]:
 > toralf -- that sounds like a separate issue, if it's happening on an
 unmodified version of git master?
 yes - that's why I pasted "git describe" too here

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Okay, revised, and added tests.  Better now?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26850 [Core Tor/Tor]: Increase coverage in libtor-string.a to 100%

[Tor Bug Tracker & Wiki]

#26850: Increase coverage in libtor-string.a to 100%
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  fast-fix
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 I was looking at coverage results and saw that there were only a handful
 of uncovered lines here, so I went and wrote tests for them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26850 [Core Tor/Tor]: Increase coverage in libtor-string.a to 100%

[Tor Bug Tracker & Wiki]

#26850: Increase coverage in libtor-string.a to 100%
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 The branch is `string_coverage`; PR at
 https://github.com/torproject/tor/pull/240

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25552 [Core Tor/Tor]: prop224: Onion service rev counters are useless and actually harmful for scalability

[Tor Bug Tracker & Wiki]

#25552: prop224: Onion service rev counters are useless and actually harmful for
scalability
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.1.9
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, 035-roadmap-|  Actual Points:
  master, 035-must, regression, 035-triaged- |
  in-20180711|
Parent ID:   | Points:  6+++
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by nickm):

 Squashed, and merged to master.

 The squash was trivial and produced
 14b507e5207ce7e581c5fc773921f8cf65d08247.

 The merge was nontrivial, and produced
 e2b744ce38edb8901cff3288634c4ebb5b4568b9.  It would be good if one of you
 would review it, then close this ticket. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26520 [Applications/Tor Browser]: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser

[Tor Bug Tracker & Wiki]

#26520: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by rustybird):

 > I wasn't able to reproduce these two issues.

 The "multiple messages to NoScript" problem is gone with the revised
 patch. I still have the "first site load" problem on a freshly extracted
 and patched TB - sorry if it's tediously verbose:

 1. Run system tor on `SocksPort 9150`, `ControlPort 9151`
 2. Extract `tor-browser-linux64-8.0a9_en-US.tar.xz` to a new directory
 3. In the extensions directory, `unzip -d torbut...@torproject.org/
 torbut...@torproject.org.xpi` and delete the .xpi
 4. In `torbut...@torproject.org/`, apply the revised patch with `-p2`
 5. Make a backup of the pristine patched `tor-browser_en-US/` directory
 6. Run `TOR_SKIP_LAUNCH=1 ./start-tor-browser.desktop`
 7. Go to https://enable-javascript.com

 It shows "JavaScript is disabled in your web browser" until I refresh the
 site, at which point it switches to "JavaScript is enabled". Same for
 other websites that depend on JavaScript, e.g.
 https://twitter.com/torproject (after restarting with a new copy of the
 backed up directory from step 5).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25625 [Metrics/Website]: Make CollecTor's file structure description part of Metrics-Web's CollecTor docs

[Tor Bug Tracker & Wiki]

#25625: Make CollecTor's file structure description part of Metrics-Web's 
CollecTor
docs
-+
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  irl  |Sponsor:
-+

Comment (by karsten):

 Hmm, is this something that you can write a patch for, and where I can
 then go ahead and fill in all the details? It's something that I keep
 postponing, because I'm not yet sure how to best present things in order
 for others to make sense of. Of course, if you're already too busy with
 other things, let me know, and I'll give it another try.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 The first bad commit `git bisect` gives me is commit
 2079a084df08c38eb4dbfc5c8de5c0245170c3d9 which is a merge. So, I need to
 dig deeper it seems...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26694 [Core Tor/Tor]: dir-spec: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#26694: dir-spec: DirAuths should expose bwauth bandwidth files
-+-
 Reporter:  juga |  Owner:  juga
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-dirauth, metrics, tor-bwauth,|  Actual Points:
  035-triaged-in-20180711|
Parent ID:  #21377   | Points:
 Reviewer:  juga, teor   |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 The spec has been merged to torspec and dir-spec, we'll continue the
 implementation in #21377.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26702 [Core Tor/Tor]: Remind authority operators that bandwidth files should be transferred outside the voting period

[Tor Bug Tracker & Wiki]

#26702: Remind authority operators that bandwidth files should be transferred
outside the voting period
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, 035-removed-20180711,   |  Actual Points:
  fast-fix, doc  |
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I don't think this is what we should recommend.  I think that instead we
 should recommend that these files be replaced atomically, via rename.  How
 would that be?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #15518 [Core Tor/Tor]: Tor considers routers in the same IPv6 /16 to be "in the same subnet"

[Tor Bug Tracker & Wiki]

#15518: Tor considers routers in the same IPv6 /16 to be "in the same subnet"
-+-
 Reporter:  isis |  Owner:  Samdney
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, path, path-bias, tor-client|  Actual Points:
  easy   |
Parent ID:  #24393   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 Samdney,

 Are you still interested in this bug report? If not, could I take it?

 Thanks,

 Neel

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26740 [Core Tor/sbws]: Make sbws generate bandwidth files atomically, and document (was: Document that bandwidth files should be generated atomically)

[Tor Bug Tracker & Wiki]

#26740: Make sbws generate bandwidth files atomically, and document
---+-
 Reporter:  juga   |  Owner:  teor
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #26851 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * status:  assigned => needs_review
 * milestone:  sbws 1.0 (MVP nice) => sbws 1.0 (MVP must)


Comment:

 sbws was deleting the symlink after generating the file. When the symlink
 is deleted, reading the path is not atomic, because it can fail with a
 file not found error.

 This change is based on nickm's feedback at:
 https://trac.torproject.org/projects/tor/ticket/26702#comment:12

 Please see my pull request:
 https://github.com/pastly/simple-bw-scanner/pull/237

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26852 [Core Tor/Tor]: doc: document Appveyor CI setup

[Tor Bug Tracker & Wiki]

#26852: doc: document Appveyor CI setup
--+
 Reporter:  teor  |  Owner:  teor
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  doc, fast-fix
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26702 [Core Tor/Tor]: Remind authority operators that bandwidth files should be written atomcally

[Tor Bug Tracker & Wiki]

#26702: Remind authority operators that bandwidth files should be written 
atomcally
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, 035-removed-20180711,   |  Actual Points:
  fast-fix, doc  |
Parent ID:  #26851   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 The travis CI failed for this doc-only branch due to #26787

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26848 [Core Tor/sbws]: Create Debian package for sbws

[Tor Bug Tracker & Wiki]

#26848: Create Debian package for sbws
---+-
 Reporter:  juga   |  Owner:  juga
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #25925 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by teor):

 Instead of modifying the description, you can open child tickets, and
 close them when they're done.
 Then the "child tickets" table in this ticket will automatically show
 their statuses.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26702 [Core Tor/Tor]: Remind authority operators that bandwidth files should be transferred outside the voting period

[Tor Bug Tracker & Wiki]

#26702: Remind authority operators that bandwidth files should be transferred
outside the voting period
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, 035-removed-20180711,   |  Actual Points:
  fast-fix, doc  |
Parent ID:  #26851   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => needs_revision
 * parent:  #25925 => #26851


Comment:

 Ok, I think that's better, I'll update all the docs at once.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26851 [Core Tor]: doc: writing bandwidth files atomically

[Tor Bug Tracker & Wiki]

#26851: doc: writing bandwidth files atomically
--+--
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Parent task

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26702 [Core Tor/Tor]: Remind authority operators that bandwidth files should be written atomcally (was: Remind authority operators that bandwidth files should be transferred outside th

[Tor Bug Tracker & Wiki]

#26702: Remind authority operators that bandwidth files should be written 
atomcally
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, 035-removed-20180711,   |  Actual Points:
  fast-fix, doc  |
Parent ID:  #26851   | Points:
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26805 [Core Tor/Tor]: Work out why Tor networks with all-zero bandwidths are unstable

[Tor Bug Tracker & Wiki]

#26805: Work out why Tor networks with all-zero bandwidths are unstable
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #26803| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * cc: neel@… (added)


Comment:

 Does "bandwidth" mean consensus weight? Is so, I believe all-zero
 bandwidth networks are unstable because it's hard for a client to
 distinguish the network between different relays as no fraction of a
 relay's bandwidth can be made. Keep in mind that I'm not an expert on Tor
 design and this could be completely inaccurate.

 I think the solution is that if there's a bandwidth of 0, we automatically
 make it 1 either on the client or on the consensus. I haven't looked fully
 into a solution so this may be an imperfect one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26702 [Core Tor/Tor]: Remind authority operators that bandwidth files should be written atomcally

[Tor Bug Tracker & Wiki]

#26702: Remind authority operators that bandwidth files should be written 
atomcally
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, 035-removed-20180711,   |  Actual Points:
  fast-fix, doc  |
Parent ID:  #26851   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 Please see my branch ticket26702-atomically on
 ​​https://github.com/teor2345/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26854 [- Select a component]: Want to Run a TOR relay or node on Windows

[Tor Bug Tracker & Wiki]

#26854: Want to Run a TOR relay or node on Windows
--+
 Reporter:  superchicken  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Very Low  |  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Hi, I want to help out. I want to run either a relay or a node on Windows
 10. Sorry for a stupid question, but is it possible to run one on Windows
 10? I tried copy pasting lines into torcc file and TOR stopped working. I
 really like what you do btw.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Appveyor CI was successful. Let's merge!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

[Tor Bug Tracker & Wiki]

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
---+---
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  task   | Status:
   |  needs_review
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531 | Points:
 Reviewer: |Sponsor:
---+---

Comment (by sysrqb):

 Replying to [comment:19 gk]:
 > commit a2c4e6217da42219327206508015ee24846907c4 -- probably okay (Any
 reason the Facebook bg color (#ffecf0f3) did not get adjusted as done in
 the original patch?)

 No, I applied the patch manually because there were many conflict. I think
 I chose keeping the Fennec background color instead of changing it to
 #ffecf0f3 because #3B5998 is the normal "Facebook Blue".

 >
 > commit 91498b6733075d1de69d9f3568bfbffb5f05 -- not okay
 >
 > I assume the resistfingerprinting related UA is not being used by Java
 code automatically? If so, then we should hardcode that one and not a
 custom one.

 Okay, I'll change the UA strings so they are hard coded instead of
 concatenating static values.

 >
 > commit 14cefdc4bd90083e22ac263954a857d254b346a9 -- not okay
 >
 > Indentation of the if-clauses
 >

 Ack.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25152 [Core Tor/Tor]: Try to call less circuitmux_find_map_entry()

[Tor Bug Tracker & Wiki]

#25152: Try to call less circuitmux_find_map_entry()
-+-
 Reporter:  dgoulet  |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  performance, tor-relay,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * cc: neel@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26829 [Core Tor/Tor]: torspec: bandwidth file generators should write the file atomically

[Tor Bug Tracker & Wiki]

#26829: torspec: bandwidth file generators should write the file atomically
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, doc, tor-dirauth,  |  Actual Points:
  metrics, tor-bwauth, torspec   |
Parent ID:  #26851   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 Please see my branch ticket26829 on
 https://github.com/teor2345/torflow.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26852 [Core Tor/Tor]: doc: document Appveyor CI setup

[Tor Bug Tracker & Wiki]

#26852: doc: document Appveyor CI setup
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doc, fast-fix  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 See my branch ticket26852 on https://github.com/teor2345/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs