Re: [tor-bugs] #33598 [Core Tor/Chutney]: chutney does not fail on some SOCKS errors

2020-05-31 Thread Tor Bug Tracker & Wiki
#33598: chutney does not fail on some SOCKS errors
-+-
 Reporter:  teor |  Owner:  c
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6, easy  |  Actual Points:
Parent ID:  #33050   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by c):

 * owner:  (none) => c
 * status:  new => assigned
 * cc: c@… (added)


Comment:

 Assuming workaround is at
 [https://gitweb.torproject.org/chutney.git/tree/lib/chutney/Traffic.py#n441
 Traffic.py:441]? I see the timeout was adjusted in
 [https://gitweb.torproject.org/chutney.git/commit/?id=95ce144c 95ce144c]
 which has more changes than just that line.

 What's a reproducible way to cause a failure case here? Or, at least, will
 decreasing the timeout back to `0.2` be enough to encourage failure?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33609 [Core Tor/Chutney]: Check that onion services have successfully posted descriptors before verifying

2020-05-31 Thread Tor Bug Tracker & Wiki
#33609: Check that onion services have successfully posted descriptors before
verifying
-+-
 Reporter:  teor |  Owner:  c
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6, easy  |  Actual Points:
Parent ID:  #33050   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-

Comment (by c):

 As I said on the PR, I think I'm ready to finalise this merge for review

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33609 [Core Tor/Chutney]: Check that onion services have successfully posted descriptors before verifying

2020-05-31 Thread Tor Bug Tracker & Wiki
#33609: Check that onion services have successfully posted descriptors before
verifying
-+-
 Reporter:  teor |  Owner:  c
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6, easy  |  Actual Points:
Parent ID:  #33050   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by c):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33084 [Internal Services/Tor Sysadmin Team]: decomission kvm5, 9 VMs to migrate

2020-05-31 Thread Tor Bug Tracker & Wiki
#33084: decomission kvm5, 9 VMs to migrate
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Description changed by weasel:

Old description:

> * [ ] build-x86-08.torproject.org (buildbox)
>  * [ ] carinatum.torproject.org (DocTor Host)
>  * [ ] colchicifolium.torproject.org (collector.torproject.org)
>  * [ ] gitlab-01.torproject.org (dip.torproject.org)
>  * [ ] henryi.torproject.org (consensus-health.torproject.org)
>  * [ ] materculae.torproject.org (exonerator.torproject.org)
>  * [ ] palmeri.torproject.org (deb.tpo master)
>  * [x] perdulce.torproject.org (people.torproject.org)
>  * [ ] staticiforme.torproject.org (static-master.torproject.org)

New description:

 * [ ] build-x86-08.torproject.org (buildbox)
  * [ ] carinatum.torproject.org (DocTor Host)
  * [ ] colchicifolium.torproject.org (collector.torproject.org)
  * [ ] gitlab-01.torproject.org (dip.torproject.org)
  * [ ] henryi.torproject.org (consensus-health.torproject.org)
  * [ ] materculae.torproject.org (exonerator.torproject.org)
  * [x] palmeri.torproject.org (deb.tpo master)
  * [ ] perdulce.torproject.org (people.torproject.org)
  * [ ] staticiforme.torproject.org (static-master.torproject.org)

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33084 [Internal Services/Tor Sysadmin Team]: decomission kvm5, 9 VMs to migrate

2020-05-31 Thread Tor Bug Tracker & Wiki
#33084: decomission kvm5, 9 VMs to migrate
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Description changed by weasel:

Old description:

> * [ ] build-x86-08.torproject.org (buildbox)
>  * [ ] carinatum.torproject.org (DocTor Host)
>  * [ ] colchicifolium.torproject.org (collector.torproject.org)
>  * [ ] gitlab-01.torproject.org (dip.torproject.org)
>  * [ ] henryi.torproject.org (consensus-health.torproject.org)
>  * [ ] materculae.torproject.org (exonerator.torproject.org)
>  * [ ] palmeri.torproject.org (deb.tpo master)
>  * [ ] perdulce.torproject.org (people.torproject.org)
>  * [ ] staticiforme.torproject.org (static-master.torproject.org)

New description:

 * [ ] build-x86-08.torproject.org (buildbox)
  * [ ] carinatum.torproject.org (DocTor Host)
  * [ ] colchicifolium.torproject.org (collector.torproject.org)
  * [ ] gitlab-01.torproject.org (dip.torproject.org)
  * [ ] henryi.torproject.org (consensus-health.torproject.org)
  * [ ] materculae.torproject.org (exonerator.torproject.org)
  * [ ] palmeri.torproject.org (deb.tpo master)
  * [x] perdulce.torproject.org (people.torproject.org)
  * [ ] staticiforme.torproject.org (static-master.torproject.org)

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34263 [Circumvention/Snowflake]: Library selection for using WebRTC for the project.

2020-05-31 Thread Tor Bug Tracker & Wiki
#34263: Library selection for using WebRTC for the project.
-+-
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by HashikD):

 Added the library to Gradle. Commit ID:
 145c344946a74ecb1533f35ed9590c05485150aa

 [https://github.com/Hashik-Donthineni/Snowflake-Mobile Github Mirror]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33420 [Metrics/Onionperf]: Add CBT events to Onionperf result files

2020-05-31 Thread Tor Bug Tracker & Wiki
#33420: Add CBT events to Onionperf result files
---+
 Reporter:  acute  |  Owner:  karsten
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  new => accepted
 * owner:  metrics-team => karsten


Comment:

 Looking into this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33084 [Internal Services/Tor Sysadmin Team]: decomission kvm5, 9 VMs to migrate

2020-05-31 Thread Tor Bug Tracker & Wiki
#33084: decomission kvm5, 9 VMs to migrate
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Description changed by weasel:

Old description:

> * [ ] build-x86-08.torproject.org (buildbox)
>  * [ ] carinatum.torproject.org (DocTor Host)
>  * [ ] colchicifolium.torproject.org (collector.torproject.org)
>  * [ ] gitlab-01.torproject.org (dip.torproject.org)
>  * [ ] henryi.torproject.org (consensus-health.torproject.org)
>  * [ ] materculae.torproject.org (exonerator.torproject.org)
>  * [x] palmeri.torproject.org (deb.tpo master)
>  * [ ] perdulce.torproject.org (people.torproject.org)
>  * [ ] staticiforme.torproject.org (static-master.torproject.org)

New description:

 * [o] build-x86-08.torproject.org (buildbox; can be retired any time; but
 ideally keep while we have kvm5)
  * [ ] carinatum.torproject.org (DocTor Host)
  * [ ] colchicifolium.torproject.org (collector.torproject.org)
  * [ ] gitlab-01.torproject.org (dip.torproject.org)
  * [ ] henryi.torproject.org (consensus-health.torproject.org)
  * [ ] materculae.torproject.org (exonerator.torproject.org)
  * [x] palmeri.torproject.org (deb.tpo master)
  * [ ] perdulce.torproject.org (people.torproject.org)
  * [ ] staticiforme.torproject.org (static-master.torproject.org)

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33084 [Internal Services/Tor Sysadmin Team]: decomission kvm5, 9 VMs to migrate

2020-05-31 Thread Tor Bug Tracker & Wiki
#33084: decomission kvm5, 9 VMs to migrate
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Description changed by weasel:

Old description:

> * [o] build-x86-08.torproject.org (buildbox; can be retired any time; but
> ideally keep while we have kvm5)
>  * [ ] carinatum.torproject.org (DocTor Host)
>  * [ ] colchicifolium.torproject.org (collector.torproject.org)
>  * [ ] gitlab-01.torproject.org (dip.torproject.org)
>  * [ ] henryi.torproject.org (consensus-health.torproject.org)
>  * [ ] materculae.torproject.org (exonerator.torproject.org)
>  * [x] palmeri.torproject.org (deb.tpo master)
>  * [ ] perdulce.torproject.org (people.torproject.org)
>  * [ ] staticiforme.torproject.org (static-master.torproject.org)

New description:

 * [o] build-x86-08.torproject.org (buildbox; can be retired any time; but
 ideally keep while we have kvm5)
  * [ ] carinatum.torproject.org (DocTor Host)
  * [ ] colchicifolium.torproject.org (collector.torproject.org)
  * [ ] gitlab-01.torproject.org (dip.torproject.org)
  * [ ] henryi.torproject.org (consensus-health.torproject.org)
  * [ ] materculae.torproject.org (exonerator.torproject.org)
  * [x] palmeri.torproject.org (deb.tpo master)
  * [x] perdulce.torproject.org (people.torproject.org)
  * [ ] staticiforme.torproject.org (static-master.torproject.org)

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34266 [Circumvention/Snowflake]: Creating and setting up the libraries and the project.

2020-05-31 Thread Tor Bug Tracker & Wiki
#34266: Creating and setting up the libraries and the project.
-+
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by HashikD):

 Since we are building using all the latest libraries and supporting latest
 Android SDK, this ticket can be closed.

 Details:
 Project Name: Snowflake-Mobile
 Package Name: org.torproject.snowflake
 Min-SDK: API-21 - Android 5.0 Lollipop

 Refer the ticket: [https://trac.torproject.org/projects/tor/ticket/34308
 #34308]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34266 [Circumvention/Snowflake]: Creating and setting up the libraries and the project.

2020-05-31 Thread Tor Bug Tracker & Wiki
#34266: Creating and setting up the libraries and the project.
-+
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by HashikD):

 * status:  new => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33084 [Internal Services/Tor Sysadmin Team]: decomission kvm5, 9 VMs to migrate

2020-05-31 Thread Tor Bug Tracker & Wiki
#33084: decomission kvm5, 9 VMs to migrate
-+-
 Reporter:  anarcat  |  Owner:  anarcat
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Description changed by weasel:

Old description:

> * [o] build-x86-08.torproject.org (buildbox; can be retired any time; but
> ideally keep while we have kvm5)
>  * [ ] carinatum.torproject.org (DocTor Host)
>  * [ ] colchicifolium.torproject.org (collector.torproject.org)
>  * [ ] gitlab-01.torproject.org (dip.torproject.org)
>  * [ ] henryi.torproject.org (consensus-health.torproject.org)
>  * [ ] materculae.torproject.org (exonerator.torproject.org)
>  * [x] palmeri.torproject.org (deb.tpo master)
>  * [x] perdulce.torproject.org (people.torproject.org)
>  * [ ] staticiforme.torproject.org (static-master.torproject.org)

New description:

 * [o] build-x86-08.torproject.org (buildbox; can be retired any time; but
 ideally keep while we have kvm5)
  * [ ] carinatum.torproject.org (DocTor Host)
  * [ ] colchicifolium.torproject.org (collector.torproject.org)
  * [G] gitlab-01.torproject.org (dip.torproject.org; gone)
  * [ ] henryi.torproject.org (consensus-health.torproject.org)
  * [ ] materculae.torproject.org (exonerator.torproject.org)
  * [x] palmeri.torproject.org (deb.tpo master)
  * [x] perdulce.torproject.org (people.torproject.org)
  * [ ] staticiforme.torproject.org (static-master.torproject.org)

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34191 [Metrics/Onionperf]: Combine multiple analysis files into single data set

2020-05-31 Thread Tor Bug Tracker & Wiki
#34191: Combine multiple analysis files into single data set
---+
 Reporter:  karsten|  Owner:  acute
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:  0.5
Parent ID:  #33321 | Points:  0.5
 Reviewer:  karsten|Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Thanks for working on this and providing a branch! I read your comment and
 the code but did not test anything yet. Two concerns:

  - I'm not sure if we can make it work with a variable number of arguments
 to the `-d` parameter. The usage string is really misleading by saying `-d
 PATH [LABEL ...]`, indicating that it accepts a single `PATH` and zero or
 more `LABEL`s. We would want it to say `-d PATH [PATH ...] LABEL` there.
 Do you know how to override that string? I didn't find something and
 stopped looking at options that felt like hacking argparse.

  - Regarding the limitation that the `LABEL` cannot be a path anymore, I
 think that's problematic. For one, it's turning this change into a
 backward incompatible one. And it's also not intuitive for new users who
 don't know how the parameter works today. Imagine a case where somebody
 puts all files for OnionPerf instance op-hk into one directory `op-hk/`
 and all files for op-ab into another one `op-ab/`. If they want to
 visualize these files using OnionPerf instance names as labels, they'd
 either have to pick different labels or rename the directories. Doable,
 but for sure surprising.

 Maybe it's better to keep this simple by allowing just two arguments as we
 do right now. Users will understand that they have to put all files for
 one data set into a directory. No surprises, they'll get what they want.
 What do you think?

 Apart from these concerns about the user interface, the patch looks good
 to me. The decisions about using `*json*` as pattern (you might want to
 use `*onionperf.analysis.json*` here, now that I think about it) or using
 functionality from the reprocessing module look good to me. I'd say if we
 can figure out the potential user interface issues, this will be a quick
 review. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34267 [Circumvention/Snowflake]: Compiling the WebRTC Google library.

2020-05-31 Thread Tor Bug Tracker & Wiki
#34267: Compiling the WebRTC Google library.
-+--
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:  #34266   | Points:
 Reviewer:  cohosh   |Sponsor:
-+--
Changes (by HashikD):

 * parent:   => #34266


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34307 [Circumvention/Snowflake]: RxJava library for making asynchronous calls.

2020-05-31 Thread Tor Bug Tracker & Wiki
#34307: RxJava library for making asynchronous calls.
-+-
 Reporter:  HashikD  |  Owner:  (none)
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:  #34266   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by HashikD):

 * parent:   => #34266


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34263 [Circumvention/Snowflake]: Library selection for using WebRTC for the project.

2020-05-31 Thread Tor Bug Tracker & Wiki
#34263: Library selection for using WebRTC for the project.
-+-
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:  #34266   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by HashikD):

 * parent:   => #34266


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34264 [Circumvention/Snowflake]: Discussion on using a library for HTTP requests.

2020-05-31 Thread Tor Bug Tracker & Wiki
#34264: Discussion on using a library for HTTP requests.
-+-
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:  #34266   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by HashikD):

 * parent:   => #34266


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34269 [Circumvention/Snowflake]: Library for testing memory leaks (only in debug mode).

2020-05-31 Thread Tor Bug Tracker & Wiki
#34269: Library for testing memory leaks (only in debug mode).
-+
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:  #34266   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by HashikD):

 * parent:   => #34266


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #30318 [Applications/Tor Browser]: Integrate snowflake into mobile Tor Browser alpha

2020-05-31 Thread Tor Bug Tracker & Wiki
#30318: Integrate snowflake into mobile Tor Browser alpha
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, TorBrowserTeam202005R,   |  Actual Points:
  tbb-10.0a1 |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by boklm):

 I don't know if it is related to this patch, but the next nightly build
 after it was merged was stuck while building tor-onion-proxy-library for
 android-armv7.

 The process that was stuck is:
 {{{
 java -Dorg.gradle.appname=gradle -classpath /var/tmp/dist/android-
 toolchain/gradle/gradle-4.10.2/lib/gradle-launcher-4.10.2.jar
 org.gradle.launcher.GradleMain --offline --no-daemon -P
 androidplugin=3.1.0 -Dmaven.repo.local=/var/tmp/tmp.wrhYrP5WDj/gradle-
 dependencies-3 assembleRelease -x lint
 }}}

 And `tor-onion-proxy-library-android-armv7.log` contains this:
 {{{
 Exception in thread "queued-resource-processor_1"
 java.lang.RuntimeException: Timed out while waiting for slave aapt
 process, make sure the aapt execute at /var/tmp/dist/android-toolchain
 /android-sdk-linux/build-tools/27.0.3/aapt2 can run successfully (some
 anti-virus may block it) or try setting environment variable
 SLAVE_AAPT_TIMEOUT to a value bigger than 5 seconds
 at
 com.android.builder.png.AaptProcess.waitForReadyOrFail(AaptProcess.java:178)
 at
 
com.android.builder.internal.aapt.AaptQueueThreadContext.creation(AaptQueueThreadContext.java:56)
 at com.android.builder.tasks.WorkQueue.run(WorkQueue.java:250)
 at java.base/java.lang.Thread.run(Thread.java:834)
 Exception in thread "queued-resource-processor_2"
 java.lang.RuntimeException: Timed out while waiting for slave aapt
 process, make sure the aapt execute at /var/tmp/dist/android-toolchain
 /android-sdk-linux/build-tools/27.0.3/aapt2 can run successfully (some
 anti-virus may block it) or try setting environment variable
 SLAVE_AAPT_TIMEOUT to a value bigger than 5 seconds
 at
 com.android.builder.png.AaptProcess.waitForReadyOrFail(AaptProcess.java:178)
 at
 
com.android.builder.internal.aapt.AaptQueueThreadContext.creation(AaptQueueThreadContext.java:56)
 at com.android.builder.tasks.WorkQueue.run(WorkQueue.java:250)
 at java.base/java.lang.Thread.run(Thread.java:834)
 Exception in thread "queued-resource-processor_3"
 java.lang.RuntimeException: Timed out while waiting for slave aapt
 process, make sure the aapt execute at /var/tmp/dist/android-toolchain
 /android-sdk-linux/build-tools/27.0.3/aapt2 can run successfully (some
 anti-virus may block it) or try setting environment variable
 SLAVE_AAPT_TIMEOUT to a value bigger than 5 seconds
 at
 com.android.builder.png.AaptProcess.waitForReadyOrFail(AaptProcess.java:178)
 at
 
com.android.builder.internal.aapt.AaptQueueThreadContext.creation(AaptQueueThreadContext.java:56)
 at com.android.builder.tasks.WorkQueue.run(WorkQueue.java:250)
 at java.base/java.lang.Thread.run(Thread.java:834)
 Exception in thread "queued-resource-processor_4"
 java.lang.RuntimeException: Timed out while waiting for slave aapt
 process, make sure the aapt execute at /var/tmp/dist/android-toolchain
 /android-sdk-linux/build-tools/27.0.3/aapt2 can run successfully (some
 anti-virus may block it) or try setting environment variable
 SLAVE_AAPT_TIMEOUT to a value bigger than 5 seconds
 at
 com.android.builder.png.AaptProcess.waitForReadyOrFail(AaptProcess.java:178)
 at
 
com.android.builder.internal.aapt.AaptQueueThreadContext.creation(AaptQueueThreadContext.java:56)
 at com.android.builder.tasks.WorkQueue.run(WorkQueue.java:250)
 at java.base/java.lang.Thread.run(Thread.java:834)
 Exception in thread "queued-resource-processor_6"
 java.lang.RuntimeException: Timed out while waiting for slave aapt
 process, make sure the aapt execute at /var/tmp/dist/android-toolchain
 /android-sdk-linux/build-tools/27.0.3/aapt2 can run successfully (some
 anti-virus may block it) or try setting environment variable
 SLAVE_AAPT_TIMEOUT to a value bigger than 5 seconds
 at
 com.android.builder.png.AaptProcess.waitForReadyOrFail(AaptProcess.java:178)
 at
 
com.android.builder.internal.aapt.AaptQueueThreadContext.creation(AaptQueueThreadContext.java:56)
 at 

Re: [tor-bugs] #34320 [Applications/Tor Browser]: TMPDIR should be set in rbm so all scripts in tor-browser-build use it if needed

2020-05-31 Thread Tor Bug Tracker & Wiki
#34320: TMPDIR should be set in rbm so all scripts in tor-browser-build use it 
if
needed
-+-
 Reporter:  gk   |  Owner:  boklm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen202005,  |  Actual Points:
  TorBrowserTeam202005R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, GeorgKoppen202005, TorBrowserTeam202005 => tbb-rbm,
 GeorgKoppen202005, TorBrowserTeam202005R
 * status:  assigned => needs_review


Comment:

 Replying to [comment:2 boklm]:

 > Alternatively, we could patch rbm to always set `$TMPDIR` when running
 scripts. I think this patch would do that (but I have not tested it yet. I
 can make a real patch if you think that's a good idea.):
 > {{{
 > diff --git a/lib/RBM.pm b/lib/RBM.pm
 > index 7cc9e24..50920af 100644
 > --- a/lib/RBM.pm
 > +++ b/lib/RBM.pm
 > @@ -461,8 +461,9 @@ sub run_script {
 >  my ($project, $cmd, $f) = @_;
 >  $f //= \_exec;
 >  my @res;
 > +local $ENV{TMPDIR} = get_tmp_dir($project);
 >  if ($cmd =~ m/^#/) {
 > -my (undef, $tmp) = File::Temp::tempfile(DIR =>
 get_tmp_dir($project));
 > +my (undef, $tmp) = File::Temp::tempfile(DIR => $ENV{TMPDIR});
 >  path($tmp)->spew_utf8($cmd);
 >  chmod 0700, $tmp;
 >  @res = $f->($tmp);
 > }}}

 There is a patch for review in branch `bug_34320`:
 
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_34320=c50d8e22c4fcddc4ed567815b1b0135419c2a53c

 Compared to the previous version of the patch we are now using
 `rbm_tmp_dir` instead of `tmp_dir` (which is a directory inside `tmp_dir`
 which is automatically removed when rbm exits). We are also fixing a place
 where the `run_script` function was not used when running a script.

 I checked that TMPDIR is correctly set with the following change:
 {{{
 diff --git a/projects/release/config b/projects/release/config
 index 17db3d0e..50901fc8 100644
 --- a/projects/release/config
 +++ b/projects/release/config
 @@ -202,6 +202,12 @@ input_files:
   - torbrowser-src

  steps:
 +  test_bug34320:
 +build_log: '-'
 +input_files: []
 +test_bug34320: |
 +  #!/bin/bash
 +  echo $TMPDIR
signtag:
  build_log: '-'
  debug: 0
 }}}
 And this command:
 {{{
 ./rbm/rbm build --step test_bug34320 release
 }}}

 There is also a `tor-browser-build` patch in branch `bug_34320` updating
 rbm and cleaning `dmg2mar`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_34320=d61aff9cf0f51de9d6fa4a8c9cb5a71e203bce4f

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34191 [Metrics/Onionperf]: Combine multiple analysis files into single data set

2020-05-31 Thread Tor Bug Tracker & Wiki
#34191: Combine multiple analysis files into single data set
---+
 Reporter:  karsten|  Owner:  acute
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:  0.5
Parent ID:  #33321 | Points:  0.5
 Reviewer:  karsten|Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * reviewer:   => karsten


Comment:

 I'll take a look, but probably later today or tomorrow. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34191 [Metrics/Onionperf]: Combine multiple analysis files into single data set

2020-05-31 Thread Tor Bug Tracker & Wiki
#34191: Combine multiple analysis files into single data set
---+
 Reporter:  karsten|  Owner:  acute
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:  0.5
Parent ID:  #33321 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * status:  accepted => needs_review
 * actualpoints:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #34191 [Metrics/Onionperf]: Combine multiple analysis files into single data set

2020-05-31 Thread Tor Bug Tracker & Wiki
#34191: Combine multiple analysis files into single data set
---+
 Reporter:  karsten|  Owner:  acute
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33321 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by acute):

 This is now ready to review at: https://github.com/ana-
 cc/onionperf/tree/34191

 The visualize command now accepts a mix of one or more multiple files or
 directories in each dataset!
 {{{
 onionperf visualize -d file1 file2 label1 -d file3 file4 label2

 onionperf visualize -d dir1 label1

 onionperf visualize -d dir1 dir2 label1 -d dir3 dir4 label2

 onionperf visualize -d dir1 file1 file2 label1 -d file3 file4 dir2 label2
 ...etc
 }}}

 There have been quite a few changes:

   * We reuse the existing command `reprocessing.collect_logs` in the
 reprocessing module, with the search pattern `*json*` to find analysis
 files in supplied directories; I thought about using `*json.xz` as a
 pattern as well, but it probably does not matter too much. This seems to
 work nicely!

   * All the analysis files given by the user or found in directories are
 collected in a list of 'analyses'

   * The visualization module now iterates through the list of supplied
 'analyses' to load data

  * The label can no longer be a path - that is, if we detect the last
 argument supplied to this command is a path, we complain. This is to avoid
 the case where the user forgets to supply a label, and instead the last
 path supplied is used as a label instead:

 {{{
 $ onionperf visualize -d file1 file2 file3
 usage: onionperf visualize [-h] -d PATH [LABEL ...] [-p STRING]
 onionperf visualize: error: argument -d/--data: The supplied label cannot
 be a path
 }}}

 Let me know if you have any questions, this is quite a sizeable change!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33420 [Metrics/Onionperf]: Add CBT events to Onionperf result files

2020-05-31 Thread Tor Bug Tracker & Wiki
#33420: Add CBT events to Onionperf result files
---+---
 Reporter:  acute  |  Owner:  karsten
 Type:  enhancement| Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+---
Changes (by karsten):

 * cc: mikeperry, gaba (added)
 * status:  accepted => needs_information


Comment:

 I'm afraid I don't understand what needs to be done here.

 Here's what we have right now: OnionPerf logs `BUILDTIMEOUT_SET` and
 `CIRC` events and includes `TIMEOUT_MS` and `CUTOFF_QUANTILE` values from
 the last known `BUILDTIMEOUT_SET` event when parsing a `CIRC` event with
 status `LAUNCHED`. The result is the following structure in the analysis
 .json file:

 {{{
   "15965": {
 "build_quantile": 0.8, < from
 CUTOFF_QUANTILE
 "build_timeout": 1500, < from
 TIMEOUT_MS
 "buildtime_seconds": 0.2599046325684,
 "circuit_id": 15965,
 "elapsed_seconds": [
   [
 "GENERAL:LAUNCHED",
 0.0
   ],
   [
 "GENERAL:EXTENDED",
 0.0792370605469
   ],
   [
 "GENERAL:EXTENDED",
 0.1485694885254
   ],
   [
 "GENERAL:EXTENDED",
 0.2599046325684
   ],
   [
 "GENERAL:BUILT",
 0.2599046325684
   ],
   [
 "GENERAL:CLOSED",
 670.990095367
   ]
 ],
 "path": [
   [
 "$1CD48F4ED0F1821FFBF1940802A13EEFD4C27502~Piratenpartei00",
 0.0792370605469
   ],
   [
 "$8C00FA7369A7A308F6A137600F0FA07990D9D451~GrmmlLitavis",
 0.1485694885254
   ],
   [
 "$A99AC59B0C94FBBBC44FA2660CEE1A1362F4C649~deepSpace1001",
 0.2599046325684
   ]
 ],
 "unix_ts_end": 1590624905.93,
 "unix_ts_start": 1590624234.94
   },
 }}}

 Note that not all `circuit` objects in OnionPerf's analysis .json files
 contain these two fields. OnionPerf analyzes (processes) log files on a
 daily basis. Now, if a `CIRC` even with status `LAUNCHED` gets fired
 before the first `BUILDTIMEOUT_SET` event arrives for the day, it won't be
 able to tell the quantile and timeout used for building this circuit. The
 result is that these two fields are missing, which we should treat as "we
 don't know what the values were" rather than "there was no timeout set at
 the time".

 Also note that I have not yet seen a `BUILDTIMEOUT_SET` event of
 ''another'' type than `COMPUTED` in the wild. I scanned all past logs from
 op-hk and op-hk2, but did not find a single one. I know they are specified
 and implemented, but I just haven't seen them. I would have expected them
 to occur on op-hk and op-hk2, because those typically have the most
 interesting network conditions of all OnionPerf instances.

 So, what is this ticket about? Do we want to include more information from
 the `BUILDTIMEOUT_SET` event in the `circuit` object? If so, what are we
 interested in?

 And once we have these additional fields (assuming this is what the ticket
 is about), what are we going to do with them? Should we visualize this
 information, or is it sufficient to keep it in the analysis .json files
 for later use?

 Is the goal here to prepare for measuring changes in a future Tor network
 that fires wildly different `BUILDTIMEOUT_SET` events than what we see
 today? If so, what can we expect?

 Setting to needs_information and cc'ing mikeperry and gaba to shed light
 on this before we implement something at random.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33422 [Metrics/Onionperf]: Include more events about CBT in results

2020-05-31 Thread Tor Bug Tracker & Wiki
#33422: Include more events about CBT in results
---+---
 Reporter:  acute  |  Owner:  metrics-team
 Type:  enhancement| Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+---
Changes (by karsten):

 * cc: mikeperry, gaba (added)
 * status:  new => needs_information


Comment:

 I don't really understand how this ticket is different from #33420.
 Setting to needs_information and cc'ing mikeperry and gaba.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs