Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently

[Tor Bug Tracker & Wiki]

#21641: Prop274: Rotate onion keys less frequently
---+
 Reporter:  nickm  |  Owner:  ahf
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:  2.1
Parent ID: | Points:  2
 Reviewer:  nickm  |Sponsor:  Sponsor4
---+
Changes (by ahf):

 * status:  needs_revision => needs_review


Comment:

 I've updated my branch with a set of fixup commits and one additional
 "real" commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21765 [Core Tor/Tor]: PortForwardingHelper stdout/stderr log forwarding seems fragile

[Tor Bug Tracker & Wiki]

#21765: PortForwardingHelper stdout/stderr log forwarding seems fragile
--+
 Reporter:  ahf   |  Owner:
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by ahf):

 A work in progress patch can be found at
 https://gitlab.com/ahf/tor/commit/2ca32216054803f2e966b7b5e21b9479de8b7758
 - note that this depends upon the changes in #21757.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21765 [Core Tor/Tor]: PortForwardingHelper stdout/stderr log forwarding seems fragile

[Tor Bug Tracker & Wiki]

#21765: PortForwardingHelper stdout/stderr log forwarding seems fragile
--+
 Reporter:  ahf   |  Owner:
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 While working on a fix for a regression I caused in #21757 I noticed that
 we had code in our utility module that could be affected by the same
 regression as I was trying to fix.

 I've tried to list some of my observations while studying this code:

 - We use non-blocking I/O for stdout and stderr in the spawned `tor-fw-
 helper` child process, but we only call `log_from_pipe()` once immediately
 after spawning the process. From my quick observation the call to
 `log_form_pipe()` almost always result in a `EAGAIN` and we then return
 without processing any lines at all since we never actually try to read
 again.
 - We have duplicated code in `handle_fw_helper_line()` and
 `log_from_pipe()` to handle `SPAWN_ERROR_MESSAGE` error messages during
 child creation with a comment related to the first observation.

 I tried to test this with a simple dummy `PortForwardingHelper` script
 which outputs a set of lines on stdout and stderr, sleeps for a while,
 then continues to write some more content before it exits and only a
 subset of these lines are actually forwarded to tor's logging subsystem.

 The application seems to work correctly and contact my router, so this
 issue is purely related to the forwarding of stdout and stderr from the
 helper process.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21757 [Core Tor/Tor]: Using Pluggable Transports on tor master is broken

[Tor Bug Tracker & Wiki]

#21757: Using Pluggable Transports on tor master is broken
--+
 Reporter:  gk|  Owner:  ahf
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * status:  accepted => needs_review


Comment:

 Landed a possible fix on `bugs/21757` on Gitlab:
 https://gitlab.com/ahf/tor/commits/bugs/21757

 Passes tests on FreeBSD. Bootstrap and "normal" usage tested via an obfs4
 bridge seems to work fine now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21764 [Applications/Tor Browser Sandbox]: Use bubblewrap's `--die-with-parent` once a release is made.

[Tor Bug Tracker & Wiki]

#21764: Use bubblewrap's `--die-with-parent` once a release is made.
--+-
 Reporter:  yawning   |  Owner:  yawning
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser Sandbox  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 There's a good amount of work that goes into "Kill sandboxed processes"
 that can be dramatically simplified and made more robust with bubblewrap's
 `--die-with-parent` option.  As of this moment this is unreleased, so
 support will need to wait until after they tag the next version.

 
https://github.com/projectatomic/bubblewrap/commit/b6370de0fc4be6bb801206e39437ad1f2f5c0be7

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21763 [Applications/Tor Browser]: Improve Cookie settings

[Tor Bug Tracker & Wiki]

#21763: Improve Cookie settings
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 about:preferences#privacy

 Before:
 [_] Accept Cookies from sites

 After:
 [_] Accept Cookies from clearnet sites
 [X] Accept Cookies from .onion sites

 I had to add my .onion site to "Exceptions"(Allow for session).
 It automatically cleared when I restart the browser.

 Please make this permanent by:
 a) Add new option: [X] Don't clear my cookie exceptions list.
 b) Or, add new cookie option, like above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21745 [Applications/Tor Browser]: Catch-all circuits are not working properly in ESR 52 based Tor Browser

[Tor Bug Tracker & Wiki]

#21745: Catch-all circuits are not working properly in ESR 52 based Tor Browser
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-7.0-must, |  Actual Points:
  ff52-esr, TorBrowserTeam201703 |
Parent ID:  #21201   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by arthuredelstein):

 * owner:  tbb-team => arthuredelstein
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21747 [Applications/Tor Browser]: Requesting a new circuit for a site is not working in ESR 52 based Tor Browser

[Tor Bug Tracker & Wiki]

#21747: Requesting a new circuit for a site is not working in ESR 52 based Tor
Browser
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, ff52-esr, |  Actual Points:
  tbb-7.0-must, TorBrowserTeam201703 |
Parent ID:  #21201   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by arthuredelstein):

 * status:  new => assigned
 * owner:  tbb-team => arthuredelstein


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21762 [Applications/Tor Browser]: Check new Firefox favicon code for first-party isolation

[Tor Bug Tracker & Wiki]

#21762: Check new Firefox favicon code for first-party isolation
--+---
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-52esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 mcs and brade noticed some new favicon patches in Firefox that we should
 check for first-party isolation, and patch if FPI is violated:
  https://bugzilla.mozilla.org/show_bug.cgi?id=530999
  https://bugzilla.mozilla.org/show_bug.cgi?id=1184739
  https://bugzilla.mozilla.org/show_bug.cgi?id=1206560

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #21647, #21648, #21649, #21650

[Tor Bug Tracker & Wiki]

Batch modification to #21647, #21648, #21649, #21650 by nickm:


Action: reassign

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  implemented
  group-17   |  Actual Points:  .5
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Answered there; merging this; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  .5
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 A minor question there, but that's it - other than that it looks good!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21272 [Metrics]: Onionperf deployment

[Tor Bug Tracker & Wiki]

#21272: Onionperf deployment
-+--
 Reporter:  hiro |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Thanks for looking again, and thanks for opening those new tickets.  I
 just squashed and merged to master, together with a change log entry.

 I noticed the empty file, too.  It's yet unclear whether it will go away
 tonight.  If not, we should handle that case less loudly.

 I'll keep this ticket open until deployment is complete, with data being
 collected by CollecTor.  But let's wait at least until tomorrow to see
 what the three op-xx instances produce.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Okay -- I've squashed this and merged it into tor, and I've added the
 fuzzing corpora to the tor-fuzzing-corpora repository.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21754 [Applications/Tor Browser]: Switch to OS X 10.7 SDK everywhere in our OS X descriptors (was: Swtich to OS X 10.7 SDK everywhere in our OS X descriptors)

[Tor Bug Tracker & Wiki]

#21754: Switch to OS X 10.7 SDK everywhere in our OS X descriptors
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201703,|  Actual Points:
  GeorgKoppen201703, tbb-gitian  |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21753 [Applications/Tor Browser]: Get rid of old GCC toolchain in pluggable transports macOS descriptor

[Tor Bug Tracker & Wiki]

#21753: Get rid of old GCC toolchain in pluggable transports macOS descriptor
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam21703R,|  Actual Points:
  GeorgKoppen201703, tbb-gitian  |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam21703, GeorgKoppen201703, tbb-gitian =>
 TorBrowserTeam21703R, GeorgKoppen201703, tbb-gitian
 * status:  new => needs_review
 * cc: dcf (added)


Comment:

 `bug_21753_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_21753_v3=d0465e4ce9e9fa13a46faae8c7401b5fb78582f8)
 in my public tor-browser-bundle repo has a fix for this bug.

 dcf: you might find this interesing while testing the switch to Go 1.7.5
 and 1.8. (If you have feedback regarding that patch I am all ears; I have
 not been doing much work in the Go cross-compiling area so far).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21761 [Applications/Tor Browser]: Low contrast mode

[Tor Bug Tracker & Wiki]

#21761: Low contrast mode
--+--
 Reporter:  neocode   |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I propose to implement the low contrast mode in Tor Browser.
 This will make it more difficult for outsiders to spy on the visited pages
 from the side or behind you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21272 [Metrics]: Onionperf deployment

[Tor Bug Tracker & Wiki]

#21272: Onionperf deployment
-+--
 Reporter:  hiro |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Replying to [comment:36 karsten]:
 > iwakeh, patch looks good, pushed to
 [https://gitweb.torproject.org/karsten/metrics-db.git/log/?h=task-21272 my
 task-21272 branch].  Thanks!  Do you want to change anything else, or can
 I squash and merge?
 >

 So far, this seems ready for merge.  Tests pass and the download works.

 The persistence topic from comment:18 and before, and also the later sync-
 addition has a separate ticket #21759.

 Let's move any further things related to CollecTor java code to #21760,
 which already lists the open final move to onionperf and the tests etc.

 The test run showed empty files
 https://op-us.onionperf.torproject.net/op-us-5242880-2017-03-15.tpf (size
 0)
 on the us source.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21760 [Metrics/CollecTor]: Onionperf deployment - CollecTor side

[Tor Bug Tracker & Wiki]

#21760: Onionperf deployment - CollecTor side
---+--
 Reporter:  iwakeh |  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 This covers all CollecTor code base related topics for the introduction of
 onionperf measurements (see #21272).

 Open is the addition of tests and the final move to OnionPerf only.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21759 [Metrics/CollecTor]: Add persistence for torperf/onionperf

[Tor Bug Tracker & Wiki]

#21759: Add persistence for torperf/onionperf
---+--
 Reporter:  iwakeh |  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 As discussed in
 [https://trac.torproject.org/projects/tor/ticket/21272#comment:18 #21272
 comment:18] and before.

 All storing of files should be done by the persist-mechanism, i.e.,
 a o.t.c.persist.TpfPersistence class needs to be introduced (this would
 shorten TorperfDownloader quite a bit and prevent another
 re-implementation of this functionality).

 Decide if sync-functionality for the Xperf files can be done with this
 ticket, too, or needs another ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks like all GL issues have been resolved. Looks good to me.

 I don't know if we have other code that could benefit from doing base64
 comparison without first decoding the base64 encoded buffer and then do a
 `memcmp()`, but if we have then it could be useful to lift that code out
 of the consdiff specific code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've responded to the questions, added a typo fix, and moved this back
 into needs_review for the additional set of eyes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21758 [Core Tor/Tor]: Improve compression estimators for directory spooling

[Tor Bug Tracker & Wiki]

#21758: Improve compression estimators for directory spooling
--+
 Reporter:  nickm |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  prop278
Actual Points:|  Parent ID:  #21662
   Points:  .5|   Reviewer:
  Sponsor:  Sponsor4  |
--+
 Once we have zstd compression in place, we should improve the estimated
 ratio in estimate_compression_ratio().  We could also do well to have that
 function consider the _size_ of the input data, since bigger data sets
 compress better.

 (I'm deliberately only saying zstd here, not lzma2:  We should never do
 lzma2 compression on the fly, so we shouldn't need to estimate the size of
 the output for spooling purposes.)

 Calling this "low" priority because "0.5" isn't that bad of an estimate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  .5
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've updated the branch to address your comments.  How is it now?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21677 [Core Tor/Tor]: Prop140: analyze diff performance

[Tor Bug Tracker & Wiki]

#21677: Prop140: analyze diff performance
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  TorCoreTeam201703 prop140  |  Actual Points:  1
Parent ID:  #21643 | Points:  1
 Reviewer: |Sponsor:  Sponsor4
---+---
Changes (by nickm):

 * status:  accepted => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21677 [Core Tor/Tor]: Prop140: analyze diff performance

[Tor Bug Tracker & Wiki]

#21677: Prop140: analyze diff performance
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703 prop140  |  Actual Points:  1
Parent ID:  #21643 | Points:  1
 Reviewer: |Sponsor:  Sponsor4
---+---
Changes (by nickm):

 * status:  new => accepted
 * parent:  #13339 => #21643
 * owner:   => nickm
 * points:   => 1
 * actualpoints:   => 1
 * keywords:  prop140 => TorCoreTeam201703 prop140


Comment:

 I've done this a bit , which led to the speed-ups already in #21643.

 The big performance wins were:
* Improve sha3 speed
* Stop copying lines from input lists to output lists.
* Stop copying lines from input strings to intermediate lists.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21643 [Core Tor/Tor]: Prop140: Extract, test, revise, and clean the diff code

[Tor Bug Tracker & Wiki]

#21643: Prop140: Extract, test, revise, and clean the diff code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  2
  group-17   |
Parent ID:  #13339   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I believe I've addressed all the gitlab comments.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10369 [Applications/Tor Browser]: Building the Utils component in OS X TBBs is broken with the new cross-compiler

[Tor Bug Tracker & Wiki]

#10369: Building the Utils component in OS X TBBs is broken with the new cross-
compiler
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  gitian, tbb-3.0, tbb-gitian, |  Actual Points:
  GeorgKoppen201703, TorBrowserTeam201703R   |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, the final one from my side: `bug_10369_v5`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_10369_v5=b73ae0f7fcd60e979d8651da81c5c947616d5514)
 It includes some comment updates and does not extract our build tools into
 `$INSTDIR`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #10369 [Applications/Tor Browser]: Building the Utils component in OS X TBBs is broken with the new cross-compiler

[Tor Bug Tracker & Wiki]

#10369: Building the Utils component in OS X TBBs is broken with the new cross-
compiler
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  gitian, tbb-3.0, tbb-gitian, |  Actual Points:
  GeorgKoppen201703, TorBrowserTeam201703R   |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  assigned => needs_review


Comment:

 Actually, `LLVMCONFIG` is not needed here, so let's remove it:
 `bug_10369_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_10369_v3=75ec50a3bb12ac7d7ee0294a46ae20dfcba77207).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21757 [Core Tor/Tor]: Using Pluggable Transports on tor master is broken

[Tor Bug Tracker & Wiki]

#21757: Using Pluggable Transports on tor master is broken
--+
 Reporter:  gk|  Owner:  ahf
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * owner:   => ahf
 * status:  new => accepted


Comment:

 Looking into it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21757 [Core Tor/Tor]: Using Pluggable Transports on tor master is broken

[Tor Bug Tracker & Wiki]

#21757: Using Pluggable Transports on tor master is broken
--+
 Reporter:  gk|  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 While testing a patch for #21753 I realized that PTs in general are
 currently broken with tor master resulting into output like
 {{{
 CMETHOD obfs2 socks5 127.0.0.1:41925
 CMETHOD obfs3 socks5 127.0.0.1:41299
 CMETHOD obfs4 socks5 127.0.0.1:34025
 CMETHOD scramblesuit socks5 127.0.0.1:35225
 CMETHODS DONE'. We only support version '1'
 Mar 16 13:03:05.000 [warn] Managed proxy at
 './TorBrowser/Tor/PluggableTransports/obfs4proxy' failed the configuration
 protocol and will be destroyed.
 }}}
 if started from Tor Browser.

 Bisecting reveals that this got introduced with
 6e78ede73f190f3aaf91623a131a20cf031aad7e which fixed #21654.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20699 [Core Tor/Tor]: prop224: Add control port events and commands

[Tor Bug Tracker & Wiki]

#20699: prop224: Add control port events and commands
-+-
 Reporter:  dgoulet  |  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Very High|  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, needs-proposal, |  Actual Points:
  prop224-extra  |
Parent ID:  #12424   | Points:  6
 Reviewer:   |Sponsor:
 |  SponsorR-must
-+-

Comment (by asn):

 Just gonna mention here the request from Riastradh that ideally we would
 have the same private key format used in `ADD_ONION` and in the secret_key
 files in the filesystem. We might want to think about this when we make
 the control port changes here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21752 [Metrics/Atlas]: put "Current Status" under an Android Browser on top

[Tor Bug Tracker & Wiki]

#21752: put "Current Status" under an Android Browser on top
---+-
 Reporter:  toralf |  Owner:  irl
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Atlas  |Version:
 Severity:  Minor  | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by dgoulet):

 * milestone:  Tor: 0.3.0.x-final =>


Comment:

 Atlas doesn't use those "Tor" milestone.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21755 [Applications/Tor Browser]: Restrict third party cookies and other tracking data is unchecked in ESR52 based Tor Browser

[Tor Bug Tracker & Wiki]

#21755: Restrict third party cookies and other tracking data is unchecked in 
ESR52
based Tor Browser
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52esr, tbb-7.0-must,   |  Actual Points:
  TorBrowserTeam201703   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Oh, and when I check it, close the dialog and reopen it again, it is
 unchecked again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21756 [Applications/Tor Browser]: HTTP Authentication data is still sent to third parties with ESR 52 based Tor Browser

[Tor Bug Tracker & Wiki]

#21756: HTTP Authentication data is still sent to third parties with ESR 52 
based
Tor Browser
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff52esr, tbb-7.0-must,
 Severity:  Normal   |  TorBrowserTeam201703
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:  Sponsor4 |
-+-
 Testing a build based on ESR 52 and our patches in #20680 it turns our
 that HTTP Authentication data seems to leak to third parties as can be
 seen on the http://ip-check.info test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21755 [Applications/Tor Browser]: Restrict third party cookies and other tracking data is unchecked in ESR52 based Tor Browser

[Tor Bug Tracker & Wiki]

#21755: Restrict third party cookies and other tracking data is unchecked in 
ESR52
based Tor Browser
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff52esr, tbb-7.0-must,
 Severity:  Normal   |  TorBrowserTeam201703
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:  Sponsor4 |
-+-
 Our first party isolation patches are activated right now (ESR 45 based
 Tor Browser) if the checkbox "Restrict third party cookies and other
 tracking data" is checked. But that's not the case anymore with an ESR 52
 base. We should fix that or remove that checkbox altogether.

 It might be a sign, though, that some of our first-party isolation code is
 not working. We should doublecheck that that's not the case

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs