Re: [tor-bugs] #21989 [Core Tor/Tor]: Should we tell Exits to reject all traffic if DNS fails?

[Tor Bug Tracker & Wiki]

#21989: Should we tell Exits to reject all traffic if DNS fails?
---+--
 Reporter:  teor   |  Owner:
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  dns, tor-exit  |  Actual Points:
Parent ID:  #21900 | Points:  1
 Reviewer: |Sponsor:
---+--

Comment (by arma):

 I think we think we already have exits refuse to be exits if their dns
 isn't working.

 See check_dns_honesty_callback() and the dns_launch_correctness_checks()
 that it calls.

 It looks like it could be improved.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21117 [Core Tor/Tor]: can't migrate onion services to single-hop onion services

[Tor Bug Tracker & Wiki]

#21117: can't migrate onion services to single-hop onion services
--+
 Reporter:  weasel|  Owner:  dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.8
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, single-onion  |  Actual Points:  0.1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * owner:  teor => dgoulet


Comment:

 dgoulet said he will do this, I might not get time in 0.3.2.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21425 [Core Tor/Tor]: entry_list_is_constrained() should look at the guard_selection_t object

[Tor Bug Tracker & Wiki]

#21425: entry_list_is_constrained() should look at the guard_selection_t object
---+---
 Reporter:  nickm  |  Owner:
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  guards, 031-deferred-20170425  |  Actual Points:
Parent ID:  #20822 | Points:  .5
 Reviewer: |Sponsor:
---+---
Changes (by neel):

 * cc: neel@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13929 [Core Tor/Tor]: Increase Authority reachability testing rate with low TestingAuthDirTimeToLearnReachability

[Tor Bug Tracker & Wiki]

#13929: Increase Authority reachability testing rate with low
TestingAuthDirTimeToLearnReachability
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.7
 Severity:  Normal   | Resolution:
 Keywords:  testing, chutney, SponsorS-  |  Actual Points:
  deferred, tor-dirauth  |
Parent ID:  #22463   | Points:  small
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:  #14034 => #22463


Comment:

 We should do this when we do #22463.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22463 [Core Tor/Tor]: Reduce REACHABLE_TIMEOUT in test networks

[Tor Bug Tracker & Wiki]

#22463: Reduce REACHABLE_TIMEOUT in test networks
--+--
 Reporter:  teor  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy intro chutney-needs  |  Actual Points:
Parent ID:  #14034| Points:  0.5
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * parent:   => #14034


Comment:

 We should do #13929 along with this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22518 [Internal Services/Tor Sysadmin Team]: Please create email alias for Stephanie

[Tor Bug Tracker & Wiki]

#22518: Please create email alias for Stephanie
-+-
 Reporter:  ewyatt   |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 {{{
 Please create an email alias for Stephanie, our new Communications
 Director. Thank you!



 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA512

 First name: Stephanie
 Last name: Whited
 Desired uid/email alias: st...@torproject.org
 Forwarding address: stephanie.whi...@gmail.com
 GPG public key fingerprint: E976 9771 7D46 2E63 9697  9F6D 6D6B 72C3 39A8
 76AD
 -BEGIN PGP SIGNATURE-

 iQIcBAEBCgAGBQJZNzgeAAoJELoMlAD4D5HOvUUP/AvbKt515SmZG8s5gLItRwGK
 kQTvbKZcAxNG3Li+WBis4Hzrnj1WTlig5xCNTDxBY7mpPSa05n+X7slsXkDth5Qf
 YJfwiUnY86eniOuH40LZRE0BgpWUMt70KaQFMAHQhron/x8U56An8atvWerjgaCP
 SOn2xT4YKby1x2o3Cr+PcT4BhhzB+RDyLuy0/Ljawm0dtmaf6vN8BaO4TBVuzGy9
 IfTCi1xntT9x5NpLNf8nFd/cDpCd6RBPJ9uo8pLrxWNxQCl8c7EdbJ7R8Egcik/G
 CFqIYhYDXmk/jDTdbs7hzaXUGoNcVMfKA4gd95EnlAufQsuDXUk6z8VyMHEE68Bl
 u5USH8nrvDTQzDIEjBur7Tu2+/syqXyW5LCNTVnWQztZxAejPP/Sy60bPqtfsYyq
 zorSXD6IMT4FzqcMvwRbVUpmtoGBKuNoYw30WNc1wZrAqWui2ulzwDieBZsZyDvn
 VUqCn19t13zLvzvgi9bKEfeHBC57DK5iWuQsCZ83JefCRfo2gaE68h80Kddgllmu
 mEez7D9xow80vvzJbSjfnXoIbVP47VGQLF7Df4xqN520xjGiFy5cV20ndihCoHls
 rOe5P1VFmsJqHkZEam1xZTst1zD415RjfxWfxgis7Igj76s1hCU2OYW/jezOHQVP
 2udex0pzwsJkb9XtbZsm
 =ZMSb
 -END PGP SIGNATURE-
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21989 [Core Tor/Tor]: Should we tell Exits to reject all traffic if DNS fails?

[Tor Bug Tracker & Wiki]

#21989: Should we tell Exits to reject all traffic if DNS fails?
---+--
 Reporter:  teor   |  Owner:
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  dns, tor-exit  |  Actual Points:
Parent ID:  #21900 | Points:  1
 Reviewer: |Sponsor:
---+--
Changes (by micah):

 * cc: micah (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22516 [Core Tor/Tor]: tor fails to start with 'Sandbox 1'

[Tor Bug Tracker & Wiki]

#22516: tor fails to start with 'Sandbox 1'
-+---
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Core Tor/Tor |Version:  Tor: 0.2.9.10
 Severity:  Normal   | Resolution:
 Keywords:  seccomp Sandbox  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by cypherpunks):

 relevant log line before the sandbox related logs:
 {{{
 Fixing permissions on directory /var/lib/tor-instances/...
 }}}

 Permissions on the data dir are:
 {{{
 drwx--
 }}}

 Owner and group is the user specified in the {{{User}}} directive

 Tor does not "fix" (change) any permissions (also when testing with
 'Sandbox 0').

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22516 [Core Tor/Tor]: tor fails to start with 'Sandbox 1'

[Tor Bug Tracker & Wiki]

#22516: tor fails to start with 'Sandbox 1'
-+---
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Core Tor/Tor |Version:  Tor: 0.2.9.10
 Severity:  Normal   | Resolution:
 Keywords:  seccomp Sandbox  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by cypherpunks):

 same configuration on Debian 8 with tor 0.3.0.7 works fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22517 [Internal Services/Service - lists]: task: new bandwidth measurement list

[Tor Bug Tracker & Wiki]

#22517: task: new bandwidth measurement list
---+-
 Reporter:  micah  |  Owner:  qbi
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Internal Services/Service - lists  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+-
 I think it makes sense to create a mailing list for bandwidth measurement
 related discussions. That would include people who are running bandwidth
 authorities, bw web servers, working on the bandwidth authority code, and
 discussion of how to better enhance that system.

 I don't really want to limit it to bandwidth authorities and make a secret
 list, so maybe we can call it 'bw-measurement' or 'bandwidth-measurement'
 (I prefer shorter)... its too bad both words are so long, would anyone be
 opposed to just 'bandwidth'?


 I'm happy to be the list owner and configure it. Thanks in advance!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22516 [Core Tor/Tor]: tor fails to start with 'Sandbox 1'

[Tor Bug Tracker & Wiki]

#22516: tor fails to start with 'Sandbox 1'
--+-
 Reporter:  cypherpunks   |  Owner:
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.10
 Severity:  Normal|   Keywords:  seccomp Sandbox
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 OS: CentOS 7
 SELinux: disabled
 tor-0.2.9.10-1.el7.x86_64

 {{{
  
  (Sandbox) Caught a bad syscall attempt (syscall fchmod)
  /usr/bin/tor(+0x15d83a)[0x7ff9aa58b83a]
  /lib64/libc.so.6(fchmod+0x7)[0x7ff9a8b1a917]
  /lib64/libc.so.6(fchmod+0x7)[0x7ff9a8b1a917]
  /usr/bin/tor(check_private_dir+0x151)[0x7ff9aa584741]
  /usr/bin/tor(init_keys+0x9b)[0x7ff9aa4b6cab]
  /usr/bin/tor(do_main_loop+0x4b)[0x7ff9aa472b1b]
  /usr/bin/tor(tor_main+0x1c25)[0x7ff9aa4763a5]
  /usr/bin/tor(main+0x19)[0x7ff9aa46e8c9]
  /lib64/libc.so.6(__libc_start_main+0xf5)[0x7ff9a8a53b35]
  /usr/bin/tor(+0x4091b)[0x7ff9aa46e91b]
 }}}
 torrc:
 {{{
 OfflineMasterKey 1
 RunAsDaemon 0
 Log notice syslog
 OutboundBindAddress ...
 SocksPort 0
 User ...
 DataDirectory /var/lib/tor-instances/...
 ORPort ...
 DirPort ...
 SyslogIdentityTag ...
 Nickname ...
 ControlSocket 0
 CookieAuthentication 0
 ExitRelay 0
 ExitPolicy reject *:*
 Sandbox 1
 ShutdownWaitLength 1
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4185 [Core Tor/Tor]: Bridge easily detected by GFW

[Tor Bug Tracker & Wiki]

#4185: Bridge easily detected by GFW
-+-
 Reporter:  hrimfaxi |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.5-alpha
 Severity:  Normal   | Resolution:
 Keywords:  blocking needs-proposal tor-bridge   |  worksforme
  censorship block cn|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dcf):

 * status:  reopened => closed
 * resolution:   => worksforme


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4185 [Core Tor/Tor]: Bridge easily detected by GFW

[Tor Bug Tracker & Wiki]

#4185: Bridge easily detected by GFW
-+-
 Reporter:  hrimfaxi |  Owner:
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.5-alpha
 Severity:  Normal   | Resolution:
 Keywords:  blocking needs-proposal tor-bridge   |  Actual Points:
  censorship block cn|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dcf):

 * status:  closed => reopened
 * keywords:  blocking needs-proposal tor-bridge => blocking needs-proposal
 tor-bridge censorship block cn
 * resolution:  worksforme =>
 * severity:   => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4744 [Core Tor/Tor]: GFW probes based on Tor's SSL cipher list

[Tor Bug Tracker & Wiki]

#4744: GFW probes based on Tor's SSL cipher list
-+-
 Reporter:  asn  |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.2.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tls fingerprinting tor-bridge|  implemented
  censorship block cn|  Actual Points:
Parent ID:  #4185| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dcf):

 * keywords:  tls fingerprinting tor-bridge => tls fingerprinting tor-bridge
 censorship block cn
 * severity:   => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4014 [Core Tor/Tor]: Iran filters Tor by ssl handshake, Sept 2011

[Tor Bug Tracker & Wiki]

#4014: Iran filters Tor by ssl handshake, Sept 2011
+--
 Reporter:  arma|  Owner:
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tor-client censorship block ir  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by dcf):

 * keywords:  tor-client => tor-client censorship block ir
 * severity:   => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14006 [Core Tor/Tor]: Hidden service error: "We'd like to launch a circuit to handle a connection, but we already have 32 general-purpose client circuits..."

[Tor Bug Tracker & Wiki]

#14006: Hidden service error: "We'd like to launch a circuit to handle a
connection, but we already have 32 general-purpose client circuits..."
--+--
 Reporter:  asn   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by tokotoko):

 * cc: fdsfgs@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22513 [Applications/Tor Browser]: Tor Browser connects to the same circuit even after CONNRESET received

[Tor Bug Tracker & Wiki]

#22513: Tor Browser connects to the same circuit even after CONNRESET received
--+---
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by cypherpunks):

 Here is the way to test this reliably https://pinning-test.badssl.com/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22369 [Metrics/Censorship analysis]: Increase of users in Ukraine due to block of Russia-based services

[Tor Bug Tracker & Wiki]

#22369: Increase of users in Ukraine due to block of Russia-based services
-+--
 Reporter:  dcf  |  Owner:  metrics-team
 Type:  project  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Censorship analysis  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  censorship block ua  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by dcf):

 Replying to [comment:9 dcf]:
 > The blckd.json file changed on 25 May, changing http URLs to https ones.

 Just a small update on this. Previously I claimed that blckd.json files
 were identifiable by their `Last-Modified` and `ETag` headers. That's not
 quite true. 5 of the 6 servers (all but update.svbrwsr.com) share four
 similar `Last-Modified`/`ETag` combinations, as if they are being load
 balanced:
 ||`Last-Modified` ||`ETag` ||
 ||`Thu, 25 May 2017 16:58:03 GMT` ||`"59270d1b-9f8"` ||
 ||`Thu, 25 May 2017 16:58:04 GMT` ||`"59270d1c-9f8"` ||
 ||`Thu, 25 May 2017 16:58:18 GMT` ||`"59270d2a-9f8"` ||
 ||`Thu, 25 May 2017 16:58:21 GMT` ||`"59270d2d-9f8"` ||
 The sixth server, update.svbrwsr.com, is different than the others. Its
 `Last-Modified` and `ETag` have been increasing over irregular intervals:
 ||`Last-Modified` ||`ETag` ||
 ||`Tue, 30 May 2017 13:13:19 GMT` ||`"592d6fef-9f8"` ||
 ||`Wed, 31 May 2017 10:59:25 GMT` ||`"592ea20d-9f8"` ||
 ||`Wed, 31 May 2017 17:46:42 GMT` ||`"592f0182-9f8"` ||
 ||`Thu, 01 Jun 2017 16:19:36 GMT` ||`"59303e98-9f8"` ||
 ||`Fri, 02 Jun 2017 16:33:23 GMT` ||`"59319353-9f8"` ||
 ||`Mon, 05 Jun 2017 10:01:01 GMT` ||`"59352bdd-9f8"` ||

 I know these values from a four-times-daily fetch against each server
 since May 30, 2017.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20732 [Applications/Tor Browser]: https://www.bittrex.com/home/markets does not work in Tor Browser

[Tor Bug Tracker & Wiki]

#20732: https://www.bittrex.com/home/markets does not work in Tor Browser
--+---
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability-website |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by cypherpunks):

 * status:  new => needs_information


Comment:

 What exactly doesn't work?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22515 [Obfuscation/meek]: Check meek TLS fingerprint on ESR 52

[Tor Bug Tracker & Wiki]

#22515: Check meek TLS fingerprint on ESR 52
--+-
 Reporter:  dcf   |  Owner:  dcf
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 #18927 previous ticket for ESR 45.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22395 [Webpages/Blog]: find a way to present the comment threading more intuitively

[Tor Bug Tracker & Wiki]

#22395: find a way to present the comment threading more intuitively
---+--
 Reporter:  arma   |  Owner:  antonela
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID:  #22013 | Points:
 Reviewer: |Sponsor:
---+--

Comment (by arma):

 Replying to [comment:4 linda]:
 > * using icons for visually communicating who is taking
 > * highlighting non-anonymous or tor-official people's comments

 Something interesting that we can make use of here that is probably
 nonstandard for this situation: everybody who has a blog account is a Tor
 person, and is thus (from our perspective) inherently more worth listening
 to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22514 [Metrics/metrics-lib]: Replace DescriptorReader's setMaxDescriptorFilesInQueue() with setMaxMemory()

[Tor Bug Tracker & Wiki]

#22514: Replace DescriptorReader's setMaxDescriptorFilesInQueue() with
setMaxMemory()
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  new => needs_review


Comment:

 Please find [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-22514 my branch task-22514].  Let's discuss, not
 decide about merging just yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22514 [Metrics/metrics-lib]: Replace DescriptorReader's setMaxDescriptorFilesInQueue() with setMaxMemory()

[Tor Bug Tracker & Wiki]

#22514: Replace DescriptorReader's setMaxDescriptorFilesInQueue() with
setMaxMemory()
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 We currently let applications define a limit for parsed descriptor files
 in `DescriptorReader#setMaxDescriptorFilesInQueue()`.  If the background
 can parse descriptor files faster than the application can process them,
 it pauses when the configured number of descriptor files is contained in
 the queue and only resumes as soon as the application has dequeued a
 descriptor file.

 As we say in the docs, "the default is 100, but if descriptor files
 contain hundreds or even thousands of descriptors, that default may be too
 high".  But honestly, it's impossible to define a useful number there that
 works for all descriptor types, from microdescriptors to votes or even
 files containing tens or hundreds of concatenated votes.

 The real purpose of having a limit is to avoid running out of memory when
 parsing descriptors.  So, we should just replace
 `setMaxDescriptorFilesInQueue()` with `setMaxMemory()`.  This can't be a
 hard limit, because we cannot put partial descriptors in the queue (or not
 even partial descriptor files right now).  But this limit can define a
 magnitute of available memory, which could be anything between, say, 50M
 and 1G.

 This change is useful on its own, but it also prepares #22141 (after which
 we won't add `DescriptorFile` instances to the queue anymore, but
 `Descriptor` instances) and #21751 (when we'll likely want to define a
 `setMaxThreads()` method).

 I'll attach a branch as soon as I have a ticket number.  The code there is
 for discussion, not meant to be merged just yet.  It provides another
 method to define an upper limit for descriptors (not descriptor files)
 which I briefly considered but deemed less useful than a limit for
 descriptor bytes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22513 [Applications/Tor Browser]: Tor Browser connects to the same circuit even after CONNRESET received

[Tor Bug Tracker & Wiki]

#22513: Tor Browser connects to the same circuit even after CONNRESET received
--+---
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by cypherpunks):

 Maybe, because "Secure Connection Failed" page has about: address, and it
 has the default circuit? (Tor Browser 7.0a4)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22432 [Applications/Tor Browser]: Tor Browser doesn't stop "loading" when Tor gave up

[Tor Bug Tracker & Wiki]

#22432: Tor Browser doesn't stop "loading" when Tor gave up
---+--
 Reporter:  cypherpunks|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-usability  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by cypherpunks):

 I tried to open `about:cert` and got similar experience.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22513 [Applications/Tor Browser]: Tor Browser connects to the same circuit even after CONNRESET received

[Tor Bug Tracker & Wiki]

#22513: Tor Browser connects to the same circuit even after CONNRESET received
--+---
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-usability |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => needs_information


Comment:

 I just hit the same issue but changing the circuit worked for me (tested
 with the 7.0 rc). I wonder why it is changing the default circuit for you.
 Which operating system are you on? And which Tor Browser version?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22280 [Metrics/metrics-lib]: check tests and parsing for duplicate keys and empty keys exceptions

[Tor Bug Tracker & Wiki]

#22280: check tests and parsing for duplicate keys and empty keys exceptions
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  metrics-lib 1.9.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by iwakeh):

 First batch of checking messages in expected exceptions is
 [https://gitweb.torproject.org/user/iwakeh/metrics-
 lib.git/commit/?h=task-22280=06f65152e357c93effc9fbf6e19d39fae9e84e7e
 here].

 There are 270 left:
 {{{
 
src/test/java/org/torproject/descriptor/impl/RelayNetworkStatusConsensusImplTest.java:100
 
src/test/java/org/torproject/descriptor/impl/RelayNetworkStatusVoteImplTest.java:90
 src/test/java/org/torproject/descriptor/impl/ServerDescriptorImplTest.java:80
 }}}

 And, of course the empty and duplicate key changes to tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22511 [Community]: Tor Code of Conduct

[Tor Bug Tracker & Wiki]

#22511: Tor Code of Conduct
---+-
 Reporter:  alison |  Owner:
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #22079 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by cypherpunks):

 Replying to [comment:2 arma]:
 No, the point stands.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22513 [Applications/Tor Browser]: Tor Browser connects to the same circuit even after CONNRESET received

[Tor Bug Tracker & Wiki]

#22513: Tor Browser connects to the same circuit even after CONNRESET received
--+---
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-usability
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 Tor Browser connects to the same circuit even after CONNRESET received.
 That ends with "Secure Connection Failed" page.
 {{{
 [06-06 17:32:12] Torbutton INFO: controlPort >> 650 STREAM 1954 REMAP 393
 138.201.212.227:443 SOURCE=EXIT
 [06-06 17:32:12] Torbutton INFO: controlPort >> 650 STREAM 1954 SUCCEEDED
 393 138.201.212.227:443
 [06-06 17:32:12] Torbutton INFO: controlPort >> 650 STREAM 1954 CLOSED 393
 138.201.212.227:443 REASON=END REMOTE_REASON=CONNRESET
 Use of getPreventDefault() is deprecated.  Use defaultPrevented instead.
 jquery.js:3:7052
 [06-06 17:32:13] Torbutton INFO: tor SOCKS:
 https://trac.torproject.org/projects/tor/timeline via
torproject.org:a7eac59b7dfafaad4c547239cc9ef742
 [06-06 17:32:13] Torbutton INFO: controlPort >> 650 STREAM 1955 NEW 0
 trac.torproject.org:443 SOURCE_ADDR=127.0.0.1:53314 PURPOSE=USER
 [06-06 17:32:13] Torbutton INFO: controlPort >> 650 STREAM 1955
 SENTCONNECT 393 trac.torproject.org:443
 [06-06 17:32:14] Torbutton INFO: controlPort >> 650 STREAM 1955 REMAP 393
 138.201.212.227:443 SOURCE=EXIT
 [06-06 17:32:14] Torbutton INFO: controlPort >> 650 STREAM 1955 SUCCEEDED
 393 138.201.212.227:443
 [06-06 17:32:14] Torbutton INFO: controlPort >> 650 STREAM 1955 CLOSED 393
 138.201.212.227:443 REASON=END REMOTE_REASON=CONNRESET
 }}}
 Any subsequent attempts to refresh the page (including "Try Again" button)
 end with nothing (because circuit doesn't change).
 {{{
 [06-06 17:36:32] Torbutton INFO: tor SOCKS:
 https://trac.torproject.org/projects/tor/timeline via
torproject.org:a7eac59b7dfafaad4c547239cc9ef742
 [06-06 17:36:32] Torbutton INFO: controlPort >> 650 STREAM 1956 NEW 0
 trac.torproject.org:443 SOURCE_ADDR=127.0.0.1:53319 PURPOSE=USER
 [06-06 17:36:32] Torbutton INFO: controlPort >> 650 STREAM 1956
 SENTCONNECT 393 trac.torproject.org:443
 [06-06 17:36:32] Torbutton INFO: controlPort >> 650 STREAM 1956 REMAP 393
 138.201.212.227:443 SOURCE=EXIT
 [06-06 17:36:32] Torbutton INFO: controlPort >> 650 STREAM 1956 SUCCEEDED
 393 138.201.212.227:443
 [06-06 17:36:33] Torbutton INFO: controlPort >> 650 STREAM 1956 CLOSED 393
 138.201.212.227:443 REASON=END REMOTE_REASON=CONNRESET
 }}}
 Even "New Tor Circuit for this Site" ends with nothing (because it changes
 the default circuit!).
 {{{
 [06-06 17:40:35] Torbutton INFO: New domain isolation for --unknown--:
 a9feb8e55bbdc3d5e6d8be2e5c473674
 [06-06 17:40:35] Torbutton INFO: tor SOCKS:
 https://trac.torproject.org/projects/tor/timeline via
torproject.org:a7eac59b7dfafaad4c547239cc9ef742
 [06-06 17:40:36] Torbutton INFO: controlPort >> 650 STREAM 1961 NEW 0
 trac.torproject.org:443 SOURCE_ADDR=127.0.0.1:53328 PURPOSE=USER
 [06-06 17:40:36] Torbutton INFO: controlPort >> 650 STREAM 1961
 SENTCONNECT 393 trac.torproject.org:443
 [06-06 17:40:36] Torbutton INFO: controlPort >> 650 STREAM 1961 REMAP 393
 138.201.212.227:443 SOURCE=EXIT
 [06-06 17:40:36] Torbutton INFO: controlPort >> 650 STREAM 1961 SUCCEEDED
 393 138.201.212.227:443
 [06-06 17:40:37] Torbutton INFO: controlPort >> 650 STREAM 1961 CLOSED 393
 138.201.212.227:443 REASON=END REMOTE_REASON=CONNRESET
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22511 [Community]: Tor Code of Conduct

[Tor Bug Tracker & Wiki]

#22511: Tor Code of Conduct
---+-
 Reporter:  alison |  Owner:
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #22079 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by arma):

 Replying to [comment:1 cypherpunks]:
 > WTF? I dislike you

 An anonymous flame on a trac thread is not the way to engage on this
 topic.

 To be constructive: the right way to engage on this topic is to first do
 useful things for Tor and the Tor community, and then people will be
 excited to listen to your perspective when we are considering things like
 the code of conduct.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22512 [Metrics/metrics-lib]: Add enums for keywords used in exit lists, Torperf measurement results, bridge pool assignments, and soon sanitized web logs

[Tor Bug Tracker & Wiki]

#22512: Add enums for keywords used in exit lists, Torperf measurement results,
bridge pool assignments, and soon sanitized web logs
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 We recently introduced the `Key` enum with keywords contained in relay
 descriptors, sanitized bridge descriptors, and sanitized bridge pool
 assignments.  We did not include keywords in exit lists and Torperf
 measurement results, and in retrospect we should have excluded sanitized
 bridge pool assignments there.

 The reason why each data source should have its own enum is that naming
 conventions might vary in terms of upper/lower case and word separators.
 For example, Tor descriptors use `lower-case-keywords`, exit lists contain
 `CamelCase`, and Torperf/OnionPerf use `ALL_UPPER_CASE_WITH_UNDERSCORES`.
 There could be conflicts for keywords like `source` vs. `SOURCE`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22511 [Community]: Tor Code of Conduct

[Tor Bug Tracker & Wiki]

#22511: Tor Code of Conduct
---+-
 Reporter:  alison |  Owner:
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #22079 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by cypherpunks):

 WTF? I dislike you, and I and my friends sure won't ever follow a CoC and
 wouldn't want others to follow one. Similarly, anyone who *would* follow
 it, wouldn't act differently if there was one. ...?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22511 [Community]: Tor Code of Conduct

[Tor Bug Tracker & Wiki]

#22511: Tor Code of Conduct
---+
 Reporter:  alison |  Owner:
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #22079
   Points: |   Reviewer:
  Sponsor: |
---+
 To be completed after the membership guidelines are ratified.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22080 [Community]: add bios for active Community Team members on wiki

[Tor Bug Tracker & Wiki]

#22080: add bios for active Community Team members on wiki
---+
 Reporter:  alison |  Owner:  alison
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by alison):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22080 [Community]: add bios for active Community Team members on wiki

[Tor Bug Tracker & Wiki]

#22080: add bios for active Community Team members on wiki
---+--
 Reporter:  alison |  Owner:
 Type:  task   | Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by alison):

 * status:  closed => reopened
 * resolution:  fixed =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22080 [Community]: add bios for active Community Team members on wiki

[Tor Bug Tracker & Wiki]

#22080: add bios for active Community Team members on wiki
---+--
 Reporter:  alison |  Owner:  alison
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by alison):

 * status:  reopened => assigned
 * owner:   => alison


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22080 [Community]: add bios for active Community Team members on wiki

[Tor Bug Tracker & Wiki]

#22080: add bios for active Community Team members on wiki
---+
 Reporter:  alison |  Owner:
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Community  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by alison):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22501 [Applications/Tor Browser]: Requests via javascript: violate FPI

[Tor Bug Tracker & Wiki]

#22501: Requests via javascript: violate FPI
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:
 Keywords:  tbb-linkability   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 You were asking about new issues so persistently on tor-qa (as if you lack
 them :) that I couldn't pass by :) How many new issues will be enough for
 you? What are you going to do with all of them?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22506 [Applications/Tor Browser]: Tor Browser 7.0 dalayed startup with certain addons (with filter lists)

[Tor Bug Tracker & Wiki]

#22506: Tor Browser 7.0 dalayed startup with certain addons (with filter lists)
--+---
 Reporter:  morbis55  |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => needs_information


Comment:

 FWIW, I tested this on a 64bit Linux system by installing ublock Origin in
 a clean Tor Browser 7.0 and I did not notice any lag/slowdown. Neither
 during surfing, nor during start-up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22510 [Webpages/Blog]: Increasing brand presence on the Tor blog (i.e. to make it look more Tor-y)

[Tor Bug Tracker & Wiki]

#22510: Increasing brand presence on the Tor blog (i.e. to make it look more 
Tor-y)
---+--
 Reporter:  linda  |  Owner:  antonela
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by linda):

 * owner:  hiro => antonela
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22510 [Webpages/Blog]: Increasing brand presence on the Tor blog (i.e. to make it look more Tor-y)

[Tor Bug Tracker & Wiki]

#22510: Increasing brand presence on the Tor blog (i.e. to make it look more 
Tor-y)
---+--
 Reporter:  linda  |  Owner:  hiro
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 During the UX ticket triaging discussion, we realized that various people
 didn't like how bright the tor blog was, wanted more tor in the blog, and
 many other things. Let's intentionally design a color scheme and design
 for our new blog!

 Possible options:
 * using tor colors (light theme with tor-purple and tor-green accents,
 dark theme with tor-purple and tor-green accents, predominantly tor-purple
 theme, or predominantly tor-green theme)
 * adding more graphics (onions, tor logo, etc.)
 * making it look like our other sites (but torproject.org is not so great
 that we want it to necessarily look like it, looking at
 metrics.torproject.org can give ideas)

 Resources:
 * [https://blog.torproject.org/ How the current blog looks]
 *
 [https://web.archive.org/web/20170426133309/https://blog.torproject.org/blog
 /tor-browser-70a3-released How the old blog used to look]
 * [https://github.com/uracreative/tor-
 styleguide/blob/master/RGB/Tor%20Style%20Guide%20Complete%20-%20RGB.pdf
 Tor style guide]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22392 [Webpages/Blog]: Should we remove or compress the left column on the blog?

[Tor Bug Tracker & Wiki]

#22392: Should we remove or compress the left column on the blog?
---+--
 Reporter:  arma   |  Owner:  antonela
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID:  #22013 | Points:
 Reviewer: |Sponsor:
---+--

Comment (by linda):

 As discussed during the ux ticket triage, Antonela will mock up how the
 blog would look without a left column.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22392 [Webpages/Blog]: Should we remove or compress the left column on the blog?

[Tor Bug Tracker & Wiki]

#22392: Should we remove or compress the left column on the blog?
---+--
 Reporter:  arma   |  Owner:  antonela
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID:  #22013 | Points:
 Reviewer: |Sponsor:
---+--
Changes (by linda):

 * owner:  hiro => antonela
 * status:  new => assigned
 * cc: linda, antonela (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22395 [Webpages/Blog]: find a way to present the comment threading more intuitively

[Tor Bug Tracker & Wiki]

#22395: find a way to present the comment threading more intuitively
---+--
 Reporter:  arma   |  Owner:  antonela
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID:  #22013 | Points:
 Reviewer: |Sponsor:
---+--

Comment (by linda):

 As discussed during the ux ticket triage, Antonela will find a way to
 display the comment threading more intuitively. Some of the ideas
 discussed were:

 * displaying the commenter's name near the top/beside the comment
 * using icons for visually communicating who is taking
 * highlighting non-anonymous or tor-official people's comments
 * using smaller fonts to display more comments on a screen
 * changing the layout of the blog (getting rid of the left column, as
 discussed in #22392, can help)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22395 [Webpages/Blog]: find a way to present the comment threading more intuitively

[Tor Bug Tracker & Wiki]

#22395: find a way to present the comment threading more intuitively
---+--
 Reporter:  arma   |  Owner:  antonela
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID:  #22013 | Points:
 Reviewer: |Sponsor:
---+--
Changes (by linda):

 * cc: linda, antonela (added)
 * status:  needs_review => assigned
 * owner:  hiro => antonela


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22509 [Webpages/Blog]: Put "Reply" bar at the bottom of comment

[Tor Bug Tracker & Wiki]

#22509: Put "Reply" bar at the bottom of comment
---+
 Reporter:  cypherpunks|  Owner:  hiro
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #22013
   Points: |   Reviewer:
  Sponsor: |
---+
 subj

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22395 [Webpages/Blog]: find a way to present the comment threading more intuitively

[Tor Bug Tracker & Wiki]

#22395: find a way to present the comment threading more intuitively
---+--
 Reporter:  arma   |  Owner:  hiro
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID:  #22013 | Points:
 Reviewer: |Sponsor:
---+--

Comment (by arma):

 Compare to
 http://web.archive.org/web/20170426133309/https://blog.torproject.org/blog
 /tor-browser-70a3-released
 for blog comment threads that are much easier to follow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22499 [Applications/Tor Browser]: Decide what we want to do with python obfsproxy and fteproxy pluggable transports

[Tor Bug Tracker & Wiki]

#22499: Decide what we want to do with python obfsproxy and fteproxy pluggable
transports
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201706  |  Actual Points:
Parent ID:  #17379| Points:
 Reviewer:|Sponsor:
--+--

Comment (by dcf):

 For reference, here are notes from when obfsproxy was ported to the
 Gitian-based build system initially, in 2013:
  * comment:18:ticket:9444 "I'm having trouble making Python work for the
 Windows bundles."
  * comment:19:ticket:9444 "I have a windows build more or less working."
  * comment:20:ticket:9444 "These are noteworthy characteristics of the
 windows pluggable transports build:"

 I would prefer to keep FTE in the browser. I know how hard it was to get
 Python windows builds going, though. As I remember, linux and mac were
 pretty easy, but Windows was really hard, requiring for example building
 under Wine (the right version of which was not in deb repositories, etc.,
 etc.).

 Currently FTE is only included in the linux and windows builds because of
 a packaging bug on mac: #18495 (also #21343 which removed FTE dependencies
 from the mac build).

 A few users noticed on the blog when FTE disappeared from the mac builds:
  * [https://blog.torproject.org/comment/196721#comment-196721 Tor Browser
 6.0.3] "How many Pluggable transports are there? The Torproject site shows
 'FTE' but I don't have that trnasport."
  * [https://blog.torproject.org/comment/219937#comment-219937 Tor Browser
 6.0.6] "On a Mac OS transport meek-azure does not work and the transport
 FTE is stil mising."
  * [https://blog.torproject.org/comment/224545#comment-224545 Tor Browser
 6.0.7] "It is missing the transport FTE and scramblesuit yet scramblesuit
 is shown in the Torbrowser."
  * [https://blog.torproject.org/comment/251899#comment-251899 Tor Browser
 6.5.1] "My Mac's torbrowser does not have the FTE transports ?"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18495 [Obfuscation/FTE]: Mac OS: reorganize FTE packaging

[Tor Bug Tracker & Wiki]

#18495: Mac OS: reorganize FTE packaging
-+
 Reporter:  mcs  |  Owner:  kpdyer
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/FTE  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  None
-+
Changes (by dcf):

 * keywords:   => tbb-gitian


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16583 [Applications/Tor Browser]: obfsproxy executable no longer needed in Tor Browser

[Tor Bug Tracker & Wiki]

#16583: obfsproxy executable no longer needed in Tor Browser
--+---
 Reporter:  arma  |  Owner:  tbb-team
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:  SponsorS, tbb-gitian  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by dcf):

 * status:  new => closed
 * resolution:   => duplicate
 * severity:   => Normal


Comment:

 Closing this for newer #22499.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22508 [Core Tor/Tor]: Assertion failure in rotate_x509_certificate_callback()

[Tor Bug Tracker & Wiki]

#22508: Assertion failure in rotate_x509_certificate_callback()
---+
 Reporter:  dgoulet|  Owner:
 Type:  defect | Status:  closed
 Priority:  Very High  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  client regression  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by nickm):

 Looks like my fix broke unit tests.  committed 68c3df69dec4b2 to try to
 solve everything.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22392 [Webpages/Blog]: Should we remove or compress the left column on the blog?

[Tor Bug Tracker & Wiki]

#22392: Should we remove or compress the left column on the blog?
---+--
 Reporter:  arma   |  Owner:  hiro
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords:  ux-team|  Actual Points:
Parent ID:  #22013 | Points:
 Reviewer: |Sponsor:
---+--

Comment (by linda):

 My opinion is that it can go. I say opinion, because there are some times
 when three columns make sense, but I don't think we need the left column.

 If there is important material that will go into the left column that is
 different from the middle column, I can see a point for it. But to me, the
 blog posts are itself updates from Tor.

 Even if we had unique content on the left, I think there is a good point
 to be made about using the  space more efficiently. Using just one column
 on the right for both content can work, if we limit what  we show (i.e.
 last 3 tweets, upcoming 3 events, with a link to the twitter account/list
 of all updates).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22346 [Metrics/Metrics website]: tor browser update URL change and the update ping metrics

[Tor Bug Tracker & Wiki]

#22346: tor browser update URL change and the update ping metrics
-+--
 Reporter:  cypherpunks  |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Metrics website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * cc: boklm (added)


Comment:

 boklm, gk, any ideas what we're missing?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22488 [Metrics/Onionoo]: Include relay version listed in consensus in addition to platform line from server descriptor (was: recommended_version is false but it should be true)

[Tor Bug Tracker & Wiki]

#22488: Include relay version listed in consensus in addition to platform line 
from
server descriptor
-+--
 Reporter:  cypherpunks  |  Owner:  metrics-team
 Type:  enhancement  | Status:  reopened
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  closed => reopened
 * type:  defect => enhancement
 * resolution:  not a bug =>


Comment:

 From the [https://lists.torproject.org/pipermail/metrics-
 team/2017-June/000382.html metrics-team@ mailing list]:

 > thanks for your prompt reply, since the ticket has been closed I'm
 answering here.
 >
 > We display whatever version was last uploaded by the relay but we only
 care about what made it into the consensus.
 >
 > What do you think about _also_ just displaying whatever made it into the
 consensus so there is no mismatch between what atlas displays and what is
 actually in the consensus?

 Sounds plausible to me.  I'm currently focusing on metrics-lib, so I'm
 reopening this ticket for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22508 [Core Tor/Tor]: Assertion failure in rotate_x509_certificate_callback()

[Tor Bug Tracker & Wiki]

#22508: Assertion failure in rotate_x509_certificate_callback()
---+
 Reporter:  dgoulet|  Owner:
 Type:  defect | Status:  closed
 Priority:  Very High  |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  client regression  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.0.x-final


Comment:

 Please reopen if it comes back again?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22508 [Core Tor/Tor]: Assertion failure in rotate_x509_certificate_callback()

[Tor Bug Tracker & Wiki]

#22508: Assertion failure in rotate_x509_certificate_callback()
---+
 Reporter:  dgoulet|  Owner:
 Type:  defect | Status:  new
 Priority:  Very High  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  client regression  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by nickm):

 Likely fix in 4ed0f0d62f760f (on maint-0.3.0).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22280 [Metrics/metrics-lib]: check tests and parsing for duplicate keys and empty keys exceptions

[Tor Bug Tracker & Wiki]

#22280: check tests and parsing for duplicate keys and empty keys exceptions
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  metrics-lib 1.9.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by karsten):

 * milestone:  metrics-lib 1.8.0 => metrics-lib 1.9.0


Comment:

 Sounds good.  Moving to 1.9.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22280 [Metrics/metrics-lib]: check tests and parsing for duplicate keys and empty keys exceptions

[Tor Bug Tracker & Wiki]

#22280: check tests and parsing for duplicate keys and empty keys exceptions
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by iwakeh):

 Replying to [comment:4 iwakeh]:
 > Replying to [comment:3 karsten]:
 > > One day until the planned 1.8.0 release.  Should we move this to
 1.9.0, or is this already almost done?
 >
 ~~> This should go into 1.8.0; update following.~~

 OK, I checked and there are way too many expected-exception-tests to be
 changed for this release.
 It is important to have these.  I'll check-in some changes later, but
 these might not need to go in now.
 So I'd suggest too to move this ticket to 1.9.0

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21932 [Metrics/metrics-lib]: Stop relying on the platform's default charset

[Tor Bug Tracker & Wiki]

#21932: Stop relying on the platform's default charset
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  metrics-lib 2.0.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by karsten):

 * status:  merge_ready => assigned
 * milestone:  metrics-lib 1.8.0 => metrics-lib 2.0.0


Comment:

 Great, thanks for looking!  Rebased, squashed, and pushed to master.
 Changing status to assigned and milestone to 2.0.0, because we still rely
 on the platform's default charset.  Still good to have the preparatory
 changes merged now and released soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22508 [Core Tor/Tor]: Assertion failure in rotate_x509_certificate_callback()

[Tor Bug Tracker & Wiki]

#22508: Assertion failure in rotate_x509_certificate_callback()
--+
 Reporter:  dgoulet   |  Owner:
 Type:  defect| Status:  new
 Priority:  Very High |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  client regression
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Surely related to #22460.

 Normal tor client (not a relay) with version `0.3.1.2-alpha-dev (git-
 5343d2b03c8158fc)`. Got this two hours after it started:

 {{{
 Jun 06 09:06:02.000 [warn] Can't get my x509 link cert.
 Jun 06 09:06:02.000 [err] Unable to update Ed25519->TLS link certificate
 for new TLS context.
 Jun 06 09:06:02.000 [err] tor_assertion_failed_(): Bug:
 src/or/main.c:1611: rotate_x509_certificate_callback: Assertion 0 failed;
 aborting. (on Tor 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: Assertion 0 failed in
 rotate_x509_certificate_callback at src/or/main.c:1611. Stack trace: (on
 Tor 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: tor(log_backtrace+0x44)
 [0x557794125024] (on Tor 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: tor(tor_assertion_failed_+0x8d)
 [0x55779413dfbd] (on Tor 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: tor(+0x4ac00) [0x557794004c00] (on Tor
 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: tor(+0x69590) [0x557794023590] (on Tor
 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7ff066d47420] (on Tor
 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: tor(do_main_loop+0x245)
 [0x557794008345] (on Tor 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: tor(tor_main+0x1c35) [0x55779400bd45]
 (on Tor 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: tor(main+0x19) [0x557794003bd9] (on Tor
 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf1) [0x7ff065a573f1] (on Tor 0.3.1.2
 -alpha-dev 5343d2b03c8158fc)
 Jun 06 09:06:02.000 [err] Bug: tor(_start+0x2a) [0x557794003c2a] (on
 Tor 0.3.1.2-alpha-dev 5343d2b03c8158fc)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22279 [Metrics/metrics-lib]: simplify and avoid repetition in ParserHelper methods

[Tor Bug Tracker & Wiki]

#22279: simplify and avoid repetition in ParserHelper methods
-+---
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Great, thanks for checking!  Merged and re-closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22506 [Applications/Tor Browser]: Tor Browser 7.0 dalayed startup with certain addons (with filter lists)

[Tor Bug Tracker & Wiki]

#22506: Tor Browser 7.0 dalayed startup with certain addons (with filter lists)
--+--
 Reporter:  morbis55  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by mcs):

 * cc: mcs (added)


Comment:

 Thanks for opening this ticket. What OS are you using?

 What is your security slider setting, and does changing it make any
 difference?

 Is the slowness noticeable only during startup or does the browser remain
 slow while you use it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22507 [Internal Services/Tor Sysadmin Team]: Please prepare schleuder transport for tor-community-coun...@torproject.org

[Tor Bug Tracker & Wiki]

#22507: Please prepare schleuder transport for 
tor-community-coun...@torproject.org
-+-
 Reporter:  hiro |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 To be able to setup tor-community-coun...@torproject.org on Schleuder I
 need the following added to postfix transport

 tor-community-coun...@lists.torproject.org  schleuder:
 tor-community-council-requ...@lists.torproject.org  schleuder:
 tor-community-council-bou...@lists.torproject.org   schleuder:
 tor-community-council-send...@lists.torproject.org  schleuder:
 tor-community-council-ow...@lists.torproject.orgschleuder:

 Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22506 [Applications/Tor Browser]: Tor Browser 7.0 dalayed startup with certain addons (with filter lists) (was: Torbrowser 7.0 dalayed startup with certain addons (with filter lists))

[Tor Bug Tracker & Wiki]

#22506: Tor Browser 7.0 dalayed startup with certain addons (with filter lists)
--+--
 Reporter:  morbis55  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22506 [Applications/Tor Browser]: Torbrowser 7.0 dalayed startup with certain addons (with filter lists)

[Tor Bug Tracker & Wiki]

#22506: Torbrowser 7.0 dalayed startup with certain addons (with filter lists)
--+--
 Reporter:  morbis55  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 How to reproduce:
 - Use the latest unofficial Tor Browser (same result for version 7.0a3,
 7.04a, 7.0-build1 and 7.0)
 - It will launch just fine without problems
 - Go to "Get Add-ons" and just as an example install "uBlock Origin"
 - After it installed you will see the browser get extremely laggy and
 freeze for some seconds
 - Restart the browser and see how it will take abnormally long to start

 The reason are the filter lists of the addon
 If you disable the filters, the problem is gone
 (does not make any sense with a filter list based blocker however, so not
 a solution)
 This also goes for all other addons with filter lists like:
 uMatrix, Ghostery, Adblock Plus, ... etc

 In previous versions of Tor Browser there is also a small delay
 but not even far as drastically as it is with Tor Browser 7.0
 Also it is not a problem with original Firefox 52ESR itself as the problem
 does not occure there.
 Thus it must be a Problem with Tor Browser 7.0

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19640 [Metrics/metrics-lib]: review and improve interface hierarchy

[Tor Bug Tracker & Wiki]

#19640: review and improve interface hierarchy
-+---
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:  metrics-lib 1.9.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by iwakeh):

 Also from #21932 comments 14/15, listed for discussion:
 * avoid constant duplication, think about adding or not adding certain
 constants to the api (refers to DescriptorImpl.NL and ExitList.EOL)
 * add overloaded methods for `newScanner`, b/c the usual delimiter is "\n"
 * DescriptorImpl.setDigestXXX allow empty or null argument.  This should
 have a check even though currently the calling methods make sure the
 argument is not null or empty, but when working on other tasks in the
 future that might not be apparent anymore and would get lost w/o a check
 and accompanying test.
 * Think about improving TorperfResultImpl and ExitListImpl (also in regard
 to delimiter use, see question 4, comment 14, #21932).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21932 [Metrics/metrics-lib]: Stop relying on the platform's default charset

[Tor Bug Tracker & Wiki]

#21932: Stop relying on the platform's default charset
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 The current commits look fine.  Tests and checks pass.

 As the the open questions above existed for a while their discussion can
 be transferred to the API overhaul ticket #19640 (in 1.9.0).  I'll add a
 comment there in  a sec.

 All else is fine to be released in 1.8.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22279 [Metrics/metrics-lib]: simplify and avoid repetition in ParserHelper methods

[Tor Bug Tracker & Wiki]

#22279: simplify and avoid repetition in ParserHelper methods
-+---
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Test and fix look fine; all tests and checks pass. => ready for
 merge

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22280 [Metrics/metrics-lib]: check tests and parsing for duplicate keys and empty keys exceptions

[Tor Bug Tracker & Wiki]

#22280: check tests and parsing for duplicate keys and empty keys exceptions
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by iwakeh):

 Replying to [comment:3 karsten]:
 > One day until the planned 1.8.0 release.  Should we move this to 1.9.0,
 or is this already almost done?

 This should go into 1.8.0; update following.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22279 [Metrics/metrics-lib]: simplify and avoid repetition in ParserHelper methods

[Tor Bug Tracker & Wiki]

#22279: simplify and avoid repetition in ParserHelper methods
-+---
 Reporter:  iwakeh   |  Owner:  karsten
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by karsten):

 Still needs review, and needs to go into 1.8.0 which we're planning to
 release tomorrow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22280 [Metrics/metrics-lib]: check tests and parsing for duplicate keys and empty keys exceptions

[Tor Bug Tracker & Wiki]

#22280: check tests and parsing for duplicate keys and empty keys exceptions
-+---
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by karsten):

 One day until the planned 1.8.0 release.  Should we move this to 1.9.0, or
 is this already almost done?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21932 [Metrics/metrics-lib]: Stop relying on the platform's default charset

[Tor Bug Tracker & Wiki]

#21932: Stop relying on the platform's default charset
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by karsten):

 Replying to [comment:15 karsten]:
 > Okay, I pushed two new commits to
 [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-21932-3 my task-21932-3 branch] with new tests and
 renamed `newScanner()` method.  I'll hunt for new bugs now.  If I don't
 find any, should I squash and merge to master?  Or do you want to add more
 changes from your suggestions above?

 Update: I didn't run into any issues, but I'll do another round of tests
 as soon as we have a pre-release tarball.

 Ready to merge, or needs revision?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22504 [Applications/Tor Browser]: Change update_2 to update_3 in ReleaseProcess

[Tor Bug Tracker & Wiki]

#22504: Change update_2 to update_3 in ReleaseProcess
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201706R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * keywords:  . => TorBrowserTeam201706R
 * status:  new => needs_review


Comment:

 We also need to update the path to use aus1.tpo instead of dist.tpo. I
 attached a patch doing both changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22505 [Internal Services/Service - lists]: Please remove the hidserv-stats mailing list

[Tor Bug Tracker & Wiki]

#22505: Please remove the hidserv-stats mailing list
---+-
 Reporter:  karsten|  Owner:  qbi
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:
Component:  Internal Services/Service - lists  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+-
 {{{
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA256

 Please remove the hidserv-stats mailing list, and please leave the
 archives in place if possible.  Thanks!

 -BEGIN PGP SIGNATURE-
 Comment: GPGTools - http://gpgtools.org

 iQEcBAEBCAAGBQJZNnhxAAoJEO85p7J7H00BcU8IAIDcrXvN/vbdkPKWc5wmwsuw
 OV53WNZrA05asMZ3Xke0RCmHeAGv96FHC3cbhTJn3eQfGvitFFZVrnokA9iWdcA1
 TV2MkMHJNnwM1RBc92i0QZ6ZQ4jQOikPAX7koYKKU9T+46/I8f/R4/FQFNZYbi5J
 EcxOYGoxWZbXXseILYiLjdv8/fH/8r0U/1cA0bz8Lu8cdY31FlkDRAGo9QP61GUa
 zNOt+LmOlmuKD83yet3KKsjzwVSnoELWYtVFJzyPJNZ8MKJVjzpO3KOtCmdhQbFI
 +8t2pm8vLrrs2NHkoSPe1q7kVMPtqNtsVSbep2mXKVYlkKzTx+mDVw/tBPtE2Ic=
 =GO1q
 -END PGP SIGNATURE-
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22504 [Applications/Tor Browser]: Change update_2 to update_3 in ReleaseProcess

[Tor Bug Tracker & Wiki]

#22504: Change update_2 to update_3 in ReleaseProcess
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  .
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Starting with the 7.0 release, we should not touch the update files in
 `update_2` and use instead `update_3`.

 I will attach a patch for `tor-browser-spec.git` to update the
 `processes/ReleaseProcess` file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22426 [Webpages/Blog]: Missing `#comments` anchor on article pages

[Tor Bug Tracker & Wiki]

#22426: Missing `#comments` anchor on article pages
---+
 Reporter:  dcf|  Owner:  hiro
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Minor  | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID:  #22013 | Points:
 Reviewer: |Sponsor:
---+
Changes (by hiro):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22476 [Metrics/metrics-lib]: Replace ImplementationNotAccessibleException with RuntimeException

[Tor Bug Tracker & Wiki]

#22476: Replace ImplementationNotAccessibleException with RuntimeException
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * milestone:  metrics-lib 1.8.0 =>


Comment:

 Ah, I think I never considered that distinction between API and
 implementation important.  Realistically, we'll provide the only
 implementation of this API.

 (Maybe this also explains why you care about keeping the info log line
 `"Serving implementation {} for {}."` whereas I'd still prefer toning that
 down to a debug message.)

 Let's take this ticket out of the 1.8.0 milestone and discuss later
 whether we really need this abstraction layer or not.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21932 [Metrics/metrics-lib]: Stop relying on the platform's default charset

[Tor Bug Tracker & Wiki]

#21932: Stop relying on the platform's default charset
-+---
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---

Comment (by karsten):

 Replying to [comment:14 iwakeh]:
 > Replying to [comment:13 karsten]:
 > > I just pushed one more commit to that branch to fix a bug.
 >
 > Good, that you found that!

 Indeed.  I guess I would have found it when running Onionoo and metrics-
 web with this metrics-lib version, which I was planning to do today.  But
 always good to find bugs early.  Let's see what else I'll find today!

 > Should there be a test added for this in particular?

 Sure, added.

 > All looks fine, passes tests and checks.  I added a simple test class
 directly for DescriptorImpl [https://gitweb.torproject.org/user/iwakeh
 /metrics-
 lib.git/commit/?h=task-21932-3=991dc7bddfe6a6e692a3c580fe318ed01c23844d
 here].

 Looks good!

 > Some questions (partially not related to current changes):
 > 1. Rename `getScanner` into `newScanner`, because a new Scanner is
 created with every call and this is not a 'getter'?

 Good idea, changed.

 > 1. `ExitList.EOL = "\n" = DescriptorImpl.NL` why not use one for all
 delimiters in `newScanner` calls? Shouldn't `NL` be defined in
 `Descriptor` and be used everywhere, i.e., deprecate `ExitList.EOL` and
 replace with release 2.0.0?

 This one is tricky.  We shouldn't impose a newline character for all
 descriptor types.  For example, Torperf measurement results use either
 `\n` or `\r\n` as newline character(s), depending on whether they're
 written by Torperf or OnionPerf.  And we don't know what future descriptor
 types will (want to) use.

 But do we need to expose this in the interface at all?  I could imagine
 deprecating `ExitList.EOL` and just using `DescriptorImpl.NL`, but without
 moving `DescriptorImpl.NL` to `Descriptor.NL`.  Should we do that?  We
 could easily do this in 1.9.0.

 > 1. Make NL the delimiter default that is already set for the Scanner
 returned by `newScanner`?

 See above.  We'd have to provide an overloaded method for non-default
 delimiters, and the question is whether that saves so much code or
 complexity overall.  We could do it, but we could just leave it as is.

 > 1. The Scanner usage in TorperfResult is essentially getLine() in the
 two places.  Do Torperf descriptors contain "\r"?

 See above.  But to be honest, I focused mainly on Tor descriptors and just
 tweaked the other descriptors until everything compiled again. ;)  We
 could probably make `TorperfResultImpl` and `ExitListImpl` better if we
 wanted.  But maybe we should save that for 1.9.0?

 > 1. DescriptorImpl.setDigestXXX allow empty or null argument.  Should
 there be a check?

 Do you think that's necessary?  These methods are only called by
 ourselves, and we're already making sure that we're neither passing an
 empty or null argument when calling that method.  I don't feel strongly
 though.

 Okay, I pushed two new commits to
 [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-21932-3 my task-21932-3 branch] with new tests and
 renamed `newScanner()` method.  I'll hunt for new bugs now.  If I don't
 find any, should I squash and merge to master?  Or do you want to add more
 changes from your suggestions above?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs