Re: [tor-bugs] #34286 [Applications/GetTor]: gettor appears to be in an email loop war with a .sk address

[Tor Bug Tracker & Wiki]

#34286: gettor appears to be in an email loop war with a .sk address
-+
 Reporter:  arma |  Owner:  cohosh
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  phw  |Sponsor:
-+
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged and deployed at `2020-05-30T02:03:11+`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34286 [Applications/GetTor]: gettor appears to be in an email loop war with a .sk address

[Tor Bug Tracker & Wiki]

#34286: gettor appears to be in an email loop war with a .sk address
-+-
 Reporter:  arma |  Owner:  cohosh
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  phw  |Sponsor:
-+-
Changes (by cohosh):

 * status:  reopened => merge_ready


Comment:

 lgtm. Thanks for catching this!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29368 [Metrics/Onionperf]: Add single onion service mode

[Tor Bug Tracker & Wiki]

#29368: Add single onion service mode
---+
 Reporter:  irl|  Owner:  phw
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by acute):

 This looks good! Appending here a git formatted patch to avoid passing the
 `single-onion` as a new parameter to all the server and config functions.
 Instead this initializes `self.single_onion` as a class attribute (e.g,
 the same way `serf.torserver_conf_file` works).
 In the future we could also treat `do_onion` and `do_inet` the same way,
 but the opportunity for simplification there is smaller.
 Let me know if this looks good to you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29368 [Metrics/Onionperf]: Add single onion service mode

[Tor Bug Tracker & Wiki]

#29368: Add single onion service mode
---+
 Reporter:  irl|  Owner:  phw
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * Attachment "0001-Simplifies-measurement-function-parameters.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34286 [Applications/GetTor]: gettor appears to be in an email loop war with a .sk address

[Tor Bug Tracker & Wiki]

#34286: gettor appears to be in an email loop war with a .sk address
-+--
 Reporter:  arma |  Owner:  cohosh
 Type:  defect   | Status:  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  phw  |Sponsor:
-+--
Changes (by phw):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I'm reopening this because we seem to have overlooked a bug. GetTor
 chocked earlier today and I found the following exception in its log file:
 {{{
 2020-05-29 19:04:43+ [email parser] Error while parsing email content:
 [Failure instance: Traceback: : 'command'
 /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:311:addCallbacks
 /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:654:_runCallbacks
 /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:1613:unwindGenerator
 /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:1529:_cancellableInlineCallbacks
 ---  ---
 /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:1418:_inlineCallbacks
 /srv/gettor.torproject.org/home/gettor/gettor/parse/email.py:256:parse_callback
 ].
 }}}

 When GetTor detects an autoresponder, it returns an empty request
 dictionary, `{}`. GetTor then calls `parse_callback`, which assumes that
 the given request has the "command" key but that's not the case.

 Here's a fix:
 https://gitlab.torproject.org/tpo/anti-censorship/gettor-
 project/gettor/-/merge_requests/13

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29369 [Metrics/Onionperf]: Fix message logging and filtering

[Tor Bug Tracker & Wiki]

#29369: Fix message logging and filtering
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.4
Parent ID:  #33321 | Points:  1.0
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by phw):

 Replying to [comment:12 karsten]:
 > Without the date prefix the output file written at midnight will
 overwrite the output file from one day before. Do you prefer if I write
 this patch early next week and you review it?
 [[br]]
 I think I now understand. Is this (untested) code what you had in mind?
 https://github.com/NullHypothesis/onionperf/compare/defect/29369

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29368 [Metrics/Onionperf]: Add single onion service mode

[Tor Bug Tracker & Wiki]

#29368: Add single onion service mode
---+
 Reporter:  irl|  Owner:  phw
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by phw):

 * status:  assigned => needs_review


Comment:

 Here's a patch that adds support for single onion services:
 https://github.com/NullHypothesis/onionperf/compare/enhancement/29368

 The patch adds a new command line switch, --single-onion, which passes a
 flag to `create_tor_config`. How does it look? Note that I haven't written
 unit tests yet because I wanted to get feedback first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30318 [Applications/Tor Browser]: Integrate snowflake into mobile Tor Browser alpha

[Tor Bug Tracker & Wiki]

#30318: Integrate snowflake into mobile Tor Browser alpha
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, TorBrowserTeam202005R,   |  Actual Points:
  tbb-10.0a1 |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by sysrqb):

 * status:  needs_review => closed
 * keywords:  tbb-mobile, TorBrowserTeam202005R => tbb-mobile,
 TorBrowserTeam202005R, tbb-10.0a1
 * resolution:   => fixed


Comment:

 Nice work everyone, thanks!

 Replying to [comment:3 gk]:
 > Replying to [comment:2 gk]:
 > > `bug_30318` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_30318=4516c5951e84d5e6f432056ef278c1e2486b2f9b)
 has an untested patch for the browser parts. I plan to write the other
 ones and test those over the weekened. Shouldn't be too hard (famous last
 words).
 >
 > That patch is still good to go, I think.

 You're becoming an Android developer :)

 I rebased this patch and merged it as commit
 `002d35ffa55518c5517c2be746da2678a70da47a` on `tor-
 browser-68.9.0esr-10.0-1`.

 > The other patches are:
 >
 > 1) for `tor-andrdoid-service` (https://gitweb.torproject.org/user/gk
 /tor-android-
 service.git/commit/?h=bug_30318=ecc251d0a73f7e2034a271efd28036a0108b8688)

 I merged this patch directly (same commit hash).

 >
 > 2) for `tor-onion-proxy-library` see attachment.

 I included this patch in commit `4d57755506496d02107e4dc2adf38252032df383`
 on `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen201904, ex-  |
  sponsor-19, tbb-10.0a1 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by sysrqb):

 * status:  needs_review => closed
 * keywords:
 tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen201904, ex-
 sponsor-19
 =>
 tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen201904, ex-
 sponsor-19, tbb-10.0a1
 * resolution:   => fixed


Comment:

 Replying to [comment:43 cohosh]:
 > Woo okay here's a working patch with those fixes, thanks:
 https://gitweb.torproject.org/user/cohosh/tor-browser-
 
build.git/commit/?h=snowflake_android=5ef430adf7b7232566955aba86695ea88fd3b642

 Thanks! I rebased this and merged it with commit
 `853e75e9276432a39153db2e3fa54375af9b8822` on `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29368 [Metrics/Onionperf]: Add single onion service mode

[Tor Bug Tracker & Wiki]

#29368: Add single onion service mode
---+
 Reporter:  irl|  Owner:  phw
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by phw):

 * cc: metrics-team (added)
 * owner:  metrics-team => phw
 * status:  reopened => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34347 [Applications/Tor Browser]: The Tor Network part on the onboarding is not new anymore

[Tor Bug Tracker & Wiki]

#34347: The Tor Network part on the onboarding is not new anymore
---+--
 Reporter:  gk |  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  TorBrowserTeam202005R, tbb-10.0a1  |  Actual Points:
Parent ID: | Points:
 Reviewer:  acat, mcs  |Sponsor:
---+--
Changes (by sysrqb):

 * status:  needs_review => closed
 * keywords:  TorBrowserTeam202005R => TorBrowserTeam202005R, tbb-10.0a1
 * resolution:   => fixed


Comment:

 Thanks! Merged with commit `0d7f107b512ba82d57cc20c791aea402a499b584` on
 `tor-browser-68.9.0esr-10.0-1`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29369 [Metrics/Onionperf]: Fix message logging and filtering

[Tor Bug Tracker & Wiki]

#29369: Fix message logging and filtering
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.4
Parent ID:  #33321 | Points:  1.0
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Without the date prefix the output file written at midnight will overwrite
 the output file from one day before. Do you prefer if I write this patch
 early next week and you review it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34257 [Metrics/Onionperf]: Analyze unusual distribution of time to extend to first hop in circuit

[Tor Bug Tracker & Wiki]

#34257: Analyze unusual distribution of time to extend to first hop in circuit
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 As discussed at this week's team meeting I updated the alternative Hong
 Kong instance to run the #34303 patch and just uploaded 1 day of
 measurements [https://people.torproject.org/~karsten/op-hk-ec2-onionperf-
 data-2020-05-29.tar.xz here] (18.5M) for dennis.jackson (and others) to
 look.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34315 [Applications/Tor Browser]: avoid reading policies from /etc/firefox on Linux

[Tor Bug Tracker & Wiki]

#34315: avoid reading policies from /etc/firefox on Linux
---+
 Reporter:  mcs|  Owner:  mcs
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  TorBrowserTeam202005R, tbb-10.0a1  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by sysrqb):

 * keywords:  TorBrowserTeam202005R => TorBrowserTeam202005R, tbb-10.0a1
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks! Patch looks good to me. Merged onto `tor-browser-68.9.0esr-10.0-1`
 with commit `62b2d85bf2b29f90f554fb53079d30fd692e6d64`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34351 [Internal Services/Service - git]: Please delete builders/tor-browser-build branch snowflake_android

[Tor Bug Tracker & Wiki]

#34351: Please delete builders/tor-browser-build branch snowflake_android
-+
 Reporter:  sysrqb   |  Owner:  tor-gitadm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 {{{
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA512

 Please delete branch snowflake_android from
 repository builders/tor-browser-build.git

 Fri 29 May 2020 07:00:00 PM GMT
 -BEGIN PGP SIGNATURE-

 iQEzBAEBCgAdFiEEo4znE8duGsmMUJcuHp029Ma9dU4FAl7RXxUACgkQHp029Ma9
 dU6o4AgAmDLypv2R2t45+aCEyIVIvv5pnaxTGQudxIpghAu5ikaW2C3vhoMLAVro
 rteN2FoS3UW/KiTrCVIYKnbR/+sRj2EurU0WxzkMI4W2xXpYt2QsEagks1mFnvqg
 yHGQoDC9EwPeuRB20aIFw0KNjymCbHNO9T5kXlsYCdHM53SJ71MYsJJl3yl/3SSA
 NYXODAsSxCRefFMAjRCqIWOC0nEcQbq8PWru33w/Ckt4hvavAPuLuWUjxlq/c7z9
 Bqj487Wx0+up2viPLz3xRC9cZOVoyFDObGuQinLVneoOxGbCwnQxkauFq1nZzTZq
 shT0HctKiL/MO9GDAvJRXVjIxhU46Q==
 =yCey
 -END PGP SIGNATURE-
 }}}

 Sigh. Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34202 [Applications/Tor Browser]: Remove xz (LZMA) project for now

[Tor Bug Tracker & Wiki]

#34202: Remove xz (LZMA) project for now
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam202005R,  |  Actual Points:
  GeorgKoppen202005, tbb-10.0a1  |
Parent ID:   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005 => tbb-rbm,
 TorBrowserTeam202005R, GeorgKoppen202005, tbb-10.0a1
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks okay to me. Thanks! Merged with commit
 `aa0a75cb536fe257bc3c74f694fa362ff6194b57` on `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34350 [Applications/GetTor]: Stop logging all successful databse queries in GetTor

[Tor Bug Tracker & Wiki]

#34350: Stop logging all successful databse queries in GetTor
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  phw  |Sponsor:
-+--
Changes (by cohosh):

 * status:  assigned => needs_review
 * reviewer:   => phw


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34350 [Applications/GetTor]: Stop logging all successful databse queries in GetTor

[Tor Bug Tracker & Wiki]

#34350: Stop logging all successful databse queries in GetTor
-+
 Reporter:  cohosh   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 This is another log message that isn't helpful and fills up our logs.
 Here's a patch: https://gitlab.torproject.org/tpo/anti-censorship/gettor-
 project/gettor/-/merge_requests/12

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34350 [Applications/GetTor]: Stop logging all successful databse queries in GetTor

[Tor Bug Tracker & Wiki]

#34350: Stop logging all successful databse queries in GetTor
-+--
 Reporter:  cohosh   |  Owner:  cohosh
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by cohosh):

 * owner:  (none) => cohosh
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34286 [Applications/GetTor]: gettor appears to be in an email loop war with a .sk address

[Tor Bug Tracker & Wiki]

#34286: gettor appears to be in an email loop war with a .sk address
-+
 Reporter:  arma |  Owner:  cohosh
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  phw  |Sponsor:
-+
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged and deployed at `2020-05-29T19:04:49+`.

 Seems to be fixed now :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34349 [Internal Services/Tor Sysadmin Team]: Install weechat on chives please

[Tor Bug Tracker & Wiki]

#34349: Install weechat on chives please
-+-
 Reporter:  pastly   |  Owner:  tpa
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 It's my preferred IRC client and it's packaged for Debian.

 If it helps motivate the request, I'm going to work on a rewrite of a IRC
 mod bot again. This time as a weechat plugin.

 XOXO

 pastly

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34348 [Internal Services/Tor Sysadmin Team]: Please update gpg key for boklm in ldap

[Tor Bug Tracker & Wiki]

#34348: Please update gpg key for boklm in ldap
-+-
 Reporter:  boklm|  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * Attachment "3E39CEABFC69F6F7-20200529.asc" added.


--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34348>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34348 [Internal Services/Tor Sysadmin Team]: Please update gpg key for boklm in ldap

[Tor Bug Tracker & Wiki]

#34348: Please update gpg key for boklm in ldap
-+-
 Reporter:  boklm|  Owner:  tpa
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Please update my gpg key, for the updated expiration date on subkeys.

 I will attach the updated key to this ticket.

 Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #21549, #22919, #26529, #27604, ...

[Tor Bug Tracker & Wiki]

Batch modification to #21549, #22919, #26529, #27604, #28803, #30767, #32220, 
#32303, #32414, #32505, #32618 by gk:


Comment:
No backport for those tickets/fixes. They will emerge with 9.5.

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29369 [Metrics/Onionperf]: Fix message logging and filtering

[Tor Bug Tracker & Wiki]

#29369: Fix message logging and filtering
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.4
Parent ID:  #33321 | Points:  1.0
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by phw):

 Replying to [comment:8 karsten]:
 > I didn't work on the implementation yet and would like to leave this to
 others, also as a way to sanity check the concept. If I were to implement
 this I'd probably avoid using the `date_filter` parameter when doing the
 nightly analysis and introduce some sort of `date_prefix` parameter. We
 should just use that `date_filter` by default for all analysis files, and
 we might consider deprecating the `date_prefix` parameter in the user
 interface. When testing this, we'll have to ensure that it works for the
 nightly case as well as the reprocessing case.
 [[br]]
 I'm afraid I don't follow. Don't we accomplish our goal by simply omitting
 the date filter when analysing the results? I don't understand what the
 date prefix should do here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34219 [Applications/Tor Browser]: Enable ZSTD support properly for Android

[Tor Bug Tracker & Wiki]

#34219: Enable ZSTD support properly for Android
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam202005R,  |  Actual Points:
  GeorgKoppen202005, tbb-10.0a1  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005 => tbb-rbm,
 TorBrowserTeam202005R, GeorgKoppen202005, tbb-10.0a1
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good to me. Thanks!

 (top is from 9.5a13)
 {{{
 Tor version 0.4.3.5 (git-5ceb60e5ca61fec9).
 Library versionsCompiledRuntime
 Libevent2.1.11-stable   2.1.11-stable
 OpenSSL 1.1.1g  1.1.1g
 Zlib1.2.11  1.2.11

 Tor version 0.4.3.5 (git-5ceb60e5ca61fec9).
 Library versionsCompiledRuntime
 Libevent2.1.11-stable   2.1.11-stable
 OpenSSL 1.1.1g  1.1.1g
 Zlib1.2.11  1.2.11
 Libzstd 1.4.4   1.4.4
 }}}

 Merged onto `master` with commit
 `ede6ffb414a8684f5dab8615836504acf2774734`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30318 [Applications/Tor Browser]: Integrate snowflake into mobile Tor Browser alpha

[Tor Bug Tracker & Wiki]

#30318: Integrate snowflake into mobile Tor Browser alpha
---+---
 Reporter:  gk |  Owner:  tbb-team
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam202005R  |  Actual Points:
Parent ID:  #19001 | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---

Comment (by cohosh):

 I started using this build as my default browser on mobile. So far, I've
 noticed the following:

 - It works great when I'm on wifi. I can browse to sites pretty quickly,
 and continues to work when I leave and come back later :)

 - I still haven't gotten it to work on my cell provider's data network and
 am getting the following error messages:
 {{{
 - Starting Tor client… complete.
 - NOTICE: Bootstrapped 1% (conn_pt): Connecting to pluggable transport
 - NOTICE: Bootstrapped 2% (conn_done_pt): Connected to pluggable transport
 - NOTICE: Bootstrapped 10% (conn_done): Connected to a relay
 - NOTICE: Unknown line received by managed proxy (ice ERROR: 2020/05/29
 17:00:19 error processing checkCandidatesTimeout handler the agent is
 closed).
 - NOTICE: Delaying directory fetches: No running bridges
 - TorService is shutting down
 }}}

 This has happened every time I've tried to connect on data so far, and the
 `ice Error` bit makes me think it's not just the NAT problem from #33666.
 I wonder whether UDP/STUN/P2P traffic is disabled on data connections by
 default?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33947 [Core Tor/sbws]: Compare sbws and Torflow

[Tor Bug Tracker & Wiki]

#33947: Compare sbws and Torflow
-+-
 Reporter:  juga |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws: 1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, GeorgKoppen202005  |  Actual Points:
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by juga):

 * Attachment "20200523_bw_comparative_10.csv" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33947 [Core Tor/sbws]: Compare sbws and Torflow

[Tor Bug Tracker & Wiki]

#33947: Compare sbws and Torflow
-+-
 Reporter:  juga |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:  sbws: 1.1.0
 Severity:  Normal   | Resolution:
 Keywords:  sbws-roadmap, GeorgKoppen202005  |  Actual Points:
Parent ID:  #33121   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 Following the previous reasoning and data, i implemented other function to
 find over/under-weighted relays.
 I created a modified version of the previous function.
 I attach a new csv file and comment in this ticket due to repeated data
 and comments.
 This is what i found:

 Overweighted relays (#33350)
 

 - maatuska was still overweighting 346 relays while sbws ony 3
 - the 3 sbws cases are due to mising the descriptor average bandwidth
 - all the maatuska cases are missing descriptor observed bandwidth except
 for one relay that have higher conensus and observed bandwidth than
 longclaw, probably cause the stored descriptor was old

 Reasons why i think this happend:
 - maatuska version was not updating correctly descriptors (#30733, #33570)
 what was making skip scaling for many relays that were still included in
 the bandwidth file to vote (#33832, this would be solved by a commit in
 #33832)
 - rounding before limiting to the maximum was probably a problem too
 (would be solved by a commit in #33832 too)
 - these errors were accumulating until we got more torflows cause final
 bandwidth depends on the previous consensus bandwidth

 Underweighted relays (#33775)
 -

 https://trac.torproject.org/projects/tor/ticket/33775

 - maatuska was still underweighting 70 relays while longclaw none
 - it seems that the consensus bandwidth maatuska has for those relays is
 lower than sbws

 Reasons:
 - maybe cause using exits with low capacity (#33009)
 - again not updating often/correctly descriptors and keeping previous low
 values
 - and making them accumulate

 Regarding the total consenus weight, it can be seen here now all bwauths
 are close: https://metrics.torproject.org/totalcw.png?start=2019-12-18

 There is no code to review but someone should check whether my reasoning
 makes sense ;)

 From the list of things to check in this ticket, it would be still missing
 #33198

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34278 [Circumvention/Snowflake]: Handling connection failures.

[Tor Bug Tracker & Wiki]

#34278: Handling connection failures.
-+
 Reporter:  HashikD  |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake-mobile |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by HashikD):

 Hey! what is considered as a connection termination or failure of the
 client for (or client leaving) Snowflake proxy?

 What is the final state that I should look for to mark the end of the
 connection for WebRTC; to go ahead and close the connections and restart a
 the SDP offer request from the broker?

 In onIceConnectionChange what is the final state that I should look for:
 [https://lists.w3.org/Archives/Public/public-
 webrtc/2012Sep/att-0097/WebRTCstatesandcallbacks.pdf here are the list of
 state]

 I am getting mixed answers, sometimes it's logging "Failed" as the final
 state other times "closed".

 Feel free to ask for clarification if I am not clear enough.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34347 [Applications/Tor Browser]: The Tor Network part on the onboarding is not new anymore

[Tor Bug Tracker & Wiki]

#34347: The Tor Network part on the onboarding is not new anymore
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:| Points:
 Reviewer:  acat, mcs |Sponsor:
--+--

Comment (by acat):

 Sorry, I also missed that in the review. Tested this by repackaging the
 onboarding xpi, and works fine for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33939 [Applications/Tor Browser]: Decide which components of Fenix to rip out, disable, or use

[Tor Bug Tracker & Wiki]

#33939: Decide which components of Fenix to rip out, disable, or use
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam202004  |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
  |  Sponsor58-must
--+

Comment (by gk):

 Another thought I had: Maybe it's smarter to start with the things we
 actually think we have to/should include (for the basic proxy
 bypasses/fingerprinting checks mentioned in comment:6) so we have a base
 to build upon and move afterwards to the "Must Audit" pieces. If we don't
 have time for those, then we might try to neuter them meanwhile by
 disabling them etc.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33939 [Applications/Tor Browser]: Decide which components of Fenix to rip out, disable, or use

[Tor Bug Tracker & Wiki]

#33939: Decide which components of Fenix to rip out, disable, or use
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam202004  |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
  |  Sponsor58-must
--+

Comment (by gk):

 Replying to [comment:8 gk]:
 > Replying to [comment:6 sysrqb]:
 > > Replying to [comment:5 gk]:
 > > > Thanks, that's a good start. Two thoughts while skimming the list (I
 did not look carefully yet)
 > > >
 > > > 1) At least the progressive web apps (PWA) part should probably be
 in the Must Audit section. We even have a ticket for that already: #25845
 :)
 > >
 > > That's probably a smart thing, yes. PWA is only available in non-
 private browsing mode in Fennec, but we should audit it in Fenix. Indeed,
 PWA is available in private browsing mode in Fenix...
 > >
 > > >
 > > > 2) I was wondering how the dependencies those dependencies have
 would influence where we put them category-wise. So, starting with one
 layer seems good to me but I feel we might need to dig deeper to have a
 final assessment. One of the things I am already wary of is getting all
 the application-services parts roped in "for free". Not all components are
 probably needing that (I've not checked) but I bet some would move into
 the Must Audit part alone due to that. And there's probably other stuff
 that is bubbling in this morass, under the quiet surface... :)
 > >
 > > Ideally, we should audit everything, but I don't think that is
 realistic. We should quickly look at all components in the `Include`
 category and confirm they do not make any network calls or expose
 personal/device information. I placed them in this category purely based
 on my assumption of how these components are implemented.
 >
 > Just to be clear: I was _not_ saying we need to audit everything (yes,
 ideally we would), just that it might be worth looking in particular at
 the Mozilla dependencies of those dependencies to figure out whether
 things should be re-categorized so that we have a closer second look on
 components that really need it (even if the dependency check you did or
 the assumptions you had indicated otherwise).

 To give a practical example for that: if you look at Fenix you see that
 it's building code that should do something useful in case crashes are
 happening. Now, that depends on `android-components`' `lib-crash`.
 However, if you look at the `build.gradle` file for that one you see:
 {{{
 compileOnly Gecko.geckoview_nightly
 }}}
 But we won't be basing Fenix on `geckoview_nightly` anytime soon. Thus,
 it's reasonable to move this component out of the "Must Audit" to
 something like "Disable" for the current purposes just by looking at the
 second level dependencies and save time for auditing other stuff. But
 that's obviously not a one way direction. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31129 [Applications/Tor Browser]: Use Debian 10 for our macOS container images

[Tor Bug Tracker & Wiki]

#31129: Use Debian 10 for our macOS container images
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, GeorgKoppen202005,  |  Actual Points:
  TorBrowserTeam202005R, , tbb-10.0a1|
Parent ID:  #31127   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-rbm, GeorgKoppen202005, TorBrowserTeam202005R => tbb-rbm,
 GeorgKoppen202005, TorBrowserTeam202005R, , tbb-10.0a1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31128 [Applications/Tor Browser]: Use Debian 10 for our Windows container images

[Tor Bug Tracker & Wiki]

#31128: Use Debian 10 for our Windows container images
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam202005R,  |  Actual Points:
  GeorgKoppen202005, tbb-10.0a1  |
Parent ID:  #31127   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005 => tbb-rbm,
 TorBrowserTeam202005R, GeorgKoppen202005, tbb-10.0a1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30586 [Metrics/Onionperf]: requirements are not included in setup.py

[Tor Bug Tracker & Wiki]

#30586: requirements are not included in setup.py
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.45
Parent ID:  #33321 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by acute):

 Replying to [comment:18 karsten]:
 > Almost there! Two further questions:
 >
 >  1. What if I want to run `onionperf` from another directory than
 `onionperf/onionperf`? I tried passing another relative or absolute path
 to `PYTHONPATH=`, but all I get is: `/usr/bin/python3: can't find
 '__main__' module in 'onionperf'`.
 You also need to specify the absolute/relative path to the onionperf
 script as well in that case, for example:

 `PYTHONPATH=/home/dev/onionperf python3
 /home/dev/onionperf/onionperf/onionperf`

 Just as a note, you can copy the script itself anywhere else on the system
 and this will still work, as long as you point the PYTHONPATH to the
 onionperf directory.
 {{{
 cp /home/dev/onionperf/onionperf/onionperf /home/dev/op
 PYTHONPATH=/home/dev/onionperf python3 /home/dev/op
 }}}
 or even directly:
 {{{
 PYTHONPATH=/home/dev/onionperf /home/dev/op
 }}}
 ...since the python3 interpreter is in a sensible place anyway.
 Hope this helps!

 >
 >  2. Do you mind posting a new branch with phw's branch rebased to
 current master and with your two patches (the one on #33433 and the one
 above) on top? I would do this myself, but I'm having trouble applying
 your patches, and I don't want to claim authorship of these commits.

 This is now here:
 https://github.com/ana-cc/onionperf/tree/acute/30586

 Thank you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31129 [Applications/Tor Browser]: Use Debian 10 for our macOS container images

[Tor Bug Tracker & Wiki]

#31129: Use Debian 10 for our macOS container images
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, GeorgKoppen202005,  |  Actual Points:
  TorBrowserTeam202005R  |
Parent ID:  #31127   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks! I added it with commit `96c528a80b689becbd8faca040db15c48543ce8f`
 onto `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31128 [Applications/Tor Browser]: Use Debian 10 for our Windows container images

[Tor Bug Tracker & Wiki]

#31128: Use Debian 10 for our Windows container images
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam202005R,  |  Actual Points:
  GeorgKoppen202005  |
Parent ID:  #31127   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks! Exciting. The patch looks sane. I added it with commit
 `e1accd273fd41b6ede9a3690d1a7b5206a5edb5d` onto `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34311 [Core Tor/Tor]: Space out code in relay.c

[Tor Bug Tracker & Wiki]

#34311: Space out code in relay.c
--+
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34347 [Applications/Tor Browser]: The Tor Network part on the onboarding is not new anymore

[Tor Bug Tracker & Wiki]

#34347: The Tor Network part on the onboarding is not new anymore
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:| Points:
 Reviewer:  acat, mcs |Sponsor:
--+--

Comment (by sysrqb):

 (but, that patch is not tested. I'll test it soon)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34347 [Applications/Tor Browser]: The Tor Network part on the onboarding is not new anymore

[Tor Bug Tracker & Wiki]

#34347: The Tor Network part on the onboarding is not new anymore
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:| Points:
 Reviewer:  acat, mcs |Sponsor:
--+--
Changes (by sysrqb):

 * keywords:   => TorBrowserTeam202005R
 * status:  new => needs_review
 * reviewer:   => acat, mcs


Comment:

 I think this should do it.

 https://gitweb.torproject.org/user/sysrqb/tor-
 browser.git/commit/?h=bug34347_00=c64571e507f1d6868f6a08d807489d6b34063af1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34347 [Applications/Tor Browser]: The Tor Network part on the onboarding is not new anymore

[Tor Bug Tracker & Wiki]

#34347: The Tor Network part on the onboarding is not new anymore
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 For 9.0 we added a "New" item to the Tor Network part explaining our
 changes on `about:preferences`. But that's not new anymore. :) We should
 have removed that for 9.5 but it's not too late.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31660 [Applications/Tor Browser]: Revise onboarding to take new Firefox experience into account

[Tor Bug Tracker & Wiki]

#31660: Revise onboarding to take new Firefox experience into account
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, tbb-10, |  Actual Points:
  ReleaseTrainMigration  |
Parent ID:  #33658   | Points:  4
 Reviewer:   |Sponsor:
 |  Sponsor58-can
-+-
Changes (by sysrqb):

 * keywords:  ux-team, tbb-9.5, TorBrowserTeam202005R, ReleaseTrainMigration
 => ux-team, tbb-10, ReleaseTrainMigration


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29223 [Core Tor/Tor]: List canonical abbreviations to use in Tor functions and identifiers

[Tor Bug Tracker & Wiki]

#29223: List canonical abbreviations to use in Tor functions and identifiers
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  needs_information
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doc, s31-docs 042-can  |  Actual Points:  0.9
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by asn):

 * status:  needs_review => needs_information


Comment:

 I'm inclined to NACK this branch. I think such a big list of abbreviations
 will be hard to maintain and use both for us and for volunteers. Also I
 feel like the benefit does not outweight the overhead of enforcing the
 abbreviations and checking whether an abbreviation exists everytime you
 want to write code.

 Perhaps as a way to do short-term progress here would be to identify a
 bunch of important abbreviations that we get wrong often and fix those.

 And then if in the future this abbreviation inconsistency issue becomes a
 problem, we can revisit the list from comment:13 and see how to make it
 useful.

 Or we can ignore this ticket for now (which honestly would be my
 approach).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34185 [Internal Services/Tor Sysadmin Team]: ganeti clusters don't like automatic upgrades

[Tor Bug Tracker & Wiki]

#34185: ganeti clusters don't like automatic upgrades
-+-
 Reporter:  anarcat  |  Owner:  hiro
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Major| Resolution:
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by hiro):

 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961746 opened bug with
 upstream yesterday.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34261 [Metrics/Onionperf]: Remove pandas warning when using bullseye version of pandas

[Tor Bug Tracker & Wiki]

#34261: Remove pandas warning when using bullseye version of pandas
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.2
 Reviewer: |Sponsor:  Sponsor59
---+--
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Tried out the suggested fix from the warning message with old and new
 pandas version, and it worked. Please review
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-34261=eaa9f71d00033d2301e09f7963719dd98da6d2ae
 commit eaa9f71 in my task-34261 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34261 [Metrics/Onionperf]: Remove pandas warning when using bullseye version of pandas

[Tor Bug Tracker & Wiki]

#34261: Remove pandas warning when using bullseye version of pandas
---+---
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.2
 Reviewer: |Sponsor:  Sponsor59
---+---
Changes (by karsten):

 * owner:  metrics-team => karsten
 * status:  new => accepted


Comment:

 Taking a look.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33939 [Applications/Tor Browser]: Decide which components of Fenix to rip out, disable, or use

[Tor Bug Tracker & Wiki]

#33939: Decide which components of Fenix to rip out, disable, or use
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam202004  |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
  |  Sponsor58-must
--+

Comment (by gk):

 Replying to [comment:6 sysrqb]:
 > Replying to [comment:5 gk]:
 > > Thanks, that's a good start. Two thoughts while skimming the list (I
 did not look carefully yet)
 > >
 > > 1) At least the progressive web apps (PWA) part should probably be in
 the Must Audit section. We even have a ticket for that already: #25845 :)
 >
 > That's probably a smart thing, yes. PWA is only available in non-private
 browsing mode in Fennec, but we should audit it in Fenix. Indeed, PWA is
 available in private browsing mode in Fenix...
 >
 > >
 > > 2) I was wondering how the dependencies those dependencies have would
 influence where we put them category-wise. So, starting with one layer
 seems good to me but I feel we might need to dig deeper to have a final
 assessment. One of the things I am already wary of is getting all the
 application-services parts roped in "for free". Not all components are
 probably needing that (I've not checked) but I bet some would move into
 the Must Audit part alone due to that. And there's probably other stuff
 that is bubbling in this morass, under the quiet surface... :)
 >
 > Ideally, we should audit everything, but I don't think that is
 realistic. We should quickly look at all components in the `Include`
 category and confirm they do not make any network calls or expose
 personal/device information. I placed them in this category purely based
 on my assumption of how these components are implemented.

 Just to be clear: I was _not_ saying we need to audit everything (yes,
 ideally we would), just that it might be worth looking in particular at
 the Mozilla dependencies of those dependencies to figure out whether
 things should be re-categorized so that we have a closer second look on
 components that really need it (even if the dependency check you did or
 the assumptions you had indicated otherwise).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34320 [Applications/Tor Browser]: TMPDIR should be set in rbm so all scripts in tor-browser-build use it if needed (was: fetch-gradle-dependencies should respect tmp_dir)

[Tor Bug Tracker & Wiki]

#34320: TMPDIR should be set in rbm so all scripts in tor-browser-build use it 
if
needed
-+-
 Reporter:  gk   |  Owner:  boklm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen202005,  |  Actual Points:
  TorBrowserTeam202005   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => assigned
 * owner:  gk => boklm


Comment:

 Replying to [comment:2 boklm]:
 > The problem with using `tmp_dir` there is that the `var/build_id` of
 projects using `fetch-gradle-dependencies` will now depend on the value of
 `tmp_dir`. So for example moving the path of the `tor-browser-build`
 directory (where the default `tmp_dir` is located) will cause those
 projects to be rebuilt.

 Good catch. I think I hit something like that when rebuilding without my
 patch and wondered what happened. :)

 [snip]

 >
 > Alternatively, we could patch rbm to always set `$TMPDIR` when running
 scripts. I think this patch would do that (but I have not tested it yet. I
 can make a real patch if you think that's a good idea.):
 > {{{
 > diff --git a/lib/RBM.pm b/lib/RBM.pm
 > index 7cc9e24..50920af 100644
 > --- a/lib/RBM.pm
 > +++ b/lib/RBM.pm
 > @@ -461,8 +461,9 @@ sub run_script {
 >  my ($project, $cmd, $f) = @_;
 >  $f //= \_exec;
 >  my @res;
 > +local $ENV{TMPDIR} = get_tmp_dir($project);
 >  if ($cmd =~ m/^#/) {
 > -my (undef, $tmp) = File::Temp::tempfile(DIR =>
 get_tmp_dir($project));
 > +my (undef, $tmp) = File::Temp::tempfile(DIR => $ENV{TMPDIR});
 >  path($tmp)->spew_utf8($cmd);
 >  chmod 0700, $tmp;
 >  @res = $f->($tmp);
 > }}}

 That seems like the right approach to me, please do. :) I guess we could
 clean up the `dmg2mar` script then as well?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs