Re: [tor-bugs] #24469 [Core Tor/Tor]: Cannibalizing a circuit should check that first hop is in our guard state

[Tor Bug Tracker & Wiki]

#24469: Cannibalizing a circuit should check that first hop is in our guard 
state
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-circuit   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by arma):

 For posterity: turns out this patch had a bug (#34303), where it assumed
 that UseEntryGuards is 1, i.e. that every circuit is trying to start at a
 guard. The result was that Tor would stop considering its preemptively
 built circuits as usable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34257 [Metrics/Onionperf]: Analyze unusual distribution of time to extend to first hop in circuit

[Tor Bug Tracker & Wiki]

#34257: Analyze unusual distribution of time to extend to first hop in circuit
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by arma):

 Neat stuff. I haven't looked into all the data, but here are some first-
 thought theories, to make sure you've considered them:

 (1) When you're establishing the first hop of the circuit, you might need
 to establish a TCP connection and ORConn with the first relay. That
 process is a lot of extra round-trips -- first to do TCP, then to do TLS,
 then to do Tor's v3 handshake with netinfo cells and so on. In fact, you
 might even see the bimodal distributions that Dennis points out, where a
 few circuits build quickly because there's already an underlying ORConn in
 place, and most of them build slowly because you need to set up the ORConn
 too. 100ms latency to the guard, amplified by n round-trips, could make a
 real difference. That's part of why we build preemptive circuits, because
 it means building preemptive ORConns too.

 (2) Guards might be overloaded with CREATE cells, causing them to respond
 more slowly to circuit create attempts than other relays do. This overload
 might happen because they have a higher consensus weight than other relays
 (which is what helped get them the Guard flag), and thus attract more
 users.

 (2a) Alternatively, another difference for guards is that they have to
 handle many more TLS handshakes because they get direct connections from
 clients. We've somewhat-recently changed the parameters for when we expire
 these TLS conns (#17592, 0.3.1.1-alpha, prop#251). Maybe these more
 frequent TLS conns are using enough of their CPU that they are worse at
 handling CREATE cells. In theory the CREATE cells are handled in worker
 threads though, so there shouldn't be direct competition. But maybe
 they're not tuned well, so the worker threads don't keep up well when the
 main thread is distracted.

 I don't think (2) or (2a) look like good explanations though, because they
 should be happening to the dutch onionperf too. But (1) looks plausible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34257 [Metrics/Onionperf]: Analyze unusual distribution of time to extend to first hop in circuit

[Tor Bug Tracker & Wiki]

#34257: Analyze unusual distribution of time to extend to first hop in circuit
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by dennis.jackson):

 Not at all!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34257 [Metrics/Onionperf]: Analyze unusual distribution of time to extend to first hop in circuit

[Tor Bug Tracker & Wiki]

#34257: Analyze unusual distribution of time to extend to first hop in circuit
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Do you mind if I turn off the alternative Hong Kong instance then?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34257 [Metrics/Onionperf]: Analyze unusual distribution of time to extend to first hop in circuit

[Tor Bug Tracker & Wiki]

#34257: Analyze unusual distribution of time to extend to first hop in circuit
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by dennis.jackson):

 I took a look of the measurements but they looked about the same. I've
 fired up two nodes in Hong Kong on GCP to collect some ground truth data
 without going through OnionPerf. One node is running 0.4.2.7, the other is
 running 0.2.9.14.  I plan to run them for about 24 hours and will report
 back.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34352 [Metrics/Onionperf]: Bump OP version in setup.py

[Tor Bug Tracker & Wiki]

#34352: Bump OP version in setup.py
---+--
 Reporter:  acute  |  Owner:  metrics-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Looks good to me. Merged. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29368 [Metrics/Onionperf]: Add single onion service mode

[Tor Bug Tracker & Wiki]

#29368: Add single onion service mode
---+
 Reporter:  irl|  Owner:  phw
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  needs_review => needs_revision
 * reviewer:  karsten =>


Comment:

 I looked at the combined diff of phw's and acute's changes, and I think
 it's good to go in.

 phw, do you want to review acute's changes, see if you like them,
 squash/rebase to master, and post a new branch here? Setting to
 needs_review only for remaining Git work, not for any required changes to
 the code (from my point of view).

 Thanks to both of you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29368 [Metrics/Onionperf]: Add single onion service mode

[Tor Bug Tracker & Wiki]

#29368: Add single onion service mode
---+
 Reporter:  irl|  Owner:  phw
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  2
 Reviewer:  karsten|Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * reviewer:   => karsten


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:  0.5
Parent ID:  #33327 | Points:  0.3
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  merge_ready => closed
 * points:   => 0.3
 * resolution:   => fixed
 * actualpoints:   => 0.5


Comment:

 Thanks for the detailed review! Merged to master as
 
[https://gitweb.torproject.org/onionperf.git/commit/?id=dbd7b5040c97f12ca79e23a72a7172696de6f6e1
 commit dbd7b50].

 Adding my 0.5 actual points and the 0.3 points I had originally estimated
 and not written down here. Feel free to add your actual points for the
 review. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29369 [Metrics/Onionperf]: Fix message logging and filtering

[Tor Bug Tracker & Wiki]

#29369: Fix message logging and filtering
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.4
Parent ID:  #33321 | Points:  1.0
 Reviewer:  phw|Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  assigned => needs_review
 * reviewer:   => phw


Comment:

 Not quite, but it's going in the direction I had in mind. Please take a
 look at
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-29369=251f4576e97287b00a1136c08ef3fde5de92c901
 squash commit 251f457 in my task-29369 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+

Comment (by acute):

 The code reads well, and the graphs and csv files produced are as
 expected. Setting to ready_for_merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34352 [Metrics/Onionperf]: Bump OP version in setup.py

[Tor Bug Tracker & Wiki]

#34352: Bump OP version in setup.py
---+--
 Reporter:  acute  |  Owner:  metrics-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by acute):

 * Attachment "0001-Bumps-OP-version-to-0.3.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34352 [Metrics/Onionperf]: Bump OP version in setup.py

[Tor Bug Tracker & Wiki]

#34352: Bump OP version in setup.py
---+--
 Reporter:  acute  |  Owner:  metrics-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 I ran into a weird bug where installing the latest OP on a system that
 already has an installation from a version prior to commit
 
[https://gitweb.torproject.org/onionperf.git/commit/?id=de26da351d859b64a35b81eb2d07dbf325a86960
 de26da3] results in the following error message:

 {{{
 $ onionperf
 Traceback (most recent call last):
   File "/usr/local/bin/onionperf", line 4, in 
 __import__('pkg_resources').run_script('OnionPerf==0.2rc0',
 'onionperf')
   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line
 667, in run_script
 self.require(requires)[0].run_script(script_name, ns)
   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line
 1452, in run_script
 raise ResolutionError(
 pkg_resources.ResolutionError: Script 'scripts/onionperf' not found in
 metadata at None
 }}}

 It looks like `setuptools` is renaming the OnionPerf version from
 `0.2.pre` (as it is currently specified in `setup.py`) to `0.2rc0` when
 installing, and they somehow conflict. I've tested this can be solved by
 bumping the version to 0.3 in `setup.py` (patch attached).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34250 [Applications/Tor Browser]: Fix torbutton noscript-control race condition

[Tor Bug Tracker & Wiki]

#34250: Fix torbutton noscript-control race condition
--+-
 Reporter:  acat  |  Owner:  acat
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by rustybird):

 Replying to [ticket:34250 acat]:
 > In that ticket, "pageshow" was added `for a slightly more graceful
 failure mode in case Torbutton somehow misses NoScript startup`.

 This was for Tor Browser 8.0.x, when Torbutton was still an extension.
 IIRC the situation I had in mind was that the user had, maybe by mistake,
 disabled and then re-enabled Torbutton. (But given that Torbutton wasn't a
 restartless extension, the only way that even makes marginal sense to me
 now is on the off change that re-enabling causes some sort of delay during
 the next startup.) Anyway, kill that cruft with fire. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33433 [Metrics/Onionperf]: Add error handling for older stem versions

[Tor Bug Tracker & Wiki]

#33433: Add error handling for older stem versions
---+
 Reporter:  acute  |  Owner:  metrics-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID:  #33321 | Points:  0.5
 Reviewer:  karsten|Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * actualpoints:   => 0.1


Comment:

 Adding my 0.1 actual points

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30586 [Metrics/Onionperf]: requirements are not included in setup.py

[Tor Bug Tracker & Wiki]

#30586: requirements are not included in setup.py
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  1.15
Parent ID:  #33321 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * actualpoints:  0.85 => 1.15


Comment:

 Adding my 0.3 actual points to yours :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33433 [Metrics/Onionperf]: Add error handling for older stem versions

[Tor Bug Tracker & Wiki]

#33433: Add error handling for older stem versions
---+
 Reporter:  acute  |  Owner:  metrics-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33321 | Points:  0.5
 Reviewer:  karsten|Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 This is now merged together with #30586. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30586 [Metrics/Onionperf]: requirements are not included in setup.py

[Tor Bug Tracker & Wiki]

#30586: requirements are not included in setup.py
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.85
Parent ID:  #33321 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:  0.45 => 0.85


Comment:

 Thanks a lot for the detailed explanation of how `PYTHONPATH` works. I had
 somehow assumed that the `onionperf` script would be found by specifying
 the OnionPerf directory in `PYTHONPATH`. When specifying both paths it
 works as expected.

 Thanks, also, for rebasing and providing all patches as a single path.
 That's quite a bit easier for me to review and merge.

 Pushed to master. Finally! Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34303 [Core Tor/Tor]: Find out why onion service measurements have gotten slower

[Tor Bug Tracker & Wiki]

#34303: Find out why onion service measurements have gotten slower
--+
 Reporter:  karsten   |  Owner:  karsten
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor59-must
--+
Changes (by arma):

 * status:  accepted => needs_review
 * component:  Metrics/Onionperf => Core Tor/Tor


Comment:

 Hijacking!^WCannibalizing ;) this ticket to be about the Tor bug.

 I've put a fix in my `bug34303` branch, based on maint-0.3.5.

 I also pushed it to github and made this pull request:
 https://github.com/torproject/tor/pull/1909

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs