Re: [tor-bugs] #22564 [Applications/Tor Browser]: Hide firefox sync

[Tor Bug Tracker & Wiki]

#22564: Hide firefox sync
-+-
 Reporter:  Dbryrtfbcbhgf|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  duplicate
  ff60-esr, TorBrowserTeam201805 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => duplicate


Comment:

 Replying to [comment:14 gk]:
 > Hm. The patch is rather largish and probably won't apply cleanly. I am
 not sure, we might try it at least. If it does not work out we should flip
 the proper pref when we are switching to ESR 60, though.

 That's done with the rebasing in #25543. Thus, marking this as a
 duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22564 [Applications/Tor Browser]: Hide firefox sync

[Tor Bug Tracker & Wiki]

#22564: Hide firefox sync
-+-
 Reporter:  Dbryrtfbcbhgf|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201804, ff60-esr |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-7.0-issues, tbb-regression, TorBrowserTeam201803 =>
 tbb-7.0-issues, tbb-regression, TorBrowserTeam201804, ff60-esr


Comment:

 Hm. The patch is rather largish and probably won't apply cleanly. I am not
 sure, we might try it at least. If it does not work out we should flip the
 proper pref when we are switching to ESR 60, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22564 [Applications/Tor Browser]: Hide firefox sync

[Tor Bug Tracker & Wiki]

#22564: Hide firefox sync
-+-
 Reporter:  Dbryrtfbcbhgf|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201803   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by Dbryrtfbcbhgf):

 gk, it looks like Mozilla fixed this bug in Firefox 60 with this patch.
 https://hg.mozilla.org/mozilla-central/rev/109cd0a34ffe
 Can this be back ported to TOrBrowser 7.5.x ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22564 [Applications/Tor Browser]: Hide firefox sync

[Tor Bug Tracker & Wiki]

#22564: Hide firefox sync
-+-
 Reporter:  Dbryrtfbcbhgf|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201802   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 https://bugzilla.mozilla.org/show_bug.cgi?id=586985

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22564 [Applications/Tor Browser]: Hide firefox sync

[Tor Bug Tracker & Wiki]

#22564: Hide firefox sync
-+-
 Reporter:  Dbryrtfbcbhgf|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201709   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-7.0-issues, tbb-regression, TorBrowserTeam201709R =>
 tbb-7.0-issues, tbb-regression, TorBrowserTeam201709
 * status:  needs_review => needs_revision


Comment:

 I tested it on a Linux system and it works for me, thanks. One thing to
 fix:
 {{{
 +  Services.prefs.removeObserver(PREF_SYNC_UI_HIDDEN, gSyncUI, false);
 }}}
 I don't think there is a `removeObserver()` that takes three arguments.

 Then you are adding observers in two more places (`preferences.js` and
 `CustomizableUI.jsm`) without removing them. I wonder whether that was
 intentionally. If so, shouldn't we remove them e.g. when the preferences
 pane is closed given that we are adding it when opening that very pane.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22564 [Applications/Tor Browser]: Hide firefox sync

[Tor Bug Tracker & Wiki]

#22564: Hide firefox sync
-+-
 Reporter:  Dbryrtfbcbhgf|  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,  |  Actual Points:
  TorBrowserTeam201709R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-7.0-issues, tbb-regression => tbb-7.0-issues, tbb-
 regression, TorBrowserTeam201709R
 * status:  new => needs_review


Comment:

 Here's a branch with two patches for review. The first patch is a fixup
 that the hides Sync UI elements. The second patch is a regression test.

 https://github.com/arthuredelstein/tor-browser/commits/22564

 And here's a torbutton patch for review, that removes some Sync UI hiding
 code that has been moved into the tor-browser fixup patch.

 https://github.com/arthuredelstein/torbutton/commit/22564

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22564 [Applications/Tor Browser]: Hide firefox sync (was: Remove firefox sync)

[Tor Bug Tracker & Wiki]

#22564: Hide firefox sync
+--
 Reporter:  Dbryrtfbcbhgf   |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:   => tbb-7.0-issues, tbb-regression
 * priority:  High => Medium


Comment:

 Let's not remove it but hide it. We had/have code that did/does that in
 our esr45 branches. I guess we need to update it properly for esr52.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs