Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
-+-
 Reporter:  cypherpunks  |  Owner:
 |  Backxwash
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, easy, 034-triage-20180328, |  Actual Points:
  034-removed-20180328, fast-fix, 035-triaged-   |
  in-20180711|
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by chelseakomlo):

 * cc: chelseakomlo (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
-+-
 Reporter:  cypherpunks  |  Owner:
 |  Backxwash
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, easy, 034-triage-20180328, |  Actual Points:
  034-removed-20180328, fast-fix |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by isis):

 This could possibly because we don't have all that much Rust code at the
 present moment? Perhaps it will make more of an impact later?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
-+-
 Reporter:  cypherpunks  |  Owner:
 |  Backxwash
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, easy, 034-triage-20180328, |  Actual Points:
  034-removed-20180328, fast-fix |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by isis):

 Totally hand-wavey measurement in a Qubes VM on a x220 with an i5 using
 turboboost doing like a million other things, running `configure --enable-
 rust --enable-cargo-online-mode --enable-fatal-warnings --disable-asciidoc
 && time make -j4`:

 With `codegen-units = 1`:

 {{{
 real5m15.728s
 user14m29.903s
 sys 3m55.476s
 }}}

 Without:

 {{{
 real5m18.433s
 user15m15.399s
 sys 4m12.781s
 }}}

 So it seems to have a negligible effect on build times if it randomly
 ended up being longer without it? I don't know how much faster it makes
 the binaries.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
-+-
 Reporter:  cypherpunks  |  Owner:
 |  Backxwash
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, easy, 034-triage-20180328, |  Actual Points:
  034-removed-20180328, fast-fix |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_information


Comment:

 Hm. How badly does this affect build performance and how much does it help
 binary performance?  If the binary savings aren't significant, I say we
 shouldn't worry about this.  If the build cost is huge, we should probably
 stick it behind a configure option.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
-+-
 Reporter:  cypherpunks  |  Owner:
 |  Backxwash
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, easy, 034-triage-20180328, |  Actual Points:
  034-removed-20180328, fast-fix |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by Backxwash):

 * owner:  isis => Backxwash
 * status:  needs_review => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
-+-
 Reporter:  cypherpunks  |  Owner:  isis
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, easy, 034-triage-20180328, |  Actual Points:
  034-removed-20180328, fast-fix |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by isis):

 * status:  accepted => needs_review


Comment:

 See my `bug25269` branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
-+-
 Reporter:  cypherpunks  |  Owner:  isis
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, easy, 034-triage-20180328, |  Actual Points:
  034-removed-20180328, fast-fix |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by isis):

 * status:  new => accepted
 * owner:  (none) => isis
 * points:   => .1
 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final
 * keywords:  rust, easy, 034-triage-20180328, 034-removed-20180328 => rust,
 easy, 034-triage-20180328, 034-removed-20180328, fast-fix
 * type:  defect => enhancement


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, easy|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, easy|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Do we have to do this in all of our Cargo.toml files, or is it enough to
 do it in the toplevel one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, easy|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 Replying to [comment:2 nickm]:
 > Will this break with older versions of rust?
 `codegen-units` apparently exists since 2014 https://internals.rust-
 lang.org/t/default-settings-for-parallel-codegen/519

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, easy|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Will this break with older versions of rust?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25269 [Core Tor/Tor]: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last drop of performance

[Tor Bug Tracker & Wiki]

#25269: Set codegen-units to 1 in src/rust/Cargo.toml to eke out every last 
drop of
performance
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, easy|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by cypherpunks):

 * milestone:   => Tor: 0.3.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs