Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  implemented
  spec network-team-roadmap-2020Q1 044-must  |  Actual Points:
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Okay, I think that's everything.  Merging this to master!  Nice work,
 everybody!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Did fixes and added changes/man page! Thanks for reviews!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Left a small comment. Other than that, looks good to go!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Pushed fix commit that hopefully addresses unresolved comments! Thanks for
 review!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 arg. I went to the PR and found that I had uncommitted comments.  I've put
 my comments on the PR. Do they make sense?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by dgoulet):

 Ok I've found a tiny syntax thing but I believe we can merge this in 044.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Pushed fix to the comments. Let me know how you like that! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by mikeperry):

 * cc: mikeperry (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Okay, I've left some comments on the PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 Looks like travis CI is failing due to some bad HTML in the doxygen.

 I'm reviewing asn's changes now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by dgoulet):

 Some comments on the PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  assigned => needs_review


Comment:

 Hello,

 please see https://github.com/torproject/tor/pull/1685 for a PR that fixes
 the remaining issues of comment:15 and also fixes the comment/docs issues
 raised by teor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by teor):

 I noticed a few places on the pull request where comments need to be
 clarified, or documentation needs to be added.

 I accidentally did the old pull request as well. Sorry!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 Per request, I've rebased this as a new branch `ticket32709_044_02` with
 PR at https://github.com/torproject/tor/pull/1679 .  (This one won't have
 a merge conflict with #32137.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 I've started work on (c), but I think it's better to do in a separate
 branch.  I've opened #33014 for it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm, dgoulet   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * owner:  dgoulet => asn
 * reviewer:  nickm => nickm, dgoulet
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm|Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 I have done (a) and (b) above; I'll get to (c) before Wednesday.

 I'm putting my work in progress at `ticket32709_044_01` with PR at
 https://github.com/torproject/tor/pull/1672 in case you want to take a
 look.  It conflicts with the merged #32137, so CI isn't running on it for
 the moment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
  postfreeze-ok  |
Parent ID:  #26768   | Points:  2
 Reviewer:  nickm|Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 We talked about this on IRC; here's the current plan as I understand it.

 We're going to aim this ticket for 0.4.4, since doing it properly will
 require more time than we have for 0.4.3.  We'll plan to open the merge
 window for 0.4.4 early, ''for this sponsor only''.

 Between today and next Wednsday or so, I'll do a branch based on this one
 that will:
   a) turn subcredential into a proper type
   b) implement a constant-time multi-subcredential backend solution for
 items 2 and 3 above, on top of this branch.
   c) refactor config_service_v3() a little

 After that, for minimal viable product, we need:
   d) improved test coverage,
   e) to stop recomputing the subcredentials for every request

 Later on, we can make these improvements:
   f) compute fewer subcredentials

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 044-must  |
Parent ID:  #26768   | Points:  5
 Reviewer:  nickm|Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * keywords:
 tor-hs scaling onionbalance tor-spec network-team-roadmap-2020Q1
 043-must postfreeze-ok
 =>
 tor-hs scaling onionbalance tor-spec network-team-roadmap-2020Q1
 044-must
 * points:  2 => 5
 * milestone:  Tor: 0.4.3.x-final => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
  postfreeze-ok  |
Parent ID:  #26768   | Points:  2
 Reviewer:  nickm|Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
  postfreeze-ok  |
Parent ID:  #26768   | Points:  2
 Reviewer:  nickm|Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 Okay, reading through it all again.  I'll make comments in the PR, but
 here are some higher-level questions.

 1) Does it really make sense to compute the subcredential for three time
 periods?  It seems to me that we are never close to more than two periods.
 Maybe we should calculate the subcredentials for "now" and "the closest
 period other than now".

 2) The performance here is going to be needlessly bad.  Keep in mind that
 every time we call hs_ntor_client_get_introduce1_keys(), we're doing a
 curve25519 calculation... but the curve25519 calculation will be the same
 here every time!  The only input that changes is the subcredential, which
 is an input only to the XOF() part of the process.  This could be a
 followup branch, I guess, though.

 3) We should think about timing side channels here.  This could also be a
 followup, however.

 4) Test coverage on these changes should really be higher.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
  postfreeze-ok  |
Parent ID:  #26768   | Points:  2
 Reviewer:  nickm|Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review
 * reviewer:  dgoulet => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
  postfreeze-ok  |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_information => needs_revision


Comment:

 OK did a review on the branch and posted on the PR. Been testing it on
 OBv3 the past few hours and it works just fine!

 As discussed with David, I also wrote a spec branch documenting and
 analyzing the behavior introduced by this code:
 https://github.com/asn-d6/torspec/tree/bug32709 Please let me know if
 something is missing and should be added.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
  postfreeze-ok  |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_information


Comment:

 PR and branch are still the same but totally updated/changed after initial
 review from nickm/asn.

 Currently with unit tests and practracker happy. Spec patch is being
 written by asn with a justification for the usage of both subcredentials.

 I've notified asn about this so he can continue OBv3 testing with this
 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
  postfreeze-ok  |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * keywords:
 tor-hs scaling onionbalance tor-spec network-team-roadmap-2020Q1
 043-must
 =>
 tor-hs scaling onionbalance tor-spec network-team-roadmap-2020Q1
 043-must postfreeze-ok


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 Hi!  I'm going to take a look at the code in detail, but for now, some
 top-level things, some of which we already talked about on IRC:
* It needs unit tests
* CI needs to pass: it looks like practracker is telling us to break up
 config_service_v3() into manageable pieces
* I think we need a corresponding patch to rend-spec-v3.txt
* We should talk a bit about whether we want to accept both possible
 subcredentials or only one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1 043-must  |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * keywords:  tor-hs scaling onionbalance tor-spec network-team-roadmap-
 2020Q1 =>
 tor-hs scaling onionbalance tor-spec network-team-roadmap-2020Q1
 043-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1   |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hey hey,

 this looks really good. I actually tested this (and after fixing a few
 issues) I managed to connect to the backend service and exchange data over
 an onionbalance descriptor! That's a first!

 I pointed a few issues on GH. The main ones is an off-topic assertion
 failure on the logging subsystem, and the more important one is something
 weird going on with the `hs_cell_parse_introduce2 data` structure and
 `client_pk` gets wiped when it shouldn't. I fixed both of those issues
 quickly for testing but we need to fix them well.

 Other than that, it looks good, plus it needs changes file and man page
 entry. Also, a unittest for the config parsing wouldn't be bad if
 possible.

 Thanks a lot!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1   |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 Branch to be tested: ticket32709_043_01
 PR: https://github.com/torproject/tor/pull/1647

 I have done ZERO test on it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1   |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * owner:  asn => dgoulet
 * status:  assigned => accepted


Comment:

 Will take over this for asn. We just had a conf call about it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance tor- |  Actual Points:
  spec network-team-roadmap-2020Q1   |
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by gaba):

 * keywords:  tor-hs scaling onionbalance network-team-roadmap-september
 tor-spec => tor-hs scaling onionbalance tor-spec network-team-roadmap-
 2020Q1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance  |  Actual Points:
  network-team-roadmap-september tor-spec|
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by asn):

 The suggested approach here is to introduce a torrc option for the OB
 instances `HiddenServiceOnionbalanceFrontendConfigFile` that points to a
 file which contains info about the OB frontend. In particular, it will
 contain (a number of) `FrontendOnionAddress` which is the onion address of
 the frontend, and can be used to decrypt and finish the ntor handshake
 with the client.

 It's still not decided if we should allow the instances with that
 configured to also be accessed over their regular instance onion or not.

 I will be working on this and hopefully have something before the end of
 week. Unittests might be hard to do.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32709 [Core Tor/Tor]: hsv3: Support onionbalance keys when handling INTRO2 cells

[Tor Bug Tracker & Wiki]

#32709: hsv3: Support onionbalance keys when handling INTRO2 cells
-+-
 Reporter:  asn  |  Owner:  asn
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs scaling onionbalance  |  Actual Points:
  network-team-roadmap-september tor-spec|
Parent ID:  #26768   | Points:  2
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * owner:  (none) => asn
 * reviewer:   => dgoulet
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs