Re: [tor-bugs] #13239 [Core Tor/Tor]: Maybe we want three preemptive internal circs for hidden services?

[Tor Bug Tracker & Wiki]

#13239: Maybe we want three preemptive internal circs for hidden services?
-+-
 Reporter:  arma |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.9.x-final
 Severity:  Normal   |Version:
 Keywords:  tor-client, tor-hs,  | Resolution:  fixed
  TorCoreTeam201605  |  Actual Points:
Parent ID:  #5271| Points:  small
 Reviewer:  asn  |Sponsor:
 |  SponsorR-can
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged into master.

 I'd also like to see the magic numbers replaced with constants; I'm adding
 a note on that to #18873

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13239 [Core Tor/Tor]: Maybe we want three preemptive internal circs for hidden services?

[Tor Bug Tracker & Wiki]

#13239: Maybe we want three preemptive internal circs for hidden services?
-+-
 Reporter:  arma |  Owner:
 Type:  defect   | Status:
 Priority:  Medium   |  merge_ready
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-client, tor-hs,  |Version:
  TorCoreTeam201605  | Resolution:
Parent ID:  #5271|  Actual Points:
 Reviewer:  asn  | Points:  small
 |Sponsor:
 |  SponsorR-can
-+-
Changes (by asn):

 * keywords:  tor-client, tor-hs, TorCoreTeam201604 => tor-client, tor-hs,
 TorCoreTeam201605


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13239 [Core Tor/Tor]: Maybe we want three preemptive internal circs for hidden services?

[Tor Bug Tracker & Wiki]

#13239: Maybe we want three preemptive internal circs for hidden services?
-+-
 Reporter:  arma |  Owner:
 Type:  defect   | Status:
 Priority:  Medium   |  merge_ready
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-client, tor-hs,  |Version:
  TorCoreTeam201604  | Resolution:
Parent ID:  #5271|  Actual Points:
 Reviewer:  asn  | Points:  small
 |Sponsor:
 |  SponsorR-can
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:15 dgoulet]:
 > Ok, to move this one forward, here is the _minimal_ fix suggested.
 Please make sure that this one liner is correct because there are two
 "need_uptime" thingy...
 >
 > See branch: `bug13239_029_01`
 >
 > Thought: what sysrqb did here is imo useful that is move hardcoded
 values to defines and improve code flow. Maybe we should open a ticket for
 "let's refactor/improve circuit_predict_and_launch_new()" for which what
 sysrqb did is not lost?

 Your patch `bug13239_029_01` looks good to me. It also seems to agree with
 sysrqb's patch in terms of the parameter changed.

 I also created a ticket for refactoring the function entirely at #18873. I
 filed it under `Tor: 0.2.??` because I was not sure what milestone to file
 it under.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13239 [Core Tor/Tor]: Maybe we want three preemptive internal circs for hidden services?

[Tor Bug Tracker & Wiki]

#13239: Maybe we want three preemptive internal circs for hidden services?
-+-
 Reporter:  arma |  Owner:
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor-client, tor-hs,  |Version:
  TorCoreTeam201604  | Resolution:
Parent ID:  #5271|  Actual Points:
 Reviewer:  asn  | Points:  small
 |Sponsor:
 |  SponsorR-can
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Ok, to move this one forward, here is the _minimal_ fix suggested. Please
 make sure that this one liner is correct because there are two
 "need_uptime" thingy...

 See branch: `bug13239_029_01`

 Thought: what sysrqb did here is imo useful that is move hardcoded values
 to defines and improve code flow. Maybe we should open a ticket for "let's
 refactor/improve circuit_predict_and_launch_new()" for which what sysrqb
 did is not lost?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs