Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by mcs):

 #3967 was resolved as a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * status:  needs_information => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by arthuredelstein):

 Looks good to me. I had noticed a couple of blank lines added to
 io.asyncSocketStreams, but it's really not important.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by gk):

 Okay, pushed to master commit 28a55f5bf324f43373006328c5b03793096f71c4.
 Arthur, let us know if we should make additional changes or just close
 this bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by brade):

 Here's a revised patch:
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug14271-03=28a55f5bf324f43373006328c5b03793096f71c4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by gk):

 mcs/brade could you create an updated patch? I want to have this in the
 alpha as well. We can accommodate Arthur's remaining concerns (if there
 are any) in a fixup commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by mcs):

 * keywords:  tbb-torbutton, tbb-security, TorBrowserTeam201609R => tbb-
 torbutton, tbb-security, TorBrowserTeam201609
 * status:  needs_review => needs_information


Comment:

 Replying to [comment:16 arthuredelstein]:
 > Sorry for the late review. This patch looks good to me -- nice work! I
 have a couple of minor stylistic suggestions that you may or may not want
 to adopt:
 > {{{
 > +// given socketFile or host and port.
 > +io.asyncSocketStreams = function (socketFile, host, port) {
 > +  let socketTransport;
 > +  let sts = Cc["@mozilla.org/network/socket-transport-service;1"]
 > +
 .getService(Components.interfaces.nsISocketTransportService),
 > +   UNBUFFERED = Ci.nsITransport.OPEN_UNBUFFERED;
 > +
 > +  // Create an instance of a socket transport.
 > +  if (socketFile) {
 > +socketTransport = sts.createUnixDomainTransport(socketFile);
 > +  } else {
 > +socketTransport = sts.createTransport(null, 0, host, port, null);
 > +  }
 > +
 > }}}
 > Maybe move `let socketTransport` down to after the comment `// Create an
 instance of a socket transport`?

 Good idea.

 > Also, in that file, I had used blank lines to separate functions, though
 that's probably a personal eccentricity...

 I am OK with accommodating eccentricities, but can you explain what we
 need to fix? I don't think we removed any blank lines, but maybe I am just
 not seeing it.

 >
 > Also, a somewhat bigger suggestion that could be part of this patch or
 left for another time. In `torbutton.js`, we will now have
 > {{{
 >  var m_tb_control_socket_file = null; // Set if using a UNIX domain
 socket.
 >  var m_tb_control_port = null;// Set if not using a socket.
 >  var m_tb_control_host = null;// Set if not using a socket.
 >  var m_tb_control_pass = null;
 >  var m_tb_control_desc = null;
 > }}}
 > I imagine it might be cleaner to collect these into a single data object
 like
 > {{{
 > var m_tb_control = { socket_file, host, port, password, descriptor }
 > }}}
 > Then we could factor out a single factory function from
 `torbutton_init()` that generates this object. And we could use this
 object as a single argument for functions in `tor-control-port.js` and
 `tor-circuit-display.js` as well.

 Kathy and I like that suggestion, but let's do it as a follow up. I
 created #20102 for it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by arthuredelstein):

 Replying to [comment:15 mcs]:
 > Replying to [comment:14 gk]:
 > > I think we should not set `m_tb_control_port` to `9151` now in the
 catch clause and open a new ticket for implementing a saner solution
 across all Torbutton code. We can discuss there what we want that solution
 to be.
 >
 > That sounds like a good plan. I opened #20057.
 > Here is a revised patch for this ticket:
 >
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug14271-02=abb01118a8445c541bb359d85fe9af941536b43a

 Sorry for the late review. This patch looks good to me -- nice work! I
 have a couple of minor stylistic suggestions that you may or may not want
 to adopt:
 {{{
 +// given socketFile or host and port.
 +io.asyncSocketStreams = function (socketFile, host, port) {
 +  let socketTransport;
 +  let sts = Cc["@mozilla.org/network/socket-transport-service;1"]
 +
 .getService(Components.interfaces.nsISocketTransportService),
 + UNBUFFERED = Ci.nsITransport.OPEN_UNBUFFERED;
 +
 +  // Create an instance of a socket transport.
 +  if (socketFile) {
 +socketTransport = sts.createUnixDomainTransport(socketFile);
 +  } else {
 +socketTransport = sts.createTransport(null, 0, host, port, null);
 +  }
 +
 }}}
 Maybe move `let socketTransport` down to after the comment `// Create an
 instance of a socket transport`? Also, in that file, I had used blank
 lines to separate functions, though that's probably a personal
 eccentricity...

 Also, a somewhat bigger suggestion that could be part of this patch or
 left for another time. In `torbutton.js`, we will now have
 {{{
  var m_tb_control_socket_file = null; // Set if using a UNIX domain
 socket.
  var m_tb_control_port = null;// Set if not using a socket.
  var m_tb_control_host = null;// Set if not using a socket.
  var m_tb_control_pass = null;
  var m_tb_control_desc = null;
 }}}
 I imagine it might be cleaner to collect these into a single data object
 like
 {{{
 var m_tb_control = { socket_file, host, port, password, descriptor }
 }}}
 Then we could factor out a single factory function from `torbutton_init()`
 that generates this object. And we could use this object as a single
 argument for functions in `tor-control-port.js` and `tor-circuit-
 display.js` as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by mcs):

 * status:  assigned => needs_review
 * keywords:  tbb-torbutton, tbb-security, TorBrowserTeam201609 => tbb-
 torbutton, tbb-security, TorBrowserTeam201609R


Comment:

 Replying to [comment:14 gk]:
 > I think we should not set `m_tb_control_port` to `9151` now in the catch
 clause and open a new ticket for implementing a saner solution across all
 Torbutton code. We can discuss there what we want that solution to be.

 That sounds like a good plan. I opened #20057.
 Here is a revised patch for this ticket:
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug14271-02=abb01118a8445c541bb359d85fe9af941536b43a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * status:  needs_information => assigned


Comment:

 Replying to [comment:13 mcs]:
 > Replying to [comment:12 gk]:
 > > 3) Checking whether we should call `torbutton_local_tor_check()`
 should check for
 > > `m_tb_control_socket_file` as well (not only for `m_tb_control_port`)
 I guess?
 >
 > We did add that check, although if you look at the patch with git's
 default of three lines of context it is not so obvious.

 Hm. No, it is even obvious then. Must have been a different kind of code-
 blindness, my bad.

 >
 > > 4) I am not so sure about
 > > {{{
 > > +} catch(e) {
 > > +  m_tb_control_port = 9151;
 > > +}
 > > }}}
 > > What was your rationale for adding that now (given you omitted it
 earlier)? For one, the logs might be misleading showing a probably wrong
 port (I mean the setup is seriously troubling if we need to assign `9151`
 in the catch clause at all) in an error with respect to the control
 connection. On the other hand, we might want to show that something is
 wrong with the help of `torbutton_do_tor_check()` which would update the
 toolbar button in this case (if we get that far at all with a broken setup
 like the one in question).
 >
 > Kathy and I added the 9151 default to be consistent with how
 m_tb_control_host is handled (it was already defaulting to 127.0.0.1).
 Thinking about this some more and looking at the existing Torbutton code,
 it seems like there is some effort to disable features (e.g., New
 Identity, the local Tor check) when the port is missing. So maybe we
 should put things back how there were and make sure we consistently check
 for port, password, etc. before trying to do things in Torbutton that
 require authenticated control port access?
 >
 > The circuit display code also includes code that defaults the port to
 9151, so if we decide to continue with the concept that a lack of port can
 be used to disable code, we should remove the `|| 9151` from this line in
 tor-circuit-display.js:
 > `myController = controller(socketFile, host, port || 9151, password,`
 > We can also add a check to skip the call to createTorCircuitDisplay() if
 port, password, etc. are missing (the existing code will log an error if
 initialization fails).
 >
 > What do you think?

 I think we should not set `m_tb_control_port` to `9151` now in the catch
 clause and open a new ticket for implementing a saner solution across all
 Torbutton code. We can discuss there what we want that solution to be.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by mcs):

 * status:  needs_revision => needs_information


Comment:

 Replying to [comment:12 gk]:
 > Here are some comments:
 >
 > 1)
 > {{{
 > +// given sockFile or host and port.
 > }}}
 > s/sockFile/socketFile/

 Good catch.


 > 2)
 > {{{
 > let tlps = Cc["@torproject.org/torlauncher-protocol-service;1"]
 >  .getService(Ci.nsISupports).wrappedJSObject;
 > }}}
 > We should do that once and not twice in `torbutton_init()`.

 Agreed.


 > 3) Checking whether we should call `torbutton_local_tor_check()` should
 check for
 > `m_tb_control_socket_file` as well (not only for `m_tb_control_port`) I
 guess?

 We did add that check, although if you look at the patch with git's
 default of three lines of context it is not so obvious.


 > 4) I am not so sure about
 > {{{
 > +} catch(e) {
 > +  m_tb_control_port = 9151;
 > +}
 > }}}
 > What was your rationale for adding that now (given you omitted it
 earlier)? For one, the logs might be misleading showing a probably wrong
 port (I mean the setup is seriously troubling if we need to assign `9151`
 in the catch clause at all) in an error with respect to the control
 connection. On the other hand, we might want to show that something is
 wrong with the help of `torbutton_do_tor_check()` which would update the
 toolbar button in this case (if we get that far at all with a broken setup
 like the one in question).

 Kathy and I added the 9151 default to be consistent with how
 m_tb_control_host is handled (it was already defaulting to 127.0.0.1).
 Thinking about this some more and looking at the existing Torbutton code,
 it seems like there is some effort to disable features (e.g., New
 Identity, the local Tor check) when the port is missing. So maybe we
 should put things back how there were and make sure we consistently check
 for port, password, etc. before trying to do things in Torbutton that
 require authenticated control port access?

 The circuit display code also includes code that defaults the port to
 9151, so if we decide to continue with the concept that a lack of port can
 be used to disable code, we should remove the `|| 9151` from this line in
 tor-circuit-display.js:
 `myController = controller(socketFile, host, port || 9151, password,`
 We can also add a check to skip the call to createTorCircuitDisplay() if
 port, password, etc. are missing (the existing code will log an error if
 initialization fails).

 What do you think?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201609   |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * keywords:  tbb-torbutton, tbb-security, TorBrowserTeam201608R => tbb-
 torbutton, tbb-security, TorBrowserTeam201609
 * status:  needs_review => needs_revision


Comment:

 Here are some comments:

 1)
 {{{
 +// given sockFile or host and port.
 }}}
 s/sockFile/socketFile/

 2)
 {{{
 let tlps = Cc["@torproject.org/torlauncher-protocol-service;1"]
  .getService(Ci.nsISupports).wrappedJSObject;
 }}}
 We should do that once and not twice in `torbutton_init()`.

 3) Checking whether we should call `torbutton_local_tor_check()` should
 check for
 `m_tb_control_socket_file` as well (not only for `m_tb_control_port`) I
 guess?

 4) I am not so sure about
 {{{
 +} catch(e) {
 +  m_tb_control_port = 9151;
 +}
 }}}
 What was your rationale for adding that now (given you omitted it
 earlier)? For one, the logs might be misleading showing a probably wrong
 port (I mean the setup is seriously troubling if we need to assign `9151`
 in the catch clause at all) in an error with respect to the control
 connection. On the other hand, we might want to show that something is
 wrong with the help of `torbutton_do_tor_check()` which would update the
 toolbar button in this case (if we get that far at all with a broken setup
 like the one in question).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201608R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by mcs):

 Replying to [comment:9 adrelanos]:
 > Do you have a branch and/or downloadable version that I could use to
 check Whonix compatibility?

 We do not have a packaged Tor Browser that includes these changes. You
 would need to build Torbutton from the bug14271-01 branch within
 ​https://git.torproject.org/user/brade/torbutton.git and build Tor
 Launcher from the bug14272-01 branch within
 https://git.torproject.org/user/brade/tor-launcher.git. But you may also
 want the patch from #19733 (it is not needed if the local Tor check is
 disabled within Torbutton).

 But it probably makes sense to wait until after these changes are merged
 into master so that you can use a nightly Tor Browser build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201608R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by adrelanos):

 I mean, one that includes both changes, #14271 and #14272.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201608R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by adrelanos):

 Do you have a branch and/or downloadable version that I could use to check
 Whonix compatibility?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14271 [Applications/Tor Browser]: Make Torbutton work with Unix Domain Socket option

[Tor Bug Tracker & Wiki]

#14271: Make Torbutton work with Unix Domain Socket option
-+-
 Reporter:  gk   |  Owner:  brade
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, tbb-security, |  Actual Points:
  TorBrowserTeam201608R  |
Parent ID:  #14270   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by mcs):

 * keywords:  tbb-torbutton, tbb-security, TorBrowserTeam201608 => tbb-
 torbutton, tbb-security, TorBrowserTeam201608R
 * status:  assigned => needs_review
 * severity:   => Normal


Comment:

 Here is a patch for review:
 
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug14271-01=115d96e5ca5a861573a6efe08fbb3ba7a3ce149d
 For this to work correctly, you will need a Tor Launcher that includes the
 changes from #14272.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs