Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
-+--
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff45-esr, TorBrowserTeam201605R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. This is commit d127873b498fb83e4f608b82a8d382df25183dd3 on master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  ff45-esr, TorBrowserTeam201605 => ff45-esr,
 TorBrowserTeam201605R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
 Priority:  Medium  |  needs_revision
Component:  Applications/Tor Browser|  Milestone:
 Severity:  Normal  |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605  | Resolution:
Parent ID:  |  Actual Points:
 Reviewer:  | Points:
|Sponsor:
+--

Comment (by arthuredelstein):

 Thanks for the good suggestions. Here's a new version with both things
 fixed.

 ​https://github.com/arthuredelstein/torbutton/commit/18743+1
 Hash 5b17ddc4efa21716cf666594930469a99e398d44

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
 Priority:  Medium  |  needs_revision
Component:  Applications/Tor Browser|  Milestone:
 Severity:  Normal  |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605  | Resolution:
Parent ID:  |  Actual Points:
 Reviewer:  | Points:
|Sponsor:
+--
Changes (by gk):

 * keywords:  ff45-esr, TorBrowserTeam201605R => ff45-esr,
 TorBrowserTeam201605
 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:4 gk]:
 > Looks good to me. One nit: could you wrap that long line in
 `torbutton_update_sync_ui()`? It would make it a bit easier to read in my
 terminal.

 Maybe also add a try/catch in that function or check that the
 getElementById() succeeds. That way a failure there due to future Firefox
 changes won't break other Torbutton features such as the circuit display.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by gk):

 Looks good to me. One nit: could you wrap that long line in
 `torbutton_update_sync_ui()`? It would make it a bit easier to read in my
 terminal.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201604R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-

Comment (by bugzilla):

 If you pay primary attention to hamburger menu, then don't forget about
 Synced Tabs that can be added through Customize in it. The rest is in
 #16778.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18743 [Applications/Tor Browser]: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser

[Tor Bug Tracker & Wiki]

#18743: "Sign in to Sync" icon not hidden in ESR45-based Tor Browser
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201604R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  ff45-esr => ff45-esr, TorBrowserTeam201604R
 * status:  new => needs_review


Comment:

 I previously tried upstreaming our #16488 patch to Firefox, but Chris
 Karlof pointed out to me that the approach is rather Tor Browser-specific:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1217295

 So here's a torbutton patch that accomplishes the same thing:
 https://github.com/arthuredelstein/torbutton/commit/18743
 Hash 242777b8336128995219470275d50b6b6788acb1

 We could then drop the tor-browser.git patch:
 https://github.com/arthuredelstein/tor-browser/commit/18743+1
 Hash c23e50149bc76dfa0529b51f64947f556903c34f

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs