Re: [tor-bugs] #18791 [Tor Browser]: Fix for #13252 does not compile on ESR 45

[Tor Bug Tracker & Wiki]

#18791: Fix for #13252 does not compile on ESR 45
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Critical | Resolution:  fixed
 Keywords:  ff45-esr, tbb-6.0a5, |  Actual Points:
  TorBrowserTeam201604R  | Points:
Parent ID:  #15197   |Sponsor:
 Reviewer:   |
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Seems to be there now. Closing this one, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18791 [Tor Browser]: Fix for #13252 does not compile on ESR 45

[Tor Bug Tracker & Wiki]

#18791: Fix for #13252 does not compile on ESR 45
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Very High|  needs_review
Component:  Tor Browser  |  Milestone:
 Severity:  Critical |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604R  |  Actual Points:
Parent ID:  #15197   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:6 arthuredelstein]:
 > Thanks for finding this and sorry for accidentally leaving out those
 files. I used the fixup patch and added it to
 > https://github.com/arthuredelstein/tor-browser/commits/15197+11
 > Hash: f08e3270b9cb65844585279bcc1eaaeb80f0ba35

 I don't see this commit. Maybe you need to push it to github?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18791 [Tor Browser]: Fix for #13252 does not compile on ESR 45

[Tor Bug Tracker & Wiki]

#18791: Fix for #13252 does not compile on ESR 45
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Very High|  needs_review
Component:  Tor Browser  |  Milestone:
 Severity:  Critical |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604R  |  Actual Points:
Parent ID:  #15197   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Thanks for finding this and sorry for accidentally leaving out those
 files. I used the fixup patch and added it to
 https://github.com/arthuredelstein/tor-browser/commits/15197+11
 Hash: f08e3270b9cb65844585279bcc1eaaeb80f0ba35

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18791 [Tor Browser]: Fix for #13252 does not compile on ESR 45

[Tor Bug Tracker & Wiki]

#18791: Fix for #13252 does not compile on ESR 45
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Very High|  needs_review
Component:  Tor Browser  |  Milestone:
 Severity:  Critical |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604R  |  Actual Points:
Parent ID:  #15197   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18791 [Tor Browser]: Fix for #13252 does not compile on ESR 45

[Tor Bug Tracker & Wiki]

#18791: Fix for #13252 does not compile on ESR 45
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Very High|  needs_review
Component:  Tor Browser  |  Milestone:
 Severity:  Critical |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604R  |  Actual Points:
Parent ID:  #15197   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  ff45-esr, tbb-6.0a5 => ff45-esr, tbb-6.0a5,
 TorBrowserTeam201604R
 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18791 [Tor Browser]: Fix for #13252 does not compile on ESR 45

[Tor Bug Tracker & Wiki]

#18791: Fix for #13252 does not compile on ESR 45
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff45-esr, tbb-6.0a5  |  Actual Points:
Parent ID:  #15197   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Just in case Arthur does not already have rebased versions of the two
 missing files, I will attach a fixup patch that includes them. Compared to
 the ESR38-based version of xpcom/io/TorFileUtils.cpp, Kathy and I switched
 to .forget() for returning addref'd values and we also fixed a warning
 caused by redeclaration of rv.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18791 [Tor Browser]: Fix for #13252 does not compile on ESR 45

[Tor Bug Tracker & Wiki]

#18791: Fix for #13252 does not compile on ESR 45
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff45-esr, tbb-6.0a5  |  Actual Points:
Parent ID:  #15197   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 It looks like a rebase issue. The files xpcom/io/TorFileUtils.cpp and
 xpcom/io/TorFileUtils.h are missing (not included in
 ac1a02c6653c1fd1dbb313eb02e3eb89b00cb1bb).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18791 [Tor Browser]: Fix for #13252 does not compile on ESR 45 (was: Fix for #13252 does not comiple on ESR 45)

[Tor Bug Tracker & Wiki]

#18791: Fix for #13252 does not compile on ESR 45
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff45-esr, tbb-6.0a5  |  Actual Points:
Parent ID:  #15197   | Points:
 Reviewer:   |Sponsor:
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs