Re: [tor-bugs] #18801 [Tor Browser]: disable the dom.push prefs

[Tor Bug Tracker & Wiki]

#18801: disable the dom.push prefs
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Tor Browser  |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18801 [Tor Browser]: disable the dom.push prefs

[Tor Bug Tracker & Wiki]

#18801: disable the dom.push prefs
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Tor Browser  |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 Replying to [comment:2 gk]:
 > It seems Mozilla did already a good job at disabling the DOM Push prefs.
 See: https://mxr.mozilla.org/mozilla-
 esr45/source/modules/libpref/init/all.js. So, the only thing that is
 actually missing is getting rid of the serverURL?

 Yes, you are correct. Sorry about that. Please use the revised patch that
 I just attached to this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18801 [Tor Browser]: disable the dom.push prefs

[Tor Bug Tracker & Wiki]

#18801: disable the dom.push prefs
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Tor Browser  |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 It seems Mozilla did already a good job at disabling the DOM Push prefs.
 See: https://mxr.mozilla.org/mozilla-
 esr45/source/modules/libpref/init/all.js. So, the only thing that is
 actually missing is getting rid of the serverURL?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18801 [Tor Browser]: disable the dom.push prefs

[Tor Bug Tracker & Wiki]

#18801: disable the dom.push prefs
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Medium   |  needs_review
Component:  Tor Browser  |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  ff45-esr, tbb-6.0a5, TorBrowserTeam201604 => ff45-esr,
 tbb-6.0a5, TorBrowserTeam201604R
 * status:  new => needs_review


Comment:

 Please review the attached patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #18801 [Tor Browser]: disable the dom.push prefs

[Tor Bug Tracker & Wiki]

#18801: disable the dom.push prefs
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor  |Version:
  Browser|   Keywords:  ff45-esr, tbb-6.0a5,
 Severity:  Normal   |  TorBrowserTeam201604
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 In #18546, Mike said:
 We should disable all of the dom.push.* prefs. Even though it seems that
 only ServiceWorkers can use Push, it would be good for us to ensure now
 that if we decide to enable ServiceWorkers, push stays off.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs