Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:  closed
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R, | Resolution:  fixed
  tbb-6.0-must   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:19 gk]:
 > Fine with me (although we probably will need at least the UITour code
 path patched as well when upstreaming this fix which we should try as the
 current behavior is weird). Commit
 320de5db6d53f53aadfad785ce31826b3080e890 on tor-browser-45.1.0esr-6.0-1
 has the fix.

 Ah, no, the code got pulled out into an own extension. Not sure if we want
 to upstream the changes into that system extension.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:  closed
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R, | Resolution:  fixed
  tbb-6.0-must   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fine with me (although we probably will need at least the UITour code path
 patched as well when upstreaming this fix which we should try as the
 current behavior is weird). Commit
 320de5db6d53f53aadfad785ce31826b3080e890 on tor-browser-45.1.0esr-6.0-1
 has the fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605R, |Version:
  tbb-6.0-must   | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff45-esr, TorBrowserTeam201605, tbb-6.0-must => ff45-esr,
 TorBrowserTeam201605R, tbb-6.0-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
+--
 Reporter:  mcs |  Owner:
 Type:  defect  |  arthuredelstein
 Priority:  Medium  | Status:  needs_review
Component:  Applications/Tor Browser|  Milestone:
 Severity:  Normal  |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605  | Resolution:
Parent ID:  |  Actual Points:
 Reviewer:  | Points:
|Sponsor:
+--
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:15 gk]:
 > Neat idea and I guess Mozilla would even be amenable to take that patch.
 However, that still does not seem enough. I stumbled over another Pocket
 button while looking at the Reader functionality (see:
 https://mxr.mozilla.org/mozilla-
 esr45/source/browser/modules/ReaderParent.jsm#81). There are even more
 instances of `CustomizableUI.getPlacementOfWidget("pocket-button")` we
 might want to take care of when upstreaming (even though I did not figure
 out how to get a related Pocket button shown in Tor Browser for these
 cases).

 Thanks for pointing these out. Here is a new version that takes care of
 the pocket button in Reader Mode and also the unlikely event of Pocket
 items in the context menu.

 https://github.com/arthuredelstein/tor-browser/commit/18886+4
 Hash c3fc62020f4b12aaa633d5760ea77999a97c5f11

 I haven't modified the UITour code as we are already suppressing the
 UITour itself.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
+--
 Reporter:  mcs |  Owner:
 Type:  defect  |  arthuredelstein
 Priority:  Medium  | Status:
Component:  Applications/Tor Browser|  needs_revision
 Severity:  Normal  |  Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605  |Version:
Parent ID:  | Resolution:
 Reviewer:  |  Actual Points:
| Points:
|Sponsor:
+--
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  ff45-esr, TorBrowserTeam201605R => ff45-esr,
 TorBrowserTeam201605


Comment:

 Neat idea and I guess Mozilla would even be amenable to take that patch.
 However, that still does not seem enough. I stumbled over another Pocket
 button while looking at the Reader functionality (see:
 https://mxr.mozilla.org/mozilla-
 esr45/source/browser/modules/ReaderParent.jsm#81). There are even more
 instances of `CustomizableUI.getPlacementOfWidget("pocket-button")` we
 might want to take care of when upstreaming (even though I did not figure
 out how to get a related Pocket button shown in Tor Browser for these
 cases).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605R  |Version:
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:
 |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  reopened => needs_review


Comment:

 I understand the behavior better now. After studying the pocket code
 carefully I came up with the following patch to tor-browser.git. Please
 note that the "browser.pocket.enabled" patch only takes effect after
 restart. That's consistent with the behavior of Pocket itself, which is
 not enabled or disabled until after restart.

 https://github.com/arthuredelstein/tor-browser/commit/18886+3
 Hash 6844e1209e7c509c8dc67570567e61c38061f72d

 This supersedes the torbutton patch in comment:10, which should not be
 used.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:  reopened
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I could have sworn this was working for me before! The bookmarks menu is
 definitely supposed to disappear. I'm going to reopen it to remind myself
 to figure out what's wrong. That way we can also commit a single good
 patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:  closed
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R  | Resolution:  fixed
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 It seems it does not work for me as expected. I.e. once I get the Pocket
 button onto the toolbar disabling the pref removes it but a) after a
 restart I can't enable it anymore easily (by flipping the pref) and b) the
 button is still in my bookmarks menu despite the patch.

 Setting the prefs in comment:3 results in the pocket but removed from the
 customizable UI panel and by default it is nowhere visible on Winodws/OS
 X/Linux. I guess this could be enough for now given all the other things
 we have to do. Closing this for now but feel free to reopen the ticket if
 I missed anything.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605R  |Version:
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:
 |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff45-esr, TorBrowserTeam201605 => ff45-esr,
 TorBrowserTeam201605R
 * status:  needs_information => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
+--
 Reporter:  mcs |  Owner:
 Type:  defect  |  arthuredelstein
 Priority:  Medium  | Status:
Component:  Applications/Tor Browser|  needs_information
 Severity:  Normal  |  Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605  |Version:
Parent ID:  | Resolution:
 Reviewer:  |  Actual Points:
| Points:
|Sponsor:
+--

Comment (by arthuredelstein):

 Replying to [comment:6 gk]:
 > Hrm. I still seem to have a "View Pocket List" item visible after
 clicking on the hamburger menu and "Bookmarks". Arthur, is that taken care
 by your patch, too? (I just flipped the prefs and restarted to test it)

 You're right - it doesn't hide those properly. Here's a torbutton patch
 that hides the menu item and button from the hamburger menu whenever the
 "browser.pocket.enabled" pref is set to false.

 https://github.com/arthuredelstein/torbutton/commit/18886
 5d8669d20152f2c6ad0f6beb908fbdc077710be7

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
+--
 Reporter:  mcs |  Owner:
 Type:  defect  |  arthuredelstein
 Priority:  Medium  | Status:
Component:  Applications/Tor Browser|  needs_information
 Severity:  Normal  |  Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201604  |Version:
Parent ID:  | Resolution:
 Reviewer:  |  Actual Points:
| Points:
|Sponsor:
+--

Comment (by bugzilla):

 Oh shi*! What's wrong with you, guys?
 Mark, you are too shy with your "consider removing". Use "remove that crap
 to hell" instead!
 Mozilla violated a lot of principles when integrated Pocket into Firefox,
 and then
 https://bugzilla.mozilla.org/show_bug.cgi?id=1172126 became the 2nd most
 voted bug in history of Firefox!
 Link in the description has everything you need to properly remove that
 crap from the codebase.
 Just do it!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
+--
 Reporter:  mcs |  Owner:
 Type:  defect  |  arthuredelstein
 Priority:  Medium  | Status:
Component:  Applications/Tor Browser|  needs_information
 Severity:  Normal  |  Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201604  |Version:
Parent ID:  | Resolution:
 Reviewer:  |  Actual Points:
| Points:
|Sponsor:
+--
Changes (by gk):

 * status:  reopened => needs_information
 * keywords:  ff45-esr, TorBrowserTeam201604R => ff45-esr,
 TorBrowserTeam201604


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:  reopened
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201604R  | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by gk):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Hrm. I still seem to have a "View Pocket List" item visible after clicking
 on the hamburger menu and "Bookmarks". Arthur, is that taken care by your
 patch, too? (I just flipped the prefs and restarted to test it)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:  closed
Component:  Applications/Tor Browser |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, TorBrowserTeam201604R  | Resolution:  fixed
Parent ID:   |  Actual Points:
 Reviewer:   | Points:
 |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Fixed with commit d592a0e41881c06e6d93c4f272ea7e4f3ea6e9bb on tor-
 browser-45.1.0esr-6.0-1, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
-+-
 Reporter:  mcs  |  Owner:
 Type:  defect   |  arthuredelstein
 Priority:  Medium   | Status:
Component:  Applications/Tor Browser |  needs_review
 Severity:  Normal   |  Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201604R  |Version:
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:
 |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  accepted => needs_review
 * keywords:  ff45-esr => ff45-esr, TorBrowserTeam201604R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
--+-
 Reporter:  mcs   |  Owner:  arthuredelstein
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff45-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by arthuredelstein):

 Replying to [comment:1 cypherpunks]:
 > In Firefox 45 ESR the preference is browser.pocket.enabled.  As a
 defense-in-depth measure, browser.pocket.api and browser.pocket.site
 should be set to the empty string.

 Thanks for pointing these out. I agree that disabling Pocket is a good
 idea. Here's a patch that does that:

 https://github.com/arthuredelstein/tor-browser/commit/18886
 Hash: 9c1768026600b2f05efa2b31cb9f4a57b23220c2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
--+-
 Reporter:  mcs   |  Owner:  arthuredelstein
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff45-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by arthuredelstein):

 * status:  new => accepted
 * owner:  tbb-team => arthuredelstein


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
--+--
 Reporter:  mcs   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff45-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 In Firefox 45 ESR the preference is browser.pocket.enabled.  As a defense-
 in-depth measure, browser.pocket.api and browser.pocket.site should be set
 to the empty string.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
--+--
 Reporter:  mcs   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff45-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Firefox 45 ESR includes Pocket client code and UI. We may want to remove
 it, since it encourages use of a third party service that we do not know
 much about.

 Maybe all we need to do is set extensions.pocket.enabled = false to
 disable it.

 It is also worth noting that for Firefox 46, the Pocket code has been
 pulled out of the core browser and moved to a system extension (see
 https://bugzilla.mozilla.org/show_bug.cgi?id=1215694)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs