Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
-+-
 Reporter:  RainerSchmidt|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Major| Resolution:  fixed
 Keywords:  Solaris, regression, crash,  |  Actual Points:  .3
  028-backport   |
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.2.8.x-final => Tor: 0.2.9.x-final


Comment:

 No 0.2.8 backport planned; too big.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
-+-
 Reporter:  RainerSchmidt|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Major| Resolution:
 Keywords:  Solaris, regression, crash,  |  Actual Points:  .3
  028-backport   |
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  Solaris, regression, crash, review-group-8 => Solaris,
 regression, crash, 028-backport
 * status:  merge_ready => needs_review


Comment:

 Okay, merging this to master, as "probably harmless".  Not going to do an
 0.2.8 backport, though, unless it's actually confirmed to help.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
-+-
 Reporter:  RainerSchmidt|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.5-rc
 Severity:  Major| Resolution:
 Keywords:  Solaris, regression, crash, review-  |  Actual Points:  .3
  group-7|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 The fix does look OK to me but it's just impossible for me to confirm.

 As for the trunnel commit, +9k! I actually need that one :).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:  .3
 Reviewer:  | Points:  0.2
|Sponsor:
+--

Comment (by nickm):

 That's strange.  These aren't the same warnings; these are about autoconf
 failing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:  .3
 Reviewer:  | Points:  0.2
|Sponsor:
+--

Comment (by RainerSchmidt):

 Thanks, I tried your recommendation but failed, still getting the same
 problem.
 After successful running

   git clone ​​https://git.torproject.org/nickm/tor.git

 I changed to the tor directory and run

   git checkout solaris_warnings_028

 This seemed successful, so I run:

   sh autogen.sh

 and got the same warnings/errors then before (please see:
 
''[https://trac.torproject.org/projects/tor/attachment/ticket/19767/solaris_warnings_028.log.tgz
 solaris_warnings_028.log.tgz]''[https://trac.torproject.org/projects/tor
 /raw-attachment/ticket/19767/solaris_warnings_028.log.tgz ​)]
 Any help is appreciated

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:  .3
 Reviewer:  | Points:  0.2
|Sponsor:
+--

Comment (by nickm):

 You're almost there!  But you're on the master branch, and you need to
 switch to the 'solaris_warnings_028' branch.  To do that (assuming you
 have a halfway recent git) just run "git checkout solaris_warnings_028".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:  .3
 Reviewer:  | Points:  0.2
|Sponsor:
+--

Comment (by RainerSchmidt):

 I'm not an expert, I tried the fix described above as follows, but it
 didn't work:
   git clone ​https://git.torproject.org/nickm/tor.git
 After downloading I checked the README and because there is no
 "./configure" I used:
   sh autogen.sh
 but this gave the warnings/errors in the attached log: tor_git.log.

 I'm not an expert in building/compiling SW with git (in the past I used
 download source and ./configure).
 So please help to get it working.
 Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:  .3
 Reviewer:  | Points:  0.2
|Sponsor:
+--
Changes (by nickm):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:  nickm
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:  .3
 Reviewer:  | Points:  0.2
|Sponsor:
+--
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted
 * actualpoints:   => .3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:
 Reviewer:  | Points:  0.2
|Sponsor:
+--

Comment (by nickm):

 > I don't think we can break a platform.

 Well, it apparently isn't a platform that anybody tested 0.2.8 on at any
 time in the last 5 months. So I'm not sure it's a good idea to apply any
 patch here without a lot of testing, or to hold up the 0.2.8.6 release for
 all the platforms whose users _did_ test one of the alphas.

 That said, I've tried to fix up the warnings in a branch called
 "solaris_warnings_028" in my public git repository at
 https://git.torproject.org/nickm/tor.git .  If the file_offset_bits issue
 is causing the crash, I hope this will fix that.  Please review and test?

 I worry that these changes might break compilation on other platforms.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:
 Reviewer:  | Points:  0.2
|Sponsor:
+--

Comment (by nickm):

 This warning appears 25 times.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:
 Reviewer:  | Points:  0.2
|Sponsor:
+--

Comment (by nickm):

 It looks like we need include orconfig.h before we include anything that
 includes feature_tests.h.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
-+
 Reporter:  RainerSchmidt|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.2.8.5-rc
 Severity:  Major| Resolution:
 Keywords:  Solaris, regression  |  Actual Points:
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * keywords:  Solaris, core dump, compile warning_FILE_OFFSET_BITS =>
 Solaris, regression
 * points:   => 0.2
 * milestone:   => Tor: 0.2.8.x-final


Comment:

 I don't think we can break a platform.
 So this needs to be fixed before 0.2.8-stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
+--
 Reporter:  RainerSchmidt   |  Owner:
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
Component:  Core Tor/Tor|  0.2.8.x-final
 Severity:  Major   |Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  | Resolution:
Parent ID:  |  Actual Points:
 Reviewer:  | Points:  0.2
|Sponsor:
+--
Changes (by teor):

 * keywords:  Solaris, regression => Solaris, regression, crash


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
-+-
 Reporter:   |  Owner:
  RainerSchmidt  | Status:  new
 Type:  defect   |  Milestone:
 Priority:  Medium   |Version:  Tor: 0.2.8.5-rc
Component:  Core |   Keywords:  Solaris, core dump, compile
  Tor/Tor|  warning_FILE_OFFSET_BITS
 Severity:  Major|  Parent ID:
Actual Points:   |   Reviewer:
   Points:   |
  Sponsor:   |
-+-
 I'm trying to get tor-0.2.8.5-rc running, but compile warnings and core
 dumps. ( tor-0.2.7.6 works )

 Environment: Solaris 10, Intel 32bit, gcc 5.2.0

 When compiling I get the warnings like these:

 "...
 In file included from src/test/test-child.c:5:0:
 ./orconfig.h:689:0: warning: "_FILE_OFFSET_BITS" redefined

   #define _FILE_OFFSET_BITS 64

 In file included from /usr/include/stdio.h:21:0,

   from src/test/test-child.c:4:

 /opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-
 fixed/sys/feature_[tests.h:196:0 tests.h:196:0]: note: this is the
 location of the previous definition

   #define _FILE_OFFSET_BITS 32

 ..."

 The binary gets build, but when I run:
 gmake test
 or
 gmake install and start tor,
 it dies with a core dump.

 tor-0.2.7.6 runs fine

 Please help getting the issue fixed, any help is appreciated!

 Thanks.

 Regards
 Rainer

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs