Re: [tor-bugs] #20037 [Metrics/CollecTor]: Add support for Bifroest's bridge descriptor tarballs

[Tor Bug Tracker & Wiki]

#20037: Add support for Bifroest's bridge descriptor tarballs
---+
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged, closing.  Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20037 [Metrics/CollecTor]: Add support for Bifroest's bridge descriptor tarballs

[Tor Bug Tracker & Wiki]

#20037: Add support for Bifroest's bridge descriptor tarballs
---+-
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 added reminder to #19755 for additional tests; this could be closed after
 merge then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20037 [Metrics/CollecTor]: Add support for Bifroest's bridge descriptor tarballs

[Tor Bug Tracker & Wiki]

#20037: Add support for Bifroest's bridge descriptor tarballs
---+--
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by iwakeh):

 Replying to [comment:3 karsten]:
 > We won't have time to add tests before deploying, because, erm, it's
 deployed as of 60 minutes ago.  And I guess I should push what I'm
 running, in particular as it didn't break.  Unless I shouldn't?!
 >

 Well, if its running it should be committed, so we know what is running.
 Not breaking doesn't necessarily mean 'working as expected' to me. (I hope
 it does here.)

 > But we can always add more tests going forward.  How about we do that
 together with the other bridgedescs module tests that I wrote on some
 other ticket?

 Yes, that would be very good and sort of the only type of documentation
 for that code.
 Of course, the code itself tells something, but often it does not exactly
 what was expected by the author.  These tests will also reduce maintenance
 time a lot in future.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20037 [Metrics/CollecTor]: Add support for Bifroest's bridge descriptor tarballs

[Tor Bug Tracker & Wiki]

#20037: Add support for Bifroest's bridge descriptor tarballs
---+--
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 We won't have time to add tests before deploying, because, erm, it's
 deployed as of 60 minutes ago.  And I guess I should push what I'm
 running, in particular as it didn't break.  Unless I shouldn't?!

 But we can always add more tests going forward.  How about we do that
 together with the other bridgedescs module tests that I wrote on some
 other ticket?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20037 [Metrics/CollecTor]: Add support for Bifroest's bridge descriptor tarballs

[Tor Bug Tracker & Wiki]

#20037: Add support for Bifroest's bridge descriptor tarballs
---+--
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by iwakeh):

 It would be great to have some tests for this addition. Is there time for
 that?
 If not these should be added as soon as possible.
 Maybe add some more inline comments with possible test cases now that will
 help adding tests later?

 The tests will be very important when huge methods like in
 BridgeSnapshotReader (just the constructor has more than 200 lines) or in
 SanitizedBridgesWriter (almost 200 lines in one method) will undergo
 refactoring.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20037 [Metrics/CollecTor]: Add support for Bifroest's bridge descriptor tarballs

[Tor Bug Tracker & Wiki]

#20037: Add support for Bifroest's bridge descriptor tarballs
---+--
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * status:  new => needs_review


Comment:

 Please review [https://gitweb.torproject.org/karsten/metrics-
 db.git/log/?h=task-20037 my branch task-20037].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20037 [Metrics/CollecTor]: Add support for Bifroest's bridge descriptor tarballs

[Tor Bug Tracker & Wiki]

#20037: Add support for Bifroest's bridge descriptor tarballs
---+-
 Reporter:  karsten|  Owner:
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+-
 The current bridge authority Tonga will be shut down in a few days.  The
 new bridge authority Bifroest is up and running for a few days now and
 will take over.  See #19690 for details about the transition.

 We'll have to handle Bifroest's bridge descriptor taballs, which we can't
 do right now.  I'll post a branch in a second.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs