Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.6
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
  043-can|
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:  0.5 => 0.6


Comment:

 Merged to master.

 Merged #32962, #32984, and #20218 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
  043-can|
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 (I also had to remove ROUTERSTATUS_FORMAT_NO_CONSENSUS_METHOD from the
 tests, also due to #32695.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
  043-can|
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Here's the PR merged into the current master, with conflicts resolved:
 * master: https://github.com/torproject/tor/pull/1673

 Waiting for CI to pass before merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
  043-can|
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 There's a conflict with #32695, which removed
 networkstatus_consensus_has_ipv6() above
 routerstatus_has_visibly_clanged(). The conflict is stopping CI from
 running,

 But the code looks good.

 I'll resolve it, run CI, then merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
  043-can|
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Okay -- I've changed the comments, updated the tests to verify that
 routerstatus_format_entry() actually changed (or hasn't), and renamed the
 identifier.  I went with "visibly" instead of "control", but I'm open to
 suggestions for other identifiers that aren't even longer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
  043-can|
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 The implementation of routerstatus_has_changed() is correct, it's only
 designed to detect changes in the control port routerstatus format. Let's
 rename routerstatus_has_changed() to a name that contains "control"?

 If you'd like to remove the named and unnamed code, let's do it in another
 ticket, and try to remove as much as we can.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
  043-can|
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've rebased on master (to sort out the merge history) and added a unit
 test, as `ticket20218_rebased` with PR at
 https://github.com/torproject/tor/pull/1670 .

 I have some questions in the unit test about particular fields; please let
 me know what you think there, and I'll revise the test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
  043-can|
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 ipv6, 029-proposed, tor-control, easy, spec-conformance, review-
 group-31, 034-triage-20180328, 034-removed-20180328
 =>
 ipv6, 029-proposed, tor-control, easy, spec-conformance, review-
 group-31, 034-triage-20180328, 034-removed-20180328 043-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => assigned
 * reviewer:  nickm, teor => teor
 * owner:  (none) => nickm


Comment:

 Nick is going to write some tests, and then I'll review and merge the
 whole branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm, teor  |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm, teor  |Sponsor:
-+-

Comment (by maurice_pibouin):

 I would actually love some help !
 I am a complete beginner in C, so I don't know how to go around with
 writing the makefile for my test (just to see if my tests work). I have
 follwed tutorials on how to write makefiles, but the issue is that when I
 include "feature/nodelist/networkstatus.h" in my test file, it says  :
 {{{
 networkstatus.h:15:10: fatal error: lib/testsupport/testsupport.h: No such
 file or directory
  #include "lib/testsupport/testsupport.h"
 }}}
 The makefile I have so far is :

 {{{
 CC = gcc
 CFLAGS = -I.
 DEPS = feature/nodelist/networkstatus.h feature/nodelist/routerstatus_st.h

 %.o: %.h $(DEPS)
 $(CC) -c -o $@ $< $(CFLAGS)

 test_routerstatus_has_changed: networkstatus.o routerstatus_st.h
 $(CC) -o hellomake networkstatus.o routerstatus_st.o

 }}}
 I temporarily placed it in the "src/test" directory.

 What steps should I take to write my test makefile ? Since I don't want to
 go through "making" the whole Tor project everytime I want to see if my
 test file works.
 Also, is this the right place to ask for help ? It feels weird posting
 questions on an issue.
 Thanks !

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm, teor  |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Looks fine to me, just a little tweak to the changes file.

 We usually require unit tests before we merge.

 Let us know if you need help writing tests :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm, teor  |Sponsor:
-+-
Changes (by maurice_pibouin):

 * status:  needs_revision => needs_review


Comment:

 Made changes according to reviews, will add unit tests at a later time if
 that's ok.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm, teor  |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:  nickm => nickm, teor


Comment:

 Just a few changes needed to the fields, comments, and changes file.

 I also think we need unit tests for:
 * `routerstatus_has_changed()`, and
 * `routerstatus_format_entry(..., NS_CONTROL_PORT, ...)`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by maurice_pibouin):

 Created pull request as suggested :
 https://github.com/torproject/tor/pull/1549

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.4.3.x-final


Comment:

 If you can make a GitHub pull request against torproject/tor/master, the
 reviewer will find it easier to review your code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by maurice_pibouin):

 * status:  needs_revision => needs_review


Comment:

 Hi ! First attempt at a patch on tor, tried to do it right.
 See https://github.com/vnepveu/tor/tree/vnepveu.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,   |
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by maurice_pibouin):

 * cc: maurice_pibouin (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31|
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Replying to [comment:31 nickm]:
 > teor, I think you have tor_addr_compare backwards. Its documentation
 says:
 > {{{
 >  * Given two addresses addr1 and addr2, return 0 if the
 two
 >  * addresses are equivalent under the mask mbits, less than 0 if addr1
 >  * precedes addr2, and greater than 0 otherwise.
 > }}}
 >
 > So the original use of tor_addr_compare (without "!") is correct.

 You're right. Oops!

 > (Unit tests would have caught this bug; that's one reason why unit tests
 are so great. ;) Any chance of writing those?)

 I think we should have unit tests.

 > As a smaller issue, it seems that this patch says the same line twice:
 > {{{
 >  a->is_hs_dir != b->is_hs_dir ||
 >  a->is_hs_dir != b->is_hs_dir ||
 > }}}
 >
 > ---
 > Another question: how did you decide on the list of fields to check?  It
 seems that some but not all of the fields in routerstatus_t are now
 checked for equality, but I don't understand the rationale about why the
 remaining ones (pv, exitsummary) are not.  Is that intentional?

 We only check the fields that are output via the control port.
 We should revise this like to say "only" not "also":
 {{{
 /* Given two router status entries for the same router identity, return 1
 if
  * if the contents have changed between them. Otherwise, return 0.
  * It also checks for changes for that are output by control port. */
 }}}

 
https://github.com/ArunaMaurya221B/tor/commit/e29292dda5ef68e441f267864357a7568b29588e
 #diff-fcb162b79906521706b54d280b939d57R1540

 > ---
 >
 > Teor asks:
 > >  How can we make sure we update functions when we add new members to a
 struct?
 >
 > In some cases, using a constructor for a struct instance will work,
 since we have turned on the options that let us know about any
 uninitialized members.  But in cases like this, I don't see an easy way to
 use a constructor.
 >
 > One option here would be to stop assuming that we list all relevant the
 members here.  We could instead change the code that we only list the
 ''irrelevant'' members, by:
 >   1. Making sure that when we construct routerstatus_t, we initialize
 the whole object to 0.
 >   2. In a function like this, using memcpy() to make a temporary copy of
 the routerstatus_t.
 >   3. Instead of listing all the relevant members in a comparison, we
 could just use fast_memeq() to compare.  If there are some members we
 don't want to compare, we would set them to 0 before calling fast_memeq().
 > I'm not sure if this is actually a good idea, though.

 I think it is enough to comment the control port printing function, and
 this function, and say that they must be kept in sync.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31|
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 teor, I think you have tor_addr_compare backwards. Its documentation says:
 {{{
  * Given two addresses addr1 and addr2, return 0 if the two
  * addresses are equivalent under the mask mbits, less than 0 if addr1
  * precedes addr2, and greater than 0 otherwise.
 }}}

 So the original use of tor_addr_compare (without "!") is correct.

 (Unit tests would have caught this bug; that's one reason why unit tests
 are so great. ;) Any chance of writing those?)

 As a smaller issue, it seems that this patch says the same line twice:
 {{{
  a->is_hs_dir != b->is_hs_dir ||
  a->is_hs_dir != b->is_hs_dir ||
 }}}

 ---
 Another question: how did you decide on the list of fields to check?  It
 seems that some but not all of the fields in routerstatus_t are now
 checked for equality, but I don't understand the rationale about why the
 remaining ones (pv, exitsummary) are not.  Is that intentional?

 ---

 Teor asks:
 >  How can we make sure we update functions when we add new members to a
 struct?

 In some cases, using a constructor for a struct instance will work, since
 we have turned on the options that let us know about any uninitialized
 members.  But in cases like this, I don't see an easy way to use a
 constructor.

 One option here would be to stop assuming that we list all relevant the
 members here.  We could instead change the code that we only list the
 ''irrelevant'' members, by:
   1. Making sure that when we construct routerstatus_t, we initialize the
 whole object to 0.
   2. In a function like this, using memcpy() to make a temporary copy of
 the routerstatus_t.
   3. Instead of listing all the relevant members in a comparison, we could
 just use fast_memeq() to compare.  If there are some members we don't want
 to compare, we would set them to 0 before calling fast_memeq().
 I'm not sure if this is actually a good idea, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance, review-group-31|
Parent ID:   | Points:  .1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:  0.5
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review
 * actualpoints:   => 0.5


Comment:

 This looks fine to me, but it needs a review, and a changes file. It might
 also help if it had unit tests.

 A question for the team:
 How can we make sure we update functions when we add new members to a
 struct?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 Corrected! [https://github.com/ArunaMaurya221B/tor/commits/Bug-20218]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Thanks! The check for tor_addr_compare() is around the wrong way.
 Just like ==, tor_addr_compare() returns true when it's arguments are
 equal.

 You need to add a ! before the function call.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 Oh !!My bad:(
 I have done the final
 changes:[https://github.com/ArunaMaurya221B/tor/commits/Bug-20218]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Hi, this branch doesn't compile, it has extra "+" at the start of some
 lines.
 Please run "make check" before submitting patches,

 Also, please remove this comment, because this patch fixes it:
 {{{
//  this function needs a huge refactoring; it has gotten out
//  of sync with routerstatus_t, and it will do so again.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 Here's it. I have put it in a separate branch:
 
[https://github.com/ArunaMaurya221B/tor/commit/e29292dda5ef68e441f267864357a7568b29588e]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 This looks good, but please submit one patch file based on the master
 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by aruna1234):

 * Attachment "0004-Refactored-the-function-to-check-all-fields.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 Have added the extra checks, and uploaded a new patch file.
 Do let me know if there are any further changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, 029-proposed, tor-control, |  Actual Points:
  easy, spec-conformance |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  029-proposed, tor-control, easy, spec-conformance => ipv6,
 029-proposed, tor-control, easy, spec-conformance
 * status:  new => needs_revision
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 Oh, I'm sorry, I've been giving you bad advice. I must have searched for
 the wrong function name.

 We don't need a new function. We need to change the existing function to
 look at more fields.

 Here's what we need to do:

 The routerstatus_t struct has a lot of fields. routerstatus_has_changed()
 checks a few of them. But it needs to check every field that is output by
 networkstatus_getinfo_helper_single().

 These missing fields can be compared using !=:
 * published
 * ipv6_orport
 * is_v2_dir
 * bandwidth_kb

 This missing field must be compared using tor_addr_compare(..., ...,
 CMP_EXACT):
 * ipv6_addr

 We don't need to worry about the summarised IPv4 exit policy output by
 networkstatus_getinfo_helper_single(). The descriptor_digest check will
 find changes in this field.

 Then we need to add comments to routerstatus_has_changed() saying that it
 checks for changes that are output by the control port. And we need to add
 a comment to routerstatus_format_entry() saying that any extra control
 port fields need to be added to routerstatus_has_changed() as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Your new function should have the same arguments and return type as
 routerstatus_has_changed():
 {{{
 static int
 routerstatus_has_changed(const routerstatus_t *a, const routerstatus_t *b)
 }}}
 https://gitweb.torproject.org/tor.git/tree/src/or/networkstatus.c#n1541

 So now that you have two routerstatus objects, what can you do?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 Have added a patch file. Do let me know, if the changes are correct,
 although I doubt as 'now' is not a structure member.
 But if I need to check for change in timestamp, and published_on is my
 parameter, then I need to compare it with something.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by aruna1234):

 * Attachment "0003-Bug-20218-Function-added-to-check-for-new-file-
 descr.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 Then this check would be the right one, I suppose:

 /* Function to check for new descriptors. Returns 0 if changed, else 1 */

 static int check_tiemstamp(const routerstatus_t *a)
 {
 if(a->published_on == a->now)
 return 1;
 else
 return 0;
 }

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 But that check isn't the right check: you only want newer descriptors.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Yes, this field is the right field.

 Here's how to do this patch:
 1. Create a new function that just checks this field
 2. Find all calls to router_has_changed() in control.c and from controller
 helper functions
 3. Replace them with a call to this new function

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 The definition of the routerstatus_t structure, as in or.h has only
 `time_t published_on`. Is that the required timestamp to check.
 A check like, (a->published_on != b->published_on) would do the task?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 No, the timestamp is in the router structure that is passed to the
 function.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 Hey!

 I went through the code of networkstatuc.c.Can the timestamp be changed by
 checking time_t now parameter?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 routerstatus_has_changed() checks for some differences in descriptors.
 This is the right thing to do when the function is called from some code.
 But it hides some changed descriptors from controllers.

 When called from control port code, the function should check if the
 timestamp has changed. That will give the controller *all* the changed
 descriptors.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 By different kinds of changes, you mean checking whether there are any new
 descriptors or not? And then changing the function calls as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 There are a few different issues:
 * the function comment needs to say that the function checks for semantic
 changes
 * the function is used by two different parts of the code, and the
 controller part needs it to check for more changes

 The controller part of the code wants all new descriptors:
 https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n2144

 The other part of the code just wants descriptors that are different
 enough to matter.

 This means adding an argument to the function that makes it check for
 different kinds of changes. Or making two functions. But we try not to
 copy and paste code, we get functions to call other functions instead.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 So the issue is with that router_has_changed() is not properly documented.
 The fact that it only checks for semantic changes that tor cares about, is
 not documented?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed, tor-control, easy, |  Actual Points:
  spec-conformance   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  029-proposed, tor-control => 029-proposed, tor-control, easy,
 spec-conformance


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-+--
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed controller  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+--

Comment (by nickm):

 (do not change this till #19958 is merged)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
--+-
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  029-proposed controller
Actual Points:|  Parent ID:
   Points:  .1|   Reviewer:
  Sponsor:|
--+-
 The routerstatus_has_changed() function is used by controllers to to tell
 which rs entries are new.  But it only looks at a fraction of the fields
 which might change in a routerstatus.  Also, it only checks for semantic
 changes that tor cares about (though this is not documented).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs