Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by mcs):

 Replying to [comment:11 teor]:
 > Looks like a completely different issue. Please open a new ticket.
 > (I'm not sure why that assertion is even there.)

 Thanks for the quick feedback. I created #20494.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by teor):

 Replying to [comment:10 mcs]:
 > I encountered another one of these when testing tor master with Tor
 Browser:
 >  Oct 28 10:38:31.000 [warn] tor_bug_occurred_: Bug:
 src/or/connection_edge.c:1593: connection_ap_handshake_rewrite_and_attach:
 This line should not have been reached. (Future instances of this warning
 will be silenced.) (on Tor 0.3.0.0-alpha-dev f3e158edf7d8128d)
 >
 > I will attach the stack trace that was logged.
 > Should I open a new ticket or should I reopen this one?

 Looks like a completely different issue. Please open a new ticket.
 (I'm not sure why that assertion is even there.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by mcs):

 I encountered another one of these when testing tor master with Tor
 Browser:
  Oct 28 10:38:31.000 [warn] tor_bug_occurred_: Bug:
 src/or/connection_edge.c:1593: connection_ap_handshake_rewrite_and_attach:
 This line should not have been reached. (Future instances of this warning
 will be silenced.) (on Tor 0.3.0.0-alpha-dev f3e158edf7d8128d)

 I will attach the stack trace that was logged.
 Should I open a new ticket or should I reopen this one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by mcs):

 My tests with Tor Browser show that these changes fix the problem.
 Thank you Nick and Yawning!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  closed
 Priority:  High   |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 2e7e635c593f13 tweaks this a little as discussed above.  Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  needs_review
 Priority:  High   |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by nickm):

 Looks good to me, but I have one question.

 In case there are other places in the code --or there later become places
 in the code! -- where we compare two AF_UNIX addresses, maybe we should
 make them turn out _unequal_ by default?  I think that missing a match is
 probably safer than reporting a spurious match, right?  If you agree, I'll
 switch the hack to do a pointer comparison.

 (Also, a note on tor_addr_t : the main reason to use tor_addr_t at all,
 instead of sockaddr_storage, was to keep it small in the case where we
 need to create a zillion of them. So if we're going to make AF_UNIX
 firstclass, we'll need some other approach to keeping it small.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  needs_review
 Priority:  High   |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by yawning):

 * status:  assigned => needs_review


Comment:

 This is ugly because we never bothered to treat AF_UNIX as a full class
 citizen.  In particular `tor_addr_t` doesn't contain the path at all, so
 when we go to compare them, there isn't any information regarding the
 address beyond the family.

 The correct solution is probably to extend tor_addr_t to Do The Right
 Thing, but this branch should cover Tor Browser's use cases.  The first
 commit is probably safe to take since it's the `IsolateClientAddr` change,
 the second may be more controversial.

 https://git.schwanenlied.me/yawning/tor/src/bug20261

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * priority:  Medium => High


Comment:

 Putting this as High because tbb-needs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * milestone:   => Tor: 0.2.9.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by yawning):

 * status:  new => assigned


Comment:

 The assert still happens because we always compare addresses regardless of
 if IsolateClientAddr is set.

 This requires a few changes I think, after looking at it:

  * We need to disable `IsolateClientAddr` whne using AF_LOCAL sockets
 (Easy, done in my branch).
  * `tor_addr_compare_masked()` should probably handle AF_LOCAL sockets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by mcs):

 Adding `NoIsolateClientAddr` did not fix the problem for me on OSX. I will
 attach a stack trace.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
---+
 Reporter:  mcs|  Owner:  yawning
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor   |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal | Resolution:
 Keywords:  tbb-needs  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by mcs):

 Yawning says we can work around this by adding the `NoIsolateClientAddr`
 to the SocksPort isolation flags.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20261 [Core Tor]: tor_fragile_assert() when Unix domain socket is used

[Tor Bug Tracker & Wiki]

#20261: tor_fragile_assert() when Unix domain socket is used
--+
 Reporter:  mcs   |  Owner:  yawning
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:  Tor: 0.2.9.2-alpha
 Severity:  Normal|   Keywords:  tbb-needs
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 When a Unix domain socket is used for the SocksPort, a soft assertion is
 triggered inside tor_addr_compare_masked(). Log message:
  Sep 28 11:34:45.000 [warn] tor_bug_occurred_(): Bug:
 src/common/address.c:1119: tor_addr_compare_masked: This line should not
 have been reached. (Future instances of this warning will be silenced.)
 (on Tor 0.2.9.2-alpha 00ec701f8343f552)

 The config used is:
  SocksPort unix:/Users/.../TorBrowser-Data/Tor/socks.socket IPv6Traffic
 PreferIPv6 KeepAliveIsolateSOCKSAuth

 For more details, see: ticket:20111#comment:13

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs