Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711, tbb-rbm |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-
 safe-exception-handlers?redirectedfrom=MSDN=vs-2019
 {{{
 /SAFESEH is only valid when linking for x86 targets. /SAFESEH is not
 supported for platforms that already have the exception handlers noted.
 For example, on x64 and ARM, all exception handlers are noted in the
 PDATA. ML64.exe has support for adding annotations that emit SEH
 information (XDATA and PDATA) into the image, allowing you to unwind
 through ml64 functions. See MASM for x64 (ml64.exe) for more information.
 }}}
 So, 64bit files `PASS` in our check script just because they are 64bit
 ones. I wonder whether we need to do more here, though, given that we
 don't use `ML64.exe`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711, tbb-rbm |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:10 gk]:
 > Replying to [comment:9 gk]:
 > > I think we are done here with mingw-w64-clang but we should double-
 check that.
 >
 > It seems the mingw-w64/gcc toolchain is not doing the right thing for
 32bit exe/dll files. Thus, fixing this needs #29318 solved first, too.

 PTs based on `Go` need separate treatment. I've opened #31716 for `obfs4`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711, tbb-rbm |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * parent:  #29318 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711, tbb-rbm |
Parent ID:  #29318   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * parent:   => #29318


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711, tbb-rbm |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:9 gk]:
 > I think we are done here with mingw-w64-clang but we should double-check
 that.

 It seems the mingw-w64/gcc toolchain is not doing the right thing for
 32bit exe/dll files. Thus, making this needs #29318 solved first, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711, tbb-rbm |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * keywords:  tbb-security, TorBrowserTeam201711, GeorgKoppen201711 => tbb-
 security, TorBrowserTeam201711, GeorgKoppen201711, tbb-rbm


Comment:

 I think we are done here with mingw-w64-clang but we should double-check
 that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * parent:  #21777 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711  |
Parent ID:  #21777   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by cypherpunks):

 Replying to [comment:6 gk]:
 > I did some digging and with our GCC-based toolchain this is tricky right
 now.
 Read comment:3. There is nothing tricky in adding one flag.
 > Thus, it makes no sense to fix this bug right now for the current
 toolchain.
 Quite the opposite.
 > There is a very real security benefit to this, mainly because it's so
 easy for malware to corrupt the SEH chain. Once the SEH chain is
 corrupted, it's typically very easy to cause an exception, at which point
 the exception handling machinery will go and dispatch execution to the
 handlers indicated in the chain. If a handler points into a DLL which
 doesn't have NO-SEH or SAFESEH, execution will transfer to that address
 without trouble.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711  |
Parent ID:  #21777   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * priority:  Very High => Medium
 * parent:   => #21777


Comment:

 I did some digging and with our GCC-based toolchain this is tricky right
 now. However, we probably need a clang-based toolchain for ESR 59 anyway
 due to https://bugzilla.mozilla.org/show_bug.cgi?id=1390583 and it seems
 we'd get SafeSEH when switching. Thus, it makes no sense to fix this bug
 right now for the current toolchain. We should get SafeSEH with #21777
 being fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-+-
 Reporter:  bugzilla |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711,  |  Actual Points:
  GeorgKoppen201711  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * keywords:  tbb-security => tbb-security, TorBrowserTeam201711,
 GeorgKoppen201711
 * sponsor:   => Sponsor4


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-security  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 https://bugs.chromium.org/p/chromium/issues/detail?id=99901

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-security  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 As there is no activity on this problem, should we proceed with the public
 disclosure?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-security  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * parent:  #16010 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
--+--
 Reporter:  bugzilla  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-security
Actual Points:|  Parent ID:  #16010
   Points:|   Reviewer:
  Sponsor:|
--+--
 Not only SEH, because of www.fuzzysecurity.com/tutorials/expDev/3.html
 Even YASM can do it https://www.tortall.net/projects/yasm/manual/html
 /objfmt-win32-safeseh.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs