Re: [tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good, merged to master.  Thanks!  Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+--
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by iwakeh):

 This is the
 
[https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-20523=8419a062967efcf25359d7c3c88c972afac177c0
 correct link].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+--
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by iwakeh):

 Oh, I forgot to commit the move of logging.properties into resources.
 
[https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-20523=f6668f1bccd7ea352263b4bd99ffd40d98f88bf8
 amended here]

 I'd rather keep logging configuration in 'resources' than in 'webapp'.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+--
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Thanks for those fixes.  The only thing I'm still missing is
 `logging.properties`.  Mind taking a look at the last commit in
 [https://gitweb.torproject.org/user/karsten/exonerator.git/log/?h=task-20523
 my updated task-20523 branch]?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by iwakeh):

 Replying to [comment:3 karsten]:
 > Thanks for looking at the patch and for making those build changes.
 >
 > Would you mind making some more changes to that `build.xml`?  (I'm
 terrible at finding the correct Ant commands for all those things.)
 >

 Sure, please find the
 
[https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-20523=fda2f01de78b68dca9726291de3372910ad7996c
 amended branch].

 Thanks for checking this thoroughly!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Thanks for looking at the patch and for making those build changes.

 Would you mind making some more changes to that `build.xml`?  (I'm
 terrible at finding the correct Ant commands for all those things.)

  - `src/main/webapp/logging.properties` needs to be included in
 `exonerator.war` as `WEB-INF/classes/logging.properties` (currently
 missing).
  - `src/main/webapp/css/*` need to be included in `exonerator.war` as
 `css/*` (currently in root).
  - `src/main/webapp/images/*` need to be included in `exonerator.war` as
 `images/*` (currently in root).
  - `config` can be omitted from `exonerator.war` (currently in `WEB-
 INF/classes/`)
  - `src/main/resources/db/exonerator.sql` can be omitted from
 `exonerator.war` (currently in `WEB-INF/classes/db/`)
  - Is the `etc` property actually used?
  - Can you include `${libs}/gson-2.2.4.jar` in the classpath (was already
 missing before).

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+--
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by iwakeh):

 Looks fine, nice to see all those lines replaced by standard-metrics-lib
 parsing!

 Please find a commit on top of that
 
[https://gitweb.torproject.org/user/iwakeh/exonerator.git/commit/?h=task-20523=ee2f00516037378a98657efd0c8ba2a37f03f385
 here] straightening out the project structure toward metrics project
 standards.
 And, please test thoroughly, if this still works as expected.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+--
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by karsten):

 * cc: iwakeh (added)
 * status:  new => needs_review


Comment:

 Please review
 [https://gitweb.torproject.org/user/karsten/exonerator.git/log/?h=task-20523
 my task-20523 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

[Tor Bug Tracker & Wiki]

#20523: Use metrics-lib for parsing descriptors
+-
 Reporter:  karsten |  Owner:
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Metrics/ExoneraTor  |Version:
 Severity:  Normal  |   Keywords:
Actual Points:  |  Parent ID:
   Points:  |   Reviewer:
  Sponsor:  |
+-
 We're using metrics-lib for downloading descriptors from CollecTor, but
 we're still using our own parsing code.  Let's avoid duplicating code by
 using what metrics-lib provides.

 Also update to Java 7 and metrics-lib 1.5.0.

 Branch follows in a moment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs