Re: [tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

[Tor Bug Tracker & Wiki]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
-+-
 Reporter:  dgoulet  |  Owner:
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, easy, refactoring, review-   |  implemented
  group-12   |  Actual Points:
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  SponsorR-can
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

[Tor Bug Tracker & Wiki]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
-+-
 Reporter:  dgoulet  |  Owner:
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, easy, refactoring, review-   |  Actual Points:
  group-12   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
 |  SponsorR-can
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

[Tor Bug Tracker & Wiki]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
---+---
 Reporter:  dgoulet|  Owner:
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, easy, refactoring  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:  SponsorR-can
---+---
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Thanks neel! lgtm! I only fixed one thing which is that I put back this
 comment in the code ;).
 {{{
 -/* === ENCODING === */
 }}}

 I've put the patch in a branch and added an extra fixup commit for the
 above: `ticket20568_030_01`

 NOTE: this patch doesn't make `router.c` use this function, it's only use
 by the HS subsystem so far. So maybe a second ticket once this merged on
 actually using this interface in the code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

[Tor Bug Tracker & Wiki]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
---+---
 Reporter:  dgoulet|  Owner:
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, easy, refactoring  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:  SponsorR-can
---+---

Comment (by neel):

 I created a revised patch (0001-Move-encode_cert-to-torcert.c-and-rename-
 it-to-tor_c.patch​) which merges all the changes as one commit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

[Tor Bug Tracker & Wiki]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
---+---
 Reporter:  dgoulet|  Owner:
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, easy, refactoring  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:  SponsorR-can
---+---

Comment (by neel):

 I have made an updated patch for this. Keep in mind that it is just
 additions to the first patch, but the changes you requested were made.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

[Tor Bug Tracker & Wiki]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
---+---
 Reporter:  dgoulet|  Owner:
 Type:  enhancement| Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, easy, refactoring  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:  SponsorR-can
---+---
Changes (by dgoulet):

 * status:  new => needs_revision


Comment:

 Thanks for this neel!

 * DG1: I would rename the function to something more meaningful as this
 function encoded an ed25519 certificate which is pretty specific and also
 should follow the torcert.c namespace. Maybe `tor_cert_encode_ed22519()` ?

 * DG2: You can remove it from `hs_descriptor.h` instead of commenting it
 out.

 * DG3: We have to change this log message to be a bit more generic as it's
 very specific to HS right now.
 {{{
 log_err(LD_BUG, "Couldn't base64-encode descriptor signing key
 cert!");
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

[Tor Bug Tracker & Wiki]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
---+---
 Reporter:  dgoulet|  Owner:
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, easy, refactoring  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:  SponsorR-can
---+---

Comment (by neel):

 I have attempted to do this refactoring, and please tell me what you think
 about this code.

 Thanks,
 Neel Chauhan

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c

[Tor Bug Tracker & Wiki]

#20568: Move encode_cert() from hs_descriptor.c into torcert.c
--+---
 Reporter:  dgoulet   |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-hs, easy, refactoring
Actual Points:|  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:  SponsorR-can  |
--+---
 Give it a better name, maybe improve the code to be a bit more generic and
 start using it in router.c at minimum.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs