Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  closed
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  6
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by dgoulet):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 All child ticket have been triaged. End of an era!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:  accepted
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  6
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+
Changes (by dgoulet):

 * status:  needs_review => accepted


Comment:

 Code merged but many child ticket still about some issues and sub
 features.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  enhancement   | Status:
  |  needs_review
 Priority:  Very High |  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, prop224, review-group-22  |  Actual Points:
Parent ID:  #12424| Points:  6
 Reviewer:  nickm |Sponsor:  SponsorR-
  |  must
--+

Comment (by dgoulet):

 Replying to [comment:31 asn]:
 > For some reason I can't close the ticket. ~~Trac just gives me a comment
 preview instead of closing it...
 > If someone else can close it, please do.~~
 >
 > Seems like children ticket are still open. I wonder what should we do
 with these.

 So the implementation is done and merged so I propose we unparent all
 child ticket and treat them as "normal ticket" affecting a tor subsystem
 so we can close this and move on.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+

Comment (by asn):

 For some reason I can't close the ticket. Trac just gives me a comment
 preview instead of closing it...
 If someone else can close it, please do.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+

Comment (by asn):

 So I took another look at `fcdc4bee0`. It's not an easy read, because the
 `rep_hist` subsystem (and what it expects from us) is quite strange.

 However, the commit in question does not remove any
 `rep_hist_note_used_internal()` from any legacy call points, so the
 removals should not influence the legacy system.

 It wouldn't surprise me if there are still circ timeout bugs like #23097
 in the v3 system, so I expect that we will need to fine tune the rephist
 system further as we continue with client-side prop224 testing. For now I
 think we are good. I'm closing this ticket! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+

Comment (by nickm):

 okay, I've squashed and merged.  Please close this (or leave open) once
 you know what you think about fcdc4be.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+

Comment (by asn):

 Replying to [comment:27 nickm]:
 > {{{
 > 13:03 <+nickm> 1) asn, are you sure you resolved all the open
 discussions on
 >oniongit?  It's down so I can't check for myself, but I
 will
 >believe you if you say "yeah I think so"
 > 13:04 <+nickm> 2) dgoulet and asn: can you tell me a little more about
 >fcdc4bee04dd5baa3fe82bf05e6b1cc1630aa06e ?
 > 13:04 <+nickm> I'm confused about how that patch adds and removes calls
 to
 >rep_hist_note_used_internal!
 > }}}

 Hey Nick!

 1) Yes,  we are done now. I just pushed one final commit (just now) which
 added an XXX to the trunnel definition, and now everything should have
 checkmark!

 2) So yes `fcdc4be` is a weird one and comes straight from #23097. Lots of
 info in that ticket. Unfortunately I'm not very familiar with it either.
 tl;dr David was getting crazy timeouts on his circuits and it was building
 new internal circs every 30 secs, so he asked Mike for advice on how to
 use the rephist system, and that's what Mike suggested in
 comment:3:ticket:23097 . I'll do some double checking tomorrow on the
 correctness of the patch and make sure that it won't influence legacy HSes
 if possible.

 I'll be back in this ticket tomorrow!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+

Comment (by nickm):

 {{{
 13:03 <+nickm> 1) asn, are you sure you resolved all the open discussions
 on
oniongit?  It's down so I can't check for myself, but I
 will
believe you if you say "yeah I think so"
 13:04 <+nickm> 2) dgoulet and asn: can you tell me a little more about
fcdc4bee04dd5baa3fe82bf05e6b1cc1630aa06e ?
 13:04 <+nickm> I'm confused about how that patch adds and removes calls to
rep_hist_note_used_internal!
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Some more fixes done and back in needs_review for now! Let me know what's
 next! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_revision
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Almost done; back into needs_revision.  Just a few cleanups to make,
 comments to add, or tickets to open left. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Addressed all pending review comments again!
 Let me know what else is missing!

 I will be testing in the meanwhile.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_revision
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Reviewed again!  More comments are there. Closer and closer!  Any
 conversation on gitlab not ending with a ✔ probably needs some attention.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+

Comment (by nickm):

 ✓

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by asn):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_revision
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+

Comment (by asn):

 Finished addressing Nick's review. Please check out the fixes!

 The most interesting commits IMO are:

 {{{
 0ae3f171b * Don't set HSDir index if we don't have a live consensus.
 efc6ab662 * Correctly assign HSDir flags based on protocol list
 543d8a0f1 * Make ed25519 id keys optional for IPs and RPs.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_revision
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Review finished. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+

Comment (by nickm):

 Note to self: I have reviewed up to but not including "prop224:
 Introduction circuit creation"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 The service mother branch is ready. Some stats:
 {{{
  55 commits
  53 files changed, 7904 insertions(+), 1007 deletions(-)
 }}}

 Code: `ticket20657_032_02`
 OnionGit: https://oniongit.eu/dgoulet/tor/merge_requests/6

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_revision
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Few things changed with #21979 so I'll resubmit soon a branch rebased on
 that with a new onion git link.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  assigned => needs_review
 * reviewer:   => nickm


Comment:

 Many things have been addressed from asn's ongoing review. But if we want
 a chance to get this upstream not in 3 months, we have to start the
 upstream review process. We can easily deal with multiple reviewers at
 once. This branch is probably not perfect nor the 100% viable product but
 it's a start on which we can start fixing and improving on.

 Branch in: `ticket20657_032_02`

 Based on master commit 7b236403 and #21979. Review should start at this
 commit because everything before is #21979.

 {{{
 af027ddc prop224: API for the creation of blinded keys [David Goulet]
 }}}

 Oniongit: https://oniongit.eu/dgoulet/tor/merge_requests/5

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  assigned
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * milestone:  Tor: 0.3.1.x-final => Tor: 0.3.2.x-final


Comment:

 Triaging this to very-early 0.3.2 based on amsterdam discussion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  assigned
 Priority:  Very High|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  needs_review => assigned
 * keywords:  tor-hs, prop224, review-group-17 => tor-hs, prop224


Comment:

 I've moved asn's ntor branch review in #21750 so removing this ticket from
 the review group and back to the assigned state.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_review
 Priority:  Very High|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by asn):

 * status:  accepted => needs_review


Comment:

 Replying to [comment:9 asn]:
 > OK, I pushed my ntor branch at `prop224-ntor`. I also made a gitlab
 merge request here:
 > https://gitlab.com/asn/tor/merge_requests/13
 >
 > Please check it out, and let me know what needs to be fixed before it's
 merged in the rest of the service-side branch.
 >
 > Also, please check out my `prop224-ntor` torspec branch for some basic
 (non-protocol-changing) improvements.

 OK after a review from David and some comments from Nick I present the
 `prop224-ntor-v2` branch which comes with all the code review fixes, and
 with a full on integration test suite similar to the
 `./src/test/test_ntor.sh` tests for simple ntor.

 It also implements the key expansion functionality as requested by David.

 Putting this in `needs_review` just for this subtask.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  accepted
 Priority:  Very High|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * points:  parent => 6


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+

Comment (by asn):

 OK, I pushed my ntor branch at `prop224-ntor`. I also made a gitlab merge
 request here:
 https://gitlab.com/asn/tor/merge_requests/13

 Please check it out, and let me know what needs to be fixed before it's
 merged in the rest of the service-side branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+

Comment (by dgoulet):

 Replying to [comment:7 asn]:
 > I also pushed a topspec branch `prop224-time-period` which addresses
 some spec issues that we identified in IRC. Please ACK it and I will merge
 upstream.

 Actually, after playing with the code I propose we back off on this. The
 get period num function needs to do some arithmetic with the period length
 and `time_t now` which if we use `uint32_t`, it gets unpleasant fast
 because `time_t` on x64 is on 8 bytes so we have to check for all
 over/underflow possibilities. Instead, if we keep it to `INT_8()`, we
 avoid this issue entirely and it makes us also much more resilient for the
 post-apocalypse 2038 :).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+

Comment (by asn):

 I also pushed a topspec branch `prop224-time-period` which addresses some
 spec issues that we identified in IRC. Please ACK it and I will merge
 upstream.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+

Comment (by asn):

 Hello again.

 I have implemented the time period functionality you asked for. Please
 check my branch `prop224-time-period-v1`.

 It introduces three public functions:
 {{{
 +unsigned int hs_get_time_period_num(time_t now);
 +unsigned int hs_get_next_time_period(time_t now);
 +STATIC int descriptor_overlap_mode_is_active(const networkstatus_t
 *consensus);
 }}}

 Let me know what else you might want, or what other interface you might
 like.

 For example, I think you asked me for a function that returns the start of
 a time period. Why do you want that again? I couldn't find a reason in the
 spec. I can of course do it if it's still useful.

 Also, hope that's a useful overlap mode function for you. Let me know if
 you want a different interface.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * owner:   => dgoulet
 * status:  new => accepted


Comment:

 I've now been asked this twice in 2 days. For those who are curious,
 current development is ongoing in my branch: `ticket20657_031_02`.

 Expect regular rebasing, HEAVY development and all the things that come
 with that. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+

Comment (by asn):

 Hey David, I noticed what you said on IRC about the hash function only
 taking `token` as input and not the `token_type`. I think you are right on
 this. However, I think this does not influence the correctness of the hash
 table, since the hashing function is not collision resistant anyway (its
 output is only 4 bytes), so collisions are hanlded by putting the
 colliding elements in the same bucket and then running the equality
 function on the whole bucket. This means that if an HS is also a relay and
 it receives a double token, the hash table code will put both tokens in
 the same bucket and then it will filter the right one using
 `hs_circuits_have_same_token()`. I expanded the unittests as well to check
 this case.

 BTW, if we want to fix this in a deeper manner, we could expand
 `hs_circuit_hash_token()` by making it hash the token_type as well. I
 decided to not do this because I would have to do it with malloc and
 memcpy, and I thought it's too much of a hassle since the function is not
 really collision resistant in the first place.

 Let me know if you think the above is wrong. I don't mind doing the
 changes to `hs_circuit_hash_token()` if you prefer that approach.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  parent
 Reviewer:   |Sponsor:  SponsorR-must
-+

Comment (by asn):

 As discussed with dgoulet, I refactored the HS circuitmap codebase to be
 able to accept service-side circuits as well. Relay-side circuits are
 isolated from the service-side circuits using token types even if they
 have the same purpose; a test was added for this.

 The public service-side API is the following, and it's identical to the
 relay-side one but uses `origin_circuit_t` instead of `or_circuit_t`:

 {{{
 void hs_circuitmap_register_intro_circ_v2_service_side(origin_circuit_t
 *circ, const uint8_t *digest);
 void hs_circuitmap_register_intro_circ_v3_service_side(origin_circuit_t
 *circ, const ed25519_public_key_t *auth_key);
 void hs_circuitmap_register_rend_circ_service_side(origin_circuit_t *circ,
 const uint8_t *cookie);
 origin_circuit_t *hs_circuitmap_get_intro_circ_v3_service_side(const
 ed25519_public_key_t *auth_key);
 origin_circuit_t *hs_circuitmap_get_intro_circ_v2_service_side(const
 uint8_t *digest);
 origin_circuit_t *hs_circuitmap_get_rend_circ_service_side(const uint8_t
 *cookie);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
---+-
 Reporter:  dgoulet|  Owner:
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  tor-hs, prop224
Actual Points: |  Parent ID:  #12424
   Points:  parent |   Reviewer:
  Sponsor:  SponsorR-must  |
---+-
 This ticket is the parent one for anything related to service
 implementation for proposal 224.

 As we break down functionalities and needed features, we'll add more child
 tickets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs