Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

2016-12-07 Thread Tor Bug Tracker & Wiki 
#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 Changes above look good to me; applied as
 0815f96416676ace7cfdb5c29000d8cd6ee3459f

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

2016-12-06 Thread Tor Bug Tracker & Wiki 
#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

2016-12-05 Thread Tor Bug Tracker & Wiki 
#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

2016-12-03 Thread Tor Bug Tracker & Wiki 
#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * version:   => Tor: 0.2.9.5-alpha
 * points:   => 0.1


Comment:

 I think we introduced this one in 0.2.9.5-alpha.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

2016-12-03 Thread Tor Bug Tracker & Wiki 
#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Having delay == INT_MAX is entirely reasonable, and isn't a bug.
 It happens every time the last delay was INT_MAX.

 I think we should turn:
 {{{
  if (BUG(delay == INT_MAX))
delay -= 1; /* prevent overflow */
 }}}

 Into:
 {{{
  if (delay == INT_MAX)
delay -= 1; /* prevent overflow */
 }}}

 Or:
 {{{
  if (delay == INT_MAX)
return INT_MAX;
 }}}

 I also think we should add a precondition right at the top:
 {{{
  if (BUG(max_delay < 0))
max_delay = 0;
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20875 [Core Tor/Tor]: Non-fatal assertion !(delay == INT_MAX) failed in next_random_exponential_delay at src/or/directory.c:3792

2016-12-03 Thread Tor Bug Tracker & Wiki 
#20875: Non-fatal assertion !(delay == INT_MAX) failed in
next_random_exponential_delay at src/or/directory.c:3792
--+
 Reporter:  arma  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{
 Dec 03 19:59:44.346 [info] Received http status code 304 ("Not modified")
 from server '149.56.233.142:443' while fetching consensus directory.
 Dec 03 19:59:44.346 [debug] conn_close_if_marked(): Cleaning up connection
 (fd -1).
 Dec 03 19:59:44.346 [warn] tor_bug_occurred_(): Bug:
 src/or/directory.c:3792: next_random_exponential_delay: Non-fatal
 assertion !(delay == INT_MAX) failed. (on Tor 0.2.9.5-alpha-dev
 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: Non-fatal assertion !(delay == INT_MAX)
 failed in next_random_exponential_delay at src/or/directory.c:3792. Stack
 trace: (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(log_backtrace+0x42)
 [0x7f8e125a6562] (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(tor_bug_occurred_+0xb7)
 [0x7f8e125bf117] (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(+0x116615) [0x7f8e12571615]
 (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug:
 src/or/tor(download_status_increment_failure+0xa6) [0x7f8e12575f06] (on
 Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug:
 src/or/tor(networkstatus_consensus_download_failed+0x66) [0x7f8e124a9746]
 (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug:
 src/or/tor(connection_dir_about_to_close+0x24f) [0x7f8e1257a36f] (on Tor
 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(+0x4236d) [0x7f8e1249d36d]
 (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(+0x42b0c) [0x7f8e1249db0c]
 (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x7fc) [0x7f8e11ae43dc] (on Tor
 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(do_main_loop+0x234)
 [0x7f8e1249f1e4] (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(tor_main+0x1c25)
 [0x7f8e124a2935] (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(main+0x19) [0x7f8e1249aac9]
 (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf5) [0x7f8e10ab5b45] (on Tor 0.2.9.5
 -alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [warn] Bug: src/or/tor(+0x3fb19) [0x7f8e1249ab19]
 (on Tor 0.2.9.5-alpha-dev 8a767ba7fbeedb3d)
 Dec 03 19:59:44.347 [debug] connection_remove(): removing socket -1 (type
 Directory), n_conns now 12
 }}}

 This is an ordinary Tor client minding its own business. (Sorry that it is
 a few weeks before the 0.2.9.6-rc release.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs