Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2017-01-16 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  review-group-15  |  Actual Points:  .1
Parent ID:  #20822   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * type:  defect => task
 * resolution:   => implemented


Comment:

 merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2017-01-16 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-15  |  Actual Points:  .1
Parent ID:  #20822   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by dgoulet):

 * status:  needs_revision => merge_ready


Comment:

 Yes #21118 missing commit definitely fixed it, I can't reproduce either.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2017-01-16 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-15  |  Actual Points:  .1
Parent ID:  #20822   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+

Comment (by nickm):

 I can't reproduce the above test failure; does it reproduce for you?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2017-01-16 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-15  |  Actual Points:  .1
Parent ID:  #20822   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  accepted => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2017-01-16 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-15  |  Actual Points:  .1
Parent ID:  #20822   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by nickm):

 * status:  needs_revision => accepted
 * owner:   => nickm


Comment:

 setting owner

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2017-01-10 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #20822| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  merge_ready => needs_revision


Comment:

 Oh wait backoff, my test weren't finish when I pressed submit. This makes
 `make test` explode.

 {{{
 cellqueue/circ_n_cells: [forking] Jan 10 10:11:39.450 [err]
 tor_assertion_failed_(): Bug: src/or/circuitlist.c:522:
 circuit_remove_from_origin_circuit_list: Assertion origin_idx <=
 smartlist_len(global_origin_circuit_list) failed; aborting. (on Tor
 0.3.0.1-alpha-dev ef0559c3e318f16e)
 Jan 10 10:11:39.450 [err] Bug: Assertion origin_idx <=
 smartlist_len(global_origin_circuit_list) failed in
 circuit_remove_from_origin_circuit_list at src/or/circuitlist.c:522. Stack
 trace: (on Tor 0.3.0.1-alpha-dev ef0559c3e318f16e)
 circuituse/clean [...]
 circuituse/onehop [...]
 (and so on...)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2017-01-10 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #20822| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2017-01-02 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #20822| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => needs_review
 * actualpoints:   => .1


Comment:

 Implemented in my branch `ticket20921`, with a fix for #21118 too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2016-12-20 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #20822| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * points:  2 => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2016-12-20 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #20822| Points:  2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * points:   => 2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20921 [Core Tor/Tor]: Refactor global_origin_circuit_list code into separate functions.

2016-12-07 Thread Tor Bug Tracker & Wiki 
#20921: Refactor global_origin_circuit_list code into separate functions.
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #20822
   Points:|   Reviewer:
  Sponsor:|
--+


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs