Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-gitian, TorBrowserTeam201707R,   |  Actual Points:
  GeorgKoppen201707  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. Applied to `master` (tor-browser-bundle) with commit
 f890b38fd0ffc2572edc0e4dafc8a3aa3d16faa0 and to `master` (tor-browser-
 build) with commit 51ed356d2d4d411b7566987a7cc63d61c0ecd9d4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201707R,   |  Actual Points:
  GeorgKoppen201707  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:6 gk]:
 > Not sure if I did everything right but here comes my first review
 request via `oniongit`. https://oniongit.eu/gk/tor-browser-
 bundle/merge_requests/1

 This change looks good.

 I tried doing a build with rbm and this gcc version and it built without
 error.

 Corresponding changes in tor-browser-build.git: https://oniongit.eu/boklm
 /tor-browser-build/merge_requests/1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201707R,   |  Actual Points:
  GeorgKoppen201707  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:9 gk]:
 > Seems to have been a misconfiguration on my side. It should work now.
 Yep.
 There is a GCC 5.5 Release (Pending) with about 220 fixes, or
 https://gcc.gnu.org/ml/gcc/2017-07/msg00074.html, if you don't want to
 wait.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201707R,   |  Actual Points:
  GeorgKoppen201707  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:8 cypherpunks]:
 > Replying to [comment:6 gk]:
 > > Not sure if I did everything right but here comes my first review
 request via `oniongit`. https://oniongit.eu/gk/tor-browser-
 bundle/merge_requests/1
 > "You need to sign in or sign up before continuing."
 > :(

 Seems to have been a misconfiguration on my side. It should work now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201707R,   |  Actual Points:
  GeorgKoppen201707  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:6 gk]:
 > Not sure if I did everything right but here comes my first review
 request via `oniongit`. https://oniongit.eu/gk/tor-browser-
 bundle/merge_requests/1
 "You need to sign in or sign up before continuing."
 :(

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201707R,   |  Actual Points:
  GeorgKoppen201707  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 FWIW https://bugzilla.mozilla.org/show_bug.cgi?id=1305396 is a non-issue
 anymore after we switched to esr52. Not sure which change fixed it,
 though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201707R,   |  Actual Points:
  GeorgKoppen201707  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  assigned => needs_review
 * keywords:  tbb-gitian, TorBrowserTeam201707, GeorgKoppen201707 => tbb-
 gitian, TorBrowserTeam201707R, GeorgKoppen201707


Comment:

 Not sure if I did everything right but here comes my first review request
 via `oniongit`. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201707,|  Actual Points:
  GeorgKoppen201707  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-gitian, TorBrowserTeam201701 => tbb-gitian,
 TorBrowserTeam201707, GeorgKoppen201707


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201701  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:
  |  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201701  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * keywords:  tbb-gitian, TorBrowserTeam201701R => tbb-gitian,
 TorBrowserTeam201701
 * status:  needs_review => needs_revision


Comment:

 Turns out we are already hitting
 https://bugzilla.mozilla.org/show_bug.cgi?id=1305396 with the bump to
 5.4.0. Thus we need to have a fix for that one first as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
---+---
 Reporter:  gk |  Owner:  tbb-team
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201701R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by mcs):

 r=brade
 r=mcs

 This looks okay.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
---+---
 Reporter:  gk |  Owner:  tbb-team
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201701R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * keywords:  tbb-gitian, TorBrowserTeam201701 => tbb-gitian,
 TorBrowserTeam201701R
 * status:  new => needs_review


Comment:

 `bug_20929` (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_20929=edc35ff67352d66390c1cce94b4a2f114dd91a2e)
 in my tor-browser-bundle repo has a fix for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20929 [Applications/Tor Browser]: Bump GCC version in our alpha builds

[Tor Bug Tracker & Wiki]

#20929: Bump GCC version in our alpha builds
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-gitian,
 Severity:  Normal   |  TorBrowserTeam201701
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 For the 7.0aX series we should bump the GCC version used to the latest
 stable in the 5.x series. The hardened builds are already done with GCC
 5.4.0, thus there is no reason to use a different GCC (currently 5.1.0) in
 the alphas.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs