Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.7-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-relay, tor-client, hibernate,|  Actual Points:  0.2
  review-group-24|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Squashed as `bug23571_033_squashed` and merged to master. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.7-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-client, hibernate,|  Actual Points:  0.2
  review-group-24|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.7-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-client, hibernate,|  Actual Points:  0.2
  review-group-24|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Yes, I've used this patch repeatedly in chutney, because it gives better
 behaviour when counting circuits in experimental privcount.

 I added a fixup that sets the hold_open_until_flushed flag to 0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.7-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-client, hibernate,|  Actual Points:  0.2
  review-group-24|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 (Otherwise, looks plausible. I assume this is reasonably chutney-tested?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.7-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-client, hibernate,|  Actual Points:  0.2
  review-group-24|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Do we want to be setting the hold_open_until_flushed flag here, really?  I
 don't think we did that before...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.2.4.7-alpha
 Severity:  Normal| Resolution:
 Keywords:  tor-relay, tor-client, hibernate  |  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.2.4.7-alpha
 Severity:  Normal| Resolution:
 Keywords:  tor-relay, tor-client, hibernate  |  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * owner:  (none) => teor
 * status:  needs_review => assigned


Old description:

> This allows dormant connections to flush then close normally.
> Bugfix on 7267 in 0.2.4.7-alpha.

New description:

 This allows dormant connections to flush then close normally.
 Bugfix on #7267 in 0.2.4.7-alpha.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.2.4.7-alpha
 Severity:  Normal| Resolution:
 Keywords:  tor-relay, tor-client, hibernate  |  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


Comment:

 Please see my branch bug7267, which uses the documented function for
 closing OR connections.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor:
  |  0.2.4.7-alpha
 Severity:  Normal| Resolution:
 Keywords:  tor-relay, tor-client, hibernate  |  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:|Sponsor:
--+

Comment (by arma):

 Does the "this" and the ".2 points" mean you've got a patch?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23571 [Core Tor/Tor]: Stop closing channels out from under OR connections in hibernate_go_dormant()

[Tor Bug Tracker & Wiki]

#23571: Stop closing channels out from under OR connections in
hibernate_go_dormant()
+--
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core|Version:  Tor: 0.2.4.7-alpha
  Tor/Tor   |
 Severity:  Normal  |   Keywords:  tor-relay, tor-client, hibernate
Actual Points:  0.2 |  Parent ID:
   Points:  0.2 |   Reviewer:
  Sponsor:  |
+--
 This allows dormant connections to flush then close normally.
 Bugfix on 7267 in 0.2.4.7-alpha.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs