Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  1
Parent ID:  #23493   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-

Comment (by neel):

 I have a patch which includes a changes entry and (hopefully) better
 comments. The filename is 006-setup_introduce1_data_node.patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  1
Parent ID:  #23493   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by neel):

 * Attachment "006-setup_introduce1_data_node.patch" added.

 Revised Patch (Revision 5)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  1
Parent ID:  #23493   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * version:   => Tor: 0.3.2.1-alpha


Comment:

 Hi, this patch looks good, but we will need to rewrite some of the
 comments to say what the code does after the patch.
 Then we can do some tests, and merge it.

 Minor comment changes

 We don't mention local variables in function comments. And we need to
 explain what the function does after the patch:
 {{{
 Legacy ID is mandatory and will always be present in node.
 If the primary address is not IPv4, logs a BUG() warning, and returns an
 empty smartlist.
 Includes ed25519 id and IPv6 if present.
 }}}

 This is what the function does after the patch:
 {{{
  /* We require IPv4, and we will add IPv6 if it is present */
 }}}

 {{{
 /* ed25519 ID is only included if the node has it. */
 }}}

 {{{
 /* If we didn't get any link specifiers, it's because our node was bad. */
 }}}

 Possible code changes

 We might also think about using the ed25519 accessor function, rather than
 accessing the node member directly. (I'm not sure if this makes any
 difference, someone should check.)

 Changes file

 This patch needs a changes file that says what the patch does. changes
 files go in tor/changes. They have a specific format:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md


 Here is some text to get started:
 {{{
 When v3 onion service clients send introduce cells, include the IPv6
 address of the rendezvous point, if it has one.
 v3 onion services running 0.3.2 ignore IPv6 addresses.
 In future Tor versions, IPv6-only v3 single onion services can use IPv6
 addresses to connect directly to the rendezvous point.
 }}}

 It's ok for us to merge this patch to master by itself, because 0.3.2
 services ignore rendezvous point IPv6 addresses, and v3 single onion
 services can't be configured as IPv6 only in 0.3.2.

 Here are the tests we need to do on this patch before we merge:
 * run "make check"
 * run "make test-network-all" (needs chutney)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  1
Parent ID:  #23493   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  1
Parent ID:  #23493   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-

Comment (by neel):

 I have a refactored patch as 005-setup_introduce1_data_node.patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  1
Parent ID:  #23493   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by neel):

 * Attachment "005-setup_introduce1_data_node.patch" added.

 Revised Patch (Revision 4)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  1
Parent ID:  #23493   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 When #23820 merges, this patch will need to be rebased on top of it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:  1
Parent ID:  #23493   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by teor):

 * status:  needs_revision => needs_review
 * points:   => 1
 * sponsor:   => SponsorV-can
 * actualpoints:   => 1


Comment:

 Thanks for this patch, it looks good.

 We'll need to test it along with the other parts of #23493, so it might be
 a while before it merges.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 I have a new patch with the filename {{004-desriptive_msg.patch}}.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * Attachment "004-desriptive_msg.patch" added.

 Revised Patch (Revision 3)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Thanks for this patch, we're almost there!

 Code Logic:

 This check is incorrect, it should use `node_has_ipv6_orport()`:

 {{{
 if (node_ipv6_or_preferred(node)) {
 }}}

 `node_ipv6_or_preferred()` returns true if this client prefers IPv6 for
 this node. But link specifiers are sent to a remote client, which applies
 its own IPv6 preferences to the addresses. So we need to send the IPv6
 address whenever it is available.

 The code assumes that addr_len and the length of in6_addr are the same. I
 think it's probably ok for us to assume that.

 Code Structure:

 For consistency with `node_has_curve25519_onion_key()`, can you please
 change the name of `node_get_curve25519_key()` to
 `node_get_curve25519_onion_key()`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 I have a new patch {{003-desriptive_msg.patch}} which introduces
 {{node_get_curve25519_key()}} (The Revision 2 lacked this).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * Attachment "003-desriptive_msg.patch" added.

 Revised Patch (Revision 2) with node_get_curve25519_key()

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 teor, thank you so much for your comments. Also, respond whenever you
 want.

 Also, I have made a new patch with the filename 002-desriptive_msg.patch​
 including your suggestions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * Attachment "002-desriptive_msg.patch" added.

 Revised Patch (Revision 1)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:6 neel]:
 > I am working on a new patch, but I have two questions:
 >
 > 1. For the IPv6 check, I am making use of the function
 {{{link_specifier_set_un_ipv6_addr()}}}, and it has a parameter {{{size_t
 idx}}}. What is the {{{idx}}} parameter and what is it used for?

 I'd suggest you copy the IPv6 code out of hs_desc_lspec_to_trunnel().
 We'll fix up the duplicate code in #23759.

 > 2. I am introducing two new functions:
 >   a. {{{ curve25519_pubkey_eq()}}} in
 {{{src/common/crypto_curve25519.c}}} and
 {{{src/common/crypto_curve25519.h}}}

 I don't think you need to implement this function.

 >   b. {{{ node_get_curve25519_id()}}} in {{{src/or/nodelist.c}}} and
 {{{src/or/nodelist.h}}}

 If I'm guessing correctly, you're writing node_get_curve25519_id() by
 copying and modifying node_get_ed25519_id().

 But the curve25519 key is an encryption key, not an authentication id.

 And it's much easier to find in a node:
 1. If there's an ri, use the curve25519 key from it
 2. If there's an md, use the curve25519 key from it
 3. Otherwise, the entire function should fail and return NULL

 See the last few lines of extend_info_from_node() for an example, or copy
 and modify node_has_curve25519_onion_key().

 >  Do I need to implement a regression test for these two functions?

 node_get_curve25519_key() would be useful, and we might want to refactor
 other code to use it. I'll open a child ticket for this task.

 > I hope you can respond in a timely manner.

 I'm on leave right now, and then there's a meeting next week, so it might
 take some time for me to reply.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 I am working on a new patch, but I have two questions:

 1. For the IPv6 check, I am making use of the function
 {{{link_specifier_set_un_ipv6_addr()}}}, and it has a parameter {{{size_t
 idx}}}. What is the {{{idx}}} parameter and what is it used for?
 2. I am introducing two new functions:
   a. {{{ curve25519_pubkey_eq()}}} in {{{src/common/crypto_curve25519.c}}}
 and {{{src/common/crypto_curve25519.h}}}
   b. {{{ node_get_curve25519_id()}}} in {{{src/or/nodelist.c}}} and
 {{{src/or/nodelist.h}}}
  Do I need to implement a regression test for these two functions?

 I hope you can respond in a timely manner.

 Best,

 Neel

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Thank you for the patch, Neel.

 Here's my review:

 Functionality

 The reason we want to make this change is that the node sometimes has an
 IPv6 address.
 If the node has an IPv6 address, we need to add it to the link specifiers.
 Then we can remove the existing (incorrect) comment:
 {{{XXX: IPv6 is not clearly a thing in extend_info_t?}}}

 On some clients and relays, nodes don't have a routerinfo (ri is NULL).
 So you need to use the accessor functions for the primary (IPv4) and IPv6
 addresses for the node, which do the right thing.
 I think they're called something like node_get_primary_orport and
 node_get_ipv6_orport.

 Testing

 Did you test this code before you submitted it?
 Do the unit tests (make test) need changes so they pass with these code
 changes?
 Does chutney work with these changes? (make test-network-all)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 I have created a patch to address this. The filename is
 001-setup_introduce1_data_node.patch.

 -Neel

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * Attachment "001-setup_introduce1_data_node.patch" added.

 Patch to make setup_introduce1_data() take a node & create
 get_lspecs_from_node() & remove legacy get_lspecs_from_extend_info() in
 hs_circuit.c

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop224, tor-hs, single-onion, ipv6  |  Actual Points:
Parent ID:  #23493   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * cc: neel@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23577 [Core Tor/Tor]: Make setup_introduce1_data() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23577: Make setup_introduce1_data() take a node instead of an extend_info
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core |Version:
  Tor/Tor|
 Severity:  Normal   |   Keywords:  prop224, tor-hs, single-onion, ipv6
Actual Points:   |  Parent ID:  #23493
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 To provide both IPv4 and IPv6 addresses, setup_introduce1_data() needs to
 take a node, and we need to create a new get_lspecs_from_node() function.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs