Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:  tor-ci, teor-was-assigned,   |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
  very-small |
Parent ID:   | Points:  0.1
 Reviewer:  isis |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => closed
 * keywords:
 tor-ci, 032-backport, teor-was-assigned, 034-triage-20180328,
 034-removed-20180328 very-small
 =>
 tor-ci, teor-was-assigned, 034-triage-20180328, 034-removed-20180328
 very-small
 * resolution:   => fixed


Comment:

 There's no need to backport an efficiency patch

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-ci, 032-backport, teor-was-  |  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328 very-small|
Parent ID:   | Points:  0.1
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision
 * milestone:  Tor: 0.3.4.x-final => Tor: 0.3.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-ci, 032-backport, teor-was-  |  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328 very-small|
Parent ID:   | Points:  0.1
 Reviewer:  isis |Sponsor:
-+-

Comment (by Hello71):

 conflicts with 57e2f21bd8966e1ce4f9da5e9f6e7dcbe1fe0c6c by isis, doesn't
 have a bug number but apparently that wasn't backported to 0.3.2.

 options:

 1. don't bother cherry-picking this to 0.3.2. good if we don't intend to
 use travis on maint branches. I think that's a good idea though, so
 probably not a good decision.

 2. cherry-pick 57e2f21bd8966e1ce4f9da5e9f6e7dcbe1fe0c6c too

 3. "merge" by leaving out offline Rust builds entirely

 option 2 sounds good if isis is on board.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-ci, 032-backport, teor-was-  |  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328 very-small|
Parent ID:   | Points:  0.1
 Reviewer:  isis |Sponsor:
-+-

Comment (by nickm):

 I cherry-picked that commit to 0.3.3 as
 b116710e313c6debf9bc172e462837782def57bd .  It didn't seem to apply to
 0.3.2, however.  Am I missing something?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-ci, 032-backport, teor-was-  |  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328 very-small|
Parent ID:   | Points:  0.1
 Reviewer:  isis |Sponsor:
-+-

Comment (by teor):

 Let's do it

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-ci, 032-backport, teor-was-  |  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328 very-small|
Parent ID:   | Points:  0.1
 Reviewer:  isis |Sponsor:
-+-
Changes (by isis):

 * status:  needs_review => merge_ready


Comment:

 LGTM; if teor agrees, I think we should do Hello71's suggestion to cherry-
 pick d219c568abb82e4c564fb8fe95eeb4ac423affc2 onto 0.3.2 and 0.3.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-ci, 032-backport, teor-was-  |  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328 very-small|
Parent ID:   | Points:  0.1
 Reviewer:  isis |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => isis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-ci, 032-backport, teor-was-  |  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328 very-small|
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 tor-ci, 032-backport, teor-was-assigned, 034-triage-20180328,
 034-removed-20180328
 =>
 tor-ci, 032-backport, teor-was-assigned, 034-triage-20180328,
 034-removed-20180328 very-small
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-ci, 032-backport, teor-was-  |  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328   |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by Hello71):

 * priority:  Medium => Very Low
 * cc: alex_y_xu@… (added)
 * status:  assigned => needs_review
 * severity:  Normal => Minor


Comment:

 unless I'm missing something, we can just cherry-pick
 https://github.com/teor2345/tor/commit/d219c568abb82e4c564fb8fe95eeb4ac423affc2
 onto the relevant branches. it's not strictly necessary, but good to
 remove unnecessary cruft.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-ci, 032-backport  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * keywords:  tor-ci => tor-ci, 032-backport
 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


Comment:

 Moving this to 0.3.3 - it might make sense to backport this fix for the
 maint-0.3.2 branch?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-ci|  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_revision


Comment:

 Ok, I've run out of time for this, there are commits for this issue and
 #24629 in my branch  travis-osx-v2. Feel free to keep hacking on it!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24630 [Core Tor/Tor]: Stop initialising rust git submodules, travis does this automatically

[Tor Bug Tracker & Wiki]

#24630: Stop initialising rust git submodules, travis does this automatically
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-ci
Actual Points:|  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 isis told me to do this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs