Re: [tor-bugs] #24713 [Metrics/Statistics]: Make pgTAP test work again

[Tor Bug Tracker & Wiki]

#24713: Make pgTAP test work again
+-
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Great, thanks for checking! Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24713 [Metrics/Statistics]: Make pgTAP test work again

[Tor Bug Tracker & Wiki]

#24713: Make pgTAP test work again
+-
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+-
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 This is fine now, runs, and passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24713 [Metrics/Statistics]: Make pgTAP test work again

[Tor Bug Tracker & Wiki]

#24713: Make pgTAP test work again
+--
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+--
Changes (by karsten):

 * reviewer:   => iwakeh


Comment:

 Optimistically assigning to iwakeh's review queue. Feel free to give it
 back if you don't want it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24713 [Metrics/Statistics]: Make pgTAP test work again

[Tor Bug Tracker & Wiki]

#24713: Make pgTAP test work again
+--
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by karsten):

 * cc: metrics-team (added)
 * owner:  metrics-team => karsten
 * status:  new => accepted


Comment:

 I worked on this and am going to post a branch here in a second.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24713 [Metrics/Statistics]: Make pgTAP test work again

[Tor Bug Tracker & Wiki]

#24713: Make pgTAP test work again
+--
 Reporter:  iwakeh  |  Owner:  karsten
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Please review [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=task-24713=f6257c1644b0144c47eb4f7b22dfc1c5553876e1
 commit f6257c1 in my task-24713 branch]. The commit message contains all
 the details why this commit fixes the bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24713 [Metrics/Statistics]: Make pgTAP test work again

[Tor Bug Tracker & Wiki]

#24713: Make pgTAP test work again
+--
 Reporter:  iwakeh  |  Owner:  metrics-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Description changed by iwakeh:

Old description:

> The [https://gitweb.torproject.org/user/iwakeh/metrics-
> web.git/tree/src/test/sql/userstats/test-
> userstats.sql?h=tasks-24218-23761-2 userstats tests].  Some tweaks were
> already supplied (cf. the other commits on the mentioned branch), but the
> tests fail still.

New description:

 The [https://gitweb.torproject.org/user/iwakeh/metrics-
 web.git/tree/src/test/sql/userstats/test-
 userstats.sql?h=tasks-24218-23761-2 userstats tests].  Some tweaks were
 already supplied (cf. the other commits on the mentioned branch), but the
 tests fail still.

 Situation:
 Currently the tests fail b/c of the commented `SELECT merge();` calls.
 But these would prevent the tests from running at all b/c of `ERROR:
 relation "merged_part" already exists`.  There are approx. 25 calls to
 `merge()`.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24713 [Metrics/Statistics]: Make pgTAP test work again

[Tor Bug Tracker & Wiki]

#24713: Make pgTAP test work again
+--
 Reporter:  iwakeh  |  Owner:  metrics-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  |   Keywords:
Actual Points:  |  Parent ID:
   Points:  |   Reviewer:
  Sponsor:  |
+--
 The [https://gitweb.torproject.org/user/iwakeh/metrics-
 web.git/tree/src/test/sql/userstats/test-
 userstats.sql?h=tasks-24218-23761-2 userstats tests].  Some tweaks were
 already supplied (cf. the other commits on the mentioned branch), but the
 tests fail still.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs