Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  rust, doc |  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => closed
 * resolution:   => implemented


Comment:

 I've done a minimal version of this in
 74c767af29e793749e697eba8a206850b156521e, and merged it (since it's docs-
 only) to 0.3.3 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  task  | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, doc |  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 We didn't mention a version in the RustInTor wiki pake earlier, so I'm not
 adding one there.  I'll write a patch for the other stuff though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
--+
 Reporter:  teor  |  Owner:  nickm
 Type:  task  | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, doc |  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, doc |  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 "Latest nightly" makes me pretty nervous, but I think "latest stable"
 isn't too bad.

 In Rome I talked to Ximin about Debian's Rust packaging, and learned that
 Debian is apparently tracking latest stable too, so we probably won't get
 forced to freeze a rust version until the next Debian release starts to
 freeze.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, doc |  Actual Points:  0.1
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by isis):

 * keywords:  tor-rust, doc => rust, doc


Comment:

 Consolidating the tags

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-rust, doc  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+

Comment (by isis):

 Replying to [comment:3 nickm]:
 > I am in favor of requiring the most recent rust that we can "get away
 with" requiring.

 We can probably get away with the whatever the current nightly is? and
 then cease and track it to stable when we hear of a major distro that we
 care about has a new release including it, since Rust releases are quite
 rapid (6 weeks) and distros are generally quite slow to stabilise. One
 negative implication of this is we won't be able to use any `#[feature]`s,
 ever, or we'll likely have a bad time later trying to ask Rust devs for
 our features to be stabilised super fast into whichever version we're
 using that will become stable.

 Probably we should at least change `configure.ac` to check for 1.18, given
 the `HashSet` problem that teor noted above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-rust, doc  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+

Comment (by isis):

 Closed #25379 as a duplicate of this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-rust, doc  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+

Comment (by nickm):

 I am in favor of requiring the most recent rust that we can "get away
 with" requiring.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-rust, doc  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+

Comment (by Sebastian):

 When we started out we wanted to require 1.14 because that is available in
 Debian. I guess we never documented it properly, and thus it got broken.
 But if our CI can build with newer Rust then we should probably just use
 that

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
---+
 Reporter:  teor   |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-rust, doc  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+

Old description:

> On #24761, Sebastian says that we require Rust 1.14, but I can't see that
> documented anywhere.
>
> We should document it:
> * in the release notes
> * in the wiki: https://trac.torproject.org/projects/tor/wiki/RustInTor
>
> And point to it from:
> *
> https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStartedRust.md
>
> And document the nightly/feature thing in our coding standards:
> *
> https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandardsRust.md

New description:

 On #24761, Sebastian says that we require Rust ~~1.14~~, but I can't see
 that documented anywhere.

 We should document it:
 * in the release notes
 * in the wiki: https://trac.torproject.org/projects/tor/wiki/RustInTor

 And point to it from:
 *
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStartedRust.md

 And document the nightly/feature thing in our coding standards:
 *
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandardsRust.md

--

Comment (by teor):

 We actually require Rust 1.18 for HashSet retain in protover.rs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24765 [Core Tor/Tor]: What version of Rust does Tor require for 0.3.2?

[Tor Bug Tracker & Wiki]

#24765: What version of Rust does Tor require for 0.3.2?
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-rust, doc
Actual Points:  0.1   |  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 On #24761, Sebastian says that we require Rust 1.14, but I can't see that
 documented anywhere.

 We should document it:
 * in the release notes
 * in the wiki: https://trac.torproject.org/projects/tor/wiki/RustInTor

 And point to it from:
 *
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStartedRust.md

 And document the nightly/feature thing in our coding standards:
 *
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandardsRust.md

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs