Re: [tor-bugs] #25095 [Core Tor/Tor]: Update dir-spec.txt with recent consensus param additions

[Tor Bug Tracker & Wiki]

#25095: Update dir-spec.txt with recent consensus param additions
---+
 Reporter:  arma   |  Owner:  dgoulet
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tor-spec, tor-dos  |  Actual Points:
Parent ID: | Points:
 Reviewer:  ahf|Sponsor:
---+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged to torspec!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25095 [Core Tor/Tor]: Update dir-spec.txt with recent consensus param additions

[Tor Bug Tracker & Wiki]

#25095: Update dir-spec.txt with recent consensus param additions
---+
 Reporter:  arma   |  Owner:  dgoulet
 Type:  task   | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-spec, tor-dos  |  Actual Points:
Parent ID: | Points:
 Reviewer:  ahf|Sponsor:
---+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 LGTM.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25095 [Core Tor/Tor]: Update dir-spec.txt with recent consensus param additions

[Tor Bug Tracker & Wiki]

#25095: Update dir-spec.txt with recent consensus param additions
---+
 Reporter:  arma   |  Owner:  dgoulet
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-spec, tor-dos  |  Actual Points:
Parent ID: | Points:
 Reviewer:  ahf|Sponsor:
---+
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Thanks for the review!

 Fixup commit `032af0b700c4b915` pushed. I've also put the possible values
 for the `DoSConnectionDefenseType`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25095 [Core Tor/Tor]: Update dir-spec.txt with recent consensus param additions

[Tor Bug Tracker & Wiki]

#25095: Update dir-spec.txt with recent consensus param additions
---+
 Reporter:  arma   |  Owner:  dgoulet
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-spec, tor-dos  |  Actual Points:
Parent ID: | Points:
 Reviewer:  ahf|Sponsor:
---+
Changes (by ahf):

 * status:  needs_review => needs_revision
 * reviewer:   => ahf


Comment:

 I think the patch looks good, I have two questions:

 1. `DoSCircuitCreationBurst` and `DoSCircuitCreationRate` seems related.
 Is `DoSCircuitCreationRate` also per Client IP address or not? Maybe that
 is worth addressing explicitly if it is.

 2. `DoSCircuitCreationDefenseType` is a bit vaguely defined here -- what
 are the possible values this could have? From the other entries I think
 it's possible to deduct the data-type, but not for this one.

 Other than that it looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25095 [Core Tor/Tor]: Update dir-spec.txt with recent consensus param additions

[Tor Bug Tracker & Wiki]

#25095: Update dir-spec.txt with recent consensus param additions
---+
 Reporter:  arma   |  Owner:  dgoulet
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-spec, tor-dos  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 Spec branch: `ticket25095_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25095 [Core Tor/Tor]: Update dir-spec.txt with recent consensus param additions

[Tor Bug Tracker & Wiki]

#25095: Update dir-spec.txt with recent consensus param additions
---+
 Reporter:  arma   |  Owner:  dgoulet
 Type:  task   | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-spec, tor-dos  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by dgoulet):

 * cc: dgoulet (removed)
 * owner:  (none) => dgoulet
 * status:  new => accepted
 * type:  defect => task
 * keywords:  torspec => tor-spec, tor-dos


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25095 [Core Tor/Tor]: Update dir-spec.txt with recent consensus param additions

[Tor Bug Tracker & Wiki]

#25095: Update dir-spec.txt with recent consensus param additions
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  torspec
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 We have a section in dir-spec.txt that tries to describe the possible
 consensus parameters, and their ranges, and their meanings.

 We just added a bunch of new ones in #24902. And maybe we missed a few
 recently, like hs_service_max_rdv_failures.

 We should patch dir-spec.txt to specify all of them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs